Age | Commit message (Collapse) | Author | Files | Lines |
|
- create a .pre-commit-config.yaml configuration file with
* gitlint
* trailing blanks linter
* tabs removal linter
- exclude .git folder from it
- exclude Makefiles since tabs are mandatory by default in them
- create a tox pre-commit profile to run it from tox
note gitlint is not runnable at this pre-commit stage
- create pre-commit-install and pre-commit-uninstall tox profiles to
(un)install hooks locally and (un)perform tests at each "git commit"
call (i.e. without calling manually the pre-commit tox profile)
- precise pre-commit stages/types in the pre-commit configuration file
so that hooks are installed correctly. This avoids messages about
skipped tests when they are run at a wrong stage.
Issue-ID: OOM-2643
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ie95bb4f6f90be80b05a1398973caffeff7936881
|
|
- add checkbahims to tox.ini default profiles
- remove -f options to unforce bashisms detection in explicit bash
scripts and to differentiate treatments between bash and sh
- migrate #!/bin/bash shebangs to #!/bin/sh for scripts without bashisms
The following scripts have not been migrated since they still use
bashisms difficult to migrate (mostly arrays - more details below)
./kubernetes/common/mariadb-init/resources/config/db_init.sh
./kubernetes/portal/components/portal-mariadb/resources/config/ \
mariadb/docker-entrypoint.sh
./kubernetes/helm/plugins/deploy/deploy.sh
./kubernetes/helm/plugins/undeploy/undeploy.sh
./kubernetes/sdnc/components/sdnc-prom/resources/bin/ensureSdncActive.sh
$ find . -not -path '*/\.*' -name *.sh -exec checkbashisms -f {} + 2>&1\
| grep line | cut -d' ' -f 7- | sort | uniq -c | sort -k1,1nr
18 (bash arrays, ${name[0|*|@]}):
2 (declare):
1 ($FUNCNAME):
1 (shopt):
1 (trap with ERR|DEBUG|RETURN):
https://mywiki.wooledge.org/Bashism#Arrays
https://mywiki.wooledge.org/Bashism#Special_Variables
https://mywiki.wooledge.org/Bashism#Builtins
https://www.oilshell.org/release/0.5.alpha2/test/spec.wwz/builtin-trap.html
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: Id06ad1d45004321a293bdd26038d8da5f7b6b4ac
|
|
with the following command
$ find . -not -path '*/\.*' -name *.sh -exec sed -i 's/\t/ /g' {} +
then realign manually what deserves it and in particular,
unindent some EOF scripting tags so they do not trigger errors.
Issue-ID: OOM-2643
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ibfa463ec8083d5a39de18a54d9c1d8746710fe03
|
|
From ODL Aluminium, MDSAL journal dir is changed to
/opt/opendaylight/segmented-journal .
journalPath should be updated to make it retained across pod restarts.
Issue-ID: SDNC-1593
Signed-off-by: Satoshi Fujii <fujii-satoshi@jp.fujitsu.com>
Change-Id: I67cc2f9b428316922ccca5ab072bb127891ef018
|
|
Add service account to chart
Issue-ID: OOM-2719
Signed-off-by: farida azmy <farida.azmy.ext@orange.com>
Change-Id: I263f53a60e32867f61b2d85cc4dc8a78d9701449
|
|
When nodeSelector was given by values or override.yaml, helm deploy
was failed due to wrong indentation in helm charts.
This change fixed indentation level for nodeSelector and affinity
in pod spec.
Issue-ID: SDNC-1565
Signed-off-by: Satoshi Fujii <fujii-satoshi@jp.fujitsu.com>
Change-Id: Ie5446928e3f32d9333c04245fc0d2c0f98b3b4e7
|
|
pointed out by checkbashisms:
- variable name HOSTNAME
- source instead of .
- sleep with suffix
- string increments
And migrate a few shebangs to /bin/sh
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: I653c14454a3232b5a349ca1564ece53ddc94289d
|
|
This reverts commit 62178a49cc9e4088019d426636657d9f2980d242.
This commit introduced regression on portal db config job which is now
unable to start:
/usr/local/bin/docker-entrypoint.sh: line 114: syntax error near unexpected token `('
Issue-ID: OOM-1
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I3cb72cd7625b180b364b713fe942d5956736ebef
|
|
pointed out by checkbashisms:
- variable name HOSTNAME
- source instead of .
- variable increments
- sleep with suffix
And migrate a few shebangs to /bin/sh
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: I82981bcff17e88cf824935b841ce37a585ddde00
|
|
|
|
|
|
Add service account to requirements.yaml, values.yaml and deployment/statefulset
Issue-ID: OOM-2720
Signed-off-by: farida azmy <farida.azmy.ext@orange.com>
Change-Id: Iefe02cad5b2069879d043d17465f248f1f731519
|
|
- Remove cmpv2Certificate chart in order to deprecate CertService
client mechanism.
- Remove CertServiceClient init containers in SDNC.
- Replace CMPv2CertManagerIntegration with cmpv2Enabled flag
Issue-ID: OOM-2744
Signed-off-by: Piotr Marcinkiewicz <piotr.marcinkiewicz@nokia.com>
Change-Id: I8c818fcf64a029552c8833f68b6ae95fad379c8d
|
|
CCSDK mountpoint-registrar bundle consumes SEC_FAULT_OUTPUT and
VES_PNFREG_OUTPUT DMaaP topics.
Currently dmaap timeout is set to 50000, which is much longer than
jersey.config.client.readTimeout=25000. The bundle is giving up
connection before dmaap timeout and that could cause message lost
if message arrived after client timeout.
This change remove the inappropriate timeout value from
the property file so that the bundle uses default timeout value
defined in java class.
Issue-ID: CCSDK-3320
Signed-off-by: Satoshi Fujii <fujii-satoshi@jp.fujitsu.com>
Change-Id: I638af7c1f737b0904cb21c8121f2a08b2737d94b
|
|
|
|
Fix SDNC service template to make it work with aaf disabled.
Issue-ID: OOM-2748
Signed-off-by: Marat Salakhutdinov <marat.salakhutdinov@bell.ca>
Change-Id: Ic0ac6bcb12cfc86d7b338da21d621e35e94b03c0
|
|
This version bump installs the latest service release of OpenDaylight
Aluminum (SR3). This was released too late for inclusion in the
initial Honolulu release, but contains bug fixes that are needed
for SDN-R and so is being released as part of the Honolulu
maintenance release
Issue-ID: SDNC-1542
Issue-ID: CCSDK-3285
Signed-off-by: Dan Timoney <dtimoney@att.com>
Change-Id: I8b2c9763958bd33d41560d609c31bdc2f46cdcce
|
|
Expose netconf callHome port as node port
Issue-ID: OOM-2721
Signed-off-by: demskeq8 <alexander.dehn@highstreet-technologies.com>
Change-Id: I0b4205755a9e9e66fc23b4e1dc6cabe985bc859e
|
|
|
|
|
|
Version bump on sdnc images to install license fix to address issue
identified in latest license scan, and to install fix for bug
in basic_vm_model test (SDNC-1515)
Issue-ID: SDNC-1507
Issue-ID: SDNC-1515
Signed-off-by: Dan Timoney <dtimoney@att.com>
Change-Id: I80721c0ce88ce2654b637d7f6748441496a684e6
|
|
Utilize Cert-Manager to secure communication between
Cert-Service and its clients, adjust templates and
configs.
Issue-ID: OOM-2712
Signed-off-by: Piotr Marcinkiewicz <piotr.marcinkiewicz@nokia.com>
Change-Id: I96426b1a184b4d254575e76d29214d9deda08cce
Signed-off-by: Remigiusz Janeczek <remigiusz.janeczek@nokia.com>
|
|
|
|
pointed out by checkbashisms.
$ mycmd=$(tox -e checkbashisms | grep "(should be 'b = a')" | sed -e
"s@^[^.]*\(.[^ ]*\) line \([0-9]*\) .*@sed -i -e '\2s/==/=/g' \1;@")
$ eval $mycmd
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: I9032130bc4717e111de11a73187c2f1052376e45
|
|
pointed out by checkbashisms.
$ mycmd=$(tox -e checkbashisms | grep "^possible .*'function' is useless
" | sed -e "s@^[^.]*\(.[^ ]*\) line \([0-9]*\) .*@sed -i -e '\2s/functio
n \\\([^ ()]*\\\) *(\\\?)\\\?/\\\1 ()/\' -e '\2s/(){/() {/' \1;@")
$ eval $mycmd
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: Ic41c8ba8288b7a90db9f5775cd601c09ff2ab663
|
|
pointed out by checkbashisms.
$ tox -e checkbashisms |grep 'interpreter line' | cut -d' ' -f2
|xargs grep -lv '#!/bin/sh' | xargs sed -i -e '1i#!/bin/sh' -e '1i\\'
plus manual fixes
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: Ic41fec6ebadd162cecf889f2b119ac82551bd21d
|
|
|
|
|
|
- add additional environment variables
- add config file for external oauth-providers
Issue-ID: OOM-2675
Signed-off-by: demskeq8 <alexander.dehn@highstreet-technologies.com>
Change-Id: I235d3f46f5d109a1e82bdaa3c9de97508116fbe3
[Improve secretes handling]
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
|
|
sdnc container needs to wait for completion of its dbinit job before coming
online. This appears to be root cause for a recurring issue we
have seen in gating runs and in weekly run, where we see errors that
directed graphs are missing.
Issue-ID: SDNC-1512
Signed-off-by: Dan Timoney <dtimoney@att.com>
Change-Id: I3fb9dad6b36fc8a549094e94b0a6a8936f9a4916
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
|
|
Bump versions of CCSDK (including CDS) and SDNC images for
SDNC Honolulu release.
Fixed issues found in CDS command-executor and py-executor
pods.
Added missing env variable settings.
Issue-ID: CCSDK-3125
Issue-ID: SDNC-1473
Issue-ID: CCSDK-3192
Issue-ID: CCSDK-3197
Signed-off-by: Dan Timoney <dtimoney@att.com>
Change-Id: Id3bbe696313c568dc9ffb328715a7fc572330411
|
|
Updating the documentation and bumping version to 8.0.0
Issue-ID: OOM-1
Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
Change-Id: I6f942f1466fed64264c44fb8fc0e1ffc93a98f18
|
|
When installing SDNC in a local DB, the execution of the DB
initialisation job fails as the user already exists and granting the
privileges to the DB is not executed.
This patch will only create the user and DB if not already present.
Issue-ID: OOM-2705
Signed-off-by: andreasgeissler <andreas-geissler@telekom.de>
Change-Id: Iabfc90829cea1f98181caf3367c8f2b78de96c7f
|
|
remove wrong daexim link
Issue-ID: SDNC-1475
Change-Id: I52d1da10082a6fee846461ce18fc0913aea85e18
Signed-off-by: demskeq8 <alexander.dehn@highstreet-technologies.com>
|
|
Python 2 is no more supported and Python 3 must be used.
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: I81158561fa0af4b1441b27b3a4546b815fb659e3
|
|
|
|
- correct cmpv2Certificate to take outputType from 'certificates'
- add postStart hook for CertManagerIntegration to make cert dir writable
- add setting ODL_CERT_DIR env
Issue-ID: SDNC-1477
Signed-off-by: Piotr Marcinkiewicz <piotr.marcinkiewicz@nokia.com>
Change-Id: I4531392cc4f113b173d10a27b98b1fe97d6faa4d
|
|
correct value for ELASTICSEARCH_CLUSTER_NAME
Issue-ID: OOM-2685
Signed-off-by: demskeq8 <alexander.dehn@highstreet-technologies.com>
Change-Id: I1cc1d95a5ed26b6b761ef9f416527f1027087349
|
|
|
|
configure absolut path for daexim persistent directory
Issue-ID: SDNC-1475
Signed-off-by: demskeq8 <alexander.dehn@highstreet-technologies.com>
Change-Id: I1cfc348b733dee2e02b1a0193f6cba3c78e61d91
|
|
- Create certManagerCertificate chart for Certificate template
- Change default values for duration and renewBefore
- Add creation Secret with keystore password
- Use template in SDNC (add volumes and volumesMounts)
Issue-ID: OOM-2568
Signed-off-by: Piotr Marcinkiewicz <piotr.marcinkiewicz@nokia.com>
Change-Id: Ib70d91b599fa6813ed0a6d5b96206508f2fdafcf
|
|
|
|
proxyUser, ProxyPassowrd and proxyUrl for jersey.config.client.proxy settings
Issue-ID: OOM-2662
Signed-off-by: demskeq8 <alexander.dehn@highstreet-technologies.com>
Change-Id: I9136e71153ccce88b8bc8a6501ebdea2eb3a93cb
|
|
Create generic template to simplify CertServiceClient use
Issue-ID: OOM-2568
Signed-off-by: Remigiusz Janeczek <remigiusz.janeczek@nokia.com>
Change-Id: I4fb9829b27b1dd13a9e7a098f807710cc5648438
|
|
|
|
|
|
|
|
In OpenDaylight, there are three types of data that we want to retain:
- exported backups (stored in /opt/opendaylight/daexim)
- journals (stored in /opt/opendaylight/journal)
- snapshots (stored in /opt/opendaylight/snapshots)
This change saves all 3 directories to the sdnc persistent
volume so that they are retained across restarts.
Issue-ID: SDNC-1455
Signed-off-by: Dan Timoney <dtimoney@att.com>
Change-Id: I6b068c7a7bce294f94f9697a34027010bb5bfe8f
|
|
Bump SDNC docker version to 2.0.5 for Guilin maintenance release. This
release contains bug fixes related to the Transport Slicing use case
(see Issue-ID footers for list of Jiras addressed)
Issue-ID: SDNC-1431
Issue-ID: CCSDK-3075
Issue-ID: CCSDK-3013
Signed-off-by: Dan Timoney <dtimoney@att.com>
Change-Id: I87526ad058b413692cb731d3cad1457efbefc108
|
|
Genereate names of certificate and secret
Issue-ID: OOM-2568
Signed-off-by: Jan Malkiewicz <jan.malkiewicz@nokia.com>
Change-Id: I014df059f348e974f6d222b5d6d1c2416bea0440
|