Age | Commit message (Collapse) | Author | Files | Lines |
|
- create a .pre-commit-config.yaml configuration file with
* gitlint
* trailing blanks linter
* tabs removal linter
- exclude .git folder from it
- exclude Makefiles since tabs are mandatory by default in them
- create a tox pre-commit profile to run it from tox
note gitlint is not runnable at this pre-commit stage
- create pre-commit-install and pre-commit-uninstall tox profiles to
(un)install hooks locally and (un)perform tests at each "git commit"
call (i.e. without calling manually the pre-commit tox profile)
- precise pre-commit stages/types in the pre-commit configuration file
so that hooks are installed correctly. This avoids messages about
skipped tests when they are run at a wrong stage.
Issue-ID: OOM-2643
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ie95bb4f6f90be80b05a1398973caffeff7936881
|
|
- add checkbahims to tox.ini default profiles
- remove -f options to unforce bashisms detection in explicit bash
scripts and to differentiate treatments between bash and sh
- migrate #!/bin/bash shebangs to #!/bin/sh for scripts without bashisms
The following scripts have not been migrated since they still use
bashisms difficult to migrate (mostly arrays - more details below)
./kubernetes/common/mariadb-init/resources/config/db_init.sh
./kubernetes/portal/components/portal-mariadb/resources/config/ \
mariadb/docker-entrypoint.sh
./kubernetes/helm/plugins/deploy/deploy.sh
./kubernetes/helm/plugins/undeploy/undeploy.sh
./kubernetes/sdnc/components/sdnc-prom/resources/bin/ensureSdncActive.sh
$ find . -not -path '*/\.*' -name *.sh -exec checkbashisms -f {} + 2>&1\
| grep line | cut -d' ' -f 7- | sort | uniq -c | sort -k1,1nr
18 (bash arrays, ${name[0|*|@]}):
2 (declare):
1 ($FUNCNAME):
1 (shopt):
1 (trap with ERR|DEBUG|RETURN):
https://mywiki.wooledge.org/Bashism#Arrays
https://mywiki.wooledge.org/Bashism#Special_Variables
https://mywiki.wooledge.org/Bashism#Builtins
https://www.oilshell.org/release/0.5.alpha2/test/spec.wwz/builtin-trap.html
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: Id06ad1d45004321a293bdd26038d8da5f7b6b4ac
|
|
with the following command
$ find . -not -path '*/\.*' -name *.sh -exec sed -i 's/\t/ /g' {} +
then realign manually what deserves it and in particular,
unindent some EOF scripting tags so they do not trigger errors.
Issue-ID: OOM-2643
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ibfa463ec8083d5a39de18a54d9c1d8746710fe03
|
|
pointed out by checkbashisms:
- variable name HOSTNAME
- source instead of .
- sleep with suffix
- string increments
And migrate a few shebangs to /bin/sh
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: I653c14454a3232b5a349ca1564ece53ddc94289d
|
|
This reverts commit 62178a49cc9e4088019d426636657d9f2980d242.
This commit introduced regression on portal db config job which is now
unable to start:
/usr/local/bin/docker-entrypoint.sh: line 114: syntax error near unexpected token `('
Issue-ID: OOM-1
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I3cb72cd7625b180b364b713fe942d5956736ebef
|
|
pointed out by checkbashisms:
- variable name HOSTNAME
- source instead of .
- variable increments
- sleep with suffix
And migrate a few shebangs to /bin/sh
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: I82981bcff17e88cf824935b841ce37a585ddde00
|
|
CCSDK mountpoint-registrar bundle consumes SEC_FAULT_OUTPUT and
VES_PNFREG_OUTPUT DMaaP topics.
Currently dmaap timeout is set to 50000, which is much longer than
jersey.config.client.readTimeout=25000. The bundle is giving up
connection before dmaap timeout and that could cause message lost
if message arrived after client timeout.
This change remove the inappropriate timeout value from
the property file so that the bundle uses default timeout value
defined in java class.
Issue-ID: CCSDK-3320
Signed-off-by: Satoshi Fujii <fujii-satoshi@jp.fujitsu.com>
Change-Id: I638af7c1f737b0904cb21c8121f2a08b2737d94b
|
|
pointed out by checkbashisms.
$ mycmd=$(tox -e checkbashisms | grep "^possible .*'function' is useless
" | sed -e "s@^[^.]*\(.[^ ]*\) line \([0-9]*\) .*@sed -i -e '\2s/functio
n \\\([^ ()]*\\\) *(\\\?)\\\?/\\\1 ()/\' -e '\2s/(){/() {/' \1;@")
$ eval $mycmd
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: Ic41c8ba8288b7a90db9f5775cd601c09ff2ab663
|
|
- add additional environment variables
- add config file for external oauth-providers
Issue-ID: OOM-2675
Signed-off-by: demskeq8 <alexander.dehn@highstreet-technologies.com>
Change-Id: I235d3f46f5d109a1e82bdaa3c9de97508116fbe3
[Improve secretes handling]
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
|
|
When installing SDNC in a local DB, the execution of the DB
initialisation job fails as the user already exists and granting the
privileges to the DB is not executed.
This patch will only create the user and DB if not already present.
Issue-ID: OOM-2705
Signed-off-by: andreasgeissler <andreas-geissler@telekom.de>
Change-Id: Iabfc90829cea1f98181caf3367c8f2b78de96c7f
|
|
remove wrong daexim link
Issue-ID: SDNC-1475
Change-Id: I52d1da10082a6fee846461ce18fc0913aea85e18
Signed-off-by: demskeq8 <alexander.dehn@highstreet-technologies.com>
|
|
configure absolut path for daexim persistent directory
Issue-ID: SDNC-1475
Signed-off-by: demskeq8 <alexander.dehn@highstreet-technologies.com>
Change-Id: I1cfc348b733dee2e02b1a0193f6cba3c78e61d91
|
|
|
|
proxyUser, ProxyPassowrd and proxyUrl for jersey.config.client.proxy settings
Issue-ID: OOM-2662
Signed-off-by: demskeq8 <alexander.dehn@highstreet-technologies.com>
Change-Id: I9136e71153ccce88b8bc8a6501ebdea2eb3a93cb
|
|
In OpenDaylight, there are three types of data that we want to retain:
- exported backups (stored in /opt/opendaylight/daexim)
- journals (stored in /opt/opendaylight/journal)
- snapshots (stored in /opt/opendaylight/snapshots)
This change saves all 3 directories to the sdnc persistent
volume so that they are retained across restarts.
Issue-ID: SDNC-1455
Signed-off-by: Dan Timoney <dtimoney@att.com>
Change-Id: I6b068c7a7bce294f94f9697a34027010bb5bfe8f
|
|
Corrected issue in values.yaml that was causing OpenDaylight akka
configuration file override not to be loaded properly. As a result,
we are seeing memory-related exceptions (circuit-breaker exception), whic
seems to be contributing to a memory leak error.
Also, updated configuration to enhance logging so that summary of
messages in/out (aka 'audit log') is written for debugging purposes.
Issue-ID: SDNC-1430
Signed-off-by: Dan Timoney <dtimoney@att.com>
Change-Id: I2a3950ecde1c53f8e68b11bbc9c0ddc136f67b54
|
|
This hook is not really used and slows down ONAP installation.
Issue-ID: OOM-2652
Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
Change-Id: I3693615a8af53da51d12d3a735f0bf183e59626b
|
|
remove startup scripts
Issue-ID: OOM-2610
Signed-off-by: Alexander Dehn <alexander.dehn@highstreet-technologies.com>
Change-Id: Ia09de604cc502ecbbd7575cd5dd2374f253820ed
|
|
Signed-off-by: Jakub Latusek <j.latusek@samsung.com>
Change-Id: Ia390319f744931f435615af49246c0e13cdb8564
Issue-ID: OOM-2562
|
|
|
|
Bump image versions to use Guilin M4 version of SDNC images and of
CCSDK dgbuilder. Note - SDNR remains disabled in this commit pending
fix to its endpoint. Also, note that CDS version bump is not included -
that will be submitted as a separate review.
Issue-ID: SDNC-1355
Signed-off-by: Dan Timoney <dtimoney@att.com>
Change-Id: I8d660a8e303a18d4674f832b9239fa50c5abf3f2
|
|
Changes for 111973
Issue-ID: SDNC-1136
Signed-off-by: esobmar <mariusz.sobucki@est.tech>
Change-Id: If185ee3658b8f51a969bb3505f8bfb163cfea2a3
Signed-off-by: egernug <gerard.nugent@est.tech>
Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
[Access EJBCA secret from cert service]
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
|
|
fix issue in startOdl.oom.sh
Issue-ID: OOM-2561
Signed-off-by: Alexander Dehn <alexander.dehn@highstreet-technologies.com>
Change-Id: I1760155bf250dd7e3dd1c816b65df9b9c245de24
|
|
use disaggregated elasticserach DB from common
Issue-ID: SDNC-1165
Signed-off-by: Alexander Dehn <alexander.dehn@highstreet-technologies.com>
Change-Id: I0c6ac6549f6c144f0ed5a64ae76a1fa352f740d2
|
|
|
|
The sdnc-portal component is currently disabled due to known security
vulnerabilities. This component is no longer supported - the developer
left the project - and its functionality is not really needed. So, we
are removing this component in Guilin.
Issue-ID: SDNC-1236
Signed-off-by: Dan Timoney <dtimoney@att.com>
Change-Id: I45c7cad2102011fb25ca9f6707792dfd5c97624f
|
|
Use of common.log.level template in order to set the log level for
STDOUT on SDNC.
Issue-ID: OOM-2516
Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
Change-Id: I1fde92c11f769a028292325bf67ed9654948a46f
|
|
fix outstanding issues from previous changeset
Issue-ID: OOM-2426
Signed-off-by: Smokowski, Kevin (ks6305) <kevin.smokowski@att.com>
Change-Id: I97e6f5f17104bf8f76bda6f7b9492cc0e2921349
|
|
update sdnc logging configuration
Issue-ID: OOM-2426
Signed-off-by: Smokowski, Kevin (ks6305) <kevin.smokowski@att.com>
Change-Id: I2666ce7feca692dde700386e072ac1a69dfc6eec
|
|
SDNC entrypoint script sets up several environment variables
including configfiles dir. Recent addition of AAF configfiles
broke expected path for used properties files. This could be
noticed with example error from karaf logs:
org.onap.ccsdk.sli.core.sli.SvcLogicException: Cannot read property file: /opt/app/osaaf/local/generic-resource-api-dg.properties: /opt/app/osaaf/local/generic-resource-api-dg.properties (No such file or directory)
Issue-ID: SDNC-1147
Signed-off-by: Konrad Bańka <k.banka@samsung.com>
Change-Id: Ifcfde9abef1c12a7b8d1009f346d313b8fe57f44
|
|
Some passwords are still hardcoded but with this commit all components
should be using passwords provided via secrets not directly as strings.
A follow-up patch will remove hardcoded passwords where feasible.
Issue-ID: OOM-2309
Change-Id: I047974506430cbb277200d0103bcc57a6fd8a83b
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
|
|
Add support for AAF init container for config and cert generation
Issue-ID: SDNC-755
Signed-off-by: Agarwal, Ruchira (ra1926) <ra1926@att.com>
Change-Id: I06ee7921b6dbb1b4b9ca64cf276a374256af3a45
Signed-off-by: Agarwal, Ruchira (ra1926) <ra1926@att.com>
|
|
Update SDNC helm charts to use Neon-based El Alto images
Change-Id: If91320bc663992355f665b3f57f77214e96985cd
Issue-ID: SDNC-874
Signed-off-by: Timoney, Dan (dt5972) <dtimoney@att.com>
|
|
Add files to tune akka settings in OpenDaylight.
Also, added setenv to tune Java settings.
Change-Id: I2071fceb48f990929cd9f4c885bd0c9f7db0263c
Issue-ID: SDNC-858
Signed-off-by: Timoney, Dan (dt5972) <dtimoney@att.com>
|
|
Update SDNC image versions for El Alto early drop (1.6.1 for SDNC, 0.5.1
for CCSDK)
Change-Id: I48bb223116b4064b7f90847d90bd0453d311b09c
Issue-ID: SDNC-827
Signed-off-by: Timoney, Dan (dt5972) <dtimoney@att.com>
|
|
Updated sdnc helm chart to initialize database from an init container
instead of initializing in startup script.
Change-Id: I4133c70a5805227d89eef84e46bea8555bf8133d
Issue-ID: SDNC-797
Signed-off-by: Timoney, Dan (dt5972) <dtimoney@att.com>
|
|
Changes have been made in the sdnc/oam
repo that have not been refelected in
the oom repo and this file needs to be
updated so both scripts will be the same
in each repo.
Issue-ID: SDNC-766
Change-Id: I61ef6a09b9ddc3422c0f85ae89d13eb240361f6a
Signed-off-by: DarraghEgan <darragh.egan@est.tech>
|
|
|
|
Change-Id: I41330836901ccf1fcbdd0f9d6e720ce13ea3a9ea
Issue-ID: OOM-1651
Signed-off-by: Mahendra Raghuwanshi <mahendra.raghuwanshi@amdocs.com>
|
|
Add SDNR feature and adjust netconf for cluster
Change-Id: Idec95539d0becc2f4c09e71e4b66616328775956
Issue-ID: SDNC-721
Signed-off-by: Herbert Eiselt <herbert.eiselt@highstreet-technologies.com>
|
|
This is for the post operation of keystore to add
new keystore to odl while it's coming up and also
to add certificates and keys that are available
to odl's keystore and truststore
When sdnc/oam gets mounted and so does oom repo,
the startODL.sh in the oam repo gets overwritten
by the startODL.sh in the oom repo. This change
updates the startODL.sh so both scripts will be
the same in each repo
Issue-ID: SDNC-665
Change-Id: Ie9096c4d68e8c0c88682d188194c386e69b0108d
Signed-off-by: DarraghEgan <darragh.egan@est.tech>
|
|
Updated start script so that initialization of local file system is
handled by a local lockfile, while initialization of database is
handled by a lockfile on persistent volume.
Change-Id: I5ef6aa672f0863bf0d6b656b7445b42d3fbe12e5
Issue-ID: SDNC-525
Signed-off-by: Timoney, Dan (dt5972) <dtimoney@att.com>
|
|
Set lcm user/password in lcm-dg.properties
Change-Id: I76f109f7bf9096128dabdcb52448a0fe85e0da35
Issue-ID: SDNC-252
Signed-off-by: Timoney, Dan (dt5972) <dtimoney@att.com>
|
|
Store .installed marker in persistent volume (/opt/opendaylight/current/daexim)
Change-Id: If54d40225e8eb30bcd3f133801726ae5f90b02a2
Issue-ID: SDNC-518
Signed-off-by: Timoney, Dan (dt5972) <dtimoney@att.com>
|
|
Update SDNC log config file to log4j2 format
Change-Id: I66ff0be34860823d53f5a191b8c357886c6c2936
Issue-ID: SDNC-487
Signed-off-by: Timoney, Dan (dt5972) <dtimoney@att.com>
|
|
Change-Id: I85143062482443ee26f13de5ff046f80fad943d0
Issue-ID: CCSDK-596
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
|
|
Change-Id: Ic38b6917e8775d6bc335c5fbbd475a9d14ac25fa
Signed-off-by: jmac <james.macnider@amdocs.com>
Issue-ID: SDNC-467
|
|
Missing netbox and blueprint-rest-adaptor
Change-Id: Ifa4f2095190718ae8dc3412eac99ae242978c97e
Issue-ID: CCSDK-589
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
|
|
|
|
LCM DG config for ScaleOut, TrafficMgmt, SoftwareUpgrade
Change-Id: Ia607fb6002968b266fa4d025129cada72485b445
Issue-ID: SDNC-425
Signed-off-by: Agarwal, Ruchira(ra1926) <ra1926@att.com>
|