summaryrefslogtreecommitdiffstats
path: root/kubernetes/robot
AgeCommit message (Collapse)AuthorFilesLines
2020-09-28Update git submodulesmrichomme1-0/+0
* Update kubernetes/robot from branch 'master' to 0611262fbb68714cfdb922f13ffb009b58a43f71 - Update INFO.yaml Issue-ID: INT-1724 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I198320e56131e031d5364214e64a9192c8da1024 Signed-off-by: mrichomme <morgan.richomme@orange.com>
2020-08-20Update git submodulesKrzysztof Kuzmicki1-0/+0
* Update kubernetes/robot from branch 'master' to b093c77b4faa2c4f0bfc67e481f724b6d67c7229 - [ROBOT] robot_properties.py configmap contains failing character Issue-ID: INT-1700 Signed-off-by: Krzysztof Kuzmicki <krzysztof.kuzmicki@nokia.com> Change-Id: I93004428c4c794dc50f8518698a72a95e9386591
2020-08-12Update git submodulesjhh1-0/+0
* Update kubernetes/robot from branch 'master' to 1ab576be1d226a586738658943253f3e721e5a62 - change drools hostname to policy-drools-pdp This is a companion review for https://gerrit.onap.org/r/c/oom/+/111069 Issue-ID: POLICY-1000 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I031e0c13478ab196b929765f389dd9df1431c87b Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-07-20Update git submodulesMarcin Przybysz1-0/+0
* Update kubernetes/robot from branch 'master' to ad58ed92bd7c5cc7d51c09b405a99fd360ff5268 - Merge "Make ROBOT compatible with Kubernetes v1.17" - Make ROBOT compatible with Kubernetes v1.17 Issue-ID: OOM-2464 Signed-off-by: Grzegorz Lis <grzegorz.lis@nokia.com> Change-Id: Iaacf334bc72f5c529c522fcc3ee598447b2cb916
2020-07-16Update git submodulesHany Abdelbaki1-0/+0
* Update kubernetes/robot from branch 'master' to 068514942a7af8ddfabd55697a67a8d27f799af8 - run cds bootstrap before vlb_cds instantiation Issue-ID: TEST-248 Signed-off-by: Hany Abdelbaki <habdelbaki.ext@orange.com> Change-Id: Iaef0445548f3d6b97a15c00399382eedd332643d
2020-07-10Update git submodulesmrichomme1-0/+0
* Update kubernetes/robot from branch 'master' to 44a38a594677ca38c4eea288908ebf503ad91b4e - Bump 1.6.4 version for Frankfurt maintenance release This new version includes minor fixes for ue case support Issue-ID: INT-1652 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I773d78906c5b32678e58eafe825ba12059ff52cf
2020-06-04Update git submodulesmrichomme1-0/+0
* Update kubernetes/robot from branch 'master' to 7ee95b4c8f667dd0506499db17688473309cd91e - bump testsuite 1.6.3 for frankfurt RC2 the delta with 1.6.2 includes minor fixes for - 5gbulkpm - pnf-registrate Please note that these changes are already taken into account in CI as xtesting dockers are rebuilt everyday but it is cleaner to execute the use cases Issue-ID: INT-1553 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: Ibd41c65d4190421e7c790f7e1f8a754923803757 Signed-off-by: mrichomme <morgan.richomme@orange.com>
2020-05-28Update git submodulesmrichomme1-0/+0
* Update kubernetes/robot from branch 'master' to 51322d3b374588a051b4a5522fbd25ac92ffb328 - Testsuite R6 RC2 1.6.2 docker for OOM Update testsuite version for RC2 frankfurt Issue-ID: INT-1550 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I78bf8c3558658c11b2fb1fb96908d9209016014b - Merge "Subject: Fix heatbridge params for Frankfurt" - Subject: Fix heatbridge params for Frankfurt Issue-ID: INT-1584 Signed-off-by: Marco Platania <platania@research.att.com> Change-Id: I25c69c9e7849c2aadb1dedb611bb731685379baa
2020-05-19[GENERIC] Follow master branchesSylvain Desbureaux1-0/+0
we were following frankfurt branches by mistake. Issue-ID: OOM-2406 Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com> Change-Id: Ia59d84c75cecd5cc186eb61be25cc9a371282567
2020-05-11Update git submodulesLucjan Bryndza1-0/+0
* Update kubernetes/robot from branch 'master' to 1bc31c7d76408bdf2267bf72bf3b1b1e18e2367f - Change ingress base hostname Change ingress base hostname to recommended value Issue-ID: OOM-2391 Change-Id: Ica5ab275ed3eac2ec6f1669fc9ca32c29a2b12e6
2020-05-11Update git submodulesMorgan Richomme1-0/+0
* Update kubernetes/robot from branch 'master' to c3148590e3da989daebfba6e721e7a53706dda87 - Merge "Host and port template for ingress setup" - Host and port template for ingress setup Depending on the ingress robot configuration host and port template should choose ingress host and port or direct cluster host and port + alternarive ingress hostname in config file Change-Id: I04c13657f5c5cf8b5f5373897bdc551dc2efdf36 Issue-ID: OOM-2341 Signed-off-by: Lucjan Bryndza <l.bryndza@samsung.com>
2020-05-08Update git submodulesMorgan Richomme1-0/+0
* Update kubernetes/robot from branch 'master' to 91827be0924c4db10687474ed5db2f7c63f6568a - Merge "[ROBOT] Fix Ingress configuration" - [ROBOT] Fix Ingress configuration Set SSL to redirect as backend uses HTTPS. Issue-ID: OOM-2186 Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com> Change-Id: I94cf20a016f1d1face44037d9912de774a5f338c
2020-05-07Update git submodulesMarcin Przybysz1-0/+0
* Update kubernetes/robot from branch 'master' to 64233373f3e5699d3cc7b154cedeb7d70826a667 - Merge "ROBOT e2e test cases improvements for csar/zip tosca package validation in VNFSDK and SDC Onbarding fix in scrip required for Frankfurt" - ROBOT e2e test cases improvements for csar/zip tosca package validation in VNFSDK and SDC Onbarding fix in scrip required for Frankfurt Issue-ID: INT-1240 Signed-off-by: Krzysztof Kuzmicki <krzysztof.kuzmicki@nokia.com> Change-Id: I08584c00eaaa7cb84bcb055d1f7eee41d95d6019
2020-05-01Update git submodulesMarco Platania1-0/+0
* Update kubernetes/robot from branch 'master' to c81062626b69160145baac5e6a5d670cb67211fa - Merge "Add instantiateVFWCLDN for DANOS" - Add instantiateVFWCLDN for DANOS Issue-ID: INT-1566 Change-Id: I48525947492061a98092f3b102ba240146a18e61 Signed-off-by: Brian Freeman <bf1936@att.com>
2020-05-01Update git submodulesmrichomme1-0/+0
* Update kubernetes/robot from branch 'master' to beea44604181479064665a2deb67d72c8c0e5d85 - [Integration][Testsuite] bump 1.6.1 version Issue-ID: INT-1567 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: Ib337dc9134b54cadd9bb1ae7a2fa1fdfeaa42c4f
2020-04-30Update git submodulesmrichomme1-0/+0
* Update kubernetes/robot from branch 'master' to 1367bd680380828977982030eb9784250c579e25 - Use SPDX identifier for the license instead of putting an extract of the license Issue-ID: OOM-2389 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I7292b0b03dbf964d6aeaf987726e82ed7f0ba8b2
2020-04-27Update git submodulesmrichomme1-0/+0
* Update kubernetes/robot from branch 'master' to b73d77ca2e9df3d7300ca85b5593d89a9271d13a - Bump teststuite 1.6.0 to OOM Master Issue-ID: INT-1558 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: Iaf544043476e03589464d8e47ba4f89f7cbd8e5d
2020-04-16Update git submodulesBrian Freeman1-0/+0
* Update kubernetes/robot from branch 'master' to 431689c7879a92be54477f13f8e39908db5f07f2 - Handle less than /16 oam network Matching changes in testsuite and demo Issue-ID: INT-1527 Change-Id: Iac7cdb735c4544e0d6bc79c444ba9de32b79fc32 Signed-off-by: Brian Freeman <bf1936@att.com>
2020-04-09Update git submodulesKanagaraj Manickam1-0/+0
* Update kubernetes/robot from branch 'master' to a995fce78ae63d33a0c48d825001ed7faea3b18f - Robot HC CLI port setting Issue-ID: CLI-261 Signed-off-by: Kanagaraj Manickam <kanagaraj.manickam@huawei.com> Change-Id: I11ea69bf16f5e57b680c7a8260453c893a4bdd02
2020-04-08Update git submodulesKrzysztof Kuzmicki1-0/+0
* Update kubernetes/robot from branch 'master' to 4b3ce28d5c42f2bc8ca9445545895aa34ff09a03 - Enhance 5g bulk PM test case in order to use blueprints from DCAE inventory Issue-ID: INT-1521 Signed-off-by: Krzysztof Kuzmicki <krzysztof.kuzmicki@nokia.com> Change-Id: Ia99231521dfb1755177a9ac1ad8c43771b4c8726
2020-04-02Update git submodulesSylvain Desbureaux1-0/+0
* Update kubernetes/robot from branch 'master' to 7f37c3cd610edd911a8b68e2118212d9ec8149d6 - Bump chart version Use 6.0.0 in preparation for Frankfurt release Issue-ID: OOM-2320 Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com> Change-Id: I73cc56e5e12018cf2d313bea04facf9e41691ad4
2020-04-01Update git submodulesKrzysztof Kuzmicki1-0/+0
* Update kubernetes/robot from branch 'master' to 60271b7510ea9d57ed56cd9958d1c07f5ceaf3c5 - ROBOT e2e test cases improvements for csar/zip tosca package validation - Fix permission issue Issue-ID: INT-1240 Signed-off-by: Krzysztof Kuzmicki <krzysztof.kuzmicki@nokia.com> Change-Id: I255d152f2be19e5ea60831dc717e4bf01ec69435
2020-03-31Update git submodulesMarco Platania1-0/+0
* Update kubernetes/robot from branch 'master' to 6032bc4ef9224b37df3b9d1e9b2f3ef51902aaf8 - Merge "Add HTTPS config lighttpd" - Add HTTPS config lighttpd Issue-ID: REQ-231 Change-Id: I4e18eed4424414d820f3ed78dfe5b1fb959a8938 Signed-off-by: Brian Freeman <bf1936@att.com>
2020-03-31Update git submodulesKrzysztof Kuzmicki1-0/+0
* Update kubernetes/robot from branch 'master' to af54b39d9bad61bc10bf2eb5ab304819183b11f6 - ROBOT e2e test cases improvements for csar/zip tosca package validation in VNFSDK and SDC Onbarding Issue-ID: INT-1240 Signed-off-by: Krzysztof Kuzmicki <krzysztof.kuzmicki@nokia.com> Change-Id: I58fbd642057650d76a65fdd4ba08f562acb44522
2020-03-27Update git submodulesmrichomme1-0/+0
* Update kubernetes/robot from branch 'master' to a8e1918a02156ecec86409948d400669c2e67bb7 - Adapt CLI healthcheck test for HTTPS CLI provided a new docker version fixing the security issue consisting in exposing HTTP public port The code of the associated healthcheck must be updated Issue-ID: INT-1501 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I0b66afa3d77be490ddf914d3a0cc3adae0636da0
2020-03-26Update git submodulesmrichomme1-0/+0
* Update kubernetes/robot from branch 'master' to 656326e3073f9f8fd4139bb1e585722d8025cb75 - Adapt NBI robot healthcheck to HTTPS Issue-ID: EXTAPI-415 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I9caaf093c56bf6a6b0d7564dca7485cec811cb22
2020-03-24Update git submodulesstatta1-0/+0
* Update kubernetes/robot from branch 'master' to ac2783f70a211de9642de744a0a1d3c3dbe920c6 - Disable HTTP Port of portal-app Issue-ID: PORTAL-848 Change-Id: I59fc05e2af2ff9429046497bd841d7ae8d0c58e8 Signed-off-by: statta <statta@research.att.com>
2020-03-23Update git submodulesmrichomme1-0/+0
* Update kubernetes/robot from branch 'master' to 7a19b2ef27679a176d279345693c46c99aa1371f - Adapt SNDC robot test for HTTPS Change has been done in sdnc to exclude HTTP port Healthcheck test must follow Issue-ID: SDNC-1120 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I3a88f20a67ca7d018155c5682224988407a86a8e
2020-03-11Update git submodulesmrichomme1-0/+0
* Update kubernetes/robot from branch 'master' to 3fa8381f2a1e5f030ee1388466417817dda0fbe2 - Adapt Robot test for vnfsdk (move to HTTPS) Issue-ID: OJSI-154 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: Ie04b69feeeb8723e400899abd1360c90ae505d4f Signed-off-by: mrichomme <morgan.richomme@orange.com>
2020-03-06Update git submodulesefiacor1-0/+0
* Update kubernetes/robot from branch 'master' to c854b484ebbd5e0c1be1e6a032a79beeb4cab6ff - Removing http for DMaaP DR Signed-off-by: efiacor <fiachra.corcoran@est.tech> Issue-ID: DMAAP-1400 Change-Id: Ifd0502283d4efe0c14aeb1e77bfa85779596cfec
2020-02-10Update git submodulesmrichomme1-0/+0
* Update kubernetes/robot from branch 'master' to 591bfdea4f1d833abee3c7e60f084da546d9082a - Create INFO.yaml for testsuite/oom same contributors than testsuite Issue-ID: INT-1386 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I37465c46dd5b025cf284157df4a12b140eb9d487
2020-02-07Update git submodulesKrzysztof Opasiak1-0/+0
* Update kubernetes/robot from branch 'master' to df719f4a3e63cff0d5d832945f0b8ba18230635c - [ONAP-wide] Replace .Release.Name with common.release ONAP is too big to be deployed using helm install so we need to use a custom helm plugin helm deploy. This script deloys onap component by component instead of deploying evrything at once. Unfortunately this script also modifies the helm release by appending component name to it. As a result of this behavior our objects are called for example: onap-mariadb-galera-mariadb-galera-0 instead of just being called onap-mariadb-galera-0. This patch simplifies this naming convention by replacing all direct usages of .Release.Name with common.release macro which strips the component specific part from the release name. Issue-ID: OOM-2275 Change-Id: I3384bf30c663764339b0b41527ca4eb7168f0d49 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
2020-01-30Update git submodulesMarco Platania1-0/+0
* Update kubernetes/robot from branch 'master' to 091f164a832479cb40ad6f5d7e4960269e75f87f - Merge "Adjust ETE runner for security tests" - Adjust ETE runner for security tests This patch adds gathering data which cannot be easily obtained from within "robot" pod (without granting it access to "kubectl" tool and as a side effect - cluster modifications). It introduces dependency to python3 on operator's machine (to convert "kubectl" tool filtered output to JSON). Issue-ID: SECCOM-261 Change-Id: Ie5057f65f79337896191b51cfad1b3e06623f80b Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-01-22Update git submodulesSylvain Desbureaux1-0/+0
* Update kubernetes/robot from branch 'master' to 4bd799e5dbcbf2131a685bf73319e962ace86f5c - Move Storage access to RWO Today when deploying Robot with OOM, the PersistentVolumeClaim needs the "ReadWriteMany" (or "RWX") capability. According to Kubernetes Documentation (https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes), ReadWriteMany stands for "the volume can be mounted as read-write by many nodes". That means that a particular PVC needs to be read and written from many pods. That also means that your code takes that into account and do the work to avoid write at the same place at the same time. An issue on RWX mode is that most "official" storage driver from Kubernetes doesn't support it (13 over the 19 drivers doesn't support it, espacially OpenStack, Amazon and Google storage classes). Robot PVC is used only for one Robot instance. Thus we don't need RWX. Issue-ID: INT-1230 Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com> Change-Id: I300e34a9d4be40b36153812d2a99c458cae6b2c9
2020-01-20Update git submodulesDaniel Rose1-0/+0
* Update kubernetes/robot from branch 'master' to 80a8b8c11d94af39ed26701dc10f2d3fc9e9a042 - Merge "Add ingress controler support to ROBOT" - Add ingress controler support to ROBOT Issue-ID: OOM-2186 Signed-off-by: Lucjan Bryndza <l.bryndza@samsung.com> Change-Id: Id6b6f6d1a5d9ea83f73b914509098f7711a6418a
2020-01-17Update git submodulesrajendrajaiswal1-0/+0
* Update kubernetes/robot from branch 'master' to ff678657c0fa534840d063131432e1994829f660 - Update DCAE username and password Change-Id: I575be45bbbd2c53a897eac87f303e45cc2fce976 Issue-ID: INT-1375 Signed-off-by: rajendrajaiswal <rajendra.jaiswal@ericsson.com>
2019-12-11Update git submodulesDaniel Rose1-0/+0
* Update kubernetes/robot from branch 'master' to bc1480dc6c66d23ed04feaff93fca10da6a65a8f - Merge "Use global storage templates for PVC" - Use global storage templates for PVC OOM has now templates in order to create the needed PVC, using: * a PV with a specific class when using a common nfs mount path between nodes (sames as today use) --> is the default behavior today * or a storage class if we want to use dynamic PV. On this case, we use (in order of priority): - persistence.storageClassOverride if set on the chart - global.persistence.storageClass if set globally - persistence.storageClass if set on the chart Issue-ID: OOM-1227 Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com> Change-Id: Ie65e55bca92eb0ada674636f049ecb054b65c5da
2019-12-11Update git submodulesDaniel Rose1-0/+0
* Update kubernetes/robot from branch 'master' to dbb4ed7385a22871a0ffb719f04e0f0f257d0ab3 - Merge "Add distributeVCPE" - Add distributeVCPE Issue-ID: INT-1397 Change-Id: I172fc986207a61c91b2dc9b1efa5c58bd689ea06 Signed-off-by: Brian Freeman <bf1936@att.com>
2019-12-11Update git submodulesBrian Freeman1-0/+0
* Update kubernetes/robot from branch 'master' to a7e566c2c15914ad409ab4135891c0c092c300f0 - Add /etc/hosts Issue-ID: PORTAL-782 Change-Id: I8f7abd28c357cf6525c3368f38035a45126bf2ae Signed-off-by: Brian Freeman <bf1936@att.com>
2019-11-27Update git submodulesDaniel Rose1-0/+0
* Update kubernetes/robot from branch 'master' to 6e38b492acd3ec44a869055092399b6f18c659b8 - Merge "Add Inventory and Deployment Global property needed for Bulkpm" - Add Inventory and Deployment Global property needed for Bulkpm Change-Id: I9839bc2937446f4062ae922f7d287b1150a1b224 Issue-ID: INT-1375 Signed-off-by: rajendrajaiswal <rajendra.jaiswal@ericsson.com>
2019-11-26Update git submodulesmrichomme1-0/+0
* Update kubernetes/robot from branch 'master' to eb01b0f5e5f9919499d76e5aaff997c9fafdda93 - Update MSB end point to https change protocol from http to https and port from 80 to 443 impacted healthcheck tests: msb, multicloud, vfc Issue-ID: VFC-1591 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I44d03d14df43b6e1df81b27da0ee455cc9045ce4
2019-11-13Update git submodulesBrian Freeman1-0/+0
* Update kubernetes/robot from branch 'master' to 31450dcb11d18b81098b43d0d0b7ecdb0d69e238 - SO VNFM HTTPS Issue-ID: SO-2517 Change-Id: I86c59908271b6a0686162c127edd6eb256b3ce6b Signed-off-by: Brian Freeman <bf1936@att.com>
2019-11-06Update git submodulesbdfreeman14211-0/+0
* Update kubernetes/robot from branch 'master' to 5526182fa60a7a61c8158c98b6be8dfc66c8330b - Revert VNFM https Issue-ID: OOM-2163 Change-Id: Ib5d07e2ddecbe8cdaf6d5e3ac7ae195cf6d33db4 Signed-off-by: bdfreeman1421 <bf1936@att.com>
2019-10-25Update git submodulesBrian Freeman1-0/+0
* Update kubernetes/robot from branch 'master' to 868374dc9e41555fa9e75a0ca63deb7cd6780ab9 - Update to 1.5.4 Issue-ID: TEST-216 Change-Id: Ia00b0ab26a47cfd3306ccc14f1f7950c54690144 Signed-off-by: Brian Freeman <bf1936@att.com> (cherry picked from commit 71d1a6e7ea4cdba97aed46c66921ab213b4588ff)
2019-10-16Update git submodulesstark, steven1-0/+0
* Update kubernetes/robot from branch 'master' to 3d18bf3cba8b1b8d021914d4751ea44f7c3e3cd4 - updating path to listener file for OVP testcase Issue-ID: VVP-328 Signed-off-by: stark, steven <steven.stark@att.com> Change-Id: I37d92065d8eb569d2a42e23520f26ac7a573aceb
2019-09-18Update git submodulesAbdelmuhaimen Seaudi1-0/+0
* Update kubernetes/robot from branch 'master' to 1d36d59796cf69d8bba1d833a7faa2709bef531c - Add instantiate VLB CDS to Demo Robot Script Issue-ID: TEST-194 Signed-off-by: Abdelmuhaimen Seaudi <abdelmuhaimen.seaudi@orange.com> Change-Id: Id7efda3b6e8c03a336005b317365e50fa97651f5
2019-09-17Update git submodulesBrian Freeman1-0/+0
* Update kubernetes/robot from branch 'master' to 79abf3c8548fcef3ec0db7d722b1c4e9312d95d6 - Merge "update to last release image for testsuite" - update to last release image for testsuite Issue-ID: TEST-216 Change-Id: I6caadff3cbb6d167c364d380cd9d2a7ad760f127 Signed-off-by: DR695H <dr695h@att.com>
2019-09-13Update git submodulesDaniel Rose1-0/+0
* Update kubernetes/robot from branch 'master' to e319430e199814608529493c30579e15a481a070 - Merge "[INT] Add driver script for vnf lifecycle validation" - [INT] Add driver script for vnf lifecycle validation This commit goes with commit https://gerrit.onap.org/r/c/testsuite/+/94485 Signed-off-by: stark, steven <steven.stark@att.com> Issue-ID: INT-1197 Change-Id: Idf4ae2dbe0fbfea13306a18441ca1426c3055e3e
2019-09-10Update git submodulesk.kedron1-0/+0
* Update kubernetes/robot from branch 'master' to db5b5ffbd1e2281664a42ea128cde83f3dd6c8ff - HTTPS calls for sdc Proper configuration for HTTPS for the sdc. Issue-ID: SDC-2548 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I92aa92ac323bf97664841fb0d3cf8da4189a2c97 (cherry picked from commit 2b3f953c2b2099539166e49bdd18f61d70e3ca68)
2019-08-22Update git submodulesDR695H1-0/+0
* Update kubernetes/robot from branch 'master' to b6b5b0e6f8880e3a922a2fef97e95e5013475228 - these are not used anywhere so removing to avoid confusion Issue-ID: TEST-184 Change-Id: I227f0002f36a72e350f0008eef20661ee04c3e26 Signed-off-by: DR695H <dr695h@att.com>