Age | Commit message (Collapse) | Author | Files | Lines |
|
Variable attribute 'local' is not POSIX but is LSB supported.
It is available in other shells such as ash or dash.
And in ksh, local is the default scope of functions vaiables.
Though, the syntax "local var=XX" is only supported and found in bash.
Sadly, this is not detected by checkbashims.
- fix "local var=XX" bashisms
- add a manual command in tox.ini to detect them in the CI
https://wiki.ubuntu.com/DashAsBinSh#local
https://wiki.ubuntu.com/DashAsBinSh#declare_or_typeset
https://stackoverflow.com/questions/12000949/scope-of-variables-in-ksh
Issue-ID: OOM-2643
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iff26e50cd352eeb760d923a4740a6f92184fe0f2
|
|
- add checkbahims to tox.ini default profiles
- remove -f options to unforce bashisms detection in explicit bash
scripts and to differentiate treatments between bash and sh
- migrate #!/bin/bash shebangs to #!/bin/sh for scripts without bashisms
The following scripts have not been migrated since they still use
bashisms difficult to migrate (mostly arrays - more details below)
./kubernetes/common/mariadb-init/resources/config/db_init.sh
./kubernetes/portal/components/portal-mariadb/resources/config/ \
mariadb/docker-entrypoint.sh
./kubernetes/helm/plugins/deploy/deploy.sh
./kubernetes/helm/plugins/undeploy/undeploy.sh
./kubernetes/sdnc/components/sdnc-prom/resources/bin/ensureSdncActive.sh
$ find . -not -path '*/\.*' -name *.sh -exec checkbashisms -f {} + 2>&1\
| grep line | cut -d' ' -f 7- | sort | uniq -c | sort -k1,1nr
18 (bash arrays, ${name[0|*|@]}):
2 (declare):
1 ($FUNCNAME):
1 (shopt):
1 (trap with ERR|DEBUG|RETURN):
https://mywiki.wooledge.org/Bashism#Arrays
https://mywiki.wooledge.org/Bashism#Special_Variables
https://mywiki.wooledge.org/Bashism#Builtins
https://www.oilshell.org/release/0.5.alpha2/test/spec.wwz/builtin-trap.html
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: Id06ad1d45004321a293bdd26038d8da5f7b6b4ac
|
|
with the following command
$ find . -not -path '*/\.*' -name *.sh -exec sed -i 's/\t/ /g' {} +
then realign manually what deserves it and in particular,
unindent some EOF scripting tags so they do not trigger errors.
Issue-ID: OOM-2643
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ibfa463ec8083d5a39de18a54d9c1d8746710fe03
|
|
pointed out by checkbashisms
Issue-ID: OOM-264
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: Ief3b2595a55f0e7a0a2e7ab05857848c99ce42f9
|
|
pointed out by checkbashisms
$ mycmd=$(tox -e checkbashisms
| grep '(\[\[ foo \]\] should be \[ foo \])'
| sed -e "s@^[^.]*\(.[^ ]*\) line \([0-9]*\) .*@sed -i '\2s/\\\[\\\[\\\(
[^]]*\\\)\\\]\\\]/[\\\1]/g' \1;@")
$ eval $mycmd
plus fix manually quoting hells induced and bash specific regex
and multi-conditions
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: Ie7ca5b71938fae22c200b7fead418618160fbe19
|
|
pointed out by checkbashisms.
$ mycmd=$(tox -e checkbashisms | grep "^possible .*'function' is useless
" | sed -e "s@^[^.]*\(.[^ ]*\) line \([0-9]*\) .*@sed -i -e '\2s/functio
n \\\([^ ()]*\\\) *(\\\?)\\\?/\\\1 ()/\' -e '\2s/(){/() {/' \1;@")
$ eval $mycmd
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: Ic41c8ba8288b7a90db9f5775cd601c09ff2ab663
|
|
Now that all the configs lives in its chart, we can get
rid of that big config folder, taking 200Mb+ in the git
repo.
Change-Id: I222ba9c64bf4dadbe4a22d61f790a8f796f2b6eb
Issue-ID: OOM-10
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
|
|
Issue-ID: OOM-731
Change-Id: I2137b9dbe7c7a320094c13779e8e43dadef964c7
Signed-off-by: pramod <pramod.kumarsharma@amdocs.com>
Signed-off-by: Mike Elliott <mike.elliott@amdocs.com>
|
|
Issue-ID: OOM-841
Change-Id: I24cda1b989ef05050f7fba5bc2464e3855871e8f
Signed-off-by: vaibhav_16dec <vaibhav.chopra@amdocs.com>
|
|
Issue-ID: OOM-821
Change-Id: I627ac962afe8cd6bf2859a30a0e88f6c9ac89d34
Signed-off-by: vaibhav_16dec <vaibhav.chopra@amdocs.com>
|
|
Issue-ID: OOM-597
Change-Id: I708c3e9df16003a54462f76c6ffe513b270faae8
Signed-off-by: jasmineWen <jasmine.wen@amdocs.com>
|
|
Issue-ID: OOM-560
Change-Id: Iee9c7c78c6eb53b14b31d6e31f1539040daa88ba
Signed-off-by: vaibhav_16dec <vaibhav.chopra@amdocs.com>
|
|
|
|
Change-Id: I00a8b3d1cac5cc3038a3efdb36d1e78e4a2e7cde
Signed-off-by: Brian Freeman <bf1936@att.com>
Issue-ID: OOM-769
|
|
|
|
Issue-ID: OOM-622
Change-Id: I865d1a2bc01bb259d28f08ccf9853d7dc0cb3815
Signed-off-by: mayankg2703 <mayank.gupta@amdocs.com>
|
|
Change-Id: Id44e74db3a26f963957222ba6690f6d57e0378db
Issue-ID: OOM-722
Signed-off-by: BorislavG <Borislav.Glozman@amdocs.com>
|
|
Change-Id: I5fcd4d577c1fda4de27842807c7cf7a5d372756e
Issue-ID: OOM-722
Signed-off-by: BorislavG <Borislav.Glozman@amdocs.com>
|
|
Issue-ID: OOM-764
Change-Id: If1e860a310dfe42df23b3ac754961e0f070e1ed2
Signed-off-by: atulan <atul.angrish@amdocs.com>
|
|
|
|
|
|
Issue-ID: OOM-550
Signed-off-by: Pramod <pramod.kumarsharma@amdocs.com>
Change-Id: Ibad8a16fb289ddd4260be5cce0c787e4de212a97
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Change-Id: Ic322d59fe4d79e35595a72daf7842ee03954023b
Issue-ID: OOM-664
Signed-off-by: mayankg2703 <mayank.gupta@amdocs.com>
|
|
|
|
|
|
|
|
|
|
Change-Id: I868acb11ba195a9415d54d2a9352c120a8b76e08
Issue-ID: OOM-662
Signed-off-by: mayankg2703 <mayank.gupta@amdocs.com>
|
|
Change-Id: Ie0229756fabb37a88f46c3d6eb864531660885a8
Issue-ID: OOM-663
Signed-off-by: mayankg2703 <mayank.gupta@amdocs.com>
|
|
Change-Id: I1d734fee3e487ba7d2e346576e38aba84928928f
Issue-ID: OOM-660
Signed-off-by: mayankg2703 <mayank.gupta@amdocs.com>
|
|
Change-Id: Ic7572ff99d04af94e9cbab695f0597ae211fb583
Issue-ID: OOM-521
Signed-off-by: mayankg2703 <mayank.gupta@amdocs.com>
|
|
Change-Id: Ib49c01c7f602458a41c66eb354fa08a024bdea15
Issue-ID: OOM-659
Signed-off-by: mayankg2703 <mayank.gupta@amdocs.com>
|
|
Issue-ID: OOM-658
Change-Id: I8878f202147edc419341fdc3bdafeb1ebc2eec1c
Signed-off-by: mayankg2703 <mayank.gupta@amdocs.com>
|
|
Issue-ID: OOM-559
Change-Id: I215f471b6711c8491d9381257c1b91ca3d21b8ed
Signed-off-by: Pramod <pramod.kumarsharma@amdocs.com>
|
|
Change-Id: I1a8e2589a57808f3816512b8b994a157c9d184a9
Issue-ID: OOM-650
Signed-off-by: mayankg2703 <mayank.gupta@amdocs.com>
|
|
Change-Id: Iba950df2a8c957edd9f772d5f10701a688e69c28
Issue-ID: OOM-649
Signed-off-by: mayankg2703 <mayank.gupta@amdocs.com>
|
|
Change-Id: Ia2876a084a7350a91b2b0fc268fa29038d906e70
Issue-ID: OOM-648
Signed-off-by: mayankg2703 <mayank.gupta@amdocs.com>
|
|
Change-Id: Ie67e41f09dceb058d5b60f4ff90c4c819ec7387a
Issue-ID: OOM-641
Signed-off-by: mayankg2703 <mayank.gupta@amdocs.com>
|
|
Change-Id: I42697eb8c1d2d7ac8a943be09d22aaaa61b865b9
Issue-ID: OOM-640
Signed-off-by: mayankg2703 <mayank.gupta@amdocs.com>
|
|
Change-Id: I1dc5a109d6a98ce5f281f3cec07d423bfbb2565a
Issue-ID: OOM-603
Signed-off-by: mayankg2703 <mayank.gupta@amdocs.com>
|
|
* changes:
AAF config seggregation
Policy config segreggation
|
|
Issue-ID: OOM-554
Change-Id: I24367eac50b3d46be964a6d60e24b317af376c3e
Signed-off-by: vaibhav_16dec <vaibhav.chopra@amdocs.com>
|
|
Issue-ID: OOM-553
Change-Id: I8dab41aea5b0fad1395f6deb47b2faa6f7dcbdbc
Signed-off-by: vaibhav_16dec <vaibhav.chopra@amdocs.com>
|
|
|