Age | Commit message (Collapse) | Author | Files | Lines |
|
- add checkbahims to tox.ini default profiles
- remove -f options to unforce bashisms detection in explicit bash
scripts and to differentiate treatments between bash and sh
- migrate #!/bin/bash shebangs to #!/bin/sh for scripts without bashisms
The following scripts have not been migrated since they still use
bashisms difficult to migrate (mostly arrays - more details below)
./kubernetes/common/mariadb-init/resources/config/db_init.sh
./kubernetes/portal/components/portal-mariadb/resources/config/ \
mariadb/docker-entrypoint.sh
./kubernetes/helm/plugins/deploy/deploy.sh
./kubernetes/helm/plugins/undeploy/undeploy.sh
./kubernetes/sdnc/components/sdnc-prom/resources/bin/ensureSdncActive.sh
$ find . -not -path '*/\.*' -name *.sh -exec checkbashisms -f {} + 2>&1\
| grep line | cut -d' ' -f 7- | sort | uniq -c | sort -k1,1nr
18 (bash arrays, ${name[0|*|@]}):
2 (declare):
1 ($FUNCNAME):
1 (shopt):
1 (trap with ERR|DEBUG|RETURN):
https://mywiki.wooledge.org/Bashism#Arrays
https://mywiki.wooledge.org/Bashism#Special_Variables
https://mywiki.wooledge.org/Bashism#Builtins
https://www.oilshell.org/release/0.5.alpha2/test/spec.wwz/builtin-trap.html
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: Id06ad1d45004321a293bdd26038d8da5f7b6b4ac
|
|
pointed out by checkbashisms.
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: I527f9b8dcad98a5dd9eb30390d26c95c1d918c09
|
|
|
|
|
|
Changes made to common/mariadb-galera chart in Honolulu prevents existing APPC
SELECT statements with GROUP BY clause to work properly. mariadb config must
not contain ONLY_FULL_GROUP_BY in the mysql_mode config option.
Issue-ID: OOM-2777
Signed-off-by: Marcin Wilk <m.wilk@samsung.com>
Change-Id: I9388f092adcf12d92118caf390686ea708bbcc02
|
|
In order to save some space
Issue-ID: OOM-2763
Signed-off-by: andreasgeissler <andreas-geissler@telekom.de>
Change-Id: Ibbd8d5f713307ada76a0d04ede57d3c7696bcfe5
|
|
|
|
Add service account to requirements.yaml, values.yaml and deployment/statefulset
Issue-ID: OOM-2720
Signed-off-by: farida azmy <farida.azmy.ext@orange.com>
Change-Id: Iefe02cad5b2069879d043d17465f248f1f731519
|
|
$ find . -name *.sh -print |xargs grep -l '"x'| xargs sed -i 's/"x/"/g'
The "x-hack" is a historical workaround for some old UNIX shells with
buggy condition comparison code. None of them is still used today.
Recent POSIX specifications now guarantee it should work without it
in any modern POSIX shell.
More details at
https://www.vidarholen.net/contents/blog/?p=1035
https://github.com/koalaman/shellcheck/wiki/SC2268
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: Ic01bbc5faee9492dba5b5d4dea0f659540da2c24
|
|
pointed out by checkbashisms.
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: I85fd7d9beca75dc729de247fa67a20b801748c19
|
|
|
|
pointed out by checkbashisms.
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: I958443b2e4b4f6391a74f957314d7d3fcf321cd0
|
|
As retrieving values is now done via a generic script, let's clean a
little bit cert retrieval in order to remove unneeded part.
Issue-ID: OOM-2688
Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
Change-Id: Ie6590aa3c64aeb34b6ab2b25db1c3e25df8fa33e
|
|
With stability tests, we see that mariadb gets OOM killed and has some
CPU throttling.
Putting higher limits in order to make it no happen.
Scaling also replicas from VFC and APPC db from 3 to 1.
Issue-ID: INT-1883
Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
Change-Id: I2699b34ac5fcaa805c6fc01592c5a5f607b17fae
|
|
|
|
|
|
pointed out by checkbashisms.
$ mycmd=$(tox -e checkbashisms | grep "(should be 'b = a')" | sed -e
"s@^[^.]*\(.[^ ]*\) line \([0-9]*\) .*@sed -i -e '\2s/==/=/g' \1;@")
$ eval $mycmd
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: I9032130bc4717e111de11a73187c2f1052376e45
|
|
pointed out by checkbashisms.
$ mycmd=$(tox -e checkbashisms | grep "^possible .*'function' is useless
" | sed -e "s@^[^.]*\(.[^ ]*\) line \([0-9]*\) .*@sed -i -e '\2s/functio
n \\\([^ ()]*\\\) *(\\\?)\\\?/\\\1 ()/\' -e '\2s/(){/() {/' \1;@")
$ eval $mycmd
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: Ic41c8ba8288b7a90db9f5775cd601c09ff2ab663
|
|
pointed out by checkbashisms.
$ tox -e checkbashisms |grep 'interpreter line' | cut -d' ' -f2
|xargs grep -lv '#!/bin/sh' | xargs sed -i -e '1i#!/bin/sh' -e '1i\\'
plus manual fixes
Issue-ID: OOM-2643
Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: Ic41fec6ebadd162cecf889f2b119ac82551bd21d
|
|
Updating the documentation and bumping version to 8.0.0
Issue-ID: OOM-1
Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
Change-Id: I6f942f1466fed64264c44fb8fc0e1ffc93a98f18
|
|
Instead of using hardcoded certificates in container, use
certInitializer in order to retrieve them.
Issue-ID: OOM-2682
Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
Change-Id: I93b7a1a0bddf2540e222ec4406d0cfd12f6f5e5e
|
|
Mariadb DB Galera containers version is outdated and unmaintained. We
need them to move to a new image provider.
As new image provider is not compatible with our old templates, we
also update the templates (by reworking bitnami mariadb-galera chart).
An update of global mariadb image is also done in order to match mariadb
galera version.
Issue-ID: OOM-1720
Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
Change-Id: Ib9976227759e90022183d4f37fc655143be4d6ac
|
|
Update charts and requirements to 7.0.0.
Create release notes for Guilin
Update documentation
Issue-ID: OOM-2638
Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
Change-Id: I965ed6b6ebb7d74bfddaff73edd3dd55a657841c
|
|
This commit makes APPC chart to use the new generator for repositories and
images.
As new templates doesn't work well with "sub charts", we move also
subcharts to components folder.
Issue-ID: OOM-2364
Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
Change-Id: I31178186d08926ae708261e84debb5bf49562b7a
|
|
Signed-off-by: Jakub Latusek <j.latusek@samsung.com>
Change-Id: If52740c1d17d9c42b019632e0ded5cf636cdd00e
Issue-ID: OOM-2562
|
|
Signed-off-by: Jakub Latusek <j.latusek@samsung.com>
Change-Id: Ida56d581771d24e088c774db973419f1d481f18d
Issue-ID: OOM-2562
|
|
This change makes the following fixes to dgbuilder:
* Replace hard-coded certificate with certificate generated by
certInitializer
* Configure dgbuilder to use http instead of https if AAF is
disabled (i.e. global aafEnabled property = false)
* Add resource limits
Issue-ID: SDNC-1356
Signed-off-by: Dan Timoney <dtimoney@att.com>
Change-Id: I8ca97c6a44f62a0abe5b5a6f8564ebcd2e4addb1
|
|
Readiness container v3.x and up are now present in ONAP main repository.
They're also not using root user anymore and then script path has
changed.
Finally, "job_complete" script has been integrated in main "ready"
script.
As those changes are significant, we must upgrade all the components at
once.
Depends-On: I5afa83892043f4844afe12e61724a8d368a9f2e0
Issue-ID: OOM-2545
Signed-off-by: Grzegorz Lis <grzegorz.lis@nokia.com>
Change-Id: I0b4eb5dd86390273532d67d0a9696e1cfcadf110
|
|
Issue-ID: OOM-2447
Signed-off-by: Krzysztof Kosewski <krzysztof.kosewski@nokia.com>
Change-Id: I9a199104001162fbf8531ac6ce9df4c3210c917d
|
|
the final docker release for R6
Issue-ID: APPC-1869
Change-Id: Ic16764a73e0cfafc4063048a94953878d900e5af
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Issue-ID: APPC-1876
Change-Id: If958102c146b5a7b2724e5291ca0d86870ce7869
Signed-off-by: Brian Freeman <bf1936@att.com>
|
|
set redirect to https based service.
Issue-ID: OOM-2173
Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
Change-Id: I8b226cd6d8cd598cf6578b58d0d0c0f9558fd818
|
|
|
|
Add Ingress for dgbuilder in common and update SDNC and APPC in order to
use proper configuration.
Issue-ID: OOM-2173
Issue-ID: OOM-2188
Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
Change-Id: Ib810ce3f4b3ff2ff3297c39be352d246aef6d7f1
|
|
Change ingress host to the required hostnames
Change-Id: Ic78c8821e2e23e00943d8abdf7b2183b4d940c72
Signed-off-by: Lucjan Bryndza <l.bryndza@samsung.com>
Issue-ID: OOM-2391
Signed-off-by: Lucjan Bryndza <l.bryndza@samsung.com>
|
|
|
|
Start using auto-generated password for sdnctl db instead of using the
one hardcoded in values.yaml
Issue-ID: OOM-2275
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I0a3b526387830d2bf44e88281896d0b87a92ce94
|
|
Start using auto-generated password for appcctl db instead of using the
one hardcoded in values.yaml
Issue-ID: OOM-2275
Change-Id: I3884a5b30a47d602b28136f984ebe4492ec43fb2
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
|
|
Using the common templates for centralized logging.
Issue-ID: OOM-2370
Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
Change-Id: Ib0995b754597da36d06939199738cf93398e796a
|
|
|
|
|
|
1.7.1 release for APPC
Issue-ID: APPC-1849
Change-Id: I6b5f2d03bd737b0b12345339ab923f1c9b7627b4
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Use 6.0.0 in preparation for Frankfurt release
Issue-ID: OOM-2320
Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
Change-Id: I8ad82dfdf48b56c38c0e85d640b18cc13c8d9e67
|
|
move AAF cert out of APPC docker to
APPC helm chart
new AAF cert:
Validity
Not Before: Mar 27 18:03:32 2020 GMT
Not After : Mar 27 18:03:32 2021 GMT
Issue-ID: APPC-1857
Change-Id: I25adc3fce2bed234c6748a87d975c46f1e607260
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
|
|
picking up ODL default aaa-app-config.xml
file when AAF disabled.
Issue-ID: APPC-1855
Change-Id: Ic53156e3c24180a20c9b1be46d3d3a7824c468c9
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Issue-ID: OOM-2051
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I8b6d8f649d8ae45d232cd853f4f194534f8031cf
|
|
the port 30208 was using http apidoc
since we have moved to https apidoc
hence this 30208 can be removed
Issue-ID: APPC-1851
Change-Id: Iccd814bd624635939c51147489af708320caedac
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Use init container construction & common secret template to remove
hardcoded mysql db credentials.
For now credentials are still hardcoded in the values file to avoid
making too many changes at once.
I also had to make properties files writeable because appc uses some
weird design and modifies them inside main container while starting
odl.
Issue-ID: OOM-2275
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Ie36522fc1fdf92a382d5f25a54d4cb150b57ea35
|
|
In commit:
e74ed5cd24d ("[APPC] Don't hardcode mariadb root password")
startOdl.sh script has been updated to take the root password from the
environment variable. Unfortunately there was a typo in variable name
which resulted in using empty string instead of password.
Issue-ID: APPC-1830
Fixes: e74ed5cd24d ("[APPC] Don't hardcode mariadb root password")
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I537e3e24ee4bbbc20d5ebc07dddd9f0d3cbe26d8
|