diff options
| author |   guillaume.lambert <guillaume.lambert@orange.com> | 2021-12-07 20:21:17 +0100 |
|---|---|---|
| committer | guillaume.lambert <guillaume.lambert@orange.com> | 2021-12-08 13:59:00 +0100 |
| commit | f657a816b9074f5bf2b3d300d93266269c1f05a5 (patch) | |
| tree | f639250c0375d2e8a7017e694342e38809155530 /kubernetes/common/cassandra/resources | |
| parent | 370c6dc33e55bfee7b3b79bcc21481b02a3f1e24 (diff) | |
[COMMON] Fix "local var=XX" bashisms
Variable attribute 'local' is not POSIX but is LSB supported.
It is available in other shells such as ash or dash.
And in ksh, local is the default scope of functions vaiables.
Though, the syntax "local var=XX" is only supported and found in bash.
Sadly, this is not detected by checkbashims.
- fix "local var=XX" bashisms
- add a manual command in tox.ini to detect them in the CI
https://wiki.ubuntu.com/DashAsBinSh#local
https://wiki.ubuntu.com/DashAsBinSh#declare_or_typeset
https://stackoverflow.com/questions/12000949/scope-of-variables-in-ksh
Issue-ID: OOM-2643
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iff26e50cd352eeb760d923a4740a6f92184fe0f2
Diffstat (limited to 'kubernetes/common/cassandra/resources')
| -rw-r--r-- | kubernetes/common/cassandra/resources/config/docker-entrypoint.sh | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/kubernetes/common/cassandra/resources/config/docker-entrypoint.sh b/kubernetes/common/cassandra/resources/config/docker-entrypoint.sh index 4dcebc8883..f9f62739f2 100644 --- a/kubernetes/common/cassandra/resources/config/docker-entrypoint.sh +++ b/kubernetes/common/cassandra/resources/config/docker-entrypoint.sh @@ -29,7 +29,8 @@ _ip_address() { # "sed -i", but without "mv" (which doesn't work on a bind-mounted file, for example) _sed_in_place() { - local filename="$1"; shift + local filename + filename="$1"; shift local tempFile tempFile="$(mktemp)" sed "$@" "$filename" > "$tempFile" |