summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorguillaume.lambert <guillaume.lambert@orange.com>2021-09-07 16:09:54 +0200
committerguillaume.lambert <guillaume.lambert@orange.com>2021-09-07 16:32:25 +0200
commit639768edbe0fbeb61c0aac0a74510b663f33a9fd (patch)
tree17c87c2c123ca9420def2e8a34e721da03454c2a
parenta8f89adf23312cd9207f01ebdace6ea99a9e35d7 (diff)
[COMMON] Fix bashisms in import-custom-cert
Bashisms of type (should be 'b = a') were all fixed previously but a new one was reintroduced during the fixes of other types. Also commit f79b6676cfdc380e004f184a21bb969b2824c06e moved import-custom-cert shebang from bash to sh but substring syntaxes similar to ${f: -4} and only supported by bash were not migrated. Let's fix that alltogether before enforcing the checkbashisms tox profile. Issue-ID: OOM-2643 Issue-ID: POLICY-3232 Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com> Change-Id: Ie9b5ac1c2edd9ddf3574f09c77ca8734f2311d1d
-rwxr-xr-xkubernetes/common/cert-wrapper/resources/import-custom-certs.sh9
1 files changed, 4 insertions, 5 deletions
diff --git a/kubernetes/common/cert-wrapper/resources/import-custom-certs.sh b/kubernetes/common/cert-wrapper/resources/import-custom-certs.sh
index 6df7505e7b..eb07a74cd4 100755
--- a/kubernetes/common/cert-wrapper/resources/import-custom-certs.sh
+++ b/kubernetes/common/cert-wrapper/resources/import-custom-certs.sh
@@ -37,10 +37,10 @@ for f in $CERTS_DIR/*; do
# Dont use onap truststore when aaf is disabled
continue
fi
- if [ ${f: -3} = ".sh" ]; then
+ if echo $f | grep '\.sh$' >/dev/null; then
continue
fi
- if [ ${f: -4} = ".b64" ]
+ if echo $f | grep '\.b64$' >/dev/null; then
then
base64 -d $f > $WORK_DIR/`basename $f .b64`
else
@@ -49,8 +49,7 @@ for f in $CERTS_DIR/*; do
done
for f in $MORE_CERTS_DIR/*; do
- if [ ${f: -4} == ".pem" ]
- then
+ if echo $f | grep '\.pem$' >/dev/null; then
cp $f $WORK_DIR/.
fi
done
@@ -67,7 +66,7 @@ fi
# Import Custom Certificates
for f in $WORK_DIR/*; do
- if [ ${f: -4} = ".pem" ]; then
+ if echo $f | grep '\.pem$' >/dev/null; then
echo "importing certificate: $f"
keytool -import -file $f -alias `basename $f` -keystore $WORK_DIR/$TRUSTSTORE_OUTPUT_FILENAME -storepass $TRUSTSTORE_PASSWORD -noprompt
if [ $? != 0 ]; then