1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
|
/*
* Copyright 2020 Intel Corporation, Inc
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package api
import (
"bytes"
"encoding/json"
"io"
"net/http"
"net/http/httptest"
"reflect"
"testing"
moduleLib "github.com/onap/multicloud-k8s/src/orchestrator/pkg/module"
pkgerrors "github.com/pkg/errors"
)
//Creating an embedded interface via anonymous variable
//This allows us to make mockDB satisfy the DatabaseConnection
//interface even if we are not implementing all the methods in it
type mockControllerManager struct {
// Items and err will be used to customize each test
// via a localized instantiation of mockControllerManager
Items []moduleLib.Controller
Err error
}
func (m *mockControllerManager) CreateController(inp moduleLib.Controller) (moduleLib.Controller, error) {
if m.Err != nil {
return moduleLib.Controller{}, m.Err
}
return m.Items[0], nil
}
func (m *mockControllerManager) GetController(name string) (moduleLib.Controller, error) {
if m.Err != nil {
return moduleLib.Controller{}, m.Err
}
return m.Items[0], nil
}
func (m *mockControllerManager) DeleteController(name string) error {
return m.Err
}
func TestControllerCreateHandler(t *testing.T) {
testCases := []struct {
label string
reader io.Reader
expected moduleLib.Controller
expectedCode int
controllerClient *mockControllerManager
}{
{
label: "Missing Body Failure",
expectedCode: http.StatusBadRequest,
controllerClient: &mockControllerManager{},
},
{
label: "Create Controller",
expectedCode: http.StatusCreated,
reader: bytes.NewBuffer([]byte(`{
"name":"testController",
"ip-address":"10.188.234.1",
"port":8080
}`)),
expected: moduleLib.Controller{
Name: "testController",
Host: "10.188.234.1",
Port: 8080,
},
controllerClient: &mockControllerManager{
//Items that will be returned by the mocked Client
Items: []moduleLib.Controller{
{
Name: "testController",
Host: "10.188.234.1",
Port: 8080,
},
},
},
},
{
label: "Missing Controller Name in Request Body",
reader: bytes.NewBuffer([]byte(`{
"description":"test description"
}`)),
expectedCode: http.StatusBadRequest,
controllerClient: &mockControllerManager{},
},
}
for _, testCase := range testCases {
t.Run(testCase.label, func(t *testing.T) {
request := httptest.NewRequest("POST", "/v2/controllers", testCase.reader)
resp := executeRequest(request, NewRouter(nil, nil, testCase.controllerClient, nil, nil, nil, nil, nil, nil))
//Check returned code
if resp.StatusCode != testCase.expectedCode {
t.Fatalf("Expected %d; Got: %d", testCase.expectedCode, resp.StatusCode)
}
//Check returned body only if statusCreated
if resp.StatusCode == http.StatusCreated {
got := moduleLib.Controller{}
json.NewDecoder(resp.Body).Decode(&got)
if reflect.DeepEqual(testCase.expected, got) == false {
t.Errorf("createHandler returned unexpected body: got %v;"+
" expected %v", got, testCase.expected)
}
}
})
}
}
func TestControllerGetHandler(t *testing.T) {
testCases := []struct {
label string
expected moduleLib.Controller
name, version string
expectedCode int
controllerClient *mockControllerManager
}{
{
label: "Get Controller",
expectedCode: http.StatusOK,
expected: moduleLib.Controller{
Name: "testController",
Host: "10.188.234.1",
Port: 8080,
},
name: "testController",
controllerClient: &mockControllerManager{
Items: []moduleLib.Controller{
{
Name: "testController",
Host: "10.188.234.1",
Port: 8080,
},
},
},
},
{
label: "Get Non-Existing Controller",
expectedCode: http.StatusInternalServerError,
name: "nonexistingController",
controllerClient: &mockControllerManager{
Items: []moduleLib.Controller{},
Err: pkgerrors.New("Internal Error"),
},
},
}
for _, testCase := range testCases {
t.Run(testCase.label, func(t *testing.T) {
request := httptest.NewRequest("GET", "/v2/controllers/"+testCase.name, nil)
resp := executeRequest(request, NewRouter(nil, nil, testCase.controllerClient, nil, nil, nil, nil, nil, nil))
//Check returned code
if resp.StatusCode != testCase.expectedCode {
t.Fatalf("Expected %d; Got: %d", testCase.expectedCode, resp.StatusCode)
}
//Check returned body only if statusOK
if resp.StatusCode == http.StatusOK {
got := moduleLib.Controller{}
json.NewDecoder(resp.Body).Decode(&got)
if reflect.DeepEqual(testCase.expected, got) == false {
t.Errorf("listHandler returned unexpected body: got %v;"+
" expected %v", got, testCase.expected)
}
}
})
}
}
func TestControllerDeleteHandler(t *testing.T) {
testCases := []struct {
label string
name string
version string
expectedCode int
controllerClient *mockControllerManager
}{
{
label: "Delete Controller",
expectedCode: http.StatusNoContent,
name: "testController",
controllerClient: &mockControllerManager{},
},
{
label: "Delete Non-Existing Controller",
expectedCode: http.StatusInternalServerError,
name: "testController",
controllerClient: &mockControllerManager{
Err: pkgerrors.New("Internal Error"),
},
},
}
for _, testCase := range testCases {
t.Run(testCase.label, func(t *testing.T) {
request := httptest.NewRequest("DELETE", "/v2/controllers/"+testCase.name, nil)
resp := executeRequest(request, NewRouter(nil, nil, testCase.controllerClient, nil, nil, nil, nil, nil, nil))
//Check returned code
if resp.StatusCode != testCase.expectedCode {
t.Fatalf("Expected %d; Got: %d", testCase.expectedCode, resp.StatusCode)
}
})
}
}
|
