diff options
author | Victor Morales <victor.morales@intel.com> | 2018-09-25 10:33:15 -0700 |
---|---|---|
committer | Victor Morales <victor.morales@intel.com> | 2018-09-25 10:33:15 -0700 |
commit | 7395f007490c19027b81d1f73462fe3602ad630d (patch) | |
tree | 171c63498112642b9740fdc12027665452931fc3 /src/k8splugin/plugins/namespace/plugin.go | |
parent | b7e7f8f659439ac1db7b42ad47828def65eb094c (diff) |
Improve Namespaces UTs
The current implementation of Unit Tests for Namespaces wasn't
validating sucessful cases properly. This change fix that gap and
increase the coverage number.
Change-Id: Iddc0aca3b52ea8ffebca7dccfc94d4d99e052b06
Signed-off-by: Victor Morales <victor.morales@intel.com>
Issue-ID: MULTICLOUD-301
Diffstat (limited to 'src/k8splugin/plugins/namespace/plugin.go')
-rw-r--r-- | src/k8splugin/plugins/namespace/plugin.go | 18 |
1 files changed, 8 insertions, 10 deletions
diff --git a/src/k8splugin/plugins/namespace/plugin.go b/src/k8splugin/plugins/namespace/plugin.go index e29ff43d..de2f4f8b 100644 --- a/src/k8splugin/plugins/namespace/plugin.go +++ b/src/k8splugin/plugins/namespace/plugin.go @@ -37,25 +37,23 @@ func Create(data *krd.ResourceData, client kubernetes.Interface) (string, error) if err != nil { return "", pkgerrors.Wrap(err, "Create Namespace error") } + log.Printf("Namespace (%s) created", data.Namespace) + return data.Namespace, nil } // Get an existing namespace hosted in a specific Kubernetes cluster func Get(name string, namespace string, client kubernetes.Interface) (string, error) { - opts := metaV1.ListOptions{} + opts := metaV1.GetOptions{} + opts.APIVersion = "apps/v1" + opts.Kind = "Deployment" - list, err := client.CoreV1().Namespaces().List(opts) + ns, err := client.CoreV1().Namespaces().Get(name, opts) if err != nil { - return "", pkgerrors.Wrap(err, "Get Namespace list error") - } - - for _, ns := range list.Items { - if namespace == ns.Name { - return ns.Name, nil - } + return "", pkgerrors.Wrap(err, "Get Namespace error") } - return "", nil + return ns.Name, nil } // Delete an existing namespace hosted in a specific Kubernetes cluster |