Enhance error handling and HTTP codes in DCM

This improves error handling between DCM and the database resources and
adds/corrects a lot more HTTP return codes in the API, respectively.

Issue-ID: MULTICLOUD-1143
Change-Id: I3abc8025660e042f4c946f8bbfd280e1eb4c9583
Signed-off-by: Igor D.C <igor.duarte.cardoso@intel.com>

1 files changed, 6 insertions, 3 deletions

diff --git a/src/dcm/pkg/module/cluster.go b/src/dcm/pkg/module/cluster.go
index 206d79a6..85b20117 100644
--- a/src/dcm/pkg/module/cluster.go
+++ b/src/dcm/pkg/module/cluster.go
@@ -133,7 +133,7 @@ func (v *ClusterClient) GetCluster(project, logicalCloud, clusterReference strin
 		return cl, nil
 	}
 
-	return Cluster{}, pkgerrors.New("Error getting Cluster")
+	return Cluster{}, pkgerrors.New("Cluster Reference does not exist")
 }
 
 // GetAll returns all cluster references in the logical cloud
@@ -149,6 +149,9 @@ func (v *ClusterClient) GetAllClusters(project, logicalCloud string) ([]Cluster,
 	if err != nil {
 		return []Cluster{}, pkgerrors.Wrap(err, "Get All Cluster references")
 	}
+	if len(values) == 0 {
+		return []Cluster{}, pkgerrors.New("No Cluster References associated")
+	}
 
 	for _, value := range values {
 		cl := Cluster{}
@@ -188,12 +191,12 @@ func (v *ClusterClient) UpdateCluster(project, logicalCloud, clusterReference st
 
 	//Check for name mismatch in cluster reference
 	if c.MetaData.ClusterReference != clusterReference {
-		return Cluster{}, pkgerrors.New("Update Error - Cluster reference mismatch")
+		return Cluster{}, pkgerrors.New("Cluster Reference mismatch")
 	}
 	//Check if this Cluster reference exists
 	_, err := v.GetCluster(project, logicalCloud, clusterReference)
 	if err != nil {
-		return Cluster{}, pkgerrors.New("Update Error - Cluster reference doesn't exist")
+		return Cluster{}, pkgerrors.New("Cluster Reference does not exist")
 	}
 	err = v.util.DBInsert(v.storeName, key, nil, v.tagMeta, c)
 	if err != nil {