diff options
author | Tait,Trevor(rt0435) <rtait@amdocs.com> | 2018-10-30 13:22:36 -0400 |
---|---|---|
committer | Tait,Trevor(rt0435) <rtait@amdocs.com> | 2018-11-02 14:12:49 -0400 |
commit | 23b36e3c69f25d8322afb79d5e6bace519db7cd3 (patch) | |
tree | 5223fe7c12d0b81877759e0c19653c6249c8cf29 /src/main/java/org/onap/pomba/contextbuilder/sdnc/model/VnfInstance.java | |
parent | a088960969f4d54e39cd83c8e24565301b6c7d67 (diff) |
Address Bugs and Vulnerabilities in Sonar Report
Addressing Bugs and Vulnerabilities in Sonar Report.
https://sonar.onap.org/dashboard?id=org.onap.logging-analytics.pomba%3Apomba-sdnc-context-builder
Issue-ID: LOG-791
Change-Id: I11b984cac77c8a5674103672fa0e1332ed0aa4f7
Signed-off-by: Tait,Trevor(rt0435) <rtait@amdocs.com>
Diffstat (limited to 'src/main/java/org/onap/pomba/contextbuilder/sdnc/model/VnfInstance.java')
-rw-r--r-- | src/main/java/org/onap/pomba/contextbuilder/sdnc/model/VnfInstance.java | 24 |
1 files changed, 13 insertions, 11 deletions
diff --git a/src/main/java/org/onap/pomba/contextbuilder/sdnc/model/VnfInstance.java b/src/main/java/org/onap/pomba/contextbuilder/sdnc/model/VnfInstance.java index e3fb756..0deaa63 100644 --- a/src/main/java/org/onap/pomba/contextbuilder/sdnc/model/VnfInstance.java +++ b/src/main/java/org/onap/pomba/contextbuilder/sdnc/model/VnfInstance.java @@ -118,16 +118,6 @@ public class VnfInstance { private static final Gson gson = new GsonBuilder().disableHtmlEscaping().create(); - public static VnfInstance fromJson(String payload) throws AuditException { - try { - if (payload == null || payload.isEmpty()) { - throw new Exception(AuditError.JSON_EMPTY_RESPONSE); - } - return gson.fromJson(payload, VnfInstance.class); - } catch (Exception ex) { - throw new AuditException(AuditError.JSON_PARSE_ERROR, ex); - } - } /** * No args constructor for use in serialization @@ -197,6 +187,18 @@ public class VnfInstance { this.vfModules = vfModules; } + public static VnfInstance fromJson(String payload) throws AuditException { + try { + if (payload == null || payload.isEmpty()) { + throw new AuditException(AuditError.JSON_EMPTY_RESPONSE); + } + return gson.fromJson(payload, VnfInstance.class); + } catch (Exception ex) { + throw new AuditException(AuditError.JSON_PARSE_ERROR, ex); + } + } + + public String getVnfId() { return vnfId; } @@ -428,7 +430,7 @@ public class VnfInstance { if (other == this) { return true; } - if ((other instanceof VnfInstance) == false) { + if (!(other instanceof VnfInstance)) { return false; } VnfInstance rhs = ((VnfInstance) other); |