[DMAAP] Refactoring dmaap suites

Remove dmaap-bc ssl suite
Remove 5gbulkpm as it runs in gating already
Update bc suite to use latest image

Issue-ID: DMAAP-1502
Signed-off-by: efiacor <fiachra.corcoran@est.tech>
Change-Id: I14146fe616a2da49b5dcf9b4c98f9976fc65a86f

3 files changed, 24 insertions, 205 deletions

diff --git a/tests/dmaap-buscontroller/with_dr/__init__.robot b/tests/dmaap-buscontroller/with_dr/__init__.robot
new file mode 100644
index 00000000..2d404124
--- /dev/null
+++ b/tests/dmaap-buscontroller/with_dr/__init__.robot
@@ -0,0 +1,2 @@
+*** Settings ***
+Documentation    dmaap-buscontroller - dr
diff --git a/tests/dmaap-buscontroller/with_dr/orig b/tests/dmaap-buscontroller/with_dr/orig
deleted file mode 100755
index fcac2026..00000000
--- a/tests/dmaap-buscontroller/with_dr/orig
+++ /dev/null
@@ -1,116 +0,0 @@
-*** Settings ***
-Library           OperatingSystem
-Library           RequestsLibrary
-Library           requests
-Library           Collections
-Library           String
-
-*** Variables ***
-${TARGET_URL}                   https://${DR_PROV_IP}:8443
-${TARGET_URL_FEED}              https://${DR_PROV_IP}:8443/feed/1
-${TARGET_URL_SUBSCRIBE}         https://${DR_PROV_IP}:8443/subscribe/1
-${TARGET_URL_SUBSCRIPTION}      https://${DR_PROV_IP}:8443/subs/1
-${TARGET_URL_PUBLISH}           https://${DR_NODE_IP}:8443/publish/1/csit_test
-${CREATE_FEED_DATA}             {"name": "CSIT_Test", "version": "m1.0", "description": "CSIT_Test", "business_description": "CSIT_Test", "suspend": false, "deleted": false, "changeowner": true, "authorization": {"classification": "unclassified", "endpoint_addrs": [],  "endpoint_ids": [{"password": "rs873m", "id": "rs873m"}]}}
-${UPDATE_FEED_DATA}             {"name": "CSIT_Test", "version": "m1.0", "description": "UPDATED-CSIT_Test", "business_description": "CSIT_Test", "suspend": true, "deleted": false, "changeowner": true, "authorization": {"classification": "unclassified", "endpoint_addrs": [],  "endpoint_ids": [{"password": "rs873m", "id": "rs873m"}]}}
-${SUBSCRIBE_DATA}               {"delivery":{ "url":"https://${DR_PROV_IP}:8080/",  "user":"rs873m", "password":"rs873m", "use100":true}, "metadataOnly":false, "suspend":false, "groupid":29, "subscriber":"sg481n"}
-${UPDATE_SUBSCRIPTION_DATA}     {"delivery":{ "url":"https://${DR_PROV_IP}:8080/",  "user":"sg481n", "password":"sg481n", "use100":true}, "metadataOnly":false, "suspend":true, "groupid":29, "subscriber":"sg481n"}
-${FEED_CONTENT_TYPE}            application/vnd.att-dr.feed
-${SUBSCRIBE_CONTENT_TYPE}       application/vnd.att-dr.subscription
-${PUBLISH_FEED_CONTENT_TYPE}    application/octet-stream
-
-*** Test Cases ***
-Run Feed Creation
-    [Documentation]                 Feed Creation
-    [Timeout]                       1 minute
-    ${resp}=                        PostCall                         ${TARGET_URL}         ${CREATE_FEED_DATA}    ${FEED_CONTENT_TYPE}    rs873m
-    log                             ${TARGET_URL}
-    log                             ${resp.text}
-    Should Be Equal As Strings      ${resp.status_code}              201
-    log                             'JSON Response Code:'${resp}
-
-Run Subscribe to Feed
-    [Documentation]                 Subscribe to Feed
-    [Timeout]                       1 minute
-    ${resp}=                        PostCall                         ${TARGET_URL_SUBSCRIBE}    ${SUBSCRIBE_DATA}      ${SUBSCRIBE_CONTENT_TYPE}    sg481n
-    log                             ${TARGET_URL_SUBSCRIBE}
-    log                             ${resp.text}
-    Should Be Equal As Strings      ${resp.status_code}              201
-    log                             'JSON Response Code:'${resp}
-
-Run Publish Feed
-    [Documentation]                 Publish to Feed
-    [Timeout]                       1 minute
-    Sleep                           10s                              Behaviour was noticed where feed was not created in time for publish to be sent
-    ${resp}=                        PutCall                          ${TARGET_URL_PUBLISH}    ${CREATE_FEED_DATA}      ${PUBLISH_FEED_CONTENT_TYPE}    rs873m
-    log                             ${TARGET_URL_PUBLISH}
-    log                             ${resp.text}
-    Should Be Equal As Strings      ${resp.status_code}              204
-    log                             'JSON Response Code:'${resp}
-
-Run Update Subscription
-    [Documentation]                 Update Subscription to suspend and change delivery credentials
-    [Timeout]                       1 minute
-    ${resp}=                        PutCall                          ${TARGET_URL_SUBSCRIPTION}    ${UPDATE_SUBSCRIPTION_DATA}      ${SUBSCRIBE_CONTENT_TYPE}    sg481n
-    log                             ${TARGET_URL_SUBSCRIPTION}
-    log                             ${resp.text}
-    Should Be Equal As Strings      ${resp.status_code}              200
-    log                             'JSON Response Code:'${resp}
-    ${resp}=                        GetCall                          ${TARGET_URL_SUBSCRIPTION}    ${SUBSCRIBE_CONTENT_TYPE}    sg481n
-    log                             ${resp.text}
-    Should Contain                  ${resp.text}                     "password":"sg481n","user":"sg481n"
-    log                             'JSON Response Code:'${resp}
-
-Run Update Feed
-    [Documentation]                 Update Feed description and suspend
-    [Timeout]                       1 minute
-    ${resp}=                        PutCall                          ${TARGET_URL_FEED}    ${UPDATE_FEED_DATA}      ${FEED_CONTENT_TYPE}    rs873m
-    log                             ${TARGET_URL_FEED}
-    log                             ${resp.text}
-    Should Be Equal As Strings      ${resp.status_code}              200
-    log                             'JSON Response Code:'${resp}
-    ${resp}=                        GetCall                          ${TARGET_URL_FEED}    ${FEED_CONTENT_TYPE}    rs873m
-    log                             ${resp.text}
-    Should Contain                  ${resp.text}                     "UPDATED-CSIT_Test"
-    log                             'JSON Response Code:'${resp}
-
-Run Delete Subscription
-    [Documentation]                 Delete Subscription
-    [Timeout]                       1 minute
-    ${resp}=                        DeleteCall                       ${TARGET_URL_SUBSCRIPTION}    sg481n
-    log                             ${resp.text}
-    Should Be Equal As Strings      ${resp.status_code}              204
-    log                             'JSON Response Code:'${resp}
-
-Run Delete Feed
-    [Documentation]                 Delete Feed
-    [Timeout]                       1 minute
-    ${resp}=                        DeleteCall                       ${TARGET_URL_FEED}    rs873m
-    log                             ${resp.text}
-    Should Be Equal As Strings      ${resp.status_code}              204
-    log                             'JSON Response Code:'${resp}
-
-*** Keywords ***
-PostCall
-    [Arguments]      ${url}              ${data}            ${content_type}        ${user}
-    ${headers}=      Create Dictionary   X-ATT-DR-ON-BEHALF-OF=${user}    Content-Type=${content_type}
-    ${resp}=         Evaluate            requests.post('${url}',data='${data}', headers=${headers},verify=False)    requests
-    [Return]         ${resp}
-
-PutCall
-    [Arguments]      ${url}              ${data}            ${content_type}        ${user}
-    ${headers}=      Create Dictionary   X-ATT-DR-ON-BEHALF-OF=${user}    Content-Type=${content_type}    Authorization=Basic cnM4NzNtOnJzODczbQ==
-    ${resp}=         Evaluate            requests.put('${url}',data='${data}', headers=${headers},verify=False)    requests
-    [Return]         ${resp}
-
-GetCall
-    [Arguments]      ${url}              ${content_type}        ${user}
-    ${headers}=      Create Dictionary   X-ATT-DR-ON-BEHALF-OF=${user}    Content-Type=${content_type}
-    ${resp}=         Evaluate            requests.get('${url}', headers=${headers},verify=False)    requests
-    [Return]         ${resp}
-
-DeleteCall
-    [Arguments]      ${url}              ${user}
-    ${headers}=      Create Dictionary   X-ATT-DR-ON-BEHALF-OF=${user}
-    ${resp}=         Evaluate            requests.delete('${url}', headers=${headers},verify=False)    requests
-    [Return]         ${resp}
diff --git a/tests/dmaap-buscontroller/with_dr/test1.robot b/tests/dmaap-buscontroller/with_dr/test1.robot
index a3aef42b..671e89b7 100644
--- a/tests/dmaap-buscontroller/with_dr/test1.robot
+++ b/tests/dmaap-buscontroller/with_dr/test1.robot
@@ -9,127 +9,60 @@ Library           String
 
 
 *** Variables ***
-${MESSAGE}    Hello, world!
-${DBC_URI}    webapi
-${DBC_URL}    http://${DMAAPBC_IP}:8080/${DBC_URI}
+${DBC_URI}     webapi
+${DBC_URL}     http://${DMAAPBC_IP}:8080/${DBC_URI}
 ${LOC}          csit-sanfrancisco
-${PUB_CORE}     "dcaeLocationName": "${LOC}", "clientRole": "org.onap.dmaap.client.pub", "action": [ "pub", "view" ] 
-${SUB_CORE}     "dcaeLocationName": "${LOC}", "clientRole": "org.onap.dmaap.client.sub", "action": [ "sub", "view" ] 
-${PUB}          { ${PUB_CORE} }
-${SUB}          { ${SUB_CORE} }
 ${FEED1_DATA}  { "feedName":"feed1", "feedVersion": "csit", "feedDescription":"generated for CSIT", "owner":"dgl", "asprClassification": "unclassified" }
 ${FEED2_DATA}  { "feedName":"feed2", "feedVersion": "csit", "feedDescription":"generated for CSIT", "owner":"dgl", "asprClassification": "unclassified" }
 ${PUB2_DATA}   { "dcaeLocationName": "${LOC}", "username": "pub2", "userpwd": "topSecret123", "feedId": "2" }
 ${SUB2_DATA}   { "dcaeLocationName": "${LOC}", "username": "sub2", "userpwd": "someSecret123", "deliveryURL": "https://${DMAAPBC_IP}:8443/webapi/noURI", "feedId": "2" }
-${TOPIC2_DATA}  { "topicName":"singleMRtopic2", "topicDescription":"generated for CSIT", "owner":"dgl", "clients": [ ${PUB}, ${SUB}] }
-${TOPIC3_DATA}  { "topicName":"singleMRtopic3", "topicDescription":"generated for CSIT", "owner":"dgl"}
-#${PUB3_DATA}    { "fqtn": "${TOPIC_NS}.singleMRtopic3", ${PUB_CORE} }
-#${SUB3_DATA}    { "fqtn": "${TOPIC_NS}.singleMRtopic3", ${SUB_CORE} }
-
 
 
 *** Test Cases ***
-Url Test
-    [Documentation]    Check if www.onap.org can be reached
-    Create Session     sanity          http://onap.readthedocs.io
-    ${resp}=           Get Request   sanity    /  
-    Should Be Equal As Integers  ${resp.status_code}  200
-
 (DMAAP-441c1)
     [Documentation]        Create Feed w no clients POST ${DBC_URI}/feeds endpoint
-    ${resp}=         PostCall    ${DBC_URL}/feeds    ${FEED1_DATA}
-    Should Be Equal As Integers  ${resp.status_code}  200   
+    ${resp}=         PostCall     ${DBC_URL}/feeds    ${FEED1_DATA}
+    Should Be Equal As Integers   ${resp.status_code}  200
 
 (DMAAP-441c2)
     [Documentation]        Create Feed w clients POST ${DBC_URI}/feeds endpoint
-    ${resp}=         PostCall    ${DBC_URL}/feeds    ${FEED2_DATA}
-    Should Be Equal As Integers  ${resp.status_code}  200   
+    ${resp}=         PostCall     ${DBC_URL}/feeds    ${FEED2_DATA}
+    Should Be Equal As Integers   ${resp.status_code}  200
 
 (DMAAP-441c3)
     [Documentation]        Add Publisher to existing feed
-    ${resp}=         PostCall    ${DBC_URL}/dr_pubs    ${PUB2_DATA}
-    Should Be Equal As Integers  ${resp.status_code}  201   
-    ${tmp}=          Get Json Value      ${resp.text}           /pubId
-    ${tmp}=          Remove String       ${tmp}         \"
-    Set Suite Variable          ${pubId}    ${tmp}
+    ${resp}=         PostCall      ${DBC_URL}/dr_pubs    ${PUB2_DATA}
+    Should Be Equal As Integers    ${resp.status_code}  201
+    ${JSON}=         Evaluate      json.loads(r"""${resp.content}""", strict=False)
+    ${result}=       Set Variable  ${JSON['pubId']}
+    Set Suite Variable             ${pubId}    ${result}
 
 (DMAAP-441c4)
     [Documentation]        Add Subscriber to existing feed
-    ${resp}=         PostCall    ${DBC_URL}/dr_subs    ${SUB2_DATA}
-    Should Be Equal As Integers  ${resp.status_code}  201   
-    ${tmp}=          Get Json Value      ${resp.text}           /subId
-    ${tmp}=          Remove String       ${tmp}         \"
-    Set Suite Variable          ${subId}    ${tmp}
+    ${resp}=         PostCall      ${DBC_URL}/dr_subs    ${SUB2_DATA}
+    Should Be Equal As Integers    ${resp.status_code}  201
+    ${JSON}=         Evaluate      json.loads(r"""${resp.content}""", strict=False)
+    ${result}=       Set Variable  ${JSON['subId']}
+    Set Suite Variable             ${subId}    ${result}
 
 (DMAAP-443)
     [Documentation]        List existing feeds
     Create Session     get          ${DBC_URL}
-    ${resp}=         Get Request    get       /feeds
-    Should Be Equal As Integers  ${resp.status_code}  200
+    ${resp}=         GET On Session    get       /feeds
+    Should Be Equal As Integers     ${resp.status_code}  200
 
 (DMAAP-444)
     [Documentation]        Delete existing subscriber
-    ${resp}=         DelCall    ${DBC_URL}/dr_subs/${subId}
-    Should Be Equal As Integers  ${resp.status_code}  204
+    ${resp}=         DelCall        ${DBC_URL}/dr_subs/${subId}
+    Should Be Equal As Integers     ${resp.status_code}  204
 
 (DMAAP-445)
     [Documentation]        Delete existing publisher
-    ${resp}=         DelCall    ${DBC_URL}/dr_pubs/${pubId}
-    Should Be Equal As Integers  ${resp.status_code}  204
-
-#(DMAAP-294)
-#    [Documentation]        Create Topic w pub and sub clients POST ${DBC_URI}/topics endpoint
-#    ${resp}=         PostCall    ${DBC_URL}/topics    ${TOPIC2_DATA}
-#    Should Be Equal As Integers  ${resp.status_code}  201
-#
-#(DMAAP-295)
-#    [Documentation]        Create Topic w no clients and then add a client POST ${DBC_URI}/mr_clients endpoint
-#    ${resp}=         PostCall    ${DBC_URL}/topics    ${TOPIC3_DATA}
-#    Should Be Equal As Integers  ${resp.status_code}  201   
-#    ${resp}=         PostCall    ${DBC_URL}/mr_clients    ${PUB3_DATA}
-#    Should Be Equal As Integers  ${resp.status_code}  200   
-#    ${resp}=         PostCall    ${DBC_URL}/mr_clients    ${SUB3_DATA}
-#    Should Be Equal As Integers  ${resp.status_code}  200   
-#
-#(DMAAP-297)
-#    [Documentation]    Query for all topics and specific topic
-#    Create Session     get          ${DBC_URL}
-#    ${resp}=           Get Request   get    /topics  
-#    Should Be Equal As Integers  ${resp.status_code}  200
-#    ${resp}=           Get Request   get    /topics/${TOPIC_NS}.singleMRtopic3
-#    Should Be Equal As Integers  ${resp.status_code}  200
-#
-#(DMAAP-301)
-#    [Documentation]    Delete a subscriber
-#    Create Session     get          ${DBC_URL}
-#    ${resp}=           Get Request   get    /topics/${TOPIC_NS}.singleMRtopic3
-#    Should Be Equal As Integers  ${resp.status_code}  200
-#	${tmp}=            Get Json Value      ${resp.text}           /clients/1/mrClientId
-#	${clientId}=       Remove String       ${tmp}         \"
-#    ${resp}=           DelCall   ${DBC_URL}/mr_clients/${clientId}
-#    Should Be Equal As Integers  ${resp.status_code}  204
-#
-#(DMAAP-302)
-#    [Documentation]    Delete a publisher
-#    Create Session     get          ${DBC_URL}
-#    ${resp}=           Get Request   get    /topics/${TOPIC_NS}.singleMRtopic3
-#    Should Be Equal As Integers  ${resp.status_code}  200
-#	${tmp}=            Get Json Value      ${resp.text}           /clients/0/mrClientId
-#	${clientId}=       Remove String       ${tmp}         \"
-#    ${resp}=           DelCall   ${DBC_URL}/mr_clients/${clientId}
-#    Should Be Equal As Integers  ${resp.status_code}  204
+    ${resp}=         DelCall        ${DBC_URL}/dr_pubs/${pubId}
+    Should Be Equal As Integers     ${resp.status_code}  204
 
 
 *** Keywords ***
-CheckDir
-    [Arguments]                 ${path}
-    Directory Should Exist      ${path}
-
-CheckUrl
-    [Arguments]                  ${session}   ${path}     ${expect}
-    ${resp}=                     Get  Request          ${session} ${path} 
-    Should Be Equal As Integers  ${resp.status_code}  ${expect}
-
 PostCall
     [Arguments]    ${url}           ${data}
     ${headers}=    Create Dictionary    Accept=application/json    Content-Type=application/json