1 files changed, 49 insertions, 0 deletions
diff --git a/holmes-actions/src/test/java/org/onap/holmes/common/config/MicroServiceConfigTest.java b/holmes-actions/src/test/java/org/onap/holmes/common/config/MicroServiceConfigTest.java
index 59af9d3..a5d6597 100644
--- a/holmes-actions/src/test/java/org/onap/holmes/common/config/MicroServiceConfigTest.java
+++ b/holmes-actions/src/test/java/org/onap/holmes/common/config/MicroServiceConfigTest.java
@@ -31,6 +31,7 @@ import org.powermock.api.easymock.PowerMock;
 import org.powermock.core.classloader.annotations.PowerMockIgnore;
 import org.powermock.core.classloader.annotations.PrepareForTest;
 import org.powermock.modules.junit4.rule.PowerMockRule;
+import org.powermock.reflect.internal.WhiteboxImpl;
 
 @PrepareForTest(MicroServiceConfig.class)
 @PowerMockIgnore({"javax.ws.*"})
@@ -292,4 +293,52 @@ public class MicroServiceConfigTest {
 
         System.clearProperty(MSB_ADDR);
     }
+
+    @Test
+    public void isValidIpAddress_with_port() throws Exception {
+        boolean res = WhiteboxImpl.invokeMethod(MicroServiceConfig.class, "isIpAddress", "10.75.13.21:90");
+        assertThat(res, is(true));
+    }
+
+    @Test
+    public void isValidIpAddress_without_port() throws Exception {
+        boolean res = WhiteboxImpl.invokeMethod(MicroServiceConfig.class, "isIpAddress", "10.75.13.21");
+        assertThat(res, is(true));
+    }
+
+    @Test
+    public void isValidIpAddress_with_port_with_http_prefix() throws Exception {
+        boolean res = WhiteboxImpl.invokeMethod(MicroServiceConfig.class, "isIpAddress", "http://10.75.13.21:90");
+        assertThat(res, is(true));
+    }
+
+    @Test
+    public void isValidIpAddress_without_port_with_https_prefix() throws Exception {
+        boolean res = WhiteboxImpl.invokeMethod(MicroServiceConfig.class, "isIpAddress", "https://10.75.13.21");
+        assertThat(res, is(true));
+    }
+
+    @Test
+    public void isValidIpAddress_invalid_ip_without_port() throws Exception {
+        boolean res = WhiteboxImpl.invokeMethod(MicroServiceConfig.class, "isIpAddress", "holmes-rule-mgmt");
+        assertThat(res, is(false));
+    }
+
+    @Test
+    public void isValidIpAddress_invalid_ip_with_port() throws Exception {
+        boolean res = WhiteboxImpl.invokeMethod(MicroServiceConfig.class, "isIpAddress", "holmes-rule-mgmt:80");
+        assertThat(res, is(false));
+    }
+
+    @Test
+    public void isValidIpAddress_invalid_ip_without_port_with_http_prefix() throws Exception {
+        boolean res = WhiteboxImpl.invokeMethod(MicroServiceConfig.class, "isIpAddress", "http://holmes-rule-mgmt");
+        assertThat(res, is(false));
+    }
+
+    @Test
+    public void isValidIpAddress_invalid_ip_with_port_with_https_prefix() throws Exception {
+        boolean res = WhiteboxImpl.invokeMethod(MicroServiceConfig.class, "isIpAddress", "https://holmes-rule-mgmt:80");
+        assertThat(res, is(false));
+    }
 }
 \ No newline at end of file