diff options
author | romaingimbert <romain.gimbert@orange.com> | 2018-05-04 13:55:38 +0200 |
---|---|---|
committer | romaingimbert <romain.gimbert@orange.com> | 2018-05-04 13:59:14 +0200 |
commit | f73c501dc6347ea78ff9da629e02200db1dd7297 (patch) | |
tree | b894cf206e4ed8d092fdb92909c593ecfc11ee2d /src/main/java/org/onap/nbi/apis/serviceorder/workflow/CheckOrderConsistenceManager.java | |
parent | 10684b3740dfd38323f617ef2046695e09dbcd30 (diff) |
Sonar clean code
- fix log messages
- fix 2 sonar bugs
- replace LinkedHashMap by Map
Change-Id: I0b7953f09ffa706b5357ac45c7c4290a56bba236
Issue-ID: EXTAPI-81
Signed-off-by: romaingimbert <romain.gimbert@orange.com>
Diffstat (limited to 'src/main/java/org/onap/nbi/apis/serviceorder/workflow/CheckOrderConsistenceManager.java')
-rw-r--r-- | src/main/java/org/onap/nbi/apis/serviceorder/workflow/CheckOrderConsistenceManager.java | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/src/main/java/org/onap/nbi/apis/serviceorder/workflow/CheckOrderConsistenceManager.java b/src/main/java/org/onap/nbi/apis/serviceorder/workflow/CheckOrderConsistenceManager.java index b3179c5..580a606 100644 --- a/src/main/java/org/onap/nbi/apis/serviceorder/workflow/CheckOrderConsistenceManager.java +++ b/src/main/java/org/onap/nbi/apis/serviceorder/workflow/CheckOrderConsistenceManager.java @@ -46,8 +46,8 @@ public class CheckOrderConsistenceManager { if (!existServiceInCatalog(serviceOrderItemInfo)) { serviceOrderInfo.setIsServiceOrderRejected(true); serviceOrderItem.setState(StateType.REJECTED); - LOGGER.error( - "service order item {0} of service order {1} rejected cause no service catalog found for id {2}", + LOGGER.warn( + "service order item {} of service order {} rejected cause no service catalog found for id {}", serviceOrderItem.getId(), serviceOrder.getId(), serviceOrderItem.getService().getServiceSpecification().getId()); } else { @@ -105,11 +105,11 @@ public class CheckOrderConsistenceManager { String serviceOrderId) { if (!StringUtils.isEmpty(serviceOrderItem.getService().getId())) { LOGGER - .error("serviceOrderItem {0} for serviceorder {1} rejected cause service.id must be empty in add action", + .warn("serviceOrderItem {} for serviceorder {} rejected cause service.id must be empty in add action", serviceOrderItem.getId(), serviceOrderId); return false; } else if (!serviceOrderConsumerService.isTenantIdPresentInAAI()) { - LOGGER.error("serviceOrderItem {0} for serviceOrder {1} rejected cause tenantId not found in AAI", + LOGGER.warn("serviceOrderItem {} for serviceOrder {} rejected cause tenantId not found in AAI", serviceOrderItem.getId(), serviceOrderId); return false; } @@ -121,19 +121,19 @@ public class CheckOrderConsistenceManager { ServiceOrderItemInfo serviceOrderItemInfo) { if (StringUtils.isEmpty(serviceOrderItem.getService().getId())) { - LOGGER.error( - "serviceOrderItem {0} for serviceOrder {1} rejected cause service.id is mandatory in delete/change action", + LOGGER.warn( + "serviceOrderItem {} for serviceOrder {} rejected cause service.id is mandatory in delete/change action", serviceOrderItem.getId(), serviceOrderInfo.getServiceOrderId()); return false; } else if (!isCustomerFromServiceOrderPresentInInventory(serviceOrderInfo)) { LOGGER - .error("serviceOrderItem {0} for serviceOrder {1} rejected cause customer not found in inventory", + .warn("serviceOrderItem {} for serviceOrder {} rejected cause customer not found in inventory", serviceOrderItem.getId(), serviceOrderInfo.getServiceOrderId()); return false; } else if (!existServiceInInventory(serviceOrderItem, serviceOrderItemInfo, serviceOrderInfo.getSubscriberInfo().getGlobalSubscriberId())) { LOGGER - .error("serviceOrderItem {0} for serviceOrder {1} rejected cause service id {2} not found in inventory", + .warn("serviceOrderItem {} for serviceOrder {} rejected cause service id {} not found in inventory", serviceOrderItem.getId(), serviceOrderInfo.getServiceOrderId(), serviceOrderItem.getService().getId()); return false; @@ -198,7 +198,7 @@ public class CheckOrderConsistenceManager { LinkedHashMap body = (LinkedHashMap) response.getBody(); serviceOrderItemInfo.setCatalogResponse(body); } else { - LOGGER.error("unable to retrieve catalog information for service {0}", + LOGGER.warn("unable to retrieve catalog information for service {}", serviceOrderItem.getService().getServiceSpecification().getId()); } } |