summaryrefslogtreecommitdiffstats
path: root/docs
AgeCommit message (Collapse)AuthorFilesLines
2019-03-21Update git submodulesPamela Dragosh1-0/+0
* Update docs/submodules/policy/engine.git from branch 'master' to 97ce3b94390c10a1af43ed5614ca976095c0097d - Merge "use hibernate and breakup dbdao and papservlet" - use hibernate and breakup dbdao and papservlet Change-Id: Ifa655d56bda0ab4c748f188767122e7bd927155b Issue-ID: POLICY-1417 Signed-off-by: pa834y <pa834y@att.com>
2019-03-21Update git submodulesSandeep J1-0/+0
* Update docs/submodules/appc.git from branch 'master' to 0a4c5940e9757e422adc24d84044d742563b0829 - added test case to PoolTest.java to increase code coverage Issue-ID: APPC-1086 Change-Id: I1389e3f6600bf8c09140a322c978a68c6fee5df1 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-21Update git submodulesSandeep J1-0/+0
* Update docs/submodules/appc.git from branch 'master' to f734eff061de3c8570e005aa282ceed0b0a8f7b5 - added test case to VmStatuschecker.java to increase code coverage Issue-ID: APPC-1086 Change-Id: Id1a3be46235af057c1f3f72cd2afd8ebbe377bc2 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2019-03-21Update git submoduleseronkeo1-0/+0
* Update docs/submodules/oom/offline-installer.git from branch 'master' to f842b36613c91f86dd371b590e048e5c4e510f34 - update for missing nginx tarfile This update adds an entry to the docker_images lists file to ensure it is saved as a tar file and available for processing in the "Prepare infra related images to infra folder" section. Change-Id: I293144daa96b3c579443a2e76a407ea04821dce7 Issue-ID: OOM-1738 Signed-off-by: eronkeo <ronan.keogh@est.tech>
2019-03-21Update git submodulesPamela Dragosh1-0/+0
* Update docs/submodules/policy/engine.git from branch 'master' to 37a3ff64ba8a3c4b360c7b19a1510b22a95b3415 - Update Casablanca Maint release notes Update release notes for 2nd Casablanca Maintenance release. Issue-ID: POLICY-1607 Change-Id: I283c7697df6ec7519ea3702728ddf06d035a7b09 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com> (cherry picked from commit bc7c2bd6408ce2ee742a294456e45284d7ae2fc2)
2019-03-21Update git submodulesDan Timoney1-0/+0
* Update docs/submodules/ccsdk/cds.git from branch 'master' to 0062e1b42310b4c1dd3665e0ded10b2085923a3e - Merge "Metadata component css changes" - Metadata component css changes Added css changes to metadata component Issue-ID: CCSDK-1098 Change-Id: Ic989b3bec49d0c876901458242ba0d1610ae4418 Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2019-03-21Update git submodulesDan Timoney1-0/+0
* Update docs/submodules/ccsdk/cds.git from branch 'master' to bd70c4972801b672bd7c490ce8ca77d872359bf0 - Merge "Search template css changes" - Search template css changes Made css changes to buttons in search component Issue-ID: CCSDK-1098 Change-Id: I8ad371b291ca6daf72ae8b9445d7c31e69754c33 Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2019-03-21Update git submodulesDan Timoney1-0/+0
* Update docs/submodules/ccsdk/cds.git from branch 'master' to d63aef3d2443847be38e41f3ab2b4c33d9a78a54 - Merge "Select Template css changes" - Select Template css changes Add css changes to buttons in select template component Issue-ID: CCSDK-1098 Change-Id: Id56bfaad1627a5cce2a13eb78155ecdd4a8876b8 Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2019-03-21Update git submodulesDan Timoney1-0/+0
* Update docs/submodules/ccsdk/cds.git from branch 'master' to a5bdd91eaf12ef2d9041bfb0ce3c177490eda77c - Merge "Editor Component Changes" - Editor Component Changes Implemented code to highlight file o select. Issue-ID: CCSDK-1098 Change-Id: I1daa4d86b77ebb5de72f425b536ba64e18b04dfd Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2019-03-21Update git submodulesDan Timoney1-0/+0
* Update docs/submodules/ccsdk/cds.git from branch 'master' to 51e888dddedd08ab38e9afb7de961876a6decea7 - Merge "Designer View css changes" - Designer View css changes Made css changes Issue-ID: CCSDK-975 Change-Id: Ia43f8d3952f09b06d83fe863c8841e15618be71c Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2019-03-21Update git submodulesDan Timoney1-0/+0
* Update docs/submodules/ccsdk/cds.git from branch 'master' to 9cbc876b49d8003fed7af6ae72ed0061f5cf778e - Merge "jsoneditor dependencies added" - jsoneditor dependencies added Change-Id: I5d1fa9c4ba74233792b641acd9bbb1300458bf35 Issue-ID: CCSDK-804 Signed-off-by: sp00501638 <sp00501638@techmahindra.com>
2019-03-21Update git submodulesDan Timoney1-0/+0
* Update docs/submodules/ccsdk/cds.git from branch 'master' to 202e2ec5c8428e67bf5f9b245a9ba3d5dd73a9f1 - Merge "sources template changes" - sources template changes json editor added in panels Change-Id: I99430bc4bcc3be2e729b551a77a2677dcd74d46e Issue-ID: CCSDK-804 Signed-off-by: sp00501638 <sp00501638@techmahindra.com>
2019-03-21Update git submodulesDan Timoney1-0/+0
* Update docs/submodules/ccsdk/cds.git from branch 'master' to aa3e4974775f1c93d98ac1a569dfa53131731d0b - Merge "Search pipe" - Search pipe Change-Id: I12067ff7e9e7a8aac1ea11328e8d0da08cb791f2 Issue-ID: CCSDK-804 Signed-off-by: sp00501638 <sp00501638@techmahindra.com>
2019-03-21Update git submodulesDan Timoney1-0/+0
* Update docs/submodules/ccsdk/cds.git from branch 'master' to 232706f023aa052eff928f23e6fabf32d7895c1b - Merge "Removed unwanted componets" - Removed unwanted componets Change-Id: I8fa225f4f7999e8613786726f88e07fe3259d67f Issue-ID: CCSDK-804 Signed-off-by: sp00501638 <sp00501638@techmahindra.com>
2019-03-21Update git submodulesDan Timoney1-0/+0
* Update docs/submodules/ccsdk/cds.git from branch 'master' to 018e8582d315924b5759c97c6fd495f8e4d237f2 - Merge "Removed save component" - Removed save component Change-Id: I0bec8a830384dc0ba02739e6a5ad7e7a9cebf7c4 Issue-ID: CCSDK-804 Signed-off-by: sp00501638 <sp00501638@techmahindra.com>
2019-03-21Update git submodulesDan Timoney1-0/+0
* Update docs/submodules/ccsdk/cds.git from branch 'master' to c0c91752cf7bb5bddb940de2f0eb8627ad645279 - Merge "Removed unwanted files and folders" - Removed unwanted files and folders Change-Id: I38081c450c458fb7e4f304c236d76f869978a73a Issue-ID: CCSDK-917 Signed-off-by: Ezhilarasi <ezhrajam@in.ibm.com>
2019-03-21Update git submodulesEzhilarasi1-0/+0
* Update docs/submodules/ccsdk/cds.git from branch 'master' to 9c710f46ae1305865a30285bff70a2e5778fbf7f - Modified CBA content Change-Id: I17db49b8aa1864260e0d70c4b42f95257f6d4d08 Issue-ID: CCSDK-917 Signed-off-by: Ezhilarasi <ezhrajam@in.ibm.com>
2019-03-21Update git submodulesDavid Stilwell1-0/+0
* Update docs/submodules/sdnc/oam.git from branch 'master' to b2ce22fe9115e0622eb01b1fba0faa5decb6a3d2 - Merge "Use released version of sdnc-northbound" - Use released version of sdnc-northbound Update sdnc docker build to use released version 1.5.0 of sdnc-northbound. Change-Id: Idf6f50ce14fb61ab8775002a084bdd72e68e8195 Issue-ID: SDNC-704 Signed-off-by: Timoney, Dan (dt5972) <dtimoney@att.com>
2019-03-21Update git submodulesBryan Guo1-0/+0
* Update docs/submodules/sdnc/oam.git from branch 'master' to 05ccc1879959d01720065f633d08e68ede2c04aa - add DGs for BBS usecase Issue-ID: SDNC-698,SDNC-699,SDNC-700 Change-Id: Iac71c3ad2a42def4bf1fd0e3464f028dae5a5414 Signed-off-by: Gxxxx <guofengbei@huawei.com>
2019-03-21Update git submodulesBryan Guo1-0/+0
* Update docs/submodules/sdnc/oam.git from branch 'master' to c128094513b16ceb2902d712edf47d2371d8adab - Add create\deleteAccessConnectivityInstance DGs Issue-ID: SDNC-697,SDNC-697 Change-Id: I13160216d52c32e5b54fb70b6128be4a71f4110e Signed-off-by: Gxxxx <guofengbei@huawei.com>
2019-03-21Update git submodulesBryan Guo1-0/+0
* Update docs/submodules/sdnc/oam.git from branch 'master' to e4baee0166bf461d700c0939586bb5c1170e85ed - Extend network-topology-operation rpc for bbs Issue-ID: SDNC-696 Change-Id: I2d2362e53b0e3560e87a0b13eb94fc9588b5dab3 Signed-off-by: Gxxxx <guofengbei@huawei.com>
2019-03-21Update git submodulesMarco Platania1-0/+0
* Update docs/submodules/integration.git from branch 'master' to 3e674c0d6a25fa5eb6626931ec49ef6be27bb4ae - Merge "Add script which checks for http ports" - Add script which checks for http ports ONAP should not exposed any http ports, https should be used instead. Let's start enforcing this by adding test script to integration which will find all http ports exposed outside of cluster. Issue-ID: SECCOM-231 Change-Id: I88e4b7890aaaa1bea06b496a6f97f4d5e9771215 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
2019-03-21Update git submodulesfzhang1-0/+0
* Update docs/submodules/vnfrqts/requirements.git from branch 'master' to 5cd7cca9d940fa5f867ce74ca218f6710e7ecc69 - Add PNF modeling requirement Update chapter 5 title with PNF modeling support Change-Id: Ica63866cf1aa2446cef711146589392890346646 Issue-ID: VNFRQTS-560 Signed-off-by: fzhang <fei.zhang@ericsson.com>
2019-03-21Update git submodulesMahendra Raghuwanshi1-0/+0
* Update docs/submodules/oom.git from branch 'master' to 4e4c628e28b5b6c16f30afbb8e2eba50f9f4280e - Add cassandra to all override files Issue-ID: OOM-1747 Change-Id: I9a3a1751fdd4cae1ce48d56b4a1b202ba9c3de4b Signed-off-by: Mahendra Raghuwanshi <mahendra.raghuwanshi@amdocs.com>
2019-03-21Update git submodulesfujinhua1-0/+0
* Update docs/submodules/vfc/nfvo/driver/vnfm/svnfm.git from branch 'master' to 0194671a341317b41162ce8f48f8112337c88b0c - Add api adaptor for update nfvo info Change-Id: I4fe49c57b21cfb43ea2061b35d031d01160c4f73 Issue-ID: VFC-1307 Signed-off-by: fujinhua <fu.jinhua@zte.com.cn>
2019-03-21Update git submodulesmaopengzhang1-0/+0
* Update docs/submodules/vfc/nfvo/lcm.git from branch 'master' to 33cccf1ce1c762bf0a26b3dbfb6ccc4b5b219c68 - add license add license Change-Id: I54e4c4c28623d93e9dbcad25620083b72ae46cec Issue-ID: VFC-1211 Signed-off-by: maopengzhang <zhang.maopeng1@zte.com.cn>
2019-03-21Update git submodulesIttay Stern1-0/+0
* Update docs/submodules/vid.git from branch 'master' to 926100a4e3d59d0dbee1f79570fca98d177d323b - Merge "Preset for Workflows action:EQUALS:scaleOut" - Preset for Workflows action:EQUALS:scaleOut Change I71d44c6b36babcc5b8931cda65ab86940062deda modified MsoBusinessLogicImpl.getOrchestrationRequestsForDashboard to require having a response from MSO for action:EQUALS:scaleOut in order to see the other modelType:EQUALS:vnf workflows. Change-Id: Ib5466c366938653f1cb3edfeb07328a4bc0b5afc Issue-ID: VID-403 Signed-off-by: Ittay Stern <ittay.stern@att.com>
2019-03-21Update git submodulesJimmy Forsyth1-0/+0
* Update docs/submodules/integration.git from branch 'master' to 4f12401addd74091066f6ca264374becc2e43c4d - Update ESR to latest artifact Issue-ID: AAI-2236 Change-Id: If2d2b5559c047e0730ee96e5506a50e9f0ba685f Signed-off-by: Jimmy Forsyth <jf2512@att.com>
2019-03-21Update git submoduleszhangab1-0/+0
* Update docs/submodules/usecase-ui.git from branch 'master' to c3e53185d6f653727cee2144804aa5404dea6f5a - Upgrade oparent version to 1.2.3 Change-Id: Iacb464d5333c662b3535c3111ee97978810bfc08 Issue-ID: USECASEUI-247 Signed-off-by: zhangab <zhanganbing@chinamobile.com>
2019-03-21Update git submodulesliboNet1-0/+0
* Update docs/submodules/multicloud/framework.git from branch 'master' to 74c55a7fa750262c3063f6ae8655f209ac63722b - add packages support for artifact broker add a submodule of packages to generate a .zip file. update related pom.xml to make it friendly readable. use the 9014 as healthcheck targetPort Change-Id: I98ed96639bbf6ecfeb87f1bffe2e55e7a62ac062 Issue-ID: MULTICLOUD-546 Signed-off-by: liboNet <libo.zhu@intel.com>
2019-03-21Update git submoduleszhangab1-0/+0
* Update docs/submodules/usecase-ui.git from branch 'master' to b9b4e5e304d5990f367dd30dd70622396d0b9571 - Create repository INFO.yaml file Change-Id: I62be722a7cd4a2ec3213ea73197afecd77b11b31 Issue-ID: USECASEUI-244 Signed-off-by: zhangab <zhanganbing@chinamobile.com>
2019-03-21Update git submodulesVictor Morales1-0/+0
* Update docs/submodules/multicloud/k8s.git from branch 'master' to 7830bf49fbdcf1b726dc8dc3aca3638fb2195e66 - Merge "Remove -a build flag" - Remove -a build flag -a forces rebuilding of packages that are already up-to-date. This is slowing down builds to several minutes Change-Id: Iac082538b91e60b23dc1a2f3b1f1597e078d7a4a Signed-off-by: Ritu Sood <ritu.sood@intel.com> Issue-ID: MULTICLOUD-301
2019-03-21Update git submodulesVictor Morales1-0/+0
* Update docs/submodules/multicloud/k8s.git from branch 'master' to 57ba15140f909434bd309a447c53eb6db4147f8f - Merge "Bring in all the other helper code" - Bring in all the other helper code Bring in all the helper functions added for end to end integration. This allows the api level upload of helm charts, profiles and also instantiation of said helm charts. P3: Plugin index is based on lowercase kind name whereas the map contains the correct case for kind. Convert to lower case before loading the plugin. Changes after rebasing on the new folder structure. Rebasing over the new folder structure P8: Add unit tests for Resolve function Fix the integration tests for createvnf I had to add a huge blob of base64 encoded data based on the profile and sample helm chart to test the flow. P12: Update the integration test with the rb_profile_id parameter Issue-ID: MULTICLOUD-291 Change-Id: If04c41cb185074989ab6c96557958140c43e456d Signed-off-by: Kiran Kamineni <kiran.k.kamineni@intel.com>
2019-03-21Update git submodulesvarun gudisena1-0/+0
* Update docs/submodules/dmaap/dbcapi.git from branch 'master' to cee37b37655ed5a52078e37c7da51c887e2d73e5 - Merge "Sonar Fixes : DrProvConnection.java" - Sonar Fixes : DrProvConnection.java Sonar Fixes : DrProvConnection.java Issue-ID: DMAAP-1100 Change-Id: I1fe275364d281d8fcb3f3b40a6ff2b12777a6c45 Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-03-21Update git submodulesvarun gudisena1-0/+0
* Update docs/submodules/dmaap/dbcapi.git from branch 'master' to c5e7718df9ec94e7ea9a00050caf540f439894f4 - Merge "Added additional test in AafUserRoleTest.java" - Added additional test in AafUserRoleTest.java Added additional test in AafUserRoleTest.java Issue-ID: DMAAP-1098 Change-Id: Ic25143aa1ad7f47e9c513ccee9a52639249d25ad Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-03-21Update git submodulesvarun gudisena1-0/+0
* Update docs/submodules/dmaap/dbcapi.git from branch 'master' to e88b8ed452eced15f80fa5c7ce2b6b0cd9175ec6 - Merge "Additional test case added MRClientTest.java" - Additional test case added MRClientTest.java Additional test case added MRClientTest.java Issue-ID: DMAAP-1102 Change-Id: I14afad009bd7edb66e1b2d0fb33874419af5b3d8 Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-03-21Update git submodulesvarun gudisena1-0/+0
* Update docs/submodules/dmaap/dbcapi.git from branch 'master' to 3a647d5a400d5e929b314e10ff99aea9cd779c61 - Merge "Added Junit Class for AafRole.java" - Added Junit Class for AafRole.java Added Junit Class for AafRole.java Issue-ID: DMAAP-1110 Change-Id: Iaafc578efddb28bc14beb207aa837cca32321b84 Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-03-21Update git submodulesvarun gudisena1-0/+0
* Update docs/submodules/dmaap/dbcapi.git from branch 'master' to 93a4c80c63d074ff15ce81c894f0921fab1d7bef - Merge "Added Junit coverage for BrTopic.java" - Added Junit coverage for BrTopic.java Added Junit coverage for BrTopic.java Issue-ID: DMAAP-1096 Change-Id: I53ebf89e554e2d93227e5951d62ac31589ad3117 Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-03-21Update git submodulesBin Yang1-0/+0
* Update docs/submodules/multicloud/k8s.git from branch 'master' to 69320e75210709ad2dadf3c183289e9a67cf4817 - Merge "Cleanup kubespray config values" - Cleanup kubespray config values There were some kubespray configuration values that are not needed and some are causing conflicts with the dashboard. This change removes them. Change-Id: I6e58b9faf45a24bb29e2760976a157a759ac3115 Signed-off-by: Victor Morales <victor.morales@intel.com> Issue-ID: MULTICLOUD-301
2019-03-21Update git submodulesBin Yang1-0/+0
* Update docs/submodules/multicloud/k8s.git from branch 'master' to c6d4c95561d1d1a783ca0e1176d794b3fa0fdb31 - Merge "Update setup.sh script" - Update setup.sh script This script was changed some instructions which was reported by shellcheck tool and fix some non-ubuntu instructions. Change-Id: If7dce994f024d99aa8f4d306da928e616774b013 Signed-off-by: Victor Morales <victor.morales@intel.com> Issue-ID: MULTICLOUD-301
2019-03-21Update git submoduleseconwar1-0/+0
* Update docs/submodules/dmaap/dbcapi.git from branch 'master' to cf60984e46b65f02e2b48ee423bd487108ae71ed - Add optional decompressData field to DR_Sub Change-Id: Ib9af7cbd5d40eace4d952fb10d9f667919c4df87 Issue-ID: DMAAP-1059 Signed-off-by: econwar <conor.ward@est.tech>
2019-03-21Update git submodulesJegadeesh Babu1-0/+0
* Update docs/submodules/appc.git from branch 'master' to 51550d6c0e25f0e620f3ec7efe078185a85d8e26 - Replaced equals with equalsIgnoreCase method Sonar fix Issue-ID: APPC-1546 Change-Id: I27ca1efc97240419f206502860b63d8e625c0bf8 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-03-21Update git submodulesJegadeesh Babu1-0/+0
* Update docs/submodules/appc.git from branch 'master' to 8cecdb593c5763c14ec42634d690efc170cac97e - Modified code to avoid Null pointer exc Sonar fix Issue-ID: APPC-1547 Change-Id: Ie242256130f255a05366774516cf503c2a3d47cc Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-03-21Update git submodulesJoss Armstrong1-0/+0
* Update docs/submodules/appc.git from branch 'master' to 530c16191693903bdc5bd16de944e48a3f4542a4 - Fix for incorrect handling of SQL results Corrected handling of SQL COUNT query Issue-ID: APPC-1545 Change-Id: I8c246b97c8ed8b483e79ae0e3b2cb51f8b4b62be Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-03-21Update git submodulesJoss Armstrong1-0/+0
* Update docs/submodules/appc.git from branch 'master' to 8c06462b211d573926ee1101759d818f846ea7f5 - Change identifier in database query Future release of MariaDB adds a keyword currently used as an identifier Issue-ID: APPC-1548 Change-Id: I4ced052e6acb816797024f5581f14f5f969d357f Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-03-20Update git submodulesByung-Woo Jun1-0/+0
* Update docs/submodules/so.git from branch 'master' to b06919e6f39b0e9dcb40e02155f9406460d2f38d - Merge "Increase test coverage for SO MON UI" - Increase test coverage for SO MON UI Change-Id: I24faf6303d5257f246ceee9f3280afb2ec843418 Issue-ID: SO-1648 Signed-off-by: Andrei_Barcovschi <andrei.barcovschi@ericsson.com>
2019-03-20Update git submodulesfzhang1-0/+0
* Update docs/submodules/vnfrqts/requirements.git from branch 'master' to fd47aad1b5d4733e00d84096df32701510577ba9 - Update PNFD for chapter 5.1 TOSCA requirement Change-Id: Iea9cbfeb55744a29fd6c6e9c31a7ebdea1b97a79 Issue-ID: VNFRQTS-561 Signed-off-by: fzhang <fei.zhang@ericsson.com>
2019-03-20Update git submodulesSteve Smokowski1-0/+0
* Update docs/submodules/so.git from branch 'master' to cfab2fdde91df35e9f134e128495371939b305a0 - Merge "Add cloudOwner to VNF adapter call" - Add cloudOwner to VNF adapter call The BPMN layer has the CloudRegion which includes the CloudOwner attribute, but this is not passed to the VNF adapter layer. Calls to the Multicloud infrastructure workload need the CloudOwner as well. This patch adds CloudOwner to the VNF adapter API. While the intended usage is primarily for the multicloud adapter, it touches a log of other files - though those do not make use of it at this point. Change-Id: I88028096fbd84fc3fe5d53786c70b3c8806bb711 Issue-ID: SO-1447 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2019-03-20Update git submodulesWitold Ficio Kopel1-0/+0
* Update docs/submodules/so.git from branch 'master' to 26c6548520475894fa23231987f5e3fa69fed6d9 - Removed BPMNLogger class The BPMNLogger class has overlapping use to preferred solution based on slf4j and logback - thus has been replaced by it. Change-Id: I9889d4b9ab06f28941f0d827df889e3c081155da Issue-ID: LOG-631 Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com>
2019-03-20Update git submoduleshb123f1-0/+0
* Update docs/submodules/portal.git from branch 'master' to a70761c096192e38800bf38d6c7f61f52bf72007 - CADI AAF Integration and merging the code Issue-ID: PORTAL-319 CADI AAF Integration and code merge Change-Id: I6e44f3b2741858d8d403b77a49ec9a0153084801 Signed-off-by: hb123f <hbindu@research.att.com>