Age | Commit message (Collapse) | Author | Files | Lines |
|
Project: so master d2e69c0d689596033a9c35aa98d37a44e2cc88cb
WorkflowResponse json issues
This commit adds some robustness to the interface between the
API-H and BPMN, specifically, in how the response is handled.
I don't have proof, but there appears to be some randomness to
the json provider behavior when used with the jax-rs. Sometimes,
the serializer is adding the root element, and sometimes it
is not. Maybe there's something wrong with the configuration.
Maybe we have competing json providers. I couldn't pin this
down.
I'm almost certain it is the presence of the root element in
the content that causes the API-H code to fail parsing of the
BPMN response. This doesn't kill the request, as you might
expect, but rather, the API-H passes the BPMN response through
to the client (VID, or policy, or whatever).
The original problem (SO-586) was "fixed" by "removing the
wrapper". This "wrapper" is a needed feature of the interface
between BPMN and the API-H. We shouldn't have removed it.
The fact that the "fix" appeared to work is due to the
behavior I described in the previous paragraph. The API-H
chokes on the message, and it passes it through unchanged.
Not really what we want.
So, I don't know why the jackson/json behavior is flaky and
different now, but I can (and did) modify the API-H so it can
parse a json message whether or not it has a root element.
Note that WorkflowResponse.java (in BPMN) and CamundaResponse.java
(in the API-H) are basically the same bean representing the
message format. Seems less than ideal to have two different
classes.
Also note that I changed the name of the "response" attribute
of the WorkflowResponse and CamundaResponse classes to "content".
Got tired of seeing this nonsense everywhere in the code:
response.getResponse()
Change-Id: Icaf70f8457de99e493cf882170fe778c620308c9
Issue-ID: SO-586
Issue-ID: SO-618
Signed-off-by: Rob Daugherty <rd472p@att.com>
|
|
Project: so master b4d4cb8703842aee6df6c9a5d2a0fd6617539233
Unwrap root value of request body
Change-Id: I04144bbd22773dfda08d7b13f16080930b7edb3a
Issue-ID: SO-621
Signed-off-by: Arthur Martella <am153x@att.com>
|
|
Project: so master ed47a9897c791d8ce88b188566b09225eadc38a4
Add junit for project mso-catalog-db-adapter
Change-Id: I7b28cc713929400b03b7e567bf9823d82631a1e9
Issue-ID: SO-617
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
|
|
Project: so master 2bcb1f2bdefa3478031b3c3de7eeb568364c8161
Add onap/so alias to docker build
Change-Id: I57525e367ddf5bdbbc13f9efa9e93fda4fb6748e
Issue-ID: SO-372
Signed-off-by: Arthur Martella <am153x@att.com>
|
|
Project: so master 62a8629fef90db13cebe07e07e5bb8fd059b5904
Merge "Resolved License Issues for packages"
Resolved License Issues for packages
csar files:
1. resource_Extvl.csar
2. service-ServiceFdnt-csar-0904-2.csar
3. service-ServiceFdnt-with-allotted.csar
4. service_Rg516VmmscSrvc_csar.csar
Change-Id: I9e56bf3beaeeb858d91c4e9928789458ed9ba75f
Issue-ID: SO-611
Signed-off-by: sanchitap <sanchita@techmahindra.com>
|
|
Project: so master 0833b215e3256ccd56d45430409e676df51602be
Merge "Close db connections in finally block"
Close db connections in finally block
Fix bugs reported by sonar
Change-Id: I0d3445856eb45533d904443b60d75c8aa03e5881
Issue-ID: SO-580
Signed-off-by: Ethan Lynn <ethanlynnl@vmware.com>
|
|
Project: so master 438db5f9e7a4c39afe6c9b38d12f9939418ba51a
Merge "Resolved License Issues for asdc-controller"
Resolved License Issues for asdc-controller
csar files:
1. resource_Extvl.csar
2. service-ServiceFdnt-csar-0904-2.csar
3. service-ServiceFdnt-with-allotted.csar
4. service_Rg516VmmscSrvc_csar.csar
Change-Id: I8688a8a29508c9332eaa8a0130ff2f79db5308dd
Issue-ID: SO-611
Signed-off-by: sanchitap <sanchita@techmahindra.com>
|
|
Project: so master 3e6e4249d8815e76a776615f5ca41a79a3f74a8e
Fix bugs reported by sonar
Use new variable in convertJsonToCloudOrchestrationRequest,
fix bug reported by sonar.
Change-Id: I3f95bd410d950d4661584c1510a66ce90d6785d5
Issue-ID: SO-580
Signed-off-by: Ethan Lynn <ethanlynnl@vmware.com>
|
|
Project: so master b3963d8b0901db1cde5ea85f58684e89b76bf0cc
SO API doc update
Invenroty and MultiVIM APIs updated
Change-Id: Ia72eaae208f94f2dff59a833661b181b6df1768b
Issue-ID: SO-413
Signed-off-by: sanchitap <sanchita@techmahindra.com>
|
|
Project: so master 81efcc2f327dd6583c78211ce39494ca75a99c33
Merge "Remove wrapper from WorkflowResponse"
Remove wrapper from WorkflowResponse
When the workflow response succeeds, the requestReferences object is being wrapped by "WorkflowResponse": {"response": {... and all the other fields from the WorkflowResponse object are being included as well. Adding a WorkflowResponseSerializer didn't seem to work since the root node was still included and there was no ObjectMapper in which to set WrapRootValue to false. So this is the next best thing.
Patch 2 fixes most of the broken unit tests.
Change-Id: Ifa5bd02e70b23f41c9042ac207848c8ade77313a
Issue-ID: SO-586
Signed-off-by: Arthur Martella <am153x@att.com>
|
|
Project: so master beba3e2184d727ab54c08341bbee3b14f97d92db
SO API doc update
UUI APIs, SDC APIs updated
Change-Id: I77a245217197b95b1735e75c8ff0bb09c2772d70
Issue-ID: SO-413
Signed-off-by: sanchitap <sanchita@techmahindra.com>
|
|
Project: so master f2d0a4f94fb3d4ea44d2019271c28db6cdacfb79
vnf-adapter failed to deploy
This is related to recent CloudConfig fixes. One change was apparently
not submitted in the last batch.
Change-Id: I8dcc49f7d808e0d842af3f568f5815fb48870acc
Issue-ID: SO-584
Signed-off-by: Rob Daugherty <rd472p@att.com>
|
|
Project: so master e4f5b019644bcced35371a95f726a2020857af5a
Merge "Fix for FileNotFoundException in MsoLoggerTest"
Fix for FileNotFoundException in MsoLoggerTest
Remove over 100 whitespaces from logger filename which causes the unit
tests to fail in some development environments.
Change-Id: I068f4d4562b635b19889c3537282949665348c21
Issue-ID: SO-604
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
|
|
Project: so master cf508a5dff92e6a1c1904225d35c100b2f80cb92
Merge "updated createvfmoduleinfra flow version number"
updated createvfmoduleinfra flow version number
Change-Id: I0a166b867dcacad4133c8fc679606c381cb5389a
Issue-ID: SO-602
Signed-off-by: Bancala, Ben (bb3476) <bb3476@att.com>
|
|
Project: so master deae427ef4f1203dc560718be34b10cf7b463b7e
Merge "fixed bug in createvnfinfra bpmn"
fixed bug in createvnfinfra bpmn
Change-Id: I3e27ec0d1487eb68e8c54d27508b58233bf49808
Issue-ID: SO-602
Signed-off-by: Bancala, Ben (bb3476) <bb3476@att.com>
|
|
Project: so master 1d2eddedc08439d9d803234106b724ba1c87961a
Merge "SO API document"
SO API document
VFC APIs, Policy APIs updated
Change-Id: I492cc817f57d6f6410ba5ae3cdef6c9f3db1786d
Issue-ID: SO-413
Signed-off-by: sanchitap <sanchita@techmahindra.com>
|
|
Project: so master 2d4467d94e916eea2189fa4b6be26182ff5a4dec
Use tosca parser without resolving GetInput
Use tosca parser without resolving GetInput.
Change-Id: I964464dd76c0bdd096e67ce78ab4cc7c2e76a167
Issue-ID: SO-422
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
|
|
Project: so master e70757bb1888b3e0ebed315b1c621c11dd0833d7
Fix progress update for VFC resources
Fix progress update for VFC resources.
Change-Id: Ibd7d8fb3a399ae2b40ca82e459a7e47c05cbac6a
Issue-ID: SO-422
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
|
|
Project: so master 0d0a79e12a386bcfe42000c0fb825689849422e7
Set operation type value
Set operation type value, to reflect in DB entries.
Change-Id: I2f56bf5f33912645d17bbed2fc759f9354a0ba7b
Issue-ID: SO-422
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
|
|
Project: so master ca5354cad8c8b243ca9ba77f023a247ab4d7be6e
Fix warning in DoDeleteE2E bpmn file
Fix warning in DoDeleteE2E bpmn file.
Change-Id: I50b1ad5502fc08692775d2f5d9050c3796dd32b1
Issue-ID: SO-422
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
|
|
Project: so master 3ee4ec41ac18e51a16eafa767e090502b1a33fb5
Fix CloudConfig junits
...for some definition of the word "fix". There is still a lot
that's less than ideal about how CloudConfig is handled, and with
how the unit tests are written.
Change-Id: Ic8c66c64d336f22c141687cf41a4828810bf1aec
Issue-ID: SO-584
Signed-off-by: Rob Daugherty <rd472p@att.com>
|
|
Project: so master 13999df2b5cbcfd29d479e20970b39ba876725f3
Add enforcer.skip to pom.xml
To prevent appc snapshot problem
Also change appc version to SNAPSHOT
Change-Id: Ifce05b7f44ccc70a2d654526d67da873dd325dcd
Issue-ID: SO-605
Signed-off-by: Arthur Martella <am153x@att.com>
|
|
Project: so master 232d414c6837a17e435cbdf9720b5a24fa344205
ecomp-model-information to onap-model-information
Change-Id: I05f4648ff898a54e7a00d899d97129746172cdb4
Issue-ID: SO-603
Signed-off-by: Arthur Martella <am153x@att.com>
|
|
Project: so master 0dd77e4e0e78d194d7f2839ad9d9e1348d41b432
SDNC Adapter not loading properties
Somebody changed some variables from static to non-static, and this
broke the CloudConfig loading logic.
I changed them back.
Change-Id: Id7dca76a4f0af0209ebd6cef8f3e0209c3f7a022
Issue-ID: SO-584
Signed-off-by: Rob Daugherty <rd472p@att.com>
|
|
Project: so master 19309c3514eb9cd2ec65dd9dc526c2306c80d926
Merge "Fix null attribute for aai relationship"
Fix null attribute for aai relationship
Fix null attribute for aai relationship.
Change-Id: Ifa3a7ec7101c1564be68d97a70d0cafd40d581fe
Issue-ID: SO-422
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
|
|
Project: so master 4ccc2749c4bfc46e82def24eac3a81543a50c024
Merge "createvfcns serviceInstanceid is null bug fix"
createvfcns serviceInstanceid is null bug fix
deleteResource bugs fix
Change-Id: Idaa55084f5ecb0dd3636c232cebc14fa5f06430a
Issue-ID: SO-578
Signed-off-by: Yulian Han <elaine.hanyulian@huawei.com>
|
|
Project: so master 99e77f7cc95157e5df1fb1e7f640c8bba1f4f71c
Merge "Add correlationId to ServiceInstancesRequest"
Add correlationId to ServiceInstancesRequest
Change-Id: Idc5ee56660da31f08fd8ed3a67b7cd28f9844f43
Issue-ID: SO-596
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
|
|
Project: so master 2479d5fde271fd1296fd4e1ae58a8608991496f8
Change to sdncadapter for service call
Change to sdncadapter for service call
Change-Id: I9011e69fba20d4d0f83705455791b7357e2f5bb0
Issue-ID: SO-587
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
|
|
Project: so master b882d58c3e1e94216fb104d0520b1dfc4ff74d3a
Merge "SDNC Adapter not loading properties"
SDNC Adapter not loading properties
We are missing 2 source files in SO which were part of MSO 1802:
CloudConfigInitializer.java
CloudConfigIdentityMapper.java
The missing initializer means that cloud-config.json is never loaded.
Change-Id: Id1186edda01d345de072b5288382dbdc56679294
Issue-ID: SO-584
Signed-off-by: Rob Daugherty <rd472p@att.com>
|
|
Project: so master 91f8e0b1b57565f02628a81bb0d3dd0ee7e45d0b
Merge "Remove operation status set in api-handler"
Remove operation status set in api-handler
Remove operation status set in api-handler
Change-Id: I579d25044130b0701231c0a2d42534e8c63e3ebd
Issue-ID: SO-587
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
|
|
Project: so master e4ac2d051fa33e38f6c01107ee9ba3a74231123f
Merge "Add NS relationship delete for E2E service"
Add NS relationship delete for E2E service
Add NS relationship delete for E2E service
Change-Id: Ia58308dae0fef38b32098d1e92c0871617a86ed2
Issue-ID: SO-422
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
|
|
Project: so master 418931f5d0efb811d36b5b50bcd7233eccccdc3c
Merge "Fix value for VFC sync response"
Fix value for VFC sync response
Fix value for VFC sync response.
Change-Id: Ie663f9080c051b9302dd4729aea5640c5289e14c
Issue-ID: SO-422
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
|
|
Project: so master 29dd03c6fad2ef892632f0b4ace62a6d1dfda149
SO North Bound APIs doc
SO North Bound APIs document
Change-Id: I26789d249926e192ae6a0b59804dfeb3aef740a2
Issue-ID: SO-595
Signed-off-by: sanchitap <sanchita@techmahindra.com>
|
|
Project: so master 98e3f70497d2cdde07bb03a57fdd2ebdf3208882
Fix library CVEs in SO
Fix additional CVEs:
commons-fileupload 1.3.3
For CVE-2016-1000031
logback 1.1.11
For CVE-2017-5929
springframework 4.3.14.RELEASE
For CVE-2014-0225 CVE-2015-5211
Issue-ID: SO-579
Change-Id: I94f8332d420d2586262260a0a59a645f0de66b73
Signed-off-by: chenying83 <chenying83@huawei.com>
|
|
Project: so master efdfc40f759c70b9ab2ac7e23de42c7d211fde79
Merge "Fix VFCNS termination invocation"
Fix VFCNS termination invocation
Fix VFCNS termination invocation
Change-Id: Ib30f0a3e4365e215f6da0a693f78825d5a2d32c9
Issue-ID: SO-422
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
|
|
Project: so master 72ac7f21e79eb69782df1e58cc9f8bddbff82640
Merge "Add service operation initialtion in request db"
Add service operation initialtion in request db
Add service operation initialtion in request db
Change-Id: I2aed78e5cda753b5424b8a8c39e9997a7a7dd61c
Issue-ID: SO-422
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
|
|
Project: so master 44416b271933aded25ff9c6b92a9c830d0359fc2
Merge "PnfReadyEventConsumer implementation"
PnfReadyEventConsumer implementation
Change-Id: Ic8d5814c555bad436bfcbe1b4e212637a6800947
Issue-ID: SO-466
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
|
|
Project: so master 9a8912ad8611d7efdd717e6b098c94c8ed060e45
Merge "Add sync response for VFCNS delete"
Add sync response for VFCNS delete
Add sync response for VFCNS delete
Change-Id: I4917f0a83fc0c33d51b9b90d91f10dbdc023e690
Issue-ID: SO-422
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
|
|
Project: so master 1a2ec2a99538f27dbf9801bc40b0acfe69ebf49e
Merge "Fix service topology deletion"
Fix service topology deletion
Fix request body for service topology deletion.
Issue-ID: SO-422
Change-Id: Ic2e7cc74dd45dbc4b4a190a159f3ebb852e02b84
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
|
|
Project: so master 3f49829a4de066875346091e78da488b318f83c1
Merge "SO API doc"
SO API doc
Create service instance RequestDetails object
Change-Id: I9ff684959c4173f834d424fb2c9a559d32b91182
Issue-ID: SO-413
Signed-off-by: sanchitap <sanchita@techmahindra.com>
|
|
Project: so master 92a682e18131338717cc5e284322904bfb8796b5
Merge "Set Resource Recipe Time Out Val"
Set Resource Recipe Time Out Val
Set Resource Recipe Time Out Val
Change-Id: I7f304465c71837ee37e5fa99a48ca14d97d8f91f
Issue-ID: SO-587
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
|
|
Project: so master c7c76f0e6d6aacf6f1b1cd07a42360291fde7e85
add serviceDecomposition input para for deleteE2E
Change-Id: Idaa55084f5ecb0dd3636c232cebc14fa5f064309
Issue-ID: SO-578
Signed-off-by: Yulian Han <elaine.hanyulian@huawei.com>
|
|
Project: so master 46fb3092fe5bb518f220a6b38650d08cb4fda20d
Merge "Update Delete Resource Flow"
Update Delete Resource Flow
Update Delete Resource Flow
Change-Id: Ie6270d954fc1c703de4bdd0c8f1e543a155060d1
Issue-ID: SO-587
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
|
|
Project: so master 949b8d290a6625130dd0bd9f02bc1187699a77a0
Sonar-Critical:Use Dedicated Exception
File Name:ApplicationControllerAction.java
Line: L127 L134 L142 L150 L155 L160 L165
Sonar Link:
https://sonar.onap.org/project/issues?assignees=as00465059&id=org.onap.so%3Aso&open=AWJuJvroRGy6eclHE9B2&resolved=false&rules=squid%3AS00112&severities=CRITICAL%2CMAJOR
Change-Id: I84c79aef3ceda73b9421b0a1881c5d14817c7840
Issue-ID: SO-593
Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
|
|
Project: so master 8dd34be8135e0566d1713f2f1460e94c6c26e0b0
Merge "Create VF Module Error"
Create VF Module Error
There are multiple issues here.
1) The LCM healthcheck and config-scale-out should be made
conditional upon the VNF orchestration status being Active
or Activated. I'm not going to do that with this commit,
since the logic will probably need to be moved to the
DoCreateVfModule flow. What I will do is bypass the LCM
operations to unblock testing. Another ticket will need
to address the real solution.
2) APP-C gave us an API where the controller type is configured
in their client object, which is NOT what we wanted. As a
result, we have to keep a client object for each controller
type. Our implementation did not do this.
3) Need to support the APP-C client configuration properties
for specifying the SDN-C topic names. I'm refactoring the
APP-C client urn mapping names to make it clear that they
are for configuring the APP-C *client* and not necessarily
for APP-C itself.
Change-Id: I588f3b98b4ee44ba53b4931f9f1a7938ee70bebf
Issue-ID: SO-577
Signed-off-by: Rob Daugherty <rd472p@att.com>
|
|
Project: so master a7705b66d4a5c8a52edfe7ea6b507c8bbdfd5e91
Support for new AAI certificate
Change-Id: I09d207b513008184765ed8db1ec6817323f83a10
Issue-ID: SO-589
Signed-off-by: Rob Daugherty <rd472p@att.com>
|
|
Project: so master 4e40f1186d6dac2bf112ee21dccf5b6a463c00b8
Merge "Fix to get the resource from ordered list"
Fix to get the resource from ordered list
Fix to get the resource from ordered list
Change-Id: I43a7a33a7d2464d7580f175807a1b42d2dce94f2
Issue-ID: SO-422
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
|
|
Project: so master f6ed022b9b87153d5af9f9f4d08231ecbb36fadb
Merge "SO API documentation"
SO API documentation
Create service instance RequestDetails object
Change-Id: I0e7651a927b166a151da427fc3429b29e4b80ec4
Issue-ID: SO-413
Signed-off-by: sanchitap <sanchita@techmahindra.com>
|
|
Project: so master 7f20a3c7cabe00510ae12d261b7094a4b5b477e3
Merge "Fix SDNC resource deletion for E2E service"
Fix SDNC resource deletion for E2E service
Fix SDNC resource deletion for E2E service.
Change-Id: I954c39044b4e4384a7941b6b6c5a0cccc57cf9b3
Issue-ID: SO-422
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
|
|
Project: so master 21fec06da3dfd9fddccf48906260aa3fcdeb5213
Merge "Fix library CVEs in SO"
Fix library CVEs in SO
Fix additional CVEs:
Also refactored to use ubuntu apt repos instead of
manually installing from launchpad.
Issue-ID: SO-579
Change-Id: I58e29a7e0188452789741087bc9c4af82f102b09
Signed-off-by: chenying83 <chenying83@huawei.com>
|