summaryrefslogtreecommitdiffstats
path: root/docs/submodules/sdnc
AgeCommit message (Collapse)AuthorFilesLines
2018-09-14Updated git submodulesshashikanth.vh1-0/+0
Project: sdnc/oam master 1b6bfd0d82c71aa114ed81167cc80e8d2f34feca Integration test issues fix for sdwan and sotn Change-Id: I707a32f69b3ad94d731c2f315d0a7b2fed432388 Issue-ID: SDNC-357 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2018-09-13Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master 3855efad34babec9fb15da4e299c98b34cbfccf5 Merge "add LCM ansible playbooks" add LCM ansible playbooks LCM Playbooks for TrafficManagement Change-Id: I90bae6929ce279a113636b3a075f76bd6ba44188 Issue-ID: SDNC-425 Signed-off-by: Agarwal, Ruchira(ra1926) <ra1926@att.com>
2018-09-13Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master de1d566585acb612d19cd83978daf5d0194c47e3 Merge "CallNodeExecutor patch" CallNodeExecutor patch Merging an old change that prevents a nullpointerexception when calledgraph is null Change-Id: I38580a9f2044e20cc322ad8a8170a06ce69ffd0f Issue-ID: CCSDK-185 Signed-off-by: Cheung, Pat <kc1472@att.com>
2018-09-13Updated git submodulesDavid Stilwell1-0/+0
Project: sdnc/oam master 44971a437cf31e5712250b97c54009dfb775a9bb Merge "Fix group id" Fix group id Some groupIds are incorrect (com.onap instead of org.onap), causing deploy to fail. Change-Id: I9c103e99835448f063aa2b5c14345b8497786f6d Issue-ID: SDNC-445 Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
2018-09-13Updated git submodulesDavid Stilwell1-0/+0
Project: sdnc/oam master 1dec93dd78cc34d16bfd9e1096fdfbcf74db07dd Merge "Fix groupIds" Fix groupIds Incorrect groupIds - need to match repo structure. Also, name tags need to include sdnc-oam to map to correct Sonar project. Change-Id: I530855763bb02fc655a2192f9af55da63fd12512 Issue-ID: SDNC-445 Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
2018-09-13Updated git submodulesDavid Stilwell1-0/+0
Project: sdnc/oam master f60cd0b2b71f012bb931e6c1da99988e7152c7c9 Merge "Add distributionManagement section" Add distributionManagement section Add distributionManagement section to pom.xmls using parents that are outside ONAP. Change-Id: I7232a29068dd426a0f9afacfe19aea6bdd6f9ec1 Issue-ID: SDNC-445 Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
2018-09-13Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master d782247166a08b5c1776f5e09cc3f0787b4b6d13 Merge "Update IPAM_IP_POOL rows description" Update IPAM_IP_POOL rows description For the self serve, in order to assign the proper prefix id to resolve the ip address, the data dictionary will perform lookup in the DB matching on the description field. Here we're updating the description field to be a single string, for vFW, we have: - unprotected - protected - private Change-Id: Ib6ade2f8d50e269a46042ea9df84b62924445223 Issue-ID: SDNC-444 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2018-09-13Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master b86e8a42ea102e5d92cc45d56ea90ab7bf0e827b Merge "update LCM DGs" update LCM DGs allow many playbooks-various criteria for same LCM Action Change-Id: Ie29b884d05d52635a532e1d5beb10e6db7d7287e Issue-ID: SDNC-424 Signed-off-by: Agarwal, Ruchira(ra1926) <ra1926@att.com>
2018-09-13Updated git submodulesSingh, Ajay (as396y)1-0/+0
Project: sdnc/oam master 582888bc81e55ef4bf11d34c95eb7ac589de51b0 self-serve-generate-name DG changes Refactor the naming genereation sub dg for assign and un-assign to trigger the name generation rest API directly Change-Id: Ie060bed01f6c694f34e2c2518b69873e4728bd71 Issue-ID: CCSDK-482 Signed-off-by: Singh, Ajay (as396y) <as396y@att.com>
2018-09-12Updated git submodulesDavid Stilwell1-0/+0
Project: sdnc/oam master dc44af8c0962d3ed2195f566dd3610eaabf8d885 Merge "Update SDNC to use CCSDK ansible server as base" Update SDNC to use CCSDK ansible server as base Update SDNC to use CCSDK ansible server as base for its instance of ansible server Change-Id: Idaf1c83cf50ee526f17b97a3b2e376f6ad3a696b Issue-ID: CCSDK-442 Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
2018-09-12Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master 864ec09fbb41bb0ee2291a5f361e110d04df76e2 Merge "SOTN reoptimization DGs" SOTN reoptimization DGs SOTN Reoptimization DGs added to support policy Change-Id: Id9bfa483fcc83011ed76ee040f2cbc909e0da03f Issue-ID: SDNC-357 Signed-off-by: Prakash.E <prakash.e@huawei.com>
2018-09-12Updated git submodulesDushyantSinghThakur1-0/+0
Project: sdnc/oam master 94d8b3d82b82dedfd5949da2e5d1ed348ab066e2 Epic-231:versioning, and backup the configuration Merging the sdnc jira stories- 255,256 Change-Id: Iacb9274dae93f534f1331c4eb7d0669896d379d4 Issue-ID: SDNC-256 Signed-off-by: DushyantSinghThakur <dt00503496@techmahindra.com>
2018-09-11Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master 874475f0264d3271837e6f8bb6bf7512a83e1eaa Merge "Add netbox-ip-assign capability at vnf level" Add netbox-ip-assign capability at vnf level Change-Id: Icffd311e118a2ada7cc046e7884e10ca64001974 Issue-ID: CCSDK-339 Issue-ID: CCSDK-340 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2018-09-11Updated git submodulesDavid Stilwell1-0/+0
Project: sdnc/oam master c54e3d3870560d0aca3238ee46a0eab381425fbb Merge "Add new cols to TOSCA tables" Add new cols to TOSCA tables Added new columns to VF_MODEL and VF_MODULE_MODEL tables, used for TOSCA ingestion. Change-Id: Id7b7ca1415babb0ae63887419b699651bc562917 Issue-ID: SDNC-440 Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
2018-09-11Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master af1f3b46ed38e3a0a693ed6d43480f97f79b8184 Merge "integration test issues fix for sdwan and sotn" integration test issues fix for sdwan and sotn Change-Id: I3bc75cd456c15a89ebf3b4e91e9b3836e7322b66 Issue-ID: SDNC-357 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2018-09-10Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master fa490c28436152596245480283dede4c5cf7f75e Merge "self-serve DG for Casablanca" self-serve DG for Casablanca Add new self-serve DG and update existing self-serve DG for Casablanca Change-Id: Ib4c3ccf3ce2acc986df8c1a1d3374048e9ec73a1 Issue-ID: SDNC-437 Signed-off-by: Cheung, Pat <kc1472@att.com>
2018-09-07Updated git submodulesshashikanth.vh1-0/+0
Project: sdnc/oam master 3e4fa46160a5d6d52bb7eccf08dbb790d96a4682 integration test issues fix for sdwan and sotn Change-Id: I406550404f0cfb661d6e480cf1df48d39fad06e7 Issue-ID: SDNC-357 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2018-09-06Updated git submodulesAlexis de Talhouët1-0/+0
Project: sdnc/oam master 059370a180fc6630eea5f771fb61e303132f4352 Make netbox-ip-assignment resolve all params While resolving params, multiple of them could be resolved using the same capability. Adding the functionality in this self-serve DG to make sure it's processing all the param involving this capability Change-Id: I7f4d83bf5cfa90e4959fa8599a26b1cf0228a81a Issue-ID: CCSDK-339 Issue-ID: CCSDK-340 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2018-09-04Updated git submodulesprakash.e1-0/+0
Project: sdnc/oam master db088b077924366c0d9028b71d490a5b05a1a0c1 CCVPN RestApi template changes SDWAN and SOTN restapi template fix Change-Id: I2a86398487f65c9b15fb8081f383207ff778a135 Issue-ID: SDNC-357 Signed-off-by: Prakash.E <prakash.e@huawei.com>
2018-08-29Updated git submodulesAlexis de Talhouët1-0/+0
Project: sdnc/oam master 0fe5cab7a4822073c02751756f08ab64c881e528 Update self-service-netbox-ip-assignment DG - added the external_key support - fixes plugin returned value and mapping to the proper param in the MDSAL context. - couple of typos Change-Id: I6f305829e538284d7e4008352273fd82c77f4142 Issue-ID: CCSDK-339 Issue-ID: CCSDK-340 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2018-08-29Updated git submodulesAlexis de Talhouët1-0/+0
Project: sdnc/oam master b3cc6305655fee9a85d8ac42488e371b741a2f61 Added external_key column to IPAM_IP_ASSIGNMENT external_key column is to store a keu uniquely identifying the resource to a service, both within the ONAP and the external system. That key will be set prior assignment, and we be used during unassignment, to avoid having to correlate to many values. The external_key *must* be unique, at least per service. Hence lookup using both service-instance-id and external_key will be used during unassign process. Change-Id: I67691fc32b46bb6cbacd66402f5fda6456cd7e06 Issue-ID: CCSDK-463 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2018-08-28Updated git submodulesAlexis de Talhouët1-0/+0
Project: sdnc/oam master a51e4453ebe80eec9688e587e34ce480e67adb1d Add DG for self serve ip assign/unassign (netbox) This patch also adds the new capability in the capability list of the generic self-serve assign / unassign. Change-Id: Id7e1f061038c0a5caa52ba41f1fcc3e08e5f02a2 Issue-ID: CCSDK-339 Issue-ID: CCSDK-340 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2018-08-28Updated git submodulesAlexis de Talhouët1-0/+0
Project: sdnc/oam master 80d2e93d397b425ba7d134852edd1b55a9684b29 Reformat self-serve-vf-module-(un)assign Reformating in order to make changes in coming gerrit more obvious. Change-Id: I7414657e1d243792cba3e0e18174b2dfb8f779db Issue-ID: CCSDK-339 Issue-ID: CCSDK-340 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2018-08-27Updated git submodulesprakash.e1-0/+0
Project: sdnc/oam master fad8ff4f0b3660a5c1dd4b7abdb5ac5b95c8fec2 SDWAN sdnc DGs aai resource changes SDWAN configuration save in aai resource-name changes are updated in SDWAN DGs Change-Id: I9097f205751af47b5db8f228142f27786e9d190d Issue-ID: SDNC-357 Signed-off-by: Prakash.E <prakash.e@huawei.com>
2018-08-24Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master 0b84e06308b58d0308f40755b112cd730132b569 Merge "Update SQL dump for IPAM tables" Update SQL dump for IPAM tables - Fixes typos - Change status column type from Integer to varchar Change-Id: Ibf15233597fc459d43273688f42deb9538a18d51 Issue-ID: CCSDK-463 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2018-08-24Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master 9df0190342ec826746b2f9cbd8a554bab3a50a63 Merge "Add netbox-client as part of the defautl features" Add netbox-client as part of the defautl features For the self-serve initiative ongoing in Casablanca, we need to have netbox-client enabled within SDNC, so it can be used during assign/unassign stage of the VNF lifecycle events. Change-Id: Ic8d35f238548e00a52d4e1cd8d64d8be0d9e8ed5 Issue-ID: CCSDK-341 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2018-08-24Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master ddae2ce39b40e04fba13b9d99c39fad02b10e20e Merge "Epic-231 cbr junit testcase of SDNC-263" Epic-231 cbr junit testcase of SDNC-263 JUNIT Testcase for vnfconfigreportsservice Change-Id: I20d92c1514c97e9239b865e0bd3f8e015d538153 Issue-ID: SDNC-413 Signed-off-by: Soumendu Sekhar Acharya <SA00498080@techmahindra.com>
2018-08-24Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master 6d480c1894ff2f4578ae45ba450e90276943b57e Merge "SDWAN flow based end-end test and issue fix" SDWAN flow based end-end test and issue fix SDWAN DGs and restapi templates issue fixes Change-Id: I5d1d4e6cb17e9b187ea4f0942ca837472738fe62 Issue-ID: SDNC-357 Signed-off-by: Prakash.E <prakash.e@huawei.com>
2018-08-24Updated git submodulesSoumendu Sekhar Acharya1-0/+0
Project: sdnc/oam master c07d55ffd5e1838e2ec4fc6204e8a6762674f5e9 Epic-231 cbr junit testcase of SDNC-258 JUNIT Testcase for getBackupVnfDetailService Change-Id: I8b4f96b46bcfb23d35c183eed7c2ee949b956900 Issue-ID: SDNC-413 Signed-off-by: Soumendu Sekhar Acharya <SA00498080@techmahindra.com>
2018-08-24Updated git submodulesSoumendu Sekhar Acharya1-0/+0
Project: sdnc/oam master d90280efcad173fd2250b8e2e98cb8f480007657 SDN-C support&provide network layer tests Using IP SDNC-252,SDNC-253,SDNC-264,SDNC-266 are added as part of this story Change-Id: Ic65ca32c4786fac1be9269dbc6a2162b433f0630 Issue-ID: SDNC-264 Signed-off-by: Soumendu Sekhar Acharya <sa00498080@techmahindra.com>
2018-08-24Updated git submodulesSoumendu Sekhar Acharya1-0/+0
Project: sdnc/oam master 3fc03f8bde09d63f0c91c25bc95bb3419c3a6c0d Epic-231 cbr reports SDN-C to support reporting feature for automated operations e.g. backup, versioning, restoration and added jacoco plugin in parent configbackuprestore Change-Id: I355fdf0ed30a5446eb0447e3f90755dff54811cc Issue-ID: SDNC-263 Signed-off-by: Soumendu Sekhar Acharya <SA00498080@techmahindra.com>
2018-08-23Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master 90a83419e6770acbb59c332ff2f68eeb4c8610e8 Merge "Epic-231 cbr for compare" Epic-231 cbr for compare SDN-C to support the config comparison feature Change-Id: I7e9219a40c54e1d0266e0fd55a5871b572539e6b Issue-ID: SDNC-258 Signed-off-by: Soumendu Sekhar Acharya <SA00498080@techmahindra.com>
2018-08-21Updated git submodulesTimoney, Dan (dt5972)1-0/+0
Project: sdnc/oam master d46567fd73616f6b388a75f196177e35a6275ad3 Update GR-API link Update link to GENERIC-RESOURCE-API documentation to reflect latest version. Change-Id: Ibe9351e2b2cda27bf946ae78c0f974c4f88257bf Issue-ID: SDNC-427 Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
2018-08-21Updated git submodulesTimoney, Dan (dt5972)1-0/+0
Project: sdnc/oam master 94f1a25b9962969d32fe49ca3d197cad4af3f1eb Update ueb-listener artifact type config Updated ueb-listener.properties to only subscribe to TOSCA_CSAR artifacts, since it is the only type used currently in ONAP use cases. Change-Id: I1847a8a070b207ca5f4448966e3b52258b33a485 Issue-ID: CCSDK-474 Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
2018-08-20Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master e6067273537c79172e9369b248d82614297ce481 Merge "Added SQL dump for IPAM tables" Added SQL dump for IPAM tables Two tables being added in the sdnctl db: - IPAM_IP_POOL - IPAM_IP_ASSIGNMENT More information on the content here: https://jira.onap.org/browse/CCSDK-463?focusedCommentId=25838&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-25838 Change-Id: I513b620a581676a803c7a2f76adeccf5b5e9e64d Issue-ID: CCSDK-463 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2018-08-20Updated git submodulesshashikanth.vh1-0/+0
Project: sdnc/oam master 28a98a71d3b3a44e7269de435f0591946f2456d1 SDWAN WAN Attach site addition Updates include: - Addition of sdwan Attach site resource DG - Templates - Defect fixes Change-Id: Ie646f6a131a4124ac9228de4938d481d799d111f Issue-ID: SDNC-357 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2018-08-17Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master aff8871a93ea3d6ac2fbaedbb8b3483cbfdca2c3 Merge "SDWAN Site DGs update" SDWAN Site DGs update SDWAN site DG issue fix and update based on controlpoints modifications Change-Id: I7daae9adf610f2fd72150a2316cfd5f8d9ede6de Issue-ID: SDNC-357 Signed-off-by: Prakash.E <prakash.e@huawei.com>
2018-08-17Updated git submodulesAgarwal, Ruchira(ra1926)1-0/+0
Project: sdnc/oam master 51ea971e0fbd77d25e1a4b5d6436dc5b7d135a95 add LCM DGs LCM DGs for ScaleOut, TrafficMgmt, SoftwareUpgrade Change-Id: If7a4a2edb4abf12fdd2eacbf06c124740e7703b5 Issue-ID: SDNC-423 Signed-off-by: Agarwal, Ruchira(ra1926) <ra1926@att.com>
2018-08-16Updated git submodulesprakash.e1-0/+0
Project: sdnc/oam master c3161a030a9c6fd044572ff4a0dfd58da674dae2 SDWAN device instance DGs SDWAN DeviceInstance vnf topology operation DGs Change-Id: I7072271ca36030046f0146b072ad0ecfa9efd69d Issue-ID: SDNC-357 Signed-off-by: Prakash E <prakash.e@huawei.com>
2018-08-15Updated git submodulesshashikanth.vh1-0/+0
Project: sdnc/oam master 93bb206a1e4d8ce64a5f43d2733995a0a1b4fe92 SDWAN WAN port DG addition Updates include: - Addition of sdwan port resource DG - Templates Change-Id: Id3913755e2724c26663269fb9c8235fc2ca7fb91 Issue-ID: SDNC-357 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2018-08-14Updated git submodulesprakash.e1-0/+0
Project: sdnc/oam master f5b2457c6f66e4e357fe469df370d1ce8b4f0cd9 SOTN siteInstance DGs SOTN siteInstance vnf topology operation DGs Change-Id: I7018aa0c56db60d1bca0a3b234820b3128d0c111 Issue-ID: SDNC-356 Signed-off-by: Prakash E <prakash.e@huawei.com>
2018-08-10Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master 3abd0b494d868f5cb30eea4665946a52956873b3 Merge "SDWAN VPN DG deletion template addition" SDWAN VPN DG deletion template addition Updates include: - Addition of delete template Change-Id: I20153ddf252573229b6ffd6daa0ca744e8544253 Issue-ID: SDNC-357 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2018-08-10Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master cb5ba77f9c36636f37859768bdff22df5112746d Merge "SDWAN VPN DG addition" SDWAN VPN DG addition Updates include: - Addition of sdwan connectivity resource DG - Hooking the same to main DG Change-Id: Icb629089ec3f5a4983eabe3168523b24e2afd275 Issue-ID: SDNC-357 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2018-08-10Updated git submodulesgaurav1-0/+0
Project: sdnc/oam master a2c96f67d1e799f8f762fb14be3744a03649869a SOTN DG to support EPL Updates include: - Template changes to support EPL - Changes wrt. parameter names Change-Id: I016adb31b9c6ad043a43468cec198d4336bb96a1 Issue-ID: SDNC-356 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2018-08-09Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master 302ddecd0d19d7a3b6bf11b6f8ee90dc1ddf639b Merge "connectivity attachment issue fix" connectivity attachment issue fix Test issues fixed Change-Id: I991876c6176c5fa05682e635b9c1e29eb5b08d54 Issue-ID: SDNC-356 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2018-08-09Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master 6f928522e6a4a6dfbe11f6f96579aab8e31b081b Merge "Connection attachment template issue fix" Connection attachment template issue fix Template order is not according to yang defined model Change-Id: Icb21e906a945bd007396eb6538fc43a85f6b1914 Issue-ID: SDNC-356 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2018-08-09Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master 7b72cc062552903fa642002f8642ef5bd8e434a0 Merge "SOTN issue fixes" SOTN issue fixes Issues: SOTN connectivity issues in create, activate and deactivate is fixed Change-Id: I4b85cf2eb248f36369a85fc93394a1d41d2170ac Issue-ID: SDNC-356 Signed-off-by: Prakash E <prakash.e@huawei.com>
2018-08-09Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master fdef1b33bf39c529a2d0c568bc181d6d0c4d9a31 Merge "Update network topology to aai" Update network topology to aai updated to use p-interface for ltp's Change-Id: I676ad2dba4b5197a0db32c80ccf5d2f725343c53 Issue-ID: SDNC-387 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2018-08-06Updated git submoduleslalena.aria1-0/+0
Project: sdnc/oam master bff7afa7ec3921b6c67f4d16682a4777ae30ba53 Fix OMF Component ID Changes made: Revert test asdc-address, consumer-group, consumer-id and msg-bus-address in ueb-listener.properties which were accidentaly committed after testing. Change-Id: Id5cc8aff4c5c5498609f4e3ce103327e451a0740 Issue-ID: CCSDK-423 Signed-off-by: lalena.aria <lalena.aria@att.com>
2018-08-03Updated git submodulesDan Timoney1-0/+0
Project: sdnc/oam master 8826276da083f4798387a5ee631b7300e0862326 Merge "Updates to SOTN DG" Updates to SOTN DG Updates include: - Changes to support inter-domain. - Changes wrt. AAI nodes and fields. Change-Id: I50ed3553e792a382c534c72475afc666629320cc Issue-ID: SDNC-356 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>