Age | Commit message (Collapse) | Author | Files | Lines |
|
Project: policy/engine master 07450cf3a2fa5ac2049d7b287567eb2641dfb5f7
Merge "Implement Encryption on Passwords"
Implement Encryption on Passwords
Fix Fortify scan issue - hardcoded password in properties file
Issue-ID: POLICY-542
Change-Id: Icefd4097dc2e20c0ec2b78c002599defb6034267
Signed-off-by: guangxingwang <gw1218@att.com>
|
|
Project: policy/engine master 695d88bd7a987a06173fc4fa13f4135916a79a86
Policy Resiliency Code Fixes
Resolved the issue on updating the configuration files when
rename/clone/export/move actions are done through GUI.
Fixed the PolicyManagerServlet code.
Added test cases for newly added files.
Issue-ID: POLICY-609
Change-Id: I9d14f19fe20bbc0e3b3844f85d81f26e34bb26ec
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Project: policy/engine master 6425d452d8507e9eeeb4da2f9f7051e602af541e
Merge "Fix last technical debt"
Fix last technical debt
Last one that I dare to fix.
Issue-ID: POLICY-477
Change-Id: Ieb1c159b781fa2f0dd80f7dea92dcbf72c3e8364
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master fe11ab01afebfa9777c3382d28026c805f7d042b
Merge "Technical debt and fix JUnit test"
Technical debt and fix JUnit test
* One statement per line
* private constructor for class with statics
* Fix silly JUnit test
Issue-ID: POLICY-474
Change-Id: Ie760826879febbbc4db4f03079ae1f847f2194dd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master 3e642d2fcd9a09a8a40918cf0451cfdafe70e968
Merge "Remove technical debt"
Remove technical debt
* String literals on the left
* Unnecessary initialization of variables
* Change ArrayList to using List
* Remove extra semicolons
* Empty Constructor comments
* Useless parenthesis
I also added a comment on some code that is suspicious. Not comfortable
with changing that code.
Issue-ID: POLICY-482
Change-Id: I89d889737d398d047fab4b25cb5d962ee1ecdd03
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master 549cafbb3b5b5c9298e8c7371835f5c58633349f
Implement Encryption on Passwords
Fix Fortify scan issue - hardcoded password
Issue-ID: POLICY-542
Change-Id: I722b9143fbddc48b67592bb35a44f36ed8b38aad
Signed-off-by: guangxingwang <gw1218@att.com>
|
|
Project: policy/engine master bdb9bf58d7a80f43c3ce558e6fe59c3bc0f6f8bd
Merge "Technical debt reduction"
Technical debt reduction
* empty constructor
* Unnecessary imports
* try-with-resources
* missing @Override
* useless parens
* proper boolean detection
* useless imports
* Use Set vs HashSet
* moving statements to separate lines
Issue-ID: POLICY-477
Change-Id: I5fae9c5c8e7d30f731a1caefc8a5271cf382e0a0
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master 0c8425b25c093f638351a14f84a7b1df731cd0de
Resolved Fortify System Information Leak issues
Issue-ID: POLICY-550
Change-Id: I2145ecb6de43b69d6faf44c6395b119134a9904f
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Project: policy/engine master e8c14515d3f48aad6d42a31d7489a3ef25557f2d
Resolve LF license header issue
These were simple, we just forgot to remove the old license headers. Also
needed to add a missed fix for a JUnit test. Not sure how this made it past
verify.
Issue-ID: POLICY-552
Change-Id: I30610ba4f8440ee16d0a5c372985f50429d60a34
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master d9b21bad7e932ee60a8f2c64ca42d42cc9eac2cc
Merge "Included Policy GUI Enhancements and validations"
Included Policy GUI Enhancements and validations
Added hover messages for all policy templates.
Resolved few sonar issues.
Added fixes for Policy GUI Validations.
Issue-ID: POLICY-597
Change-Id: I74abb92dd6ac8722d7869b6a316fad1d8db11d9c
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Project: policy/engine master 06f456d8d06840a21f48531b0bd35b1a429b10f9
Reduce technical debt and add JUnit
* Addressed some very simple cyclic complexity
* Added simple JUnit tests and finished others
* Removed useless assignments
Issue-ID: POLICY-477
Change-Id: Ic919bbf78ad2732a430c32f1feb3c88678be710d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master 066fc4529f36d210a4a4700e8dbfd2cb42f4dc66
Merge "Reduce technical debt"
Reduce technical debt
The last for technical debt I believe. The last try-with-resources I dare to
fix. Useless import that I missed last time. Did a couple of minor
reductions in cyclomatic complexity that I think are harmless.
And lastly introduce a new variable instead of reusing a parameter.
Issue-ID: POLICY-482
Change-Id: I5f2e5abbdd472496b48cf12e485fc9b4d903f35a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master c579209f8a4045d7f96f2b566a82ce1b8cf8660d
Merge "Continue addressing technical debt for ONAP-XACML"
Continue addressing technical debt for ONAP-XACML
Follow the list of acceptable fixes in POLICY-336 description
Issue-ID: POLICY-475
Change-Id: I67f46bb383db1ac4feecb0223df98d180733fc95
Signed-off-by: Gao, Chenfei (cg287m) <cgao@research.att.com>
|
|
Project: policy/engine master 401b48bc573561f097960a9ca7abe6d788456f28
Fixed the Sonar technical debt.
Fixed the sonar technical dept primarily for the POLICY-REST module, and
accordingly updated the other policy-engine modules for successful built.
Issue-ID: POLICY-476
Change-Id: I0e9bd7209a7f9af247fa409a1682683082f92698
Signed-off-by: Ankitkumar Patel <ankit@research.att.com>
|
|
Project: policy/engine master 9301fed7c290f52208922f780fdfe4b5a880b5aa
Adding code coverage reduce duplicate lines
Removed some duplicate code across some of the classes. For CheckPDP, got the code coverage
above 80%.
Issue-ID: POLICY-482
Change-Id: I41495cf9f92e8fd248350bf33f5a183c876f38f2
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master 9df8b88412f6e890320bc446ba1c83a13e99822d
Merge "Fix technical debt and reduce lines"
Fix technical debt and reduce lines
Focused on iterating over entrySet along with more fixes for
dead stores, unnecessary exceptions. I'm also starting to work
on reducing the number of code lines.
* Iterate using entrySet
* Remove useless assignments
* Unnecessary exceptions
* Use StringBuilder instead of StringBuffer due to synchronization
* Potential null exceptions being thrown
* Returning a empty collection vs null
Issue-ID: POLICY-482
Change-Id: If6ac8e812237f37b2b10c534535df4090a5073dd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master cac5ee759fee5db51a32838c7e25b878468a27e0
Merge "Addressing Technical Debt for ONAP-XACML"
Addressing Technical Debt for ONAP-XACML
Follow the list of acceptable fixes in POLICY-336 description
Issue-ID: POLICY-475
Change-Id: I45cfb55c571d32601049beb8e5be8676216dcf5c
Signed-off-by: Gao, Chenfei (cg287m) <cgao@research.att.com>
|
|
Project: policy/engine master b65e96826d7339ce29ddb73e3ed6775bd4f54753
Reduce technical debt
Focusing on easy try-with-resources changes. Plus some other minor items.
I did not get all of them yet, as some have some heavy refactoring. These
try-with-resources seem to be fairly harmless.
* Utilize try-with-resources
* Remove unnecessary parenthesis
* Merging simple if statements
* Remove useless assignment
* Moving string literals to left hand side
Issue-ID: POLICY-482
Change-Id: If519ec8ea96f6b90bf82ac2676ffea9cd0cd2daf
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master 38261bb20e49c39f710aef47b5415dcdf14a1729
Use try-with-resources
Also enhanced JUnit tests to ensure this will work. Reduced code.
Issue-ID: POLICY-482
Change-Id: If07e17df274bdb709f7ca60078bd1fbd78d1aaaa
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master e44a43f3dbb1dbaa182122f66961c55d3b96b824
Reduce technical debt
Mainly use StringBuilder() to improve speed
* Use StringBuilder
* Remove superflous exceptions in constructor
* Remove unnecessary casts
* Remove unnecessary toString()
* Combine return into one statement
* Move string literal to LHS
Issue-ID: POLICY-482
Change-Id: Id196728d92dda7fab7e83d6eea07633c5be37f7c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master a6b8bc8875402ab721a8529926d01b2565d0f595
Addressing Technical Debt for POLICY-SDK-APP
* Using booleans true and false
* Using already predefined static strings
* Adding private constructors to hide implicit
* Adding empty constructor comment to satisfy SONAR
* Using single quotes for indexOf to use faster method
* Preferred use of .isEmpty()
* Ordering of public static synchronized syntax
* Removing commented out code
* Using an already defined constant
* Unnecessary declaration of runtime exceptions
* Unnecessary casts
* Unused variables and imports
* Unnecessary use of toString()
* Just using return vs storing into a local var and returning that
* Extra semicolons
Issue-ID: POLICY-482
Change-Id: I6b9dcc5211dd52895a8787239b9df3059928fa45
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master 7a2924a2209bce7b0c578b67fd2310d12ccdb1f7
Resolved the Critical issue reported by Sonar
Issue-ID: POLICY-521
Change-Id: I2a7072076a1ed0924bfeacd6f3d2b6a910f30338
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Project: policy/engine master 74552f84f136c01a99488aeff6d0f7b9a55d5fb3
Resolved Security Vulnerability issues
Issue-ID: POLICY-553
Change-Id: I3e0e6a31226e561cef9ec578790659d57b2f65f4
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Project: policy/engine master 528605fe8efa3631291de0b9bf8e498bdbd0c23f
Merge "Restrict file upload size in policy editor"
Restrict file upload size in policy editor
Restrict file upload size in Policy Editory using a configurable value (in
bytes) set in xacml.admin.properties. Default value is 30MB.
Issue-ID: POLICY-538
Change-Id: I4d8539ab33320446aed250ea4fdc51de585d5f2a
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
|
|
Project: policy/engine master 49c6b1bf604c3450b729dc348af36ee3af79589b
PDPGroup Audit Fix
*This fix will add new group to GroupEntity table if no default exists
during initialization and therefore provides a permanent solution to the
initialization errors on the PAP
Change-Id: Ie394d76b9cbc02cad15d62d6adea6fc17938f734
Issue-ID: POLICY-486
Signed-off-by: Michael Mokry <mm117s@att.com>
(cherry picked from commit 676d7d8dc9985e93d7c9cbc0412a26f2b19c23cd)
|
|
Project: policy/engine master c7ebb39ee23233b0104d3a0f9b1f8fdd66911d18
Merge "Local and Class variable name conflict resolved"
Local and Class variable name conflict resolved
*Renamed the local variable to othername
Change-Id: I5f1e1b8b9140acf73de241f78b0437dc9e5805b5
Issue-ID: POLICY-336
Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
|
|
Project: policy/engine master 6d3cc4662712bb636b83f8a4da9938afe192a64a
Merge "Fixed as per Java Code Conventions"
Fixed as per Java Code Conventions
*Moved the constructors after the variables
Change-Id: I099f75aea285f0bb845d464065d1e5f031d44a13
Issue-ID: POLICY-336
Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
|
|
Project: policy/engine master fb3cc27605623672fb8971bd9030872f117c7af8
Merge "Sonar cleanup for PolicyEngineUtils"
Sonar cleanup for PolicyEngineUtils
Changes to resolve some sonar "major" issues in the PolicyEngineUtils
module.
Patch 2: Updated the NotificationStoreTest junit to account for the return
of a "Collections.emptyList()" rather than "null" in StdPDPNotification
class.
Patch 3: Updated the StdPDPNotificationTest junit to account for the
return of a "Collections.emptyList()" rather than "null" in
StdPDPNotifaction class.
Issue-ID: POLICY-474
Change-Id: I925774ac181fd38d1206637f47ab27ba499629ef
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
|
|
Project: policy/engine master cedb4478c6ff50a61dc1d1b445d39401606061b5
Removed useless parentheses
*Removed those useless parentheses
Change-Id: I19e9e027182dfd7dc2211d71fbb4acd8bf6b8be5
Issue-ID: POLICY-336
Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
|
|
Project: policy/engine master f0d9cfb56a032242527a9837fd613fe64fbfee42
Merge "Fixed as code optimization"
Fixed as code optimization
*no need to create seperate object, so optimized
Change-Id: I245d7fd26c0fabb26de6e9eb7c8bedf405d9d602
Issue-ID: POLICY-336
Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
|
|
Project: policy/engine master 0213ffe513b4d1f1103e23bebcf3a6f64c408cd5
Fixed as per Java Code Conventions
*Moved the constructors after the variables
Change-Id: I531a911570867e05d2eabca98d349f4f2f26d0f9
Issue-ID: POLICY-336
Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
|
|
Project: policy/engine master f99b843890966768267a05e2f4e237bad7c386f0
Fixed as per Java Code Conventions
*Moved the constructors after the variables
*Deleted the commented code
Change-Id: I6afa9ae5b04fe5c8280fc9e08352aef699117567
Issue-ID: POLICY-336
Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
|
|
Project: policy/engine master 989ae85e3a25e059cb963a9bc293526be51273ca
Merge "Adding PolicyType to getConfig Response"
Adding PolicyType to getConfig Response
Adding a new parameter PolicyType so that getConfig Response can be known
based on type of policy. Fixes for project warnings and unused imports.
Issue-ID: POLICY-434
Change-Id: I0874abb7e986a8bb42ae18561064a8d7534eade6
Signed-off-by: Tej, Tarun <tt3868@att.com>
|
|
Project: policy/engine master e688c3ab14a546dcc7acc189007ac4d42e349332
Merge "Policy Elastic Search Validation Enhancements"
Policy Elastic Search Validation Enhancements
Issue-ID: POLICY-497
Change-Id: If97fe30706bcdbeeafaf28e5cca8fae31998cb7c
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Project: policy/engine master 84dfe2ecbdb18041ddfc49ac0beeb650238ff37c
Merge "Adding SONAR fixes for"
Adding SONAR fixes for
- pushPolicy defect fixes for POLICY-486
- Common Policy Validation feature for POLIYC-449
Change-Id: I8d54aa5a9b819c6eb4427dfa47c4ce963a21c2e0
Issue-ID: POLICY-449,POLICY-486
Signed-off-by: Michael Mokry <mm117s@att.com>
|
|
Project: policy/engine master 85e767c65b23a1fef35e5a0199a57bf755070815
Merge "Add ELK Security"
Add ELK Security
Add security to ELk such that only localhost is able to access ELK.
All other hosts will be denied service. This fixes the open elastic
serach security vulnerability.
Issue-ID: POLICY-495
Change-Id: I7f5d6fef5963f984c2bce6933c8b214c0bd3be2b
Signed-off-by: Temoc Rodriguez <cr056n@att.com>
|
|
Project: policy/engine master aa9e865ccf191e814b50b8b4b51d516fc359d948
Merge "Fix audit log to contain ending timestamp"
Fix audit log to contain ending timestamp
Add transaction end method
Change-Id: Ie818bb1650b0847800ce5481a85c5d2c8d7f4b9c
Issue-ID: POLICY-494
Signed-off-by: Mike Babinski <mb1915@att.com>
|
|
Project: policy/engine master 0368cb99d6108970d172d4dc7145c67e4524b4a9
Resolved the Policy GUI Javascript issues
Issue-ID: POLICY-440
Change-Id: I44d5304699da19bee7ae2997565802fc7d44cb0e
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Project: policy/engine master 428150834ee60899b9a8da019bae3c8bf009adf1
Upgraded the latest ONAP SDK
Upgraded latest ONAP SDK Code.
Change-Id: I669d6cfcefe068b1e4c078889d7d6c77ce788e2e
Issue-ID: POLICY-432
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Project: policy/engine master 775f45908025e46a40c9c147fca2066af5c8c5b8
Merge "Refactor to provide Common Policy Validation"
Refactor to provide Common Policy Validation
Provides a common class to perform policy validation during
create/udpate of policies by the GUI and API for consistency.
Change-Id: Ied459e73d48517bb50064cd10d6a1c871b8311e5
Issue-ID: POLICY-449
Signed-off-by: Michael Mokry <mm117s@att.com>
|
|
Project: policy/engine master 709fe78e311189429a22c4ceebf20f19e89693f3
Merge "Fix Sonar Issues for BRMSGW"
Fix Sonar Issues for BRMSGW
Removing additional sonar issues.
Issue-ID: POLICY-472
Change-Id: Id447c0e31338321051b7d5f69e3087bbc95b504f
Signed-off-by: Daniel Cruz <dc443y@att.com>
|
|
Project: policy/engine master b6bae924c4a794cd772ac1524089fc8739e310b1
Modified the code to fix various pushPolicy issues
- Added modifications per Pam's review
Change-Id: I5d67ee529cbc5245e7d1f8dbec6f2f2d453ce299
Issue-ID: POLICY-486
Signed-off-by: Michael Mokry <mm117s@att.com>
|
|
Project: policy/engine master 0eb828b9e122865eb6e9649f766d2caf25eba771
Fix BRMSGW Sonar Issues
Addressing sonar issues in the BRMSGW submodule.
Issue-ID: POLICY-472
Change-Id: I31d532153ff88dafa55c74654fbdfe3874bfb65f
Signed-off-by: Daniel Cruz <dc443y@att.com>
|
|
Project: policy/engine master 367fd935789c6c2e13b9b32d13c62dbac89e1c57
Merge "Modified dmaapClient dependency GroupId/Version"
Modified dmaapClient dependency GroupId/Version
Changed GroupId of dmaapClient deendency to
org.onap.dmaap.messagerouter.mirroragent.
Created a dmaap.version property in root pom and assigned it a value of
1.0.0.
Issue-ID: POLICY-370
Change-Id: I6846f930783a65e4fc0f5afb6b9f832a972477bb
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
|
|
Project: policy/engine master db597fe2163c073e37ad2ddc0d7fe386517e21e0
Bump minor version
Bump minor version in preparation for Amsterdam
branching.
Change-Id: I61e0ae91e3ece54ed09a88dad9b8dac173ccae07
Issue-ID: CIMAN-120
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
|
|
Project: policy/engine master 5574639015d8316696a0964c6f2f842679e4bc36
Update version.properties to 1.1.2
Missed this when updating the rest of the pom.xml
Issue-ID: POLICY-436
Change-Id: If93351317d30be54b2daa1a28b773b2ee8fe4e31
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master 483728062ba18ebe585da8287c72b8bf73a0a509
Merge "Fixed alignment"
Fixed alignment
Fixed alignment
-------------------------------------------------------------
Change-Id: Ieb26dff0703a9bfd84aa63ee8287eafed671ad69
Issue-Id: POLICY-335
Signed-off-by: Saryu Shah <ss3917@att.com>
|
|
Project: policy/engine master 183ac4aa1c5a72f0dc48b3939c5b0502a9cd878e
Merge "Update to v1.1.2-SNAPSHOT"
Update to v1.1.2-SNAPSHOT
Release 1.1.1, moving patch to 1.1.2
Issue-ID: POLICY-436
Change-Id: Iabde3e56c04c68ca966efde09b5780e6275cb8a8
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master 51c7ac7d8be19221ad2fce4c0f5d815bdb0f63a7
Merge "Updated release notes"
Updated release notes
Updated release notes
-------------------------------------------------------------
Change-Id: I3d9ece90779f2a3f2512dde228b6525ccff17684
Issue-Id: POLICY-335
Signed-off-by: Saryu Shah <ss3917@att.com>
|
|
Project: policy/engine master bcdc9c5744059598da4ffb47b4a11c681c904280
Merge "Fixed typo in clsimulation.rst"
Fixed typo in clsimulation.rst
Fixed typo in clsimulation.rst
-------------------------------------------------------------
Change-Id: I3fdeca2c7f5b6874d5d56d065580d2e4a4754392
Issue-Id: POLICY-335
Signed-off-by: Saryu Shah <ss3917@att.com>
|