Age | Commit message (Collapse) | Author | Files | Lines |
|
Project: policy/engine master 7414584e40572c7854db959052c56f3cc8849488
Modify Policy manager servlet for sonar issues
Fix basic sonar issues in policy manager servlet
major and minor issues reported by sonar
Basic refactoring
Issue-ID: POLICY-1016
Change-Id: If3c19943c04d9af43807090b6340547d69ca6a19
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Project: policy/engine master 2fc1a1510259202e8854beb8c04ef045bd28c79b
Merge "Modify ONAP PAP REST classes basic checkstyle"
Modify ONAP PAP REST classes basic checkstyle
Modify tabs to space for checkstyle issue fix in ONAP PAP REST
module. It helps future reviews and refactoring. Remaining classes
Issue-ID: POLICY-1014
Change-Id: I677eadac9e8364b388be922024528c27fd1e2545
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Project: policy/engine master dea7a9791960ac2f913e2ab4c70491706ab9e2a0
Merge "Fix major sonar issues in SDK APP admin mod"
Fix major sonar issues in SDK APP admin mod
Fix Sonar reported major issues regarding extracting constants,
method complexity, duplicated code blocks, more than 3 nested
control blocks. Rework3 after self review.
Issue-ID: POLICY-1016
Change-Id: Icbf940c966c51a8ef4319a94a3832cb1e8c360ba
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Project: policy/engine master f0fec2a861ea0a92b27b40882ea38f9422cde0c6
Convert tabs to space in ONAP PAP REST1
Modify tabs to space for checkstyle issue fix in ONAP PAP REST
module. It helps future reviews and refactoring
Issue-ID: POLICY-1014
Change-Id: Idcf45689565f039c76a3ef0f40ad9a46b41bd8d6
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Project: policy/engine master 7a6c4f9214a71101db3354ed06ccd3cfd3cea65b
Merge "Copy policy-endpoints from drools-pdp to common"
Copy policy-endpoints from drools-pdp to common
Issue-ID: POLICY-967
Change-Id: I84eba5c06d129cb2a7ef27ed78b63a8ada37805c
Signed-off-by: mmis <michael.morris@ericsson.com>
|
|
Project: policy/engine master e31e46738ca14c18a00773e598df6639154aa1f2
Merge "Convert tabs to spaces basic refactoring"
Convert tabs to spaces basic refactoring
Change tabs into spaces for checkstyle fixes in ONAP REST module of
policy engine. These changes come in way for review. Hence doing them
before refactoring is better.
Issue-ID: POLICY-1014
Change-Id: I31a372ae527946927157bc23b576f3066679b0ae
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Project: policy/engine master 64d3d5f9d4fb225fde55598e5b7462978642c417
Merge "Fix major sonar issues in SDK APP"
Fix major sonar issues in SDK APP
Fix major issues reported by sonar in POLICY SDK APP files such as
CreateBRMSParamController, PolicyManagerServlet. Also modify tabs to
space. Rework2 based on review comments
Issue-ID: POLICY-1016
Change-Id: I5407ade1ce9f597fa91d9ca18506f5ac2d8b1411
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Project: policy/engine master 1ecf9de8c889adb2dbc9ddd9a79d28e1da89d87b
Fix Sonar issues in utils PDP ParseLog rework
Fix Major Sonar issues in ParseLog BackupMonitor and ONAP-PDP component.
Issues related to nested control statements. Rework2 based on review comments
Issue-ID: POLICY-1013
Change-Id: I10edb242b45a649df902a4e7c1aba0a285b8b7fb
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Project: policy/engine master 1df87df1af0d215b9ff908dd15089393b9be270b
Merge "Copy policy-endpoints from drools-pdp to common"
Copy policy-endpoints from drools-pdp to common
Replaced references to classes deleted from drools-pdp with references to
the corresponding classes in polcy-common
Issue-ID: POLICY-967
Change-Id: I7bb580af3b3b2eb0ddcab9421c595237fa37282b
Signed-off-by: mmis <michael.morris@ericsson.com>
|
|
Project: policy/engine master dd986507648898887715a20c2f962bc714e28882
Merge "Fix nested stmts issue of Sonar"
Fix nested stmts issue of Sonar
Policy rest util MSModeUtils have Sonar flagged issues about nesting
more than 3 control stmts. Fix these. Also a minor change from prev
commit about BrmsPush.java. Rework based on review
Issue-ID: POLICY-1009
Change-Id: Ibd3cebcdebf9cf26233e810033793a5315b93272
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Project: policy/engine master d6838664316b9bfbc082f68889f4475cd25c81fa
Merge "Refactor code for nested stmts in policy std"
Refactor code for nested stmts in policy std
Refactor code for nested control statements in PolicyEngineAPI policy.std
package. These issues are flagged by Sonar as Major issues. Rework based on
review comments
Issue-ID: POLICY-1012
Change-Id: I6925dd5d56b653ef4cefe5ae64686a49f9741125
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Project: policy/engine master 2cdbafa5550465315a2328ea302b333446e1465d
Merge "Fix issues reported by sonar"
Fix issues reported by sonar
Fix issues related to unused method variables, extract constants,
not nest more than 3 control stmts, use try with res in policy
engine project. Rework for comments
Issue-ID: POLICY-1008
Change-Id: If0953de9e802110df14862707f3b525652cdf112
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Project: policy/engine master 7957dd169d09ff5fcfdfc0384e8ed7d3534d3dc0
Merge "Decision BlackList Guard Enhancements"
Decision BlackList Guard Enhancements
While creating a decision Bl Guard Policy we are allowing to add
Blacklist entries through file upload for bulk from GUI.
Issue-ID: POLICY-901
Change-Id: I4031fd4a96937b9facc330cecf72777d701d4678
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Project: policy/engine master a5ccc101707216e8ffc07773c17799c60360863f
Merge "Fix sonar issue about nested stmts"
Fix sonar issue about nested stmts
Refactor code to not nest more than 3 condition or loop stmts
in policy PolicyEngineUtils. Rework based on review comments
Issue-ID: POLICY-1003
Change-Id: I95fcfa0f99c517c02357c85ca39cd2f934e8da4d
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Project: policy/engine master 5ad6783ca5a09c0061b661a48210f6d8e22cd7d3
Merge "Refactor PolicyNotificationMail for sonar issues"
Refactor PolicyNotificationMail for sonar issues
SONAR flagged issues related with complexity of method being high
and more than 3 nested loops in the PolicyNotificationMail
Issue-ID: POLICY-986
Change-Id: Ife3e6b5610cec4bcf3898fdcad4cc2c9a3d61932
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Project: policy/engine master 8cf5ed300190ab386d95758e6d4be6c38e67123d
Add modified copyright notice
For the files which are modified add
modified copyright notices as per comments from earlier review
Issue-ID: POLICY-1002
Change-Id: I873b3ccc986d5f3d138ddb9e9b3c2307a0b127a6
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Project: policy/engine master eff265962c081edb751d5d2ed99dc443cb97f3fb
FIX SONAR ISSUE NESTED TRY BLOCKS
refactor the code for nested try blocks and rework
based on comments and fix nested loops complexity
Issue-ID: POLICY-976
Change-Id: Ied02b7838b5e4839a4906f79ff37c4fd6afeccfe
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Project: policy/engine master 9bfa1d61dc77973f85a42174b199d4c744265521
Upgrade tomcat to clear security issues
New security issue has appeared, so we will do minor upgrade.
Issue-ID: POLICY-982
Change-Id: I58ee20ec07300ab586017ca2072f63329e6f3417
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master 3555353c1baedc080f310e9e737a46f7cc7aa89e
USE TRY WITH RESOURCES
Fix sonar issues to convert try blocks to
try with resources plus change tabs 2 space
Issue-ID: POLICY-961
Change-Id: I553d6a42f1efaab5b7eb3a53bab945a3360e69bb
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Project: policy/engine master 2db31606da32d9f5d3a16854385de8e496cd28f6
Reverting "Merge "fix try block""
This reverts commit 240bbdbdc76e0e91af9f18164eadb2708d14c6fb, reversing
changes made to 3ee69f1af0acddd1e06060ad88c0029fe7ceeaaf.
Change-Id: I61f07ead1d7d3e89c512a2224efecf9ac440df10
Issue-ID: POLICY-961
Signed-off-by: Jorge Hernandez <jh1730@att.com>
|
|
Project: policy/engine master 240bbdbdc76e0e91af9f18164eadb2708d14c6fb
Merge "fix try block"
fix try block
Issue-ID: POLICY-961
Change-Id: Ia1f388368007a4a82a57520dc6ddd99cc484a393
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Project: policy/engine master 3ee69f1af0acddd1e06060ad88c0029fe7ceeaaf
Upgrade Portal SDK to resolve Security Issues
Upgraded version in pom to 2.3.1
Added SQL scripts from Portal to Upgrade Portal related db tables
Added SQL downgrade script and license header
Sorted SQL commands in upgrade script by function_cd per Jim
Change-Id: Id6bef295956b6ec5b13d8fbd0006bbfe98c1c0ac
Issue-ID: POLICY-918
Signed-off-by: Mike Mokry <mm117s@att.com>
|
|
Project: policy/engine master 54eaa820dd76f8da6076b6aad3d2c75c68236693
Revert "Fix policy gui missing schema_info table"
This reverts commit e67481ed648c419a1645d0fc8b98506fe544a454.
Change-Id: I092053ec1815cf7ca598b1913663532673125604
Issue-ID: POLICY-898
Signed-off-by: Joseph Chou <jc2555@att.com>
|
|
Project: policy/engine master aa72f4c2311d06fe699ea47e19714b66c0665b02
Merge "Address missing files in junit tests"
Address missing files in junit tests
Renamed logback.xml to logback-test.xml.
Added policyLogger.properties to config directories.
Change-Id: Ib6f50666a13c3258482b4007e7ceeb742f2e87a6
Issue-ID: POLICY-784
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Project: policy/engine master 9a1113e4128f1585dbf85aabc429e9da385a76a8
Merge "Don't use hard-coded tmp path"
Don't use hard-coded tmp path
Modified code to use java system variable to identify temp
directory.
Change-Id: Ib656dd2a2d57e43febb0daaa25cf90cb1b9330a7
Issue-ID: POLICY-920
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Project: policy/engine master b401754031d70b43ac1b1ee28256ea29add7ebf3
Merge "Fix console warning about xacml.properties"
Fix console warning about xacml.properties
Configured location of property file.
Change-Id: I58a89b34aa58f4efd6ed3ee0f984869ee7bf2f6c
Issue-ID: POLICY-921
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Project: policy/engine master 29c8effb13eab61c5697e81a7593eac051272a0c
Remove %h from log file names
Modified code, either removing "%h" or replacing it with a directory
name that is relative to the junit test.
Change-Id: I6ea3e3139a04fefadca42340454be36a5b54445d
Issue-ID: POLICY-784
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Project: policy/engine master 141052c6dcabdddf20f2b46d95540f1ceb0d7299
Change PrefixList.class to Zone.class
Changed the class. Modified the junit test to catch that type
of issue, refactoring it to extract common code.
Change-Id: Ibc3d22821f103cd3954d2f2f54d4d62307dbf4c6
Issue-ID: POLICY-909
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Project: policy/engine master e67481ed648c419a1645d0fc8b98506fe544a454
Fix policy gui missing schema_info table
Modify docker-install.sh to include db schema update
Change-Id: I75941522ea932e59cd85d7ff9887bf7d4759ae7c
Issue-ID: POLICY-898
Signed-off-by: Joseph Chou <jc2555@att.com>
|
|
Project: policy/engine master 1577c271f66912e13770eb3950a25ae40cf9c4ad
Merge "Set default logger to EELF instead of SYSTEMOUT"
Set default logger to EELF instead of SYSTEMOUT
Change-Id: I3395d3b95b11bf0166190beb454e60cb63de7454
Issue-ID: POLICY-784
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Project: policy/engine master 6eb3c7f44a64cc1aebd4bcef6b081073d91bde7b
Use POLICY_LOGS env variable in logging.properties
Some logger.properties have /var/log/onap hard-coded; changed those
to use $POLICY_LOGS.
Other logger.properties had ${POLICY_LOGS} instead of ${{POLICY_LOGS}};
fixed those, too.
Change-Id: I56faf5982abf520ee364b54a3560313d0f15cc2a
Issue-ID: POLICY-784
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Project: policy/engine master 67de0163434349c52291e49cc7bbeadcba03747c
Merge "Enforce logback version"
Enforce logback version
Some of the projects are being built with logback version, 1.1.3, which
does not support the SizeAndTimeBasedRollingPolicy appender. Updated
the offending pom.xml to force it to use logback 1.2.3 instead.
Change-Id: I3277b28133498f4ad9fbc3ed8b3e9e7e9519bbeb
Issue-ID: POLICY-785
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Project: policy/engine master c02881e7e7a0a01b5450caa04ef850438e6a299b
Merge "Decryption messages should not be errors"
Decryption messages should not be errors
Modified code to generate INFO messages when decryption fails,
instead of ERROR or WARN. Also modified some of the text in
the afforementioned messages.
Change-Id: I895967cf16b0e5667e1797bc16ea1ede81d6dd7a
Issue-ID: POLICY-785
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Project: policy/engine master 3f1057bf19f3e508ab6a01ad6acc60afac17ba3b
Merge "Remove """ from logback xml files"
Remove """ from logback xml files
Logback complains if %d{} values contain """, but it works fine
without them, thus they have been removed.
Update licenses.
Change-Id: Id1f21d3d51bb2495a92f54fcf5c3ad978612c375
Issue-ID: POLICY-785
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Project: policy/engine master 7b9a19e6c101fd834404774a40be51645992cdd5
Fixed Model Content Validation for API
This fixes the validation of the content of the model to include
validating parent nodes that are required based on the yaml. Prior to
this we were only validating required child nodes and in some cases this
was causing failures to create a policy.
Change-Id: I2bbef4a671cfc7af8b55b3b3c6454b8cea3a88c9
Issue-ID: POLICY-799
Signed-off-by: Michael Mokry <mm117s@att.com>
|
|
Project: policy/engine master e1bec1e7a8e3be989a81507eee81909314550693
Doc Updates: Policy OOM; StateMgmt
Updated policy documentation: Policy OOM; StateMgmt
-------------------------------------------------------------
Change-Id: I6abf933d842ddf9e1c88b8eec714bd7a00e07bf8
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
|
|
Project: policy/engine master 56a23de5d3f4ab454ef4a0c7c6e65456fbd234ce
Update engine to SNAPSHOT-1.3.0
Snapshot updated for Casablanca.
Change-Id: Ieb2c9a990c0f36f31c974038465e7d38aaa21e5d
Issue-ID: POLICY-875
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Project: policy/engine master a8f71f9093ad57afe14582803af8a3761ff270ea
Document Security section of the Release Notes
Change-Id: I2b74eb994ec16f47654e84a43a066c3497caca62
Issue-ID: DOC-271
Signed-off-by: Gildas Lanilis <gildas.lanilis@huawei.com>
|
|
Project: policy/engine master b4e3c54afe5aed8f5ae57b9e59a73dba38acdec6
Update Release Notes
Update Release Notes
-------------------------------------------------------------
Change-Id: I6283bc08bb95d49a343047968049e1cca5f53bf7
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
|
|
Project: policy/engine master 142ae9408466e78a4509490eb9ffe8bbc19f634a
Sonar fixes for TOSCA Parser
I fixed the sonar blocker in regards to nullPointerException and few
other majors that I found and were easy to fix. I ran my local sonar
and the blocker was removed after the changes.
Change-Id: I7dcd7584fc955e1b520235a8e1376cf871761d21
Issue-ID: POLICY-776
Signed-off-by: Michael Mokry <mm117s@att.com>
|
|
Project: policy/engine master 2f8ab5851fb070fac82472cf8a3c8542a657ca01
Merge "Replace LOGPATH with LOGSUFFIX"
Replace LOGPATH with LOGSUFFIX
docker-install.sh does not expand ${{xxx}} values in .conf
files before using them to update target files. Consequently,
replaced LOGPATH with LOGSUFFIX in .conf files and updated
target files to use ${{POLICY_LOGS}}${{LOGSUFFIX}} instead.
Replace "${POLICY_HOME}/logs" in auxiliary files (e.g., logrotate)
with "${POLICY_LOGS}/policy".
Update license dates.
In .sh files, changed ${{POLICY_LOGS}} to ${POLICY_LOGS}, and
ensured that env.sh is sourced.
Use hard-coded paths in conf files instead of replacing
LOGPATH with LOGSUFFIX.
Update license dates.
Repoint path for IntegrityMonitor.log, as we cannot easily move
since it's in common.
Replace hard-coded log path in docker-install.sh.
Undo hard-coded log paths where possible, and modify scripts to
pass $POLICY_LOGS to JVM.
Change-Id: I027d8d2173ae97fef73b0daff1d6a87452857f93
Issue-ID: POLICY-759
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Project: policy/engine master a08e498c52e5f778ec85cb698ac985488319b9f3
Merge "Fix Issues in TOSCA Parser"
Fix Issues in TOSCA Parser
Fixed a bug and added some new validations in TOSCA Parser
Issue-ID: POLICY-776
Change-Id: I2dc1b5b38cd137efc5c24ccf55b19de9f47c44da
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
|
|
Project: policy/engine master 20beb12cad63e778c837eb0f4106acd74019d340
Updated version/date in release notes
Updated version/date in release notes
-------------------------------------------------------------
Change-Id: I3d2fa0f7641074251e97e9f7b75772e9c8abe9f7
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
|
|
Project: policy/engine master 398142dc1d466c7017222b63fcb2bd9d79186d22
Merge "Update yml to use $POLICY_LOGS"
Update yml to use $POLICY_LOGS
Change-Id: I4fec68b7bd50f8e71e36510bf595126435726677
Issue-ID: POLICY-759
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Project: policy/engine master 52f36a95b2eedb4a5f897b8a3523bbe0616bd01f
Merge "Update Policy Engine to 1.2.3-SNAPSHOT"
Update Policy Engine to 1.2.3-SNAPSHOT
These reviews must be merged in order because of layering.
This review should be merged FOURTH.
Change-Id: Ifca8e33b79085a4032164b44dae3401f8179f5f6
Issue-ID: POLICY-844
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Project: policy/engine master ebb254093e0f5cef10ae1f98f85a199aacd8ed56
Updated release notes
Updated release notes
-------------------------------------------------------------
Change-Id: I4f6282d25d177078306954be852a28301eb26c2d
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
|
|
Project: policy/engine master 1da6b3b6a28f40322a13e6fb5142206f1eefa027
Add braces around property name
In pdplp.conf, changed ${POLICY_LOGS} to ${{POLICY_LOGS}}.
Change-Id: Id952dee7a38b868fea5650f4e54bfccb612bb56c
Issue-ID: POLICY-759
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Project: policy/engine master 6c3164d2e3383f909f621ec62f4bc1368d699fae
Merge "Upgrade SNAPSHOT to 1.2.2"
Upgrade SNAPSHOT to 1.2.2
These reviews must be merged in order because of layering.
This review should be merged SECOND
Note: In order to get past the following layering problems, there
are temporary chages to the following POMs to temporarily use 1.2.1-SNAPSHOT
for those dependencies. They are
ONAP-PAP-REST/pom.xml
org.onap.policy.drools-applications.controlloop.common.policy-yaml
ONAP-PDP/pom.xml
org.onap.policy.drools-pdp.policy-endpoints
A separate review will be used to restore these dependencies to 1.2.2-SNAPSHOT
once the drools-pdp and drools-applications reviews are submitted and merged
PLD added version.properties
Issue-ID: POLICY-798
Change-Id: Id7e83f2ba12181c63cc8845b7eeccf2004d2bab9
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Project: policy/engine master 6f7700a171332f3526fa6630943871a2757f86dc
Merge "Added Release Notes - Known Issues"
Added Release Notes - Known Issues
Added Release Notes - Known Issues
-------------------------------------------------------------
Change-Id: Ie5b1e9499114e09aedb72a95d389f2e07b4f5514
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
|
|
Project: policy/engine master fe7d0643ea01cda4826cb3444e47076d2ea9a268
Merge "policy documentation - release notes"
policy documentation - release notes
policy documentation - release notes
-------------------------------------------------------------
Change-Id: Ie480002003725fe6949c631c2a9c50fa7d1665c2
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
|