summaryrefslogtreecommitdiffstats
path: root/docs/submodules/policy
AgeCommit message (Collapse)AuthorFilesLines
2018-08-24Updated git submodulesMichael Mokry1-0/+0
Project: policy/engine master e1f88b91981a22cc63019d1d6b73089566425383 policy/engine changes to support PE https Enabled https connector in server.xml and modified the docker-install.sh to fix the default variable name for policy truststore Change-Id: I6db6a6d2353130c91c1f344ea7927d187150adca Issue-ID: POLICY-781 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-08-22Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master c25e4d412eb573de020ba4e5da48f48451217f52 Merge "Use builder for std pap policy" Use builder for std pap policy Modify constructor in stdpappolicy to use builder this will fix the sonar issue related with more than 7 parameters method parameters Issue-ID: POLICY-1016 Change-Id: Id736a66e5ea48f0f233cffb640cdce8aaa8f2c0d Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-20Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master b0557d5e3e2218d794fac3b28c2254593a6c3a80 Merge "Updated guard blacklist documentation" Updated guard blacklist documentation Updated guard blacklist documentation ------------------------------------------------------------- Change-Id: Ib99fd83119994a59e9708e3585d0eafdababc8d5 Issue-ID: POLICY-947 Signed-off-by: Saryu Shah <ss3917@att.com>
2018-08-20Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master a7ad88d23b2a59a16c098b156c430a2fe3558023 https certs with aaf+pe containers compatibility Change-Id: I21ed7a0fea5ea7d62857a077fa2568da4af99d26 Issue-ID: POLICY-1057 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-08-15Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master 84df4a428ded309f750f52ac1c104ac84e426fc0 Merge "Junit Coverage for Import Black List Entries" Junit Coverage for Import Black List Entries Issue-ID: POLICY-901 Change-Id: I3776d3c4ed01bb27ed930c074c370361e33b100a Signed-off-by: rb7147 <rb7147@att.com>
2018-08-14Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master 8f4e03b0867eada5220f78a3988865851443b7da Merge "Resolved the Sonar issues" Resolved the Sonar issues Issue-ID: POLICY-901 Change-Id: I30e1d075dd8eb4739bcb5aa1f2503a016900ff75 Signed-off-by: rb7147 <rb7147@att.com>
2018-08-14Updated git submodulesKrishnajinka1-0/+0
Project: policy/engine master 343df73f2b2dd2a39d090244c091371edbd2127f Optimize PAP policy constructor with builder Fix sonar issue about constructor using more than 7 params. Use builder parameters object for setting the attributes of std pap policy.Recommit1 Issue-ID: POLICY-1016 Change-Id: Id9631a42813960baa78df4ab0c0f6706244c3180 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-13Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master 5368a1d66dce2a1029e947a43e8ccdcfad98fbc8 Merge "Modify std pap policy to use builder in constr" Modify std pap policy to use builder in constr Fix sonar issue about constructor using more than 7 params. Use builder parameters object for setting the attributes of std pap policy.Rework2 Issue-ID: POLICY-1016 Change-Id: If26f7daa8d5b5d387238aad74daeddd49a8b95bb Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-13Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master a54ec0fce0cb5032d373e811d830cdd027b0dd9c Merge "Fix comparison issues in onap pap rest" Fix comparison issues in onap pap rest Fix issues about incorrect comparison in pap rest modules indicated by analysis tools.Rework to fix review comments1 Issue-ID: POLICY-1016 Change-Id: I7a0ee45a721307fc3ba89ab65e807613a3df2542 Signed-off-by: krisjinka <kris.jinka@samsung.com>
2018-08-10Updated git submoduleskrishnajinka1-0/+0
Project: policy/engine master 6ed1731fa2ce340d745dc2d39ffc6a066f50fbc2 Add PAP Policy parameter builder xacml policy Fix Sonar flagged major issue about 14 params instead of 9 in the constructor of std pap policy class. Commit5 for modify constrctor.fix test Issue-ID: POLICY-1016 Change-Id: I79c8482b7fc4e203cb18402ba2b5a68a120c57b1 Signed-off-by: krisjinka <kris.jinka@samsung.com>
2018-08-08Updated git submoduleskrishnajinka1-0/+0
Project: policy/engine master 5e8b7f573f0f7f08be242ee017ecf1243317f1b5 Fix sonar issue with constrctr in xacml comp Fix sonar issue of Method has 9 parameters, which is greater than 7 authorized in StdPDPPolicy. Make the actual sonar fix Issue-ID: POLICY-1016 Change-Id: Ibc79ddce81a6209ec190c7f393557e9c569df453 Signed-off-by: krisjinka <kris.jinka@samsung.com>
2018-08-07Updated git submodulesKrishnajinka1-0/+0
Project: policy/engine master 47c46108782dccd44101b772ba979e3fdf3ead04 Resolve sonar issue in Policy parameters Fix sonar issue of Method has 9 parameters, which is greater than 7 authorized in PolicyParameters class and related test class.Rework2 Issue-ID: POLICY-1016 Change-Id: I3096566d958e093439bcc95d92f1fe92e0ac57be Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-06Updated git submodulesKrishnajinka1-0/+0
Project: policy/engine master 7414584e40572c7854db959052c56f3cc8849488 Modify Policy manager servlet for sonar issues Fix basic sonar issues in policy manager servlet major and minor issues reported by sonar Basic refactoring Issue-ID: POLICY-1016 Change-Id: If3c19943c04d9af43807090b6340547d69ca6a19 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-03Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master 2fc1a1510259202e8854beb8c04ef045bd28c79b Merge "Modify ONAP PAP REST classes basic checkstyle" Modify ONAP PAP REST classes basic checkstyle Modify tabs to space for checkstyle issue fix in ONAP PAP REST module. It helps future reviews and refactoring. Remaining classes Issue-ID: POLICY-1014 Change-Id: I677eadac9e8364b388be922024528c27fd1e2545 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-03Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master dea7a9791960ac2f913e2ab4c70491706ab9e2a0 Merge "Fix major sonar issues in SDK APP admin mod" Fix major sonar issues in SDK APP admin mod Fix Sonar reported major issues regarding extracting constants, method complexity, duplicated code blocks, more than 3 nested control blocks. Rework3 after self review. Issue-ID: POLICY-1016 Change-Id: Icbf940c966c51a8ef4319a94a3832cb1e8c360ba Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-02Updated git submodulesKrishnajinka1-0/+0
Project: policy/engine master f0fec2a861ea0a92b27b40882ea38f9422cde0c6 Convert tabs to space in ONAP PAP REST1 Modify tabs to space for checkstyle issue fix in ONAP PAP REST module. It helps future reviews and refactoring Issue-ID: POLICY-1014 Change-Id: Idcf45689565f039c76a3ef0f40ad9a46b41bd8d6 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-31Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master 7a6c4f9214a71101db3354ed06ccd3cfd3cea65b Merge "Copy policy-endpoints from drools-pdp to common" Copy policy-endpoints from drools-pdp to common Issue-ID: POLICY-967 Change-Id: I84eba5c06d129cb2a7ef27ed78b63a8ada37805c Signed-off-by: mmis <michael.morris@ericsson.com>
2018-07-31Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master e31e46738ca14c18a00773e598df6639154aa1f2 Merge "Convert tabs to spaces basic refactoring" Convert tabs to spaces basic refactoring Change tabs into spaces for checkstyle fixes in ONAP REST module of policy engine. These changes come in way for review. Hence doing them before refactoring is better. Issue-ID: POLICY-1014 Change-Id: I31a372ae527946927157bc23b576f3066679b0ae Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-31Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master 64d3d5f9d4fb225fde55598e5b7462978642c417 Merge "Fix major sonar issues in SDK APP" Fix major sonar issues in SDK APP Fix major issues reported by sonar in POLICY SDK APP files such as CreateBRMSParamController, PolicyManagerServlet. Also modify tabs to space. Rework2 based on review comments Issue-ID: POLICY-1016 Change-Id: I5407ade1ce9f597fa91d9ca18506f5ac2d8b1411 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-30Updated git submodulesKrishnajinka1-0/+0
Project: policy/engine master 1ecf9de8c889adb2dbc9ddd9a79d28e1da89d87b Fix Sonar issues in utils PDP ParseLog rework Fix Major Sonar issues in ParseLog BackupMonitor and ONAP-PDP component. Issues related to nested control statements. Rework2 based on review comments Issue-ID: POLICY-1013 Change-Id: I10edb242b45a649df902a4e7c1aba0a285b8b7fb Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-27Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master 1df87df1af0d215b9ff908dd15089393b9be270b Merge "Copy policy-endpoints from drools-pdp to common" Copy policy-endpoints from drools-pdp to common Replaced references to classes deleted from drools-pdp with references to the corresponding classes in polcy-common Issue-ID: POLICY-967 Change-Id: I7bb580af3b3b2eb0ddcab9421c595237fa37282b Signed-off-by: mmis <michael.morris@ericsson.com>
2018-07-26Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master dd986507648898887715a20c2f962bc714e28882 Merge "Fix nested stmts issue of Sonar" Fix nested stmts issue of Sonar Policy rest util MSModeUtils have Sonar flagged issues about nesting more than 3 control stmts. Fix these. Also a minor change from prev commit about BrmsPush.java. Rework based on review Issue-ID: POLICY-1009 Change-Id: Ibd3cebcdebf9cf26233e810033793a5315b93272 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-26Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master d6838664316b9bfbc082f68889f4475cd25c81fa Merge "Refactor code for nested stmts in policy std" Refactor code for nested stmts in policy std Refactor code for nested control statements in PolicyEngineAPI policy.std package. These issues are flagged by Sonar as Major issues. Rework based on review comments Issue-ID: POLICY-1012 Change-Id: I6925dd5d56b653ef4cefe5ae64686a49f9741125 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-26Updated git submodulesLiam Fallon1-0/+0
Project: policy/engine master 2cdbafa5550465315a2328ea302b333446e1465d Merge "Fix issues reported by sonar" Fix issues reported by sonar Fix issues related to unused method variables, extract constants, not nest more than 3 control stmts, use try with res in policy engine project. Rework for comments Issue-ID: POLICY-1008 Change-Id: If0953de9e802110df14862707f3b525652cdf112 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-25Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master 7957dd169d09ff5fcfdfc0384e8ed7d3534d3dc0 Merge "Decision BlackList Guard Enhancements" Decision BlackList Guard Enhancements While creating a decision Bl Guard Policy we are allowing to add Blacklist entries through file upload for bulk from GUI. Issue-ID: POLICY-901 Change-Id: I4031fd4a96937b9facc330cecf72777d701d4678 Signed-off-by: rb7147 <rb7147@att.com>
2018-07-25Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master a5ccc101707216e8ffc07773c17799c60360863f Merge "Fix sonar issue about nested stmts" Fix sonar issue about nested stmts Refactor code to not nest more than 3 condition or loop stmts in policy PolicyEngineUtils. Rework based on review comments Issue-ID: POLICY-1003 Change-Id: I95fcfa0f99c517c02357c85ca39cd2f934e8da4d Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-24Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master 5ad6783ca5a09c0061b661a48210f6d8e22cd7d3 Merge "Refactor PolicyNotificationMail for sonar issues" Refactor PolicyNotificationMail for sonar issues SONAR flagged issues related with complexity of method being high and more than 3 nested loops in the PolicyNotificationMail Issue-ID: POLICY-986 Change-Id: Ife3e6b5610cec4bcf3898fdcad4cc2c9a3d61932 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-23Updated git submodulesKrishnajinka1-0/+0
Project: policy/engine master 8cf5ed300190ab386d95758e6d4be6c38e67123d Add modified copyright notice For the files which are modified add modified copyright notices as per comments from earlier review Issue-ID: POLICY-1002 Change-Id: I873b3ccc986d5f3d138ddb9e9b3c2307a0b127a6 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-20Updated git submodulesKrishnajinka1-0/+0
Project: policy/engine master eff265962c081edb751d5d2ed99dc443cb97f3fb FIX SONAR ISSUE NESTED TRY BLOCKS refactor the code for nested try blocks and rework based on comments and fix nested loops complexity Issue-ID: POLICY-976 Change-Id: Ied02b7838b5e4839a4906f79ff37c4fd6afeccfe Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-18Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master 9bfa1d61dc77973f85a42174b199d4c744265521 Upgrade tomcat to clear security issues New security issue has appeared, so we will do minor upgrade. Issue-ID: POLICY-982 Change-Id: I58ee20ec07300ab586017ca2072f63329e6f3417 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-07-17Updated git submodulesKrishnajinka1-0/+0
Project: policy/engine master 3555353c1baedc080f310e9e737a46f7cc7aa89e USE TRY WITH RESOURCES Fix sonar issues to convert try blocks to try with resources plus change tabs 2 space Issue-ID: POLICY-961 Change-Id: I553d6a42f1efaab5b7eb3a53bab945a3360e69bb Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-13Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master 2db31606da32d9f5d3a16854385de8e496cd28f6 Reverting "Merge "fix try block"" This reverts commit 240bbdbdc76e0e91af9f18164eadb2708d14c6fb, reversing changes made to 3ee69f1af0acddd1e06060ad88c0029fe7ceeaaf. Change-Id: I61f07ead1d7d3e89c512a2224efecf9ac440df10 Issue-ID: POLICY-961 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-07-13Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master 240bbdbdc76e0e91af9f18164eadb2708d14c6fb Merge "fix try block" fix try block Issue-ID: POLICY-961 Change-Id: Ia1f388368007a4a82a57520dc6ddd99cc484a393 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-13Updated git submodulesMichael Mokry1-0/+0
Project: policy/engine master 3ee69f1af0acddd1e06060ad88c0029fe7ceeaaf Upgrade Portal SDK to resolve Security Issues Upgraded version in pom to 2.3.1 Added SQL scripts from Portal to Upgrade Portal related db tables Added SQL downgrade script and license header Sorted SQL commands in upgrade script by function_cd per Jim Change-Id: Id6bef295956b6ec5b13d8fbd0006bbfe98c1c0ac Issue-ID: POLICY-918 Signed-off-by: Mike Mokry <mm117s@att.com>
2018-06-29Updated git submodulesJoseph Chou1-0/+0
Project: policy/engine master 54eaa820dd76f8da6076b6aad3d2c75c68236693 Revert "Fix policy gui missing schema_info table" This reverts commit e67481ed648c419a1645d0fc8b98506fe544a454. Change-Id: I092053ec1815cf7ca598b1913663532673125604 Issue-ID: POLICY-898 Signed-off-by: Joseph Chou <jc2555@att.com>
2018-06-27Updated git submodulesLiam Fallon1-0/+0
Project: policy/engine master aa72f4c2311d06fe699ea47e19714b66c0665b02 Merge "Address missing files in junit tests" Address missing files in junit tests Renamed logback.xml to logback-test.xml. Added policyLogger.properties to config directories. Change-Id: Ib6f50666a13c3258482b4007e7ceeb742f2e87a6 Issue-ID: POLICY-784 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-27Updated git submodulesLiam Fallon1-0/+0
Project: policy/engine master 9a1113e4128f1585dbf85aabc429e9da385a76a8 Merge "Don't use hard-coded tmp path" Don't use hard-coded tmp path Modified code to use java system variable to identify temp directory. Change-Id: Ib656dd2a2d57e43febb0daaa25cf90cb1b9330a7 Issue-ID: POLICY-920 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-27Updated git submodulesLiam Fallon1-0/+0
Project: policy/engine master b401754031d70b43ac1b1ee28256ea29add7ebf3 Merge "Fix console warning about xacml.properties" Fix console warning about xacml.properties Configured location of property file. Change-Id: I58a89b34aa58f4efd6ed3ee0f984869ee7bf2f6c Issue-ID: POLICY-921 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-27Updated git submodulesJim Hahn1-0/+0
Project: policy/engine master 29c8effb13eab61c5697e81a7593eac051272a0c Remove %h from log file names Modified code, either removing "%h" or replacing it with a directory name that is relative to the junit test. Change-Id: I6ea3e3139a04fefadca42340454be36a5b54445d Issue-ID: POLICY-784 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-20Updated git submodulesJim Hahn1-0/+0
Project: policy/engine master 141052c6dcabdddf20f2b46d95540f1ceb0d7299 Change PrefixList.class to Zone.class Changed the class. Modified the junit test to catch that type of issue, refactoring it to extract common code. Change-Id: Ibc3d22821f103cd3954d2f2f54d4d62307dbf4c6 Issue-ID: POLICY-909 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-15Updated git submodulesJoseph Chou1-0/+0
Project: policy/engine master e67481ed648c419a1645d0fc8b98506fe544a454 Fix policy gui missing schema_info table Modify docker-install.sh to include db schema update Change-Id: I75941522ea932e59cd85d7ff9887bf7d4759ae7c Issue-ID: POLICY-898 Signed-off-by: Joseph Chou <jc2555@att.com>
2018-06-12Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master 1577c271f66912e13770eb3950a25ae40cf9c4ad Merge "Set default logger to EELF instead of SYSTEMOUT" Set default logger to EELF instead of SYSTEMOUT Change-Id: I3395d3b95b11bf0166190beb454e60cb63de7454 Issue-ID: POLICY-784 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-12Updated git submodulesJim Hahn1-0/+0
Project: policy/engine master 6eb3c7f44a64cc1aebd4bcef6b081073d91bde7b Use POLICY_LOGS env variable in logging.properties Some logger.properties have /var/log/onap hard-coded; changed those to use $POLICY_LOGS. Other logger.properties had ${POLICY_LOGS} instead of ${{POLICY_LOGS}}; fixed those, too. Change-Id: I56faf5982abf520ee364b54a3560313d0f15cc2a Issue-ID: POLICY-784 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-08Updated git submodulesLiam Fallon1-0/+0
Project: policy/engine master 67de0163434349c52291e49cc7bbeadcba03747c Merge "Enforce logback version" Enforce logback version Some of the projects are being built with logback version, 1.1.3, which does not support the SizeAndTimeBasedRollingPolicy appender. Updated the offending pom.xml to force it to use logback 1.2.3 instead. Change-Id: I3277b28133498f4ad9fbc3ed8b3e9e7e9519bbeb Issue-ID: POLICY-785 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-08Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master c02881e7e7a0a01b5450caa04ef850438e6a299b Merge "Decryption messages should not be errors" Decryption messages should not be errors Modified code to generate INFO messages when decryption fails, instead of ERROR or WARN. Also modified some of the text in the afforementioned messages. Change-Id: I895967cf16b0e5667e1797bc16ea1ede81d6dd7a Issue-ID: POLICY-785 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-08Updated git submodulesLiam Fallon1-0/+0
Project: policy/engine master 3f1057bf19f3e508ab6a01ad6acc60afac17ba3b Merge "Remove "&quot;" from logback xml files" Remove "&quot;" from logback xml files Logback complains if %d{} values contain "&quot;", but it works fine without them, thus they have been removed. Update licenses. Change-Id: Id1f21d3d51bb2495a92f54fcf5c3ad978612c375 Issue-ID: POLICY-785 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-08Updated git submodulesMichael Mokry1-0/+0
Project: policy/engine master 7b9a19e6c101fd834404774a40be51645992cdd5 Fixed Model Content Validation for API This fixes the validation of the content of the model to include validating parent nodes that are required based on the yaml. Prior to this we were only validating required child nodes and in some cases this was causing failures to create a policy. Change-Id: I2bbef4a671cfc7af8b55b3b3c6454b8cea3a88c9 Issue-ID: POLICY-799 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-06-07Updated git submodulesSaryu Shah1-0/+0
Project: policy/engine master e1bec1e7a8e3be989a81507eee81909314550693 Doc Updates: Policy OOM; StateMgmt Updated policy documentation: Policy OOM; StateMgmt ------------------------------------------------------------- Change-Id: I6abf933d842ddf9e1c88b8eec714bd7a00e07bf8 Issue-ID: POLICY-536 Signed-off-by: Saryu Shah <ss3917@att.com>
2018-06-06Updated git submodulesliamfallon1-0/+0
Project: policy/engine master 56a23de5d3f4ab454ef4a0c7c6e65456fbd234ce Update engine to SNAPSHOT-1.3.0 Snapshot updated for Casablanca. Change-Id: Ieb2c9a990c0f36f31c974038465e7d38aaa21e5d Issue-ID: POLICY-875 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-05-31Updated git submodulesGildas Lanilis1-0/+0
Project: policy/engine master a8f71f9093ad57afe14582803af8a3761ff270ea Document Security section of the Release Notes Change-Id: I2b74eb994ec16f47654e84a43a066c3497caca62 Issue-ID: DOC-271 Signed-off-by: Gildas Lanilis <gildas.lanilis@huawei.com>