summaryrefslogtreecommitdiffstats
path: root/docs/submodules/policy/engine.git
AgeCommit message (Collapse)AuthorFilesLines
2018-05-08Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master 973929cfd6cd3e5ba3a837fa56d35b210307c9ac automate dependency.json version population This avoids error-prone manual version changes to configuration files. Change-Id: I1a991ef9a8eb4cc7dd5fe26d9952286d8b5c0115 Issue-ID: POLICY-766 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-05-04Updated git submoduleswaqas.ikram1-0/+0
Project: policy/engine master fad662d64ab3cb3aa2969fbcb9d7ff14cc1f15f1 Adding rollback for transaction handling Change-Id: I90887aafdd3cc49940bb4ed4b9283ec8a25aa205 Issue-ID: POLICY-773 Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>
2018-05-03Updated git submodulesSaryu Shah1-0/+0
Project: policy/engine master 833a2096df92eec273dc807cc930aee6e7cbc40e Updated policy documentation Updated policy documentation ------------------------------------------------------------- Change-Id: I840d17df857bb14fdc7e96e3c5f984037944c889 Issue-ID: POLICY-536 Signed-off-by: Saryu Shah <ss3917@att.com>
2018-05-02Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master 94340f3db1026e13b8bdd4ed5e2021144361992f Merge "Ignore directories created" Ignore directories created Clean up some outstanding logging side effects in .gitignore Issue-ID: POLICY-708 Change-Id: Ia3f268f0adf5615a11a109cb0d7d029a069b4520 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-05-01Updated git submodulesJessica Wagantall1-0/+0
Project: policy/engine master 8d530ba1a3697c7b7bb5e4b63d202c3a0523b825 Add INFO.yaml file Add INFO.yaml to list: - Project description - Properties - PTL information - Meeting information - Committer information Change-Id: Iab302b1e24c08980e3073d3fa34d53e4e81cabad Issue-ID: CIMAN-134 Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
2018-05-01Updated git submodulesliamfallon1-0/+0
Project: policy/engine master 5ff419848b3fd04dba17ba9088c035848015fd4e Fix Test fail with variable length memory address The unit test class PIPConfigurationTest.java has a test that checks a configuration string for length. However, the length of the "piptype" field in that string can vary, causing the test to intermittently fail. Field that passes: piptype=org.onap.policy.rest.jpa.PIPType@71b3bc45 Field that fails: piptype=org.onap.policy.rest.jpa.PIPType@a8c1f44 This fix removes the memory address from the "piptype" field, so that the configuration string will now always be 323 characters in length. Change-Id: Ib3640ec6f69ac7d691dcc989c44a7822bcc9b7f7 Issue-ID: POLICY-765 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-05-01Updated git submodulesSaryu Shah1-0/+0
Project: policy/engine master b0c7e3bd5a3fa546c1f87298ca4312b728a25495 Updated installation documentation Updated installation documentation ------------------------------------------------------------- Change-Id: I71d24c0806fc5d53691c505f87425c71e2f0a04f Issue-ID: POLICY-536 Signed-off-by: Saryu Shah <ss3917@att.com>
2018-05-01Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master 681b47487c22be6dda452501ead10b4c7d7e9c56 Merge "Remove sysout from junit and disable assert." Remove sysout from junit and disable assert. Updated BRMS Gateway junit tests to be less strict on hit counts on queries to Nexus. Draft version passed build son now submitting as full submission. Change-Id: Iab81d14be69835faefbb96fb0af17b3f3759575b Issue-ID: POLICY-756 Signed-off-by: pa834y <pa834y@att.com> Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-04-30Updated git submodulesSaryu Shah1-0/+0
Project: policy/engine master 1c022346cd42f3458816ac1e40d49efac9ae5c6b Updated policy documentation Fixed typos, Updated release notes, Deleted old release files ------------------------------------------------------------- Change-Id: I43bb64b7d1829e92b30bfd45ec3f3608a59672cf Issue-ID: POLICY-536 Signed-off-by: Saryu Shah <ss3917@att.com>
2018-04-27Updated git submodulespa834y1-0/+0
Project: policy/engine master 3eab022023bd68eee6743e30dd7db21c256bf00b Incorporate Liam code review Change-Id: I387a54b8bd8c619c521c512258928669a8c1b791 Issue-ID: POLICY-756 Signed-off-by: pa834y <pa834y@att.com>
2018-04-26Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master 9562f3b5dfc5613629b5119cb629c81005d93431 Merge "Fix typo in documentation" Fix typo in documentation Fix typo in documentation ------------------------------------------------------------- Change-Id: I01b8849c97645e9e5ed81f99768088f2fa439e45 Issue-ID: POLICY-536 Signed-off-by: Saryu Shah <ss3917@att.com>
2018-04-26Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master 37eebe9e6c814e4756443bf9d6f10afe9954aef6 Merge "Remove unit test Java version dependency" Remove unit test Java version dependency In the unit tests for the direct Sona Nexus Rest Interface, one of the unit tests only passed on an Oracle Java specific string. This test is fixed to now work on both Oracle and OpenJDK java Issue-ID: POLICY-700 Change-Id: Idae1aaf612a10ac003f2a91c0b5a80540152ac95 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-04-26Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master 693138b08a04a8027de64dc093e872bac963630a cook policy-keystore into pe image OOM team reported issues with ONAP installation in terms of config map sizes. After discussion with OOM team, one solution is to cook it in the docker image itself. This will solve the size issue on the OOM side. Change-Id: I2ca20bdc3aa8ee959c5e4c1d07483fe5f0c14607 Issue-ID: POLICY-747 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-04-25Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master 5e10681059449e28f0e49a2088cf671e75f42f19 Merge "Add JUnit for direct Sonar Nexus REST interface" Add JUnit for direct Sonar Nexus REST interface JUnit tests and changes to the source code to fix issues that were identified in JUnit testing. JUnit testing runs tests towards the Nexus server at https://nexus.onap.org If that server does not exist then the unit tests will fail but as the nexus serveir is required for the build to work then it should be OK to use that server for unit testing. This removes the need to write complex (and less effective) Mockito type unit tests. Issue-ID: POLICY-700 Change-Id: I4aa33a1022033b42bb1fd1fa36785a8e0216b887 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-04-25Updated git submodulespa834y1-0/+0
Project: policy/engine master b63b7672e6ba731c53198c69309c0d8e9ee7f138 Add websocket client code. Change-Id: I2d3939c698a0df6bec068063f08566226f65bfd3 Issue-ID: POLICY-756 Signed-off-by: pa834y <pa834y@att.com>
2018-04-24Updated git submodulesliamfallon1-0/+0
Project: policy/engine master 30b44d3e752d44f8f870594a05464c9e1c5158b6 Implement Sonar Nexus REST interface directly The BRMS gateway used the obsolete nexus-rest-client-java library to query the Nexus repository. This change removes that dependency and implements an interface directly to Nexus servers using the Nexus REST interface. This change is being submitted to ensure that the security issues with the plugin are resolved. The unit test for the new code will be implemented in a later submission. Issue-ID: POLICY-700 Change-Id: Ia1044e432d370034fe13f42cf7ed55d75e21187a Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-04-24Updated git submodulesSaryu Shah1-0/+0
Project: policy/engine master ab8bc20cabdbdd104a69da321d69d49662e53b92 Remove cookbook gif Remove cookbook picture from page ------------------------------------------------------------- Change-Id: I61edd0e4f336b19237421f05d6d36b61bb63170f Issue-ID: POLICY-536 Signed-off-by: Saryu Shah <ss3917@att.com>
2018-04-23Updated git submodulesJim Hahn1-0/+0
Project: policy/engine master e670d65eba1d1394605c2614b7f6697b07292ac8 Add license to policy/engine image files Added license to gif, jpg, and png files. Removed changes from gif files in POLICY-SDK-APP. Change-Id: Ief0c4be74cbdb844dd503040832be6c89bcc7ef9 Issue-ID: POLICY-741 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-04-23Updated git submodulesliamfallon1-0/+0
Project: policy/engine master d73f9545331d390ab3975840dea8c4a48beef498 Build fails when build host running web server If the host on which the policy engine is running a web server that respoonds with a HTTP response on the URL "http://localhost", the build fails because one of the tests in ONAP-XACML expects a ConnectException on this URL. When the URL returns a valid respose the test fails causing the buld to fail. This fix changes the URL to "http://localhost:54287", which I guess could also exist but is much less liekly to exist. Change-Id: I2f80d12a80d29a9bc7b2067f35c286f01c4d9550 Issue-ID: POLICY-700 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-04-19Updated git submodulesJim Hahn1-0/+0
Project: policy/engine master daee922e51e60c3cad6a3cc691214a34aad9ac7f Add license to policy-engine files Added license to various files. Updated XACMLPolicyScanner to work even when license comment is added to the Policy.xml file. Moved DOCTYPE before license in html files. Removed license from css files, as many are generated or come from third-party software. Removed license from other generated files. Change-Id: I9d98ca9f552a6eae17e80ef27fc7045cc4f27b8e Issue-ID: POLICY-741 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-04-19Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master 19f797e3d37c5fde0da8d58208e1256be9376e82 Merge "Remove insecure dependency on PolicyEngineAPI" Remove insecure dependency on PolicyEngineAPI The insecure dependency tyrus-container-grizzly-client is part of Tyrus, a Java web socket implementation library. A direct substitution of this library is not available so the code in AutoClientEnd.java and ManualClientEnd.java was adapted to work with the library org.java-websocket.Java-WebSocket that does not seem to have any vulnerabilities when tested with the org.owasp.dependency-check-maven plugin. The purpose of this submission is to see if the new library does indeed remove the vulnerability. If so, the implementation in AutoClientEnd and ManualClientEnd must be cleaned up. Change-Id: I961635aaea42c2f847edf11ee77e2961cdfb097b Issue-ID: POLICY-744 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-04-18Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master b082b9ff25a9794664c73c61d6f9e6a28a1b8ee5 Upgrade poi to clear CLM https://nvd.nist.gov/vuln/detail/CVE-2017-12626 Issue-ID: POLICY-722 Change-Id: I016d2d357858729b402ad010d47a31af053d2799 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-04-18Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master a4baf3adde49e27d88492339ffa5e4da4d79af57 Upgrade hibernator and netty Forgot one place for hibernator and need to upgrade netty to clear CLM issue. http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-2156 Issue-ID: POLICY-722 Change-Id: I741c47110af916c222f92329791217b0c3bc07df Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-04-17Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master 2817079ede91e3e38f767086cccb485ceff6dd03 Upgrade hibernator to clear clm Upgrade hibernator to clear clm issue. https://nvd.nist.gov/vuln/detail/CVE-2017-7536 Issue-ID: POLICY-722 Change-Id: I1a4d9aa8ad3b477db0c91bd5a53a67932554213d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-04-17Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master efe99f4403f20df12479fba8d75a8639a0fc1336 Upgrade spring 4.3.15-RELEASE Forgot this reference to spring. Issue-ID: POLICY-722 Change-Id: I4335d860a883f925f1a6ba7bf28f6b59ed52511f Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-04-16Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master 9154e24b32e41cf987daf02da01eaca7805fc291 Merge "Upgrade Spring to 4.3.15-RELEASE" Upgrade Spring to 4.3.15-RELEASE Upgrade to fix 3 security issues: https://nvd.nist.gov/vuln/detail/CVE-2018-1270 https://nvd.nist.gov/vuln/detail/CVE-2016-9878 https://nvd.nist.gov/vuln/detail/CVE-2018-1271 Issue-ID: POLICY-722 Change-Id: Icfa5775905ad091dbe55eadfb4414c67abebc13a Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-04-16Updated git submodulesWang,Frank(gw1218)1-0/+0
Project: policy/engine master 733918bc47b890af057416cdac3c321374acc321 Fix wrong data name Since MS configure name was changed in server side, its name needs to be updated in the JS file also. Issue-ID: POLICY-743 Change-Id: Iaed37a8d2b4dcfc5fb5ccd746b9aeb2270289338 Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
2018-04-14Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master 18d1759edf0805d060417f70cf162e56a71a4c27 Merge "Upgrade to SNAPSHOT 1.2.1" Upgrade to SNAPSHOT 1.2.1 Issue-ID: POLICY-736 Change-Id: If5c959aa1c0a123c7fd9eee281e39e1d646b6b03 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-04-13Updated git submodulesWang,Frank(gw1218)1-0/+0
Project: policy/engine master 36e8f5e2c625cd76f183757942db9a80a30251ab Fix Wrong Data Names Fix wrong data names due to reponse changes Issue-ID: POLICY-740 Change-Id: I28db745f88ccecd67f3daa30adf70cc69645b496 Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
2018-04-12Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master da09b036ff8f3c927e552e33e1476be4ba488efa Merge "OOF Policy Config File Creation Issue" OOF Policy Config File Creation Issue Fixed the issue with creating the config file with the wrong file name so that the PDP can pick it up when pushing the policy and getCOnfig will return the Config retrieved rather than a CONFIG_NOT_FOUND 400 status. I found this issue in the new CSIT tests for HPA policies and this should also resolve the failed test in Integration as well. Change-Id: I617133a188f3ba915feafd79da4f3e9d0b0eb4a6 Issue-ID: POLICY-738 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-04-12Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master 214338aa61978daf5c169f02c4c0e56527a3f90d Merge "Fix Fortify Header Manipulation Issue" Fix Fortify Header Manipulation Issue Fix Forfity issue on group Id by adding a validation on this input value. Issue-ID: POLICY-734 Change-Id: I83321a5ffd1ddca84f985b5fd8659e502ca967d7 Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
2018-04-12Updated git submodulesSaryu Shah1-0/+0
Project: policy/engine master 1c6d62ab27dcb3491cf52f939b06232a5c64c1ba Update Release Notes Update Release Notes ------------------------------------------------------------- Change-Id: I3119427562112969afac284576b3fe799eac0887 Issue-ID: POLICY-536 Signed-off-by: Saryu Shah <ss3917@att.com>
2018-04-11Updated git submodulesMichael Mokry1-0/+0
Project: policy/engine master aff7dbd3713e42412bcc7b5f6416896e16e82898 Modified DB Upgrade script for OptimizationModels Changed the incorrect column 'dataorder' to 'dataorderinfo' Made changes to pom and AAF client code per AAF API changes in new depedency. Change-Id: Ic9bf0edec8282cc0f96d6fedd62fa9253d52070f Issue-ID: POLICY-731 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-04-04Updated git submodulesChou, Joseph (JC2555)1-0/+0
Project: policy/engine master 4071a05a70909c9f6ec5006be2582edc961fe3a9 ONAP log files consolidation Check in changes for pap,pdp,console,brmsgw,paplp and pdplp Change-Id: I5b51368f8fed2d0ede848f1aa7f2f70c866dfe8b Issue-ID: POLICY-562 Signed-off-by: Chou, Joseph (JC2555) <jc2555@att.com>
2018-04-04Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master 7e28140dbf60ca27976668a372747af48600a325 Merge "Add More Validations on TOSCA Model Format" Add More Validations on TOSCA Model Format Add more validations on TOSCA MS model file name and content format Issue-ID: POLICY-721 Change-Id: Ic3dfe1887791be1e11bca5695866a77909334536 Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
2018-04-03Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master e313080641069b3bfc1f497113c57f1667b72bbc Merge "ONAP log files consolidation" ONAP log files consolidation Check in changes for pap,pdp,console,brmsgw,paplp and pdplp Change-Id: I23525a44e0f269d04d9870c3eed18b6b8daacb2c Issue-ID: POLICY-562 Signed-off-by: Chou, Joseph (JC2555) <jc2555@att.com>
2018-04-03Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master 11eb39f53842dff62e81a38ab599ddbc97cf7b73 Merge "Update docker script for tomcat install" Update docker script for tomcat install Issue-ID: POLICY-507 Change-Id: I14278865429dc0ccd0515ef5c84012b43b366c9a Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-04-03Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master 5797b32ae6645aeef77162ce09a37b473c9d41d0 Merge "Documentation links" Documentation links Updated swarch_pdp.rst to include links. ------------------------------------------------------------- Change-Id: I6db8fc4200ef31883496c25736158c57da4e28b4 Issue-ID: POLICY-536 Signed-off-by: Saryu Shah <ss3917@att.com>
2018-04-03Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master 09e7756ab2c21c646b7092ee7cded9c8823535a9 Merge "Fix BRMSGW Executable Jar Class Path" Fix BRMSGW Executable Jar Class Path The BRMSGW is no longer able to start up in windriver due to recent changes to the package names. The class path to generate the executable jar now reflects the recent changes. Issue-ID: POLICY-681 Change-Id: I032e516e082defd6a7ad0daae559f8c3e60ae531 Signed-off-by: Daniel Cruz <dc443y@att.com>
2018-04-03Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master def1c29d8a8c4372e006b1388a456bca92d57500 Merge "JUnit additions for PDP,PDP-REST,SDK,XACML" JUnit additions for PDP,PDP-REST,SDK,XACML Issue-ID: POLICY-600 Change-Id: I8052451c3f66116f361f2963fcc2727c022dd4d9 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-04-03Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master 145ef110e6ee7108846c91a509e33e65b5b64306 Merge "Fix a Bug on Checking Required Fields" Fix a Bug on Checking Required Fields Fix a bug in checking required fields if the object has include function Issue-ID: POLICY-717 Change-Id: I766da50c9ac02081dd4e711b8c78be0f3c25e5bd Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
2018-04-03Updated git submodulesSaryu Shah1-0/+0
Project: policy/engine master b05e6d316064acc289e72186c180aa8d5e84ed4b Documentation edits Fixing typos in modifying Release Template Page ------------------------------------------------------------- Issue-ID: POLICY-536 Change-Id: I8334afe77761ae3fe5fbee35719957ec10af1c8f Signed-off-by: Saryu Shah <ss3917@att.com>
2018-04-02Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master d105cbfe03206ad479e474e58290db4d5b9ba511 Merge "Support CSIT tests for OOF Policy" Support CSIT tests for OOF Policy I added an INSERT to the sql upgrade file and some sonar fixes and Junits Change-Id: I37139d5a8ad78d9d46ee01f81c2edd052672712e Issue-ID: POLICY-639 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-04-02Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master 1cc7a3d1ec03a9eac35c3467167be08dedd2ded8 Upgrade tomcat to resolve security issue Tomcat resulted in 30+ CLM errors level 7-8. Issue-ID: POLICY-507 Change-Id: If055426a9b3fd464063fb84f8105f35213e2701a Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-04-02Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master 26360c30af5ad955765ae0c3cb5bf2bfcf143669 Merge "Documentation Update Release Template" Documentation Update Release Template Documentation Update Release Template ------------------------------------------------------------- Change-Id: I827712a68820bccad0dcb1534cb96d5dd8bdb128 Issue-ID: POLICY-536 Signed-off-by: Saryu Shah <ss3917@att.com>
2018-03-30Updated git submodulesbobbymander1-0/+0
Project: policy/engine master 3387ae275aeb64113d48cd67b44db217b67e598e JUnit additions for XACML,PAP-REST Issue-ID: POLICY-605 Change-Id: I4b55a85eacf989ddb55743300e7f75e4b72882d0 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-30Updated git submodulesbobbymander1-0/+0
Project: policy/engine master 95ba8a85dacd65101f550e2d32dda33780b16dbd POM fixes due to update in cadi-aaf Issue-ID: POLICY-507 Change-Id: I493233f8e0e90eaf24e9c09c7433c6fb9fadb268 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-30Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master a9de6d45f97b3229cb14e164c791715a3dfed026 Merge "Fix a Bug in View Mode" Fix a Bug in View Mode To make MS template layout better for complex MS models and also add parent level elments first in view mode. Issue-ID: POLICY-714 Change-Id: If6bf472a504f15fd9bde05253e9369ba43bb082e Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
2018-03-30Updated git submodulesPamela Dragosh1-0/+0
Project: policy/engine master 4720126987f4b8408281621620209a9817b8c402 Merge "Removed checkstyle warnings" Removed checkstyle warnings Change-Id: I0701333d2b36a0796b592ce92b8015c1a56f8258 Issue-ID: POLICY-711 Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>
2018-03-29Updated git submodulesJorge Hernandez1-0/+0
Project: policy/engine master ede2c08753478bdd91deee1f8bc02230fd258b10 Merge "JUnit additions for ONAP-REST" JUnit additions for ONAP-REST Issue-ID: POLICY-603 Change-Id: Ic8a20fc758927afb9200547d5919fcf70f15852b Signed-off-by: bobbymander <bobby.mander@att.com>