Age | Commit message (Collapse) | Author | Files | Lines |
|
Project: policy/engine master f22bf064b4e4bb55c777056747b93f40d185b7a4
Merge "JUnit test for policy/engine ONAP-XACML"
JUnit test for policy/engine ONAP-XACML
Increased junits in package org.onap.policy.xacml.test.std.pap in policy/engine ONAP-XACML
Change-Id: Ifef6fcc36044039b2c3d0c0dbffecffd3e242434
Issue-ID: POLICY-605
Signed-off-by: mmis <michael.morris@ericsson.com>
|
|
Project: policy/engine master eb6547de8d3cf4feaf5ed9801200fc9dbef3c7ba
Modify sonar settings to include all sub-modules
We are now including all the sub-modules coverage into one file.
This will now reflect correct statistics for any sub-module that
tests code located in another sub-module.
Issue-ID: POLICY-634
Change-Id: I1eeb52c893aea96b3b031fabceb92e3b07f6c02c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master aee733bc72df351a0e3c4aa4df7807362fb515c1
Adding Junits in ONAP-PDP-REST
- This commit adds one Junit for PAPServices
- I needed to make a minor modification to the PAPServices class in
order to set the PAPs
Change-Id: Ia54650307e8d9e96d40ce6e68ad18508d4030a4a
Issue-ID: POLICY-338
Signed-off-by: Michael Mokry <mm117s@att.com>
|
|
Project: policy/engine master 472f049b84fd69caa1e0a07bbe3e088bbfd0a44d
Merge "Added Junits for Policy PAP-REST"
Added Junits for Policy PAP-REST
Cleaned the unnecessary constructors and methods in onap-rest.
Added Junits for JPA Classes in ONAP-REST.
Issue-ID: POLICY-338
Change-Id: I7e4f928342315475db96d89e9ad3adac5cb7eb00
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Project: policy/engine master a694b6879a44773d500e857699bb5a1e6e526140
Make drlRuleAndUIParams transient or serializable
Make drlRuleAndUIParams transient or serializable
StdPAPPolicy.java:L72
Sonar Link:
https://sonar.onap.org/project/issues?assignees=swapnalipode&id=org.onap.policy.engine%3APolicyEngineSuite&open=AWF91ipr8TZzbCgU6aom&resolved=false
Location:
src/main/java/org/onap/policy/xacml/std/pap/StdPAPPolicy.java
Change-Id: I3524881e76c69518949a622a23084e0bc8ef26a2
Issue-ID: POLICY-631
Signed-off-by: Swapnali Pode <SP00501638@techmahindra.com>
|
|
Project: policy/engine master 8baa15218033f9ab6741645eb380e17eb7d9c2dd
Merge "Fix a Bug on Editor Screen"
Fix a Bug on Editor Screen
On editor screen, sometimes click on + button only one click, it creates
more than text fields
Issue-ID: POLICY-629
Change-Id: I9acc95fa0a4a7df3828e579f994c06bfa3199eb5
Signed-off-by: guangxingwang <gw1218@att.com>
|
|
Project: policy/engine master eaca8f8d4609b0aed5a829d9d53e29e4543feaad
Merge "Added Junits for Policy PAP-REST"
Added Junits for Policy PAP-REST
Resolved the sonar issues.
Added JUnits for ONAP-PAP-REST and ONAP-REST Component.
Issue-ID: POLICY-338
Change-Id: Ibec2613f4f61e9ed426583af17c2a9d5b8c8d85d
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Project: policy/engine master 4b76cc3f5b951c8b476b1f13ebb798a2ec4a7277
Merge "Fix Fortify Scan Issue"
Fix Fortify Scan Issue
Fix Fortify Header Manipulation Issue by checking the format of a string
before adding it to response header.
Issue-ID: POLICY-543
Change-Id: I6539d22d5f8933ea29932361b152d34dd4f8857a
Signed-off-by: guangxingwang <gw1218@att.com>
|
|
Project: policy/engine master 1ef83d84ac1f803280686cca6960d1dc20695ace
Merge "Added Junits for ONAP-PAP-REST"
Added Junits for ONAP-PAP-REST
Cleaned up unused imports.
Cleaned up unused code.
Added Junits for Dictionary controllers.
Issue-ID: POLICY-338
Change-Id: If29b934e95fdaf60dcf82300a95a23ac3c980419
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Project: policy/engine master 75978c1770c5c88be836531e0c9d02514659af24
Merge "Upgrading XACML jar"
Upgrading XACML jar
XACML was released with minor fixes for XML files with comments. Mainly
it contained upgrade to dependencies that had fixed security issues. One
still remains but will not be able to be fixed.
Issue-ID: POLICY-617
Change-Id: Ib143c87156ed6a15cf4f0fe0ecbedb2407ca5b0d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master 7f09be3758d5797c22682686bad9281516cfe5a1
Merge "Added JUNITS for ONAP-REST Component"
Added JUNITS for ONAP-REST Component
Added JUnits for all Pojo classes.
Issue-ID: POLICY-338
Change-Id: I0142903899f0793a8e147a01aeea83d467e49981
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Project: policy/engine master 012c16b06d85d81e35f54d18982c183933025c8b
Remove Password from Logging
Fix Fortify logging issue
Issue-ID: POLICY-544
Change-Id: Ibfc7665dcab229a705ec3f999545b14675c24430
Signed-off-by: guangxingwang <gw1218@att.com>
|
|
Project: policy/engine master 321417267ab93b0a8f0244aef07c45cdc37dbef4
Merge "MS Model Input Validation"
MS Model Input Validation
- Provides validation for MS policy input content body that matches the GUI validations when create/update MS policy from API
- Added changes to satisfy review comments and updated copywright
headers for modified and new files
Change-Id: I02bfa639bffb48520badd0e4fa34eb36418547ae
Issue-ID: POLICY-377
Signed-off-by: Michael Mokry <mm117s@att.com>
|
|
Project: policy/engine master 9a322232dd7840065a37004000372f4332b055c9
Downgraded the POLICY-SDK spring version
Issue-ID: POLICY-620
Change-Id: Ib7cf286f62e945edcf5720ce2c53957b8456126d
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Project: policy/engine master 1a08a422414090d30d2ce1901c1e34d4965a3808
Merge "Upgrade jackson-databind to fix security"
Upgrade jackson-databind to fix security
Missed this, I should have earlier upgraded to 2.9.4
Issue-ID: POLICY-507
Change-Id: Ic75cfd2d5a265f4a728e59777eac287a3d0894d1
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master b76e99abb13f51473cdd697aa6040d9a0265d695
Merge "FFix the Bug of Missing fields on View Screen"
FFix the Bug of Missing fields on View Screen
Missing extra fields added by clicking add buton if they are more than
10 on view screen
Issue-ID: POLICY-613
Change-Id: I9e718b62301f24b71a4f6506d3e63e6185e0b1ce
Signed-off-by: guangxingwang <gw1218@att.com>
|
|
Project: policy/engine master c9039d15e8a84a9304fba40283a332a2a65ef854
Merge "Upgrade dependencies to clear security issues"
Upgrade dependencies to clear security issues
A bit of consolidation too - which could use a lot more work. These
were simple security upgrades for fixes identified by LF weekly LCM job.
Added some missing license headers.
Issue-ID: POLICY-507
Change-Id: If285b0f95d30a1084c9363bf6a41b48d52fb3aff
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master b7594ee217d0fd4c724fd64dd48d2e154fdd6e90
Fixed the sonar issues in ONAP-REST.
Minor Sonar issues are fixed in the ONAP_REST module.
The copyright headers of the changed files are also updated.
Issue-ID: POLICY-476
Change-Id: I920d8bcdd7b855e3e1660a002fb0e4e8d1674e44
Signed-off-by: Ankitkumar Patel <ankit@research.att.com>
|
|
Project: policy/engine master 6a44b2926f33b427904c2f3e7962d0dfc360c482
Merge "Implement Encryption on Passwords"
Implement Encryption on Passwords
Fix Fortify scan issue - hardcoded password in properties file
Issue-ID: POLICY-542
Change-Id: Iea7b292c4dccf5f400320cd3f63309e955953f2d
Signed-off-by: guangxingwang <gw1218@att.com>
|
|
Project: policy/engine master 7bb6ef9ad8a483bdac3ff1544cd0910ecebe5a98
Merge "Adding JUNITs for ONAP-PAP-REST"
Adding JUNITs for ONAP-PAP-REST
Issue-ID: POLICY-338
Change-Id: I123a92872a236b23144c59e87ea2dffc9ee7fc48
Signed-off-by: uj426b <uj426b@att.com>
|
|
Project: policy/engine master bf298f2be48f54c4906100e8e7a53c1f6e8da52e
Merge "Continue addressing technical debt for ONAP-XACML"
Continue addressing technical debt for ONAP-XACML
Fix all sonar issues that do not require code refactoring
Issue-ID: POLICY-475
Change-Id: Iefa91e0048b7041c96d47bce7ec99034d6fcc427
Signed-off-by: Gao, Chenfei (cg287m) <cgao@research.att.com>
|
|
Project: policy/engine master 07450cf3a2fa5ac2049d7b287567eb2641dfb5f7
Merge "Implement Encryption on Passwords"
Implement Encryption on Passwords
Fix Fortify scan issue - hardcoded password in properties file
Issue-ID: POLICY-542
Change-Id: Icefd4097dc2e20c0ec2b78c002599defb6034267
Signed-off-by: guangxingwang <gw1218@att.com>
|
|
Project: policy/engine master 695d88bd7a987a06173fc4fa13f4135916a79a86
Policy Resiliency Code Fixes
Resolved the issue on updating the configuration files when
rename/clone/export/move actions are done through GUI.
Fixed the PolicyManagerServlet code.
Added test cases for newly added files.
Issue-ID: POLICY-609
Change-Id: I9d14f19fe20bbc0e3b3844f85d81f26e34bb26ec
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Project: policy/engine master 6425d452d8507e9eeeb4da2f9f7051e602af541e
Merge "Fix last technical debt"
Fix last technical debt
Last one that I dare to fix.
Issue-ID: POLICY-477
Change-Id: Ieb1c159b781fa2f0dd80f7dea92dcbf72c3e8364
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master fe11ab01afebfa9777c3382d28026c805f7d042b
Merge "Technical debt and fix JUnit test"
Technical debt and fix JUnit test
* One statement per line
* private constructor for class with statics
* Fix silly JUnit test
Issue-ID: POLICY-474
Change-Id: Ie760826879febbbc4db4f03079ae1f847f2194dd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master 3e642d2fcd9a09a8a40918cf0451cfdafe70e968
Merge "Remove technical debt"
Remove technical debt
* String literals on the left
* Unnecessary initialization of variables
* Change ArrayList to using List
* Remove extra semicolons
* Empty Constructor comments
* Useless parenthesis
I also added a comment on some code that is suspicious. Not comfortable
with changing that code.
Issue-ID: POLICY-482
Change-Id: I89d889737d398d047fab4b25cb5d962ee1ecdd03
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master 549cafbb3b5b5c9298e8c7371835f5c58633349f
Implement Encryption on Passwords
Fix Fortify scan issue - hardcoded password
Issue-ID: POLICY-542
Change-Id: I722b9143fbddc48b67592bb35a44f36ed8b38aad
Signed-off-by: guangxingwang <gw1218@att.com>
|
|
Project: policy/engine master bdb9bf58d7a80f43c3ce558e6fe59c3bc0f6f8bd
Merge "Technical debt reduction"
Technical debt reduction
* empty constructor
* Unnecessary imports
* try-with-resources
* missing @Override
* useless parens
* proper boolean detection
* useless imports
* Use Set vs HashSet
* moving statements to separate lines
Issue-ID: POLICY-477
Change-Id: I5fae9c5c8e7d30f731a1caefc8a5271cf382e0a0
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master 0c8425b25c093f638351a14f84a7b1df731cd0de
Resolved Fortify System Information Leak issues
Issue-ID: POLICY-550
Change-Id: I2145ecb6de43b69d6faf44c6395b119134a9904f
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Project: policy/engine master e8c14515d3f48aad6d42a31d7489a3ef25557f2d
Resolve LF license header issue
These were simple, we just forgot to remove the old license headers. Also
needed to add a missed fix for a JUnit test. Not sure how this made it past
verify.
Issue-ID: POLICY-552
Change-Id: I30610ba4f8440ee16d0a5c372985f50429d60a34
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master d9b21bad7e932ee60a8f2c64ca42d42cc9eac2cc
Merge "Included Policy GUI Enhancements and validations"
Included Policy GUI Enhancements and validations
Added hover messages for all policy templates.
Resolved few sonar issues.
Added fixes for Policy GUI Validations.
Issue-ID: POLICY-597
Change-Id: I74abb92dd6ac8722d7869b6a316fad1d8db11d9c
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Project: policy/engine master 06f456d8d06840a21f48531b0bd35b1a429b10f9
Reduce technical debt and add JUnit
* Addressed some very simple cyclic complexity
* Added simple JUnit tests and finished others
* Removed useless assignments
Issue-ID: POLICY-477
Change-Id: Ic919bbf78ad2732a430c32f1feb3c88678be710d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master 066fc4529f36d210a4a4700e8dbfd2cb42f4dc66
Merge "Reduce technical debt"
Reduce technical debt
The last for technical debt I believe. The last try-with-resources I dare to
fix. Useless import that I missed last time. Did a couple of minor
reductions in cyclomatic complexity that I think are harmless.
And lastly introduce a new variable instead of reusing a parameter.
Issue-ID: POLICY-482
Change-Id: I5f2e5abbdd472496b48cf12e485fc9b4d903f35a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master c579209f8a4045d7f96f2b566a82ce1b8cf8660d
Merge "Continue addressing technical debt for ONAP-XACML"
Continue addressing technical debt for ONAP-XACML
Follow the list of acceptable fixes in POLICY-336 description
Issue-ID: POLICY-475
Change-Id: I67f46bb383db1ac4feecb0223df98d180733fc95
Signed-off-by: Gao, Chenfei (cg287m) <cgao@research.att.com>
|
|
Project: policy/engine master 401b48bc573561f097960a9ca7abe6d788456f28
Fixed the Sonar technical debt.
Fixed the sonar technical dept primarily for the POLICY-REST module, and
accordingly updated the other policy-engine modules for successful built.
Issue-ID: POLICY-476
Change-Id: I0e9bd7209a7f9af247fa409a1682683082f92698
Signed-off-by: Ankitkumar Patel <ankit@research.att.com>
|
|
Project: policy/engine master 9301fed7c290f52208922f780fdfe4b5a880b5aa
Adding code coverage reduce duplicate lines
Removed some duplicate code across some of the classes. For CheckPDP, got the code coverage
above 80%.
Issue-ID: POLICY-482
Change-Id: I41495cf9f92e8fd248350bf33f5a183c876f38f2
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master 9df8b88412f6e890320bc446ba1c83a13e99822d
Merge "Fix technical debt and reduce lines"
Fix technical debt and reduce lines
Focused on iterating over entrySet along with more fixes for
dead stores, unnecessary exceptions. I'm also starting to work
on reducing the number of code lines.
* Iterate using entrySet
* Remove useless assignments
* Unnecessary exceptions
* Use StringBuilder instead of StringBuffer due to synchronization
* Potential null exceptions being thrown
* Returning a empty collection vs null
Issue-ID: POLICY-482
Change-Id: If6ac8e812237f37b2b10c534535df4090a5073dd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master cac5ee759fee5db51a32838c7e25b878468a27e0
Merge "Addressing Technical Debt for ONAP-XACML"
Addressing Technical Debt for ONAP-XACML
Follow the list of acceptable fixes in POLICY-336 description
Issue-ID: POLICY-475
Change-Id: I45cfb55c571d32601049beb8e5be8676216dcf5c
Signed-off-by: Gao, Chenfei (cg287m) <cgao@research.att.com>
|
|
Project: policy/engine master b65e96826d7339ce29ddb73e3ed6775bd4f54753
Reduce technical debt
Focusing on easy try-with-resources changes. Plus some other minor items.
I did not get all of them yet, as some have some heavy refactoring. These
try-with-resources seem to be fairly harmless.
* Utilize try-with-resources
* Remove unnecessary parenthesis
* Merging simple if statements
* Remove useless assignment
* Moving string literals to left hand side
Issue-ID: POLICY-482
Change-Id: If519ec8ea96f6b90bf82ac2676ffea9cd0cd2daf
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master 38261bb20e49c39f710aef47b5415dcdf14a1729
Use try-with-resources
Also enhanced JUnit tests to ensure this will work. Reduced code.
Issue-ID: POLICY-482
Change-Id: If07e17df274bdb709f7ca60078bd1fbd78d1aaaa
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master e44a43f3dbb1dbaa182122f66961c55d3b96b824
Reduce technical debt
Mainly use StringBuilder() to improve speed
* Use StringBuilder
* Remove superflous exceptions in constructor
* Remove unnecessary casts
* Remove unnecessary toString()
* Combine return into one statement
* Move string literal to LHS
Issue-ID: POLICY-482
Change-Id: Id196728d92dda7fab7e83d6eea07633c5be37f7c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master a6b8bc8875402ab721a8529926d01b2565d0f595
Addressing Technical Debt for POLICY-SDK-APP
* Using booleans true and false
* Using already predefined static strings
* Adding private constructors to hide implicit
* Adding empty constructor comment to satisfy SONAR
* Using single quotes for indexOf to use faster method
* Preferred use of .isEmpty()
* Ordering of public static synchronized syntax
* Removing commented out code
* Using an already defined constant
* Unnecessary declaration of runtime exceptions
* Unnecessary casts
* Unused variables and imports
* Unnecessary use of toString()
* Just using return vs storing into a local var and returning that
* Extra semicolons
Issue-ID: POLICY-482
Change-Id: I6b9dcc5211dd52895a8787239b9df3059928fa45
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Project: policy/engine master 7a2924a2209bce7b0c578b67fd2310d12ccdb1f7
Resolved the Critical issue reported by Sonar
Issue-ID: POLICY-521
Change-Id: I2a7072076a1ed0924bfeacd6f3d2b6a910f30338
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Project: policy/engine master 74552f84f136c01a99488aeff6d0f7b9a55d5fb3
Resolved Security Vulnerability issues
Issue-ID: POLICY-553
Change-Id: I3e0e6a31226e561cef9ec578790659d57b2f65f4
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Project: policy/engine master 528605fe8efa3631291de0b9bf8e498bdbd0c23f
Merge "Restrict file upload size in policy editor"
Restrict file upload size in policy editor
Restrict file upload size in Policy Editory using a configurable value (in
bytes) set in xacml.admin.properties. Default value is 30MB.
Issue-ID: POLICY-538
Change-Id: I4d8539ab33320446aed250ea4fdc51de585d5f2a
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
|
|
Project: policy/engine master 49c6b1bf604c3450b729dc348af36ee3af79589b
PDPGroup Audit Fix
*This fix will add new group to GroupEntity table if no default exists
during initialization and therefore provides a permanent solution to the
initialization errors on the PAP
Change-Id: Ie394d76b9cbc02cad15d62d6adea6fc17938f734
Issue-ID: POLICY-486
Signed-off-by: Michael Mokry <mm117s@att.com>
(cherry picked from commit 676d7d8dc9985e93d7c9cbc0412a26f2b19c23cd)
|
|
Project: policy/engine master c7ebb39ee23233b0104d3a0f9b1f8fdd66911d18
Merge "Local and Class variable name conflict resolved"
Local and Class variable name conflict resolved
*Renamed the local variable to othername
Change-Id: I5f1e1b8b9140acf73de241f78b0437dc9e5805b5
Issue-ID: POLICY-336
Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
|
|
Project: policy/engine master 6d3cc4662712bb636b83f8a4da9938afe192a64a
Merge "Fixed as per Java Code Conventions"
Fixed as per Java Code Conventions
*Moved the constructors after the variables
Change-Id: I099f75aea285f0bb845d464065d1e5f031d44a13
Issue-ID: POLICY-336
Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
|
|
Project: policy/engine master fb3cc27605623672fb8971bd9030872f117c7af8
Merge "Sonar cleanup for PolicyEngineUtils"
Sonar cleanup for PolicyEngineUtils
Changes to resolve some sonar "major" issues in the PolicyEngineUtils
module.
Patch 2: Updated the NotificationStoreTest junit to account for the return
of a "Collections.emptyList()" rather than "null" in StdPDPNotification
class.
Patch 3: Updated the StdPDPNotificationTest junit to account for the
return of a "Collections.emptyList()" rather than "null" in
StdPDPNotifaction class.
Issue-ID: POLICY-474
Change-Id: I925774ac181fd38d1206637f47ab27ba499629ef
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
|
|
Project: policy/engine master cedb4478c6ff50a61dc1d1b445d39401606061b5
Removed useless parentheses
*Removed those useless parentheses
Change-Id: I19e9e027182dfd7dc2211d71fbb4acd8bf6b8be5
Issue-ID: POLICY-336
Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
|