summaryrefslogtreecommitdiffstats
path: root/docs/submodules/policy/apex-pdp.git
AgeCommit message (Collapse)AuthorFilesLines
2019-03-14Update git submodulesJorge Hernandez1-0/+0
* Update docs/submodules/policy/apex-pdp.git from branch 'master' to a9c0c4b8343414621f298098cf5746bf2a910a93 - Merge "reduce too many method param" - reduce too many method param Issue-ID: POLICY-1535 Change-Id: Ia6f699d315ebd214257dc64d559a0ac4685307f5 Signed-off-by: arind.mondal <arind.mondal@samsung.com>
2019-03-11Update git submodulesParshad Patel1-0/+0
* Update docs/submodules/policy/apex-pdp.git from branch 'master' to 88f2318a04c7769a4dabec9b2adb5291117166ed - Fix sonar code smell issues in apex-pdp Fix method has more than 7 parameters issues Issue-ID: POLICY-1535 Change-Id: I12d995e323bbdbe3762c903fcb116dfe81bf7b54 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-03-08Update git submodulesLiam Fallon1-0/+0
* Update docs/submodules/policy/apex-pdp.git from branch 'master' to d0870f118020464467dd34a980445792a30127d4 - Merge "Increase test coverage for plugins-event-carrier" - Increase test coverage for plugins-event-carrier Add basic JUnit test cases for plugins-event-carrier-restserver Issue-ID: POLICY-1513 Change-Id: I36e41bd05be71c44eb9e94350f4614437b0d205b Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-03-07Update git submodulesJorge Hernandez1-0/+0
* Update docs/submodules/policy/apex-pdp.git from branch 'master' to efd0a257cf6a81a62ec18962eae1d5c1cf87bcda - Merge "Increase test coverage for plugins-executor-js" - Increase test coverage for plugins-executor-js Add junit test cases into apex-pdp/plugins/plugins-executor-javascript Issue-ID: POLICY-1523 Change-Id: Ie8017be2f7507fdb641a4020e13152c656cadf04 Signed-off-by: Hengye <yehui.wang@est.tech>
2019-03-06Update git submodulesLiam Fallon1-0/+0
* Update docs/submodules/policy/apex-pdp.git from branch 'master' to 251785c1bbb3beedd4f3ed7607a552de38638c88 - Merge "Increase test coverage for plugins-event" - Increase test coverage for plugins-event Add JUnit test cases for plugins-event-carrier-websocket Issue-ID: POLICY-1513 Change-Id: I5f2a8dacfff4c14cf4a24e9258b5a551cecc1489 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-03-01Update git submodulesPamela Dragosh1-0/+0
* Update docs/submodules/policy/apex-pdp.git from branch 'master' to f0872b20425c66adeb14487c8f9e1c79f6bd3ddf - Merge "Increase test coverage for plugins-executor-mvel" - Increase test coverage for plugins-executor-mvel Add junit test cases into apex-pdp/plugins/plugins-executor-mvel Issue-ID: POLICY-1523 Change-Id: I74d47974a326c7fbd53a0b7d88262ef1dbd54c8c Signed-off-by: Hengye <yehui.wang@est.tech>
2019-03-01Update git submodulesPamela Dragosh1-0/+0
* Update docs/submodules/policy/apex-pdp.git from branch 'master' to 160487052809f33461aae8c29f085dfee316ba2e - Merge "Increase test coverage for plugins-executor-jruby" - Increase test coverage for plugins-executor-jruby Add junit test cases into apex-pdp/plugins/plugins-executor-jruby Issue-ID: POLICY-1523 Change-Id: I2ed06a69cf991d744aa5c4c69f605fdf1dca6524 Signed-off-by: shaoqiu <tim.huang@est.tech>
2019-03-01Update git submodulesPamela Dragosh1-0/+0
* Update docs/submodules/policy/apex-pdp.git from branch 'master' to f01b09965093e027323b320601d5d5566c0d3825 - Merge "Use Alpine as base docker image" - Use Alpine as base docker image change docker base image from ubuntu 16.04 to Alpine 3.9 Issue-ID: POLICY-1555 Change-Id: Ia21f5e8185bd26f4b04276eed204ac358f655a59 Signed-off-by: Hengye <yehui.wang@est.tech>
2019-02-28Update git submodulesPamela Dragosh1-0/+0
* Update docs/submodules/policy/apex-pdp.git from branch 'master' to ee74a146a62de39228a2f7128c00c419d1102792 - Merge "Increase test coverage for plugins-executor-jython" - Increase test coverage for plugins-executor-jython Add junit test cases into apex-pdp/plugins/plugins-executor-jython Issue-ID: POLICY-1523 Change-Id: I2545a9cefc6b4b9a53200b98081ddd8bc8274b40 Signed-off-by: ning.xi <ning.xi@est.tech>
2019-02-28Update git submodulesJorge Hernandez1-0/+0
* Update docs/submodules/policy/apex-pdp.git from branch 'master' to 50f6a666c5072c94fd5741415096ebe5ffe453dc - Merge "Fix checkstyle problems on sonar fix" - Fix checkstyle problems on sonar fix A sonar fix brought in some minor checkstyle issues. This review fixes those. Issue-ID: POLICY-1535 Change-Id: I4f9d66ffc0a4fcc8901d7e18bfb21a1d1cf135b7 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-02-28Update git submodulesLiam Fallon1-0/+0
* Update docs/submodules/policy/apex-pdp.git from branch 'master' to 605003e9938f38ca7dfdda3d637daf2e9ccc67e2 - Merge "Update INFO.yaml Liam's email" - Update INFO.yaml Liam's email est.tech Issue-ID: POLICY-1556 Change-Id: I1088e64016a15161ec979bf8de1af35835fa3c83 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-02-27Update git submodulesJorge Hernandez1-0/+0
* Update docs/submodules/policy/apex-pdp.git from branch 'master' to 3bbf5d0d753fa4ac55c9e5a31ae450a5bcfc6a28 - Merge "Fix sonar code smell" - Fix sonar code smell Issue-ID: POLICY-1523 Change-Id: I24f9fe5811bb93597efe79c98572c5249e74026c Signed-off-by: arindamm <arind.mondal@samsung.com>
2019-02-26Update git submodulesJorge Hernandez1-0/+0
* Update docs/submodules/policy/apex-pdp.git from branch 'master' to 94db579b98a2432fe592d09be9c96fd82ab63ad3 - Merge "Increase test coverage for plugins-event" - Increase test coverage for plugins-event Add basic JUnit test cases for plugins-event-carrier-jms Issue-ID: POLICY-1513 Change-Id: I68fa36bc988745108014f47a57fc02bc2ceed0c7 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-02-25Update git submodulesPamela Dragosh1-0/+0
* Update docs/submodules/policy/apex-pdp.git from branch 'master' to 44e82485ceb9845280a6a2115dd1c0c59a6037c1 - Merge "sonar:reduce number of method param" - sonar:reduce number of method param Changes done according to sonar recommendation. Issue-ID: POLICY-1535 Change-Id: I57a608e4db1b67959cbabe23e7fe0b1aa91e30cd Signed-off-by: arind.mondal <arind.mondal@samsung.com>
2019-02-25Update git submodulesliamfallon1-0/+0
* Update docs/submodules/policy/apex-pdp.git from branch 'master' to 085fed0cc5b2aca4bd4af81c7ccd5ad4d3aa5a10 - Fix checkstyle errors on tests Issue-ID: POLICY-1513 Change-Id: Id61df043adf398a0493916f6116ff5858c60fb29 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-02-22Update git submodulesliamfallon1-0/+0
* Update docs/submodules/policy/apex-pdp.git from branch 'master' to 1ba6a3268b220cc99e9ed993553fa6f34f111a39 - Change versions of Zookeeper and C3P0 This review changes the versions of Zookeeper and C3P0 to resolve security issues. It also merges the context test utils module into the context test because that module was misplaced and put an incompatible Zookeeper dependency in the APEX context module. Issue-ID: POLICY-1540 Change-Id: I86048ae1fc8b818611f423d6fd1f4a9fcc3f76f9 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-02-21Update git submodulesHengye1-0/+0
* Update docs/submodules/policy/apex-pdp.git from branch 'master' to 53d016bd95ded26821a7711c6f049ffc4ccd51ca - correct a typo in doc APEX User Manual Issue-ID: POLICY-1523 Change-Id: I44675a5119170ab724926ba08a3bfceefda31b57 Signed-off-by: Hengye <yehui.wang@est.tech>
2019-02-20Update git submodulesParshad Patel1-0/+0
* Update docs/submodules/policy/apex-pdp.git from branch 'master' to 5a9a4c2149faa101915cd9c8912ac6627f1120a4 - Increase test coverage for apex-pdp/plugins Add basic JUnit test cases for plugins-event-carrier-kafka Issue-ID: POLICY-1513 Change-Id: I009547115705496a850a9609416cdf71f52fb936 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-02-05Update git submodulesliamfallon1-0/+0
* Update docs/submodules/policy/apex-pdp.git from branch 'master' to 05df038e0b09bfd5f0c9bfc1e8aa10f9c97f39a4 - Fix bug with Apex rejecting HTTP 2xx responses APEX rejects all HTTP responses except 200. This change accepts any HTTP 2xx response code as a valid response. Issue-ID: POLICY-1289 Change-Id: Ief681ba4dac1ef3ff5f257dd931569bd2274d017 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-01-18Updated git submodulesramverma1-0/+0
Project: policy/apex-pdp master aacfb4ca7da6a76282c5703049fb7b52f65a36a8 Fix version warning in apex pom Change-Id: Ia3b7fa204fb8564b679a4416fcc0f70fa0a9a54f Issue-ID: POLICY-1074 Signed-off-by: ramverma <ram.krishna.verma@est.tech>
2019-01-15Updated git submodulesliamfallon1-0/+0
Project: policy/apex-pdp master 2d948a9099e2b000cc061fb77dc0502c5d721ac9 Fix crashing unit tests in Apex Issue-ID: POLICY-1403 Change-Id: Ie9d2cc46f3daf4d6b2eb2774a8be8c35e0c45754 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-01-15Updated git submodulesliamfallon1-0/+0
Project: policy/apex-pdp master cd7fbbcec7e864d2bfd33ac32fe046e827d93468 Update comment to check Sonar build issue Issue-ID: POLICY-1403 Change-Id: I87ebf85dbbe8544e38666e8e793a8e1cbbcfc7c6 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-01-11Updated git submodulesliamfallon1-0/+0
Project: policy/apex-pdp master 2e30d8c1127757d6557f142ff0288fb65412bf7a Use parent version of Eclipselink Issue-ID: POLICY-1360 Change-Id: I33d8cef3f5d273c0c2a93ecda321205316aea6de Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-01-09Updated git submodulesliamfallon1-0/+0
Project: policy/apex-pdp master cff079a8dc3eeaf4e88c0e89a828fe4244a1b3c8 Fix context clearing on model upgrade Existing context is cleared when a model upgrade is carried out on an Apex PDP. The clear() method is called in error on the Apex engine during the upgrade. This change also has some small updates to the DecisionMaker example, which is used to test this feature. Issue-ID: POLICY-1395 Change-Id: I547a3a60712d1572d9daadf5eab4afcae2a5c321 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-31Updated git submodulesParshad Patel1-0/+0
Project: policy/apex-pdp master 8f142981c3f5fddfd58c2e106ead7b4f5fc93da0 Rename test classes in apex-pdp/services Make test classes name consitence by adding 'Test' at end of junit test classes and adding 'Support' or 'Dummy' at start of util or dummy type of test classes Issue-ID: POLICY-1263 Change-Id: I951f4e30736144010d69a0fb3b9181f7fee76013 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-12-21Updated git submodulesLiam Fallon1-0/+0
Project: policy/apex-pdp master a3322831cd5efec598613e8335931944db222e9f Merge "Rename test classes in apex-pdp/model,core" Rename test classes in apex-pdp/model,core Make test classes name consitence by adding 'Test' at end of junit test classes and adding 'Support' or 'Dummy' at start of util or dummy type of test classes Issue-ID: POLICY-1263 Change-Id: I6cb8d09799d7abd1b50ead1edbc4986649ad4ba7 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-12-20Updated git submodulesJorge Hernandez1-0/+0
Project: policy/apex-pdp master 89817bf276d95091098dbd7ae9cb357ea4a38836 Merge "Add SSL keystore/truststore to Apex package" Add SSL keystore/truststore to Apex package Issue-ID: POLICY-1222 Change-Id: I4409b88d1a9439492f9aac6c3b971bae7dc04b19 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-20Updated git submodulesliamfallon1-0/+0
Project: policy/apex-pdp master 1dff5ebe27cbe79de8f9d798e256d41ecccdaa8c Add example policy for HTTPS Added an example of how to configure HTTPS for an Apex policy. Issue-ID: POLICY-1222 Change-Id: Iea8a8accac32f6d25c64a8324e202ad5e6221c7a Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-19Updated git submodulesJorge Hernandez1-0/+0
Project: policy/apex-pdp master b70b381538d2c6fca65530538b36c8f8fdebd104 Merge "Add Java property parameters for HTTPS" Add Java property parameters for HTTPS Issue-ID: POLICY-1222 Change-Id: I4a683cf2f52e7f1d28164954f84d0744b5ca7e9c Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-18Updated git submodulesliamfallon1-0/+0
Project: policy/apex-pdp master fabd8bd3d510fd8f0af13d51c2fa97a778a3375a Remove unused @throws warnings Previous checkstyle fixes rationalised the exceptions thrown by methods, however the javadoc comments were not updated. This review updates them. Issue-ID: POLICY-1263 Change-Id: I2746f30e76018ec4d0f1e74a6a415979b7874329 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-17Updated git submodulesliamfallon1-0/+0
Project: policy/apex-pdp master 8e8f3458646ec97d058d7322917f56021de2dc7f Fix sonar test renaming issues Renaming tests introduced Sonar issues: - Tests where coverage was <80% flagged as they are new code - Support test classes with names ending in "Test" flagged becasue they did not contain test cases Issue-ID: POLICY-1263 Change-Id: I17a4b27b2952a4978fab1c76579a013478b60ae1 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-13Updated git submodulesliamfallon1-0/+0
Project: policy/apex-pdp master 4b01ae1ca8bc592fbbbc4d5408d6c645487811dd Add period after inheritDoc Issue-ID: POLICY-1074 Change-Id: I88dc888b2a374b38499241f578a36dd116e2b85b Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-11Updated git submodulesPamela Dragosh1-0/+0
Project: policy/apex-pdp master 44bd7f187f704712b057b5870819b32e72bfd8e0 Merge "Remove unused parameter from test data" Remove unused parameter from test data The "restRequestTimeout" parameter is not used in the current version of Apex, it was replaced by the "requestorTimeout" paramter. However, the parameter remained in the JSON data files. Also updated to improve output of messages during unit test. This review also sets the Jersey injection dependendy scope to "test" Issue-ID: POLICY-1074 Change-Id: I75f495f571c8101310bd1eaec01a305318346cd9 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-11Updated git submodulesJorge Hernandez1-0/+0
Project: policy/apex-pdp master 36ac8e1434a2747d8cb410557cf5fcabcfae3901 Merge "Support HTTP headers in REST Client" Support HTTP headers in REST Client Fixed REST client plugin to supprot HTTP headers and add unit test to plugin. Change-Id: I6a71ab7f83ed2126b8600bb5e586f971dbdacdc0 Issue-ID: POLICY-1222 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-11Updated git submodulesliamfallon1-0/+0
Project: policy/apex-pdp master 92dd84cb28d341e9fff892adb4b616b8b795be91 Fix checkstyle issues Some minor line length and formatting checkstyle warnings fixed. Change-Id: Ib92069bbdb444560083e6d0dbf5d16a3ab824d82 Issue-ID: POLICY-1074 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-06Updated git submodulesPamela Dragosh1-0/+0
Project: policy/apex-pdp master e6753352980648bac92aff9a7295639349ea1295 Merge "Fix bugs in context flushing" Fix bugs in context flushing The context flushing support in the context distributor can throw a concurrent exception when a lot of context is active and a flush takes place. This fix introduces proper synchronized access to the album maps. In addition, there was an incorrect cast in the call to the persist() method of the persistor. Change-Id: I6594ffed83a0b34251a0c5c7893d4abb17437fd4 Issue-ID: POLICY-1380 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-06Updated git submodulesJorge Hernandez1-0/+0
Project: policy/apex-pdp master cbf3ade089e2cb866758efcb5fb9a3027b331700 Merge "Support HTTP headers in REST Requestor" Support HTTP headers in REST Requestor Change-Id: Iea4211e7d3324f5ea6244f45c91241a4067d8d33 Issue-ID: POLICY-1222 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-04Updated git submodulesliamfallon1-0/+0
Project: policy/apex-pdp master 259039fa91e3038c41f4a322d81e7ea07a78b96e Add unit test for Java executor Code coverage in the Apex-PDP plugins is very low. JUnit coverage will be increased for the Plugins over the Dublin design timeline. Issue-ID: POLICY-1379 Change-Id: Ie70ab5a9be650818cb330ec5be2a89a5db6153c5 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-03Updated git submodulesJorge Hernandez1-0/+0
Project: policy/apex-pdp master dc2e6900325c0e69e7efb0346602d29ee634fbea Merge "Fix checkstyle/sonar issues" Fix checkstyle/sonar issues Remove unused imports Add @FunctionalInterface annotation Reduce the complexity of some methods Change-Id: If519c31b113233361fbb935121fe6494263ac957 Issue-ID: POLICY-1074 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-03Updated git submodulesPamela Dragosh1-0/+0
Project: policy/apex-pdp master a3532f2fd160f1751162d27caae65414afa9c30c Merge "Rename test classes in apex-pdp" Rename test classes in apex-pdp Make test classes name consitence by adding 'Support' or 'Dummy' at start of util or dummy type of test classes Issue-ID: POLICY-1263 Change-Id: I1dc1a7f174660a90664ebdcff2ea79ed30aa465c Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-12-03Updated git submodulesliamfallon1-0/+0
Project: policy/apex-pdp master 457f041685a3a404a58a9f934282c76eba35ad81 Use Parent Eclipselink Issue-ID: POLICY-1360 Change-Id: I99a9e7bf60590fd0da5d7ba001e8ab322623fee6 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-11-29Updated git submodulesJorge Hernandez1-0/+0
Project: policy/apex-pdp master fb7c89ebe2e682170b09275a5e531d0a49d70ada Merge "Fixing issues in apex documents" Fixing issues in apex documents Change-Id: Ibc07c20fa8ac1018443a3c061613fdaecc5efb83 Issue-ID: POLICY-1280 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-11-29Updated git submodulesPamela Dragosh1-0/+0
Project: policy/apex-pdp master 9f637618ce0b5a4c893e2b6973096b52c6e564b7 Merge "Rename test classes in apex-pdp/model/basic-model" Rename test classes in apex-pdp/model/basic-model Make test classes name consitence by adding 'Support' or 'Dummy' at start of util or dummy type of test classes Issue-ID: POLICY-1263 Change-Id: Ia90e0ea73af16f6cde37692e98f1c4afc408dd2b Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-11-26Updated git submodulesJorge Hernandez1-0/+0
Project: policy/apex-pdp master 80540def7348e195ffacfbbc7c23e2e68e154965 Merge "Fix sonar issue cli codegen" Fix sonar issue cli codegen Modify CodeGeneratorCliEditor to use param object for sonar issue fix Add javadoc for the method addEventDecl Method. Modify meth declaration. Run formatter Issue-ID: POLICY-1251 Change-Id: I4f95e868c047f54dff9cf991e8f4f60e8954c788 Signed-off-by: kris.jinka <kris.jinka@samsung.com>
2018-11-25Updated git submodulesPamela Dragosh1-0/+0
Project: policy/apex-pdp master 3688d3901ad241be26671e520da0e01e4c8089c0 Create label for architecture to ref Creating a label so other documentation in the architecture section can reference this PDP engine documentation. Issue-ID: POLICY-1163 Change-Id: Ida9caba405e36675f65843b1d49e79175634fa02 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-11-21Updated git submodulesliamfallon1-0/+0
Project: policy/apex-pdp master 1f7c861c65aa8689f11196581b8ca5e79d7e4e26 Refactor Apex benchmark tests Apex performance tests are refactored and reorganised to be all in the one place and to be coherent. A test REST server that can generate events in batches is introduced and this can be configured to respond to REST calls from Apex with various batch sizes that can be varied for performance tests. Actual performance tests are added for the various executors in Apex. Change-Id: I692b41e1e4451e821a618c64dead5cc8e9685d08 Issue-ID: POLICY-812 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-11-20Updated git submodulesParshad Patel1-0/+0
Project: policy/apex-pdp master e8b197315437cac84872752e2ea090d8fb233941 Rename test classes in apex-pdp Make test classes name consistence under auth, model, plugins, testsuits, tools projects Issue-ID: POLICY-1263 Change-Id: I49ec9a9f5b457d6381e693de2c04ec0268ad1b02 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-11-19Updated git submodulesParshad Patel1-0/+0
Project: policy/apex-pdp master 62475a30ef2d425fe04df35ef2dac53c7ab5306a Rename test classes in apex-pdp Make test classes name consistence by putting 'Test' at end Issue-ID: POLICY-1263 Change-Id: I0179388d84826e698276a1995dd8173a40b5fd2b Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-11-16Updated git submodulesliamfallon1-0/+0
Project: policy/apex-pdp master da727fa247fd97a9dc5cbf010210a6dbc307bba9 Fix timing and move tests The timings on the REST test are too short and time out on ONAP Jenkins The tests of the Apex service and Apex model upgrade are not benchmark tests so are moved to Integration. Issue-ID: POLICY-1251 Change-Id: I2672d01042b33fe0cce5223005295e3b1aa26e7a Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-11-15Updated git submodulesliamfallon1-0/+0
Project: policy/apex-pdp master 96b3da652c35313d9c18b689f5606d8d7f153fe3 Fix checkstyle warnings in AxState/Codegen Recent checkins introduced some very minor checkstyle warnings, this review fixes those. Change-Id: Ie7784ad22a748017e1647be0e23dc9d3fe100cf0 Issue-ID: POLICY-1251 Signed-off-by: liamfallon <liam.fallon@ericsson.com>