summaryrefslogtreecommitdiffstats
path: root/docs/submodules/optf
AgeCommit message (Collapse)AuthorFilesLines
2018-03-29Updated git submodulesSastry Isukapalli1-0/+0
Project: optf/osdf master a3454501ed37a571cf83ab1fc4e8daeaff230220 Bring osdfapp into foreground Issue-ID: OPTFRA-22 Change-Id: I0fb409460bd9a0e7a4485298865a29279b376e68 Signed-off-by: Sastry Isukapalli <sastry@research.att.com>
2018-03-29Updated git submodulesAnkitkumar Patel1-0/+0
Project: optf/osdf master 616d7ba3006001bc53c668e5a34ae943855c2295 Added optimization query processing module. Added optimization query processing module. Issue-ID: OPTFRA-177 Change-Id: I4dd395b77bfe4bc392b90bc7087338f050fa622d Signed-off-by: Ankitkumar Patel <ankit@research.att.com>
2018-03-29Updated git submodulesSastry Isukapalli1-0/+0
Project: optf/osdf master ab7a87456538e561d60d209fe534c175ddd0269c Functest scripts, simulators, and payloads osdf/adapters/policy/utils.py: Removed duplicated code (group_policies and group_policies_gen are very similar, and group_policies seems to be not used osdf/optimizers/placementopt/conductor/api_builder.py: changed param name from "grouped_policies" to "flat_policies" tox.ini added starup and shutdown of simulators (flask app with mock payloads) in tox tests rest all files/changes in "test/" folder quite a few payload files Patch set 2: removed a "print()" statement from simulator code Issue-ID: OPTFRA-22 Change-Id: I0006c577fc459c7c884b55e8316c689afd151780 Signed-off-by: Sastry Isukapalli <sastry@research.att.com>
2018-03-28Updated git submodulesShankaranarayanan Puzhavakath Narayanan1-0/+0
Project: optf/has master e8443b794814c9d73f8a7baacf5a41f648f49635 Merge "HPA flavor matching code" HPA flavor matching code Code to match flavors available in candidate with required features for a VM Change-Id: Ibcb5faa8213b52607fcbb0446680da3173ff5748 Issue-ID: OPTFRA-180 Signed-off-by: Ritu Sood <ritu.sood@intel.com>
2018-03-28Updated git submodulesDileep Ranganathan1-0/+0
Project: optf/has master 19b159d57e21b25c2d3eb7b70a371288371c4395 Fixed HPA attribute translation validation Fixed HPA Feature Atrribute parameters validation in translation Change-Id: I2dc0c65826e07d26d49f142042e848f66f0176e8 Issue-ID: OPTFRA-168 Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
2018-03-28Updated git submodulesDileep Ranganathan1-0/+0
Project: optf/has master 0bb996194e6b2c462be39efb12f9f8b1f18f15eb Fixing the HPA parameters from Homing Template Fixed the label to flavorLabel Fixed the features to flavorProperties Change-Id: I157afbf5969e9434c29de21c6041e9ede7b511af Issue-ID: OPTFRA-170 Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
2018-03-28Updated git submodulesYing Ruoyu1-0/+0
Project: optf/has master 04bf647bc948fed77d2574e0f97ffbab5f857522 HPA Enablement for controller Translator Module Add support for HPA constraints translation Add unit tests for HPA constraints validation Updated with mandatory and score parameters Updated flavorLabel and flavorProperties instead of label and features Change-Id: Iec8fff2ad71f8ebeb58ef807d8d2b95ed3635ec1 Issue-ID: OPTFRA-168 Signed-off-by: Ying Ruoyu <ruoyu.ying@intel.com>
2018-03-28Updated git submodulesAnkitkumar Patel1-0/+0
Project: optf/osdf master ad29f38cbcb164a7f328b26daf789dbff90deb98 Update the SO sync and async responses. Updated the sync and async responses and addes testcases related to policy adaptors. Issue-ID: OPTFRA-208 Change-Id: Ia0f88df1b897b6158674f3c3a7ef239f2328dcfc Signed-off-by: Ankitkumar Patel <ankit@research.att.com>
2018-03-28Updated git submodulesDileep Ranganathan1-0/+0
Project: optf/has master 39f63ef31ba3f0dc0db3ee8d5ff502a715702e1a Multicloud vim controller plugin Implemented Multicloud vim controller plugin Updated translator to parse vim_fit constraint Implemented vim_fit constraint type Implemented RPC for check_vim_capacity Reordered constraint rank Added unit tests Change-Id: I5f01cf8fbefbb4b53e4370c5c6b43f72897e62bd Issue-ID: OPTFRA-148 Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
2018-03-28Updated git submodulesSastry Isukapalli1-0/+0
Project: optf/osdf master cf5fe0f8b49f6f354a77fb28b56465a2e18e820d Adding an autostart in Docker Issue-ID: OPTFRA-22 Change-Id: I6b5e072d48d312e86cd681908e62b71059774093 Signed-off-by: Sastry Isukapalli <sastry@research.att.com>
2018-03-28Updated git submodulesAnkitkumar Patel1-0/+0
Project: optf/osdf master a79d2cdd881bbafaf672b20ec540ee1c34ddfb3a SO response build module updated SO response build module is updated based on the HAS API. Issue-ID: OPTFRA-208 Change-Id: I57ed198967d2dc9a58f1221eb57fda56fcb5fd2d Signed-off-by: Ankitkumar Patel <ankit@research.att.com>
2018-03-27Updated git submodulesDileep Ranganathan1-0/+0
Project: optf/has master 1ad66ccc583b778b9b1aef8aefb4b13362f6045f Fixed oslo.config dependency Change-Id: I725aa29918f4d30b9977413629f4bc71a3513893 Issue-ID: OPTFRA-2 Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
2018-03-27Updated git submodulesAnkitkumar Patel1-0/+0
Project: optf/osdf master ca43ea7c87abbcaa71617de50598449ff5ff007c Updated the conductor adaptor Updated the conductor adaptor code. Issue-ID: OPTFRA-207 Change-Id: I41bd6f2e39bc5ca6d2d27539772175363590416f Signed-off-by: Ankitkumar Patel <ankit@research.att.com>
2018-03-27Updated git submodulesSastry Isukapalli1-0/+0
Project: optf/osdf master a775ec8b904a0ea7ed863726ffe7f7d9b363d47a Merge "Updates to address new HPA policies" Updates to address new HPA policies Issue-ID: OPTFRA-100 Change-Id: Iaff7b50dc5394546cc46591bef9b054cd6cde792 Signed-off-by: Ankitkumar Patel <ankit@research.att.com>
2018-03-27Updated git submodulesDileep Ranganathan1-0/+0
Project: optf/has master 784505a1ff2aa94fab7c2eb8c754fcba8b6049a7 Implemented match all operator for HPA Implemented match all operator for list inputs. For eg: InstructionSetExetensions which checks for a input set of requirements in the available capability list. Change-Id: I3784ae2f85309236f790a0d6a5927ab3ec535b97 Issue-ID: OPTFRA-181 Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
2018-03-27Updated git submodulesDileep Ranganathan1-0/+0
Project: optf/has master f559ed62d76b90c28c874c2efee7c9bbb67bba87 Add Postman collection for HPA Added postman scripts for Conductor, MUSIC and A&AI Added postman Multicloud mock server and check_vim_capacity API Change-Id: If8ae4d10a0bcc640d7f54e14a20b777867692ad9 Issue-ID: OPTFRA-169 Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
2018-03-27Updated git submodulesDileep Ranganathan1-0/+0
Project: optf/has master fbafa4fc9aa5a130870ce0cacaba90a9384303b4 Add flavor label mapping to Homing response Added flavors to the recommendation JSON response from HAS Change-Id: I7f993dba59d7a07866a2383567c75efe960e601a Issue-ID: OPTFRA-182 Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
2018-03-27Updated git submodulesDileep Ranganathan1-0/+0
Project: optf/has master 3437fc2b299bf73a525bbb30e9241af14c62bd57 Data Service RPC for HPA Implemented RPC for get candidate list with hpa flavor mapping Added unit tests for get_candidates_with_hpa Issue-ID: OPTFRA-183 Change-Id: I9db74499ba964341368542b339163c3803e0924e Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
2018-03-27Updated git submodulesDileep Ranganathan1-0/+0
Project: optf/has master ac91747b8819d23fd2e56d9e1dd170b83498a2bf HPA Constraint solver plugin Implement hpa constraint plugin and implement solve method Initialize HPA constraint per solver request Reordered constraint ranking Implemented RPC invocation to data plugin for matching hpa Change-Id: I5d63464b6bff6abc10599e000b2b56f926f146f9 Issue-ID: OPTFRA-178 Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
2018-03-26Updated git submodulesSastry Isukapalli1-0/+0
Project: optf/osdf master 477092abdb41449158538dfd49d8cd25c5c8e42a Remove code smell from DMaaP adapter Issue-ID: OPTFRA-195 Change-Id: I67f2f5c6f9190bb91f34b371c0bc3ea1aa2367b0 Signed-off-by: Sastry Isukapalli <sastry@research.att.com>
2018-03-26Updated git submodulesAnkitkumar Patel1-0/+0
Project: optf/osdf master 4de3bb8c9f62f15d6aeb965f9d4c47edb7efd2e9 Updated the schematics models of the HAS API Updated the validation models and related testcases. Issue-ID: OPTFRA-203 Change-Id: I02219e64543eb7a9a7933322bf19f21e070496f4 Signed-off-by: Ankitkumar Patel <ankit@research.att.com>
2018-03-26Updated git submodulesSastry Isukapalli1-0/+0
Project: optf/osdf master 215b19360f73242f2348c812c0afab7d77c083a8 Merge "Inserted policy tosca models and examples" Inserted policy tosca models and examples Uploaded the policy tosca models and policy examples for HAS. Issue-ID: OPTFRA-27 Change-Id: I96ae70c5fe34ce7f40f461801e149d81afa52ea3 Signed-off-by: Ankitkumar Patel <ankit@research.att.com>
2018-03-26Updated git submodulesDileep Ranganathan1-0/+0
Project: optf/osdf master 1989be6667eeb3b70e959c688c6b423b30dde78a Adding the missing healthcheck Adding the missing healthcheck from previous commit. Change-Id: I443dff8a22ea641bcbdfc4e8aa73ba5557d3259f Issue-ID: OPTFRA-22 Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
2018-03-26Updated git submodulesAnkitkumar Patel1-0/+0
Project: optf/osdf master bc1d288ac29c3c9bf968cea5ac2d95b8bcd67eae Update the policy adaptor and related testcases Generalized the policy adaptor code by removing homing specific logic. Issue-ID: OPTFRA-27 Change-Id: I331030a2f3f5c0c17af1a72af9794131555a9217 Signed-off-by: Ankitkumar Patel <ankit@research.att.com>
2018-03-25Updated git submodulesramkri1231-0/+0
Project: optf/osdf master ed70b5c6d6589e4e1ce80229612ea5b680736c4c added healthcheck Issue-ID: OPTFRA-22 Change-Id: I783a597b81abd0027819fff0c103250e1e003c10 Signed-off-by: ramkri123 <ramkri123@gmail.com>
2018-03-25Updated git submodulesramkri1231-0/+0
Project: optf/osdf master 5f91345fbb9cf6a9c55a0bdc70156af02fcf9b02 fixing docker image tag Issue-ID: OPTFRA-22 Change-Id: Iacd81643a3a317171aaa3af8e78b2c6a33c52348 Signed-off-by: ramkri123 <ramkri123@gmail.com>
2018-03-25Updated git submodulesramkri1231-0/+0
Project: optf/osdf master d3e7cabfd2ec2a77145b65e4d1fe6b378345adb9 fixing name of staging image Issue-ID: OPTFRA-22 Change-Id: Iea233cbebc5b277ee23e7e52edce3778a23308a0 Signed-off-by: ramkri123 <ramkri123@gmail.com>
2018-03-24Updated git submodulesSastry Isukapalli1-0/+0
Project: optf/osdf master 53b90c3fc5d8a187b1a35992b039a8291a321fc4 Fix bug in docker build script Fixed a spurios typo in date command Issue-ID: OPTFRA-22 Change-Id: I4a9b02f52d07bba2091b95ab201c9fc0b252f971 Signed-off-by: Sastry Isukapalli <sastry@research.att.com>
2018-03-24Updated git submodulesShankaranarayanan Puzhavakath Narayanan1-0/+0
Project: optf/has master 1c4a9f7f0d7ca61df2f0955f60aea9670e399d45 Merge "Fix Exception in resolve_demands RPC" Fix Exception in resolve_demands RPC 'keyspace' is missing in the context parameter passed to the resolve_demands rpc from translator Change-Id: Ic9a3a11232ec558daa89890f904b4ee485ad3c50 Issue-ID: OPTFRA-198 Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
2018-03-23Updated git submodulesShankaranarayanan Puzhavakath Narayanan1-0/+0
Project: optf/has master 743b0cafc7a2ebc174c21e272ff017d8f4d8a801 Merge "Accommodate Changes for Music 2.4.x" Accommodate Changes for Music 2.4.x Issue-ID: OPTFRA-199 Change-Id: Ieadb1ae38621cd406af384458a9fce6ffdd15f0c Signed-off-by: Ikram Ikramullah <ikram@research.att.com>
2018-03-23Updated git submodulesDileep Ranganathan1-0/+0
Project: optf/has master d8a3bd9ae9c72947b53df661c57f8dd697ef73dc HPA Enablement for A&AI data plugin Implemented HPA Enablement feature support for A&AI data plugin Added flavors and hpa-capability child nodes to cloud-region cache. Added unit tests for _get_flavors Modified unit tests for resolve_demands Change-Id: Ifeedb5f53a351079e8adbd42d216633062c36e1b Issue-ID: OPTFRA-167 Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
2018-03-22Updated git submodulesShankaranarayanan Puzhavakath Narayanan1-0/+0
Project: optf/osdf master b211c1919e8c04974ba8ab26ec63d34be3826e19 Merge "Fix "brain-overload" functions flagged by SONAR" Fix "brain-overload" functions flagged by SONAR Refactored two brain-overload functions Moved a policy util function from conductor/api_builder.py to policy/utils.py Issue-ID: OPTFRA-195 Change-Id: I879e7f4f5d92cc530c66d3ed071bf5246397ba13 Signed-off-by: Sastry Isukapalli <sastry@research.att.com>
2018-03-22Updated git submodulesSastry Isukapalli1-0/+0
Project: optf/osdf master aa429005c6670758fcf1d895f699b03250e8035b Add docker components for CSIT Added license to Dockerfile Added 8699 internal port and 8698 external port Issue-ID: OPTFRA-22 Change-Id: I232acc6cd417efda164ae825362dcc6d0be28a12 Signed-off-by: Sastry Isukapalli <sastry@research.att.com>
2018-03-22Updated git submodulesShankaranarayanan Puzhavakath Narayanan1-0/+0
Project: optf/has master 5e2f356e8a51c08b442c05a954f1d8ada394932f Merge "Added vim-id attribute for Homing Candidates" Added vim-id attribute for Homing Candidates Added vim-id attribute to both cloud and service candidate Updated unit tests for aai.py Change-Id: I3e1faf89c0490690b3988bb6d466dfbd534e37b6 Issue-ID: OPTFRA-187 Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
2018-03-20Updated git submodulesLeonardo Bellini1-0/+0
Project: optf/has master 9c7878cd58992d239bc1828d192cbaa8519b3452 add first seed of aaisim Issue-ID: OPTFRA-192 Change-Id: I8347b99dbf09514dab7daa2f8e7bb8abc0122d54 Signed-off-by: Leonardo Bellini <leonardo.bellini@att.com>
2018-03-18Updated git submodulesSastry Isukapalli1-0/+0
Project: optf/osdf master 1a9638f5d5fc78f7e8be700e71b506fed3cc9d2d New policies and required code changes Issue-ID: OPTFRA-146 Change-Id: I2261ae69f52b184cd7dcb7b86d5905538666a411 Signed-off-by: Sastry Isukapalli <sastry@research.att.com>
2018-03-18Updated git submodulesSastry Isukapalli1-0/+0
Project: optf/has master 0983301fc60decb20a88f5d7b07d6fa9c8fb8855 Merge "Update oparent-python version for optf/has" Update oparent-python version for optf/has Change-Id: Ice973735086d9412220256678b1d0f71ca9ff979 Issue-ID: OPTFRA-184 Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
2018-03-16Updated git submodulesIkram Ikramullah1-0/+0
Project: optf/has master 589264e69c389524b390c2daa0dc33539e9b929b All compnents on Single docker image Made changes to docker settings to make a single image instead of multiple. Also made changes to the run and build scripts to work on this single image. The data component requires certs, keys and ca bundles settings too. For this, made changes to the run script. Also, do to this, added the feature of picking the default values from the current directory if arguments are not provided to the run-docker.scripts. For example: sudo ./run-dockers.sh will run without providing any arguments to it IF the directory from where it is run has these files in it. 1. conductor.conf -- configuration file 2. log.conf -- log settings files 3. aai_cert.cer 4. aai_key.key 5. aai_ca_bunlde.pem (pem) file The first two from the above have been created and provided in the current directory (has/). However, since certs will be different from env to env, the last three needs to be provided either by copying in the current direcotry or as the arguments 3, 4 and 5. The script will give a detailed message on what may be missing and how an attempt was made to get the default files. Checkt it out by playing with run-docker.sh file. Finally, the build script also calls the push script now. Since there can be no testing of this in ONAP artifcats prod BEFORE being merged to master, we can only test the push part once merged to master. Issue-ID: OPTFRA-123 Change-Id: I83c54c97953b71aae18166b937dd89195e705f73 Signed-off-by: Ikram Ikramullah <ikram@research.att.com>
2018-03-15Updated git submodulesShankaranarayanan Puzhavakath Narayanan1-0/+0
Project: optf/has master e73422283d5075d038a4ac95b97d8f089431e5ff Merge "Docker dir - removed unused conf file" Docker dir - removed unused conf file Removed file not needed for docker images. (conductor.conf). Also, added a remove-images.sh to remove images if needed. Issue-ID: OPTFRA-123 Change-Id: I7494a47da268a229d3d6730eb23fd5a5deb27653 Signed-off-by: Ikram Ikramullah <ikram@research.att.com>
2018-03-15Updated git submodulesSastry Isukapalli1-0/+0
Project: optf/osdf master 7c70d5ba1469b9ea3220bc61be1d1973e5e3e98a Merge "Update oparent-python version for optf/osdf" Update oparent-python version for optf/osdf Change-Id: I8b63a0e2ea35fbaa28674e4edf7da54ddd6ce054 Issue-ID: OPTFRA-184 Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
2018-03-15Updated git submodulesSastry Isukapalli1-0/+0
Project: optf/has master 13b79a8318b767c55109f5ab5d2b8454ec03f7b6 Merge "Adding more unit tests and .coveragerc" Adding more unit tests and .coveragerc Added more unit tests for DataEndpoint class Usage of pragma reverted Change-Id: Id8d4ff76c3ca75a2538352b7eb29b87b1a598794 Issue-ID: OPTFRA-101 Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
2018-03-15Updated git submodulesramkri1231-0/+0
Project: optf/osdf master a02baa907ffa2a700013987cae25dc197ac63b69 Example Minizinc Placement Models for 5G Issue-ID: OPTFRA-173 Change-Id: I245e64764d8dd6e9e254a79a97a7d49e228b125a Signed-off-by: ramkri123 <ramkri123@gmail.com>
2018-03-14Updated git submodulesShankaranarayanan Puzhavakath Narayanan1-0/+0
Project: optf/has master e4cee54e5b2bf43b3da857866036b1d178ee9617 Merge "Added more unit test cases in aai.py file" Added more unit test cases in aai.py file Added more unit tests for AAI. get_aai_rel_link and get_aai_rel_link_data Usage Change-Id: Ie5bc835013da5333b7e2c6f19f48ad8910793643 Issue-ID: OPTFRA-101 Signed-off-by: rl001m <ruilu@research.att.com>
2018-03-13Updated git submodulesIkram Ikramullah (ikram@research.att.com)1-0/+0
Project: optf/has master 3871d29d2414548083b1308298517562e6728117 Corrected Nexus Package content Before dockerzation can proceed, contents of the package must be correct. Few folders/files were missing. Changed assembly.xml to include all but the ones that are not needed. Also, removed files from conductor/conductor folder that were thought to have contributed to the correction of the package initially. conductor/conductor/README.rst conductor/conductor/README.md conductor/conductor/setup.py conductor/conductor/setup.cfg These files are actually not needed in that level of folder (conductor/condcutor) - They should exist only on the main conductor/ folder. Issue-ID: OPTFRA-123 Change-Id: I006694ddc8e7e5de21ad17fb0d4720c5b19dc960 Signed-off-by: Ikram Ikramullah (ikram@research.att.com) <ikram@research.att.com>
2018-03-13Updated git submodulesShankaranarayanan Puzhavakath Narayanan1-0/+0
Project: optf/has master 6b4a181efbe7234074539ee9b2abed72fd7af964 Merge "Fixed Controller unit tests and UnboundlocalError" Fixed Controller unit tests and UnboundlocalError Fix parse_optimization function in translator.py Defined and initialized variable function in the scope Fix unit test for parse_optimization function Add condition variable in function row_update in api.MockAPI Change-Id: I2f08bcfc001e9ccb22a7315d243006a1995edc81 Issue-ID: OPTFRA-69 Signed-off-by: Ying Ruoyu <ruoyu.ying@intel.com>
2018-03-13Updated git submodulesShankar Narayanan1-0/+0
Project: optf/has master ac16f162c5b3a74b3d44a7445202f675f90992f5 Add homing specification guide Add the homing specification guide in rst format. This should be in sync with doc/template/README.md Issue-ID: OPTFRA-174 Change-Id: I972aa837fe520ade884b8254216bcf5f306e2ff8 Signed-off-by: Shankar Narayanan <snarayanan@research.att.com>
2018-03-13Updated git submodulesShankar Narayanan1-0/+0
Project: optf/has master 57e1819840dbf6e5531f0abd62350098723a7599 Add homing specification guide Add the homing specification guide in the rst format. Need to keep this in sync with doc/template/README.md. Issue-ID: OPTFRA-174 Change-Id: I8b16f21d9657838577a8dc5788b522d4577bf190 Signed-off-by: Shankar Narayanan <snarayanan@research.att.com>
2018-03-12Updated git submodulesIkram Ikramullah (ikram@research.att.com)1-0/+0
Project: optf/has master bfcbea292aa9e9c3e01bddd1cba80035c85df8ec Moved all docker files moved to main folder Issue-ID: OPTFRA-123 Change-Id: I9334bda9ef05ed18c4e1fe35616b53e9ba128dc1 Signed-off-by: Ikram Ikramullah (ikram@research.att.com) <ikram@research.att.com>
2018-03-12Updated git submodulesShankaranarayanan Puzhavakath Narayanan1-0/+0
Project: optf/has master be08ec28dc94e6a5b3bd21c422dd90a28a5a979e Merge "Add INFO.yaml file" Add INFO.yaml file Add INFO.yaml to list: - Project description - Properties - PTL information - Meeting information - Committer information Change-Id: I726b06556d7d2ff1fcde75522e38678eb367aa6d Issue-ID: CIMAN-134 Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
2018-03-12Updated git submodulesramkri1231-0/+0
Project: optf/osdf master ebfec9169be3767c354b455fdbb4b6f7314f59a3 Dockerfile for OSDF Minizinc Placement Examples Issue-ID: OPTFRA-153 Change-Id: Ieba7c834e1fa028a00f64bdbf1994fd6703a8fa0 Signed-off-by: ramkri123 <ramkri123@gmail.com>