summaryrefslogtreecommitdiffstats
path: root/docs/submodules/aai/aai-common.git
AgeCommit message (Collapse)AuthorFilesLines
2018-12-11Updated git submodulesJames Forsyth1-0/+0
Project: aai/aai-common master e42c7cf9d25b5a5ec3e3bf2cbb5e04441ec45359 Merge "AAI-1523 checkstyle warnings for aai-core auth" AAI-1523 checkstyle warnings for aai-core auth Issue-ID: AAI-1523 re-indent code with spaces to clean up some checkstyle warnings for aai-core test auth (part of 24k lines of output) Change-Id: I634a49d499f5a6605510633ec2ab6069a04cccba Signed-off-by: Keong Lim <keong.lim@huawei.com>
2018-12-11Updated git submodulesjimmy1-0/+0
Project: aai/aai-common master 80fee7d8e6bb5c28de01cefe3453618051188528 Bump patch version in version.properties Issue-ID: AAI-1900 Change-Id: I29e56e0deaa3d201795c5326d7358ce2d4b652de Signed-off-by: jimmy <jf2512@att.com>
2018-12-10Updated git submodulesJimmy Forsyth1-0/+0
Project: aai/aai-common master 3d2bc847bcfaeb05bfa56f72fad8b395854c4598 Update to latest spring and spring boot Issue-ID: AAI-1900 Change-Id: Ie6fa1338fd88fcd7ce3f3d350277f82b8f90138f Signed-off-by: Jimmy Forsyth <jf2512@att.com>
2018-12-06Updated git submodulesJames Forsyth1-0/+0
Project: aai/aai-common master 88bb14a7c2a1638133182b6030a01eead186bb66 Merge "Update schema ingest library call schema service" Update schema ingest library call schema service Issue-ID: AAI-1994 Change-Id: Icc9910db0371eeb8289abd4381ae1936a281a5df Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-12-05Updated git submodulesJimmy Forsyth1-0/+0
Project: aai/aai-common master ddf953affc477a77f9b68583f8ba0d6d5705882a Add nodesQuery document Issue-ID: AAI-1993 Change-Id: Ic18ed4be11ce654214cffd7f2e0180f078eee9ed Signed-off-by: Jimmy Forsyth <jf2512@att.com>
2018-12-05Updated git submodulesKajur, Harish (vk250x)1-0/+0
Project: aai/aai-common master 8fb7aa6480d4d7becbbab5fcfabd6af3f57e7d74 Improve the performance of resoures microservice Currently the findSubGraph is being invoked and causing additional calls to the database by backing a tree backed vertex and slowing the performance of GET ALLs Original intention of both of them was to pre fetch depth 0, 1, and 2 at once so we don't have to get them at each depth but since that was not done right there is extra amount of time After the aai-uri migration to ensure all vertexes have the aai-uri and also to make sure they are unique across graph we don't need to traverse a vertex to find the parents to build aai-uri it was done previously when there was no aai-uri to derive the uri of a given vertex and its not necessary anymore so there would be performance improvements of vserver when there are a lot of relationships Currently the edge labels are retrieved for each vertex a and b and the performance of the GET with relationships will be propotional to the GET request and how many cousin edges it has and the more cousin edges there are the more slower the response time will be as for each cousin vertex its trying to get the edge in between so the code is modified to only go to the database for the edge label when there are multiple edge labels (cousin edges) between a and b If there are only one edge label and its a cousin vertex then we can use the edge rule to be able to figure out the edge label Improve PUT on the cloud region by modifying the getEdgesBetween method which currently was retrieving all the parent child edges between a and b and then only using the first edge The traversal itself was too complicated and was costly in terms of database retrieval and calls and optimized the code to utilize the edge information so we can modify the query to db at runtime based on the information provided so when a 10000 vservers under a tenant adding a new vserver under tenant would be slow because of the old query performance as it was taking some time there but with this optimization, its only spending at most a millisecond or 2 in that method Also noticed that when a PUT operation takes place, the method calls the related objects to create a dmaap event which was in turn calling the findParents and actually utilizing the parents to create the dmaap event and would spend quite a lot of time here because of the expensive call of the findParents in this case we need those vertexes So optimized the code so based on a given vertex, we have the aai-uri and the newly added metadata uriTemplate to break the aai-uri into its parent aai-uri and grand parent aai-uri and so forth With this breakdown, we can get the list of aai-uris which are parents, grandparents and then use the aai-uri to look them up which is O(1) lookup time due to the fact they are unique indexes The time it takes when doing a traversal to find the parents is propotional to the number of edges but this will be optimistic Another area which was improved was the json path execution of the edge rules so when the edge rules get loaded into memory it creates a document object, it utilizes the jsonpath to query information about the edge rules but the only thing here is each time it gets called the query gets invoked and uses jsonpath to retrieve the edge rules when we can cached them based on the filter so that the user executed and if the filter is the same as before, the expected edge rules will return the same Too much time was spent making the query and retrieving and building the edgerules So a cache is a perfect way to optimize this part Issue-ID: AAI-1987 Change-Id: Ieb8237de3fd31136ceac14bf4a8216a7ab3b7179 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-12-03Updated git submodulesJames Forsyth1-0/+0
Project: aai/aai-common master 7bc1735a516e56d837aa5af3d4849cdcb7af26c7 Merge "Make instance-group description optional" Make instance-group description optional Issue-ID: AAI-1982 Change-Id: Ie572a40a7d0590a62d4919a76753a632c52c4766 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-12-03Updated git submodulesJames Forsyth1-0/+0
Project: aai/aai-common master b5fd9c7b3b584da14ddb839556b769d4ed82c4a3 Merge "Add support for generic vnf to cloud region" Add support for generic vnf to cloud region Issue-ID: AAI-1980 Change-Id: Ic1a5689a891dac0ca13ab1b26760174985f304de Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-11-30Updated git submodulesjimmy1-0/+0
Project: aai/aai-common master 1ec56296a5cd88ba083dbd247d314a0c56dd4de8 Move epics into New Features section Change-Id: Ie265699bdfe61b3b58f7c5f01397c0accf319069 Issue-ID: AAI-1914 Signed-off-by: jimmy <jf2512@att.com> (cherry picked from commit 9859c648e1d601b3398d40562bacce0068177030)
2018-11-30Updated git submodulesJimmy Forsyth1-0/+0
Project: aai/aai-common master 7737fd1d14edd46b2417a1efc4b1e2c71924f608 Update aai release notes Issue-ID: AAI-1914 Change-Id: Ief1f951c6b20543c5f2f16af07d27bb62f8d02a1 Signed-off-by: Jimmy Forsyth <jf2512@att.com> (cherry picked from commit 73ff5292241bb2c58ef52fb06f373140481058db)
2018-11-22Updated git submodulesKeong Lim1-0/+0
Project: aai/aai-common master 49c37cdfbb9378cbc4531b8731c68c33c7cf1d18 AAI-1926 Fix EdgeRules for Dublin Issue-ID: AAI-1926 Fix EdgeRules for Dublin, rework AAI-1925 instead of cherry-pick. Fix EdgeRule for allotted-resource to allotted-resource in main json. Fix EdgeRule for allotted-resource to p-interface in ccvpn json. Change-Id: I32c404f48583fc7d770e65fbff0b23afb0320245 Signed-off-by: Keong Lim <keong.lim@huawei.com>
2018-11-20Updated git submodulesKeong Lim1-0/+0
Project: aai/aai-common master 3985d3b0e00c8137010c73770aecb1bb7b62b46f AAI-1523 checkstyle warnings for aai-core Issue-ID: AAI-1523 re-indent code with spaces to clean up some checkstyle warnings for aai-core test (part of 24k lines of output) Change-Id: I3b33fbe46458e4f0f3273c48ff9cfb0673ae18f4 Signed-off-by: Keong Lim <keong.lim@huawei.com>
2018-11-16Updated git submodulesJames Forsyth1-0/+0
Project: aai/aai-common master f19c486c7d6f2082ef697f24dcbd82890c16d584 Merge "Update:Typo Issue-ID: AAI-1911" Update:Typo Issue-ID: AAI-1911 Change-Id: I5185a4051d7e76c0be67f7f53099bd0fd6b95e1a Signed-off-by: Manish Kumar <manishjpiet@gmail.com>
2018-11-16Updated git submodulesKeong Lim1-0/+0
Project: aai/aai-common master ea6602027e5b2d7e1305b4d2a3d49d6a4d74a0c6 AAI-1923 Problem deleting due to EdgeRules Issue-ID: AAI-1923 Fixed EdgeRules for ext-aai-info to esr-system-info Fixed EdgeRules for lan-port-config to dhcp-service Fixed EdgeRules for pnf to network-resource Fixed EdgeRules for logical-link to ext-aai-network Fixed EdgeRules for vpn-binding to ext-aai-network Fixed EdgeRules for pnf to ext-aai-network Fixed EdgeRules for connectivity to ext-aai-network Fixed EdgeRules for lan-port-config to ext-aai-network Fixed EdgeRules for network-resource to ext-aai-network Fixed EdgeRules for site-resource to ext-aai-network Fixed EdgeRules for sdwan-vpn to ext-aai-network Fixed EdgeRules for device to ext-aai-network Fixed EdgeRules for wan-port-config to ext-aai-network Appears to be a problem with this combo in EdgeRules: - "delete-other-v": "${direction}", - "prevent-delete": "!${direction}", Break the dependency by making one of these values "NONE". (cherry picked from commit 04694a8e17d599bc8fd8b7732c648acfb2378f82) Change-Id: Idc220c88742144a8ad091f316b3afef7be4537f6 Signed-off-by: Keong Lim <keong.lim@huawei.com>
2018-11-14Updated git submodulesJimmy Forsyth1-0/+0
Project: aai/aai-common master 6d4c56a5f9288d21ffe6d0711ede3b288f6030a2 Update R3 release notes Issue-ID: AAI-1914 Change-Id: Iffed2a049e4b1e746d845a73da31432e6e9c74dc Signed-off-by: Jimmy Forsyth <jf2512@att.com>
2018-11-08Updated git submodulesJimmy Forsyth1-0/+0
Project: aai/aai-common master b2d56c3929923a6cba040083279feaf7d80bea34 Add icons for offeredapis doc Issue-ID: AAI-1878 Change-Id: I96bf71a3fb4547532cd7720cbaf9b2aaf3a6af80 Signed-off-by: Jimmy Forsyth <jf2512@att.com>
2018-11-08Updated git submodulesJimmy Forsyth1-0/+0
Project: aai/aai-common master 4f1f48e0253e802a6eb505b7bcbdab687811d79c Update offeredapis doc Issue-ID: AAI-1878 Change-Id: Ida28026f4d7edddd901fa3c6e5b6c2327b33c084 Signed-off-by: Jimmy Forsyth <jf2512@att.com>
2018-11-07Updated git submodulesJimmy Forsyth1-0/+0
Project: aai/aai-common master 6edb62395a4a18481ff851a218af3e570f085b4e Update API doc and custom query doc Issue-ID: AAI-1878 Change-Id: I597eed7bfc64f73b2ac4300ca63f77384e727813 Signed-off-by: Jimmy Forsyth <jf2512@att.com>
2018-11-07Updated git submodulesJimmy Forsyth1-0/+0
Project: aai/aai-common master 84e5a3a494565d21fae0ea79b470b0ef7f31a6d6 Update API doc and add custom query doc Issue-ID: AAI-1878 Change-Id: I55d29b3a4ad6c5b4a641644a82fe1848b3a10b7c Signed-off-by: Jimmy Forsyth <jf2512@att.com>
2018-11-07Updated git submodulesVenkata Harish Kajur1-0/+0
Project: aai/aai-common master 2456dc2bb7901d129e8d77dc2bab64ea6747d1ce Merge "Add Casablanca API Doc" Add Casablanca API Doc Issue-ID: AAI-1878 Change-Id: I5fd0cb3d1aa90a2db282fd390d45bad3d5f44048 Signed-off-by: Jimmy Forsyth <jf2512@att.com>
2018-11-01Updated git submodulesKajur, Harish (vk250x)1-0/+0
Project: aai/aai-common master 7bfc30305b9341999e74f19f747bb7d3c77f6414 Fix bug on create created ts and modified ts where on create the values should be the same but it ends up being different sometimes Issue-ID: AAI-1832 Change-Id: Ia8cfb75a5812e6b59f8000a820cf3605ab17eb2b Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-11-01Updated git submodulesKajur, Harish (vk250x)1-0/+0
Project: aai/aai-common master c2ccad8c88d6eec83e8abb0eb4bab6f65cb74912 Add capability to record timestamp Issue-ID: AAI-1831 Change-Id: Ifcadf1caa0f7764c759997f10f3f789b1a702872 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-11-01Updated git submodulesKajur, Harish (vk250x)1-0/+0
Project: aai/aai-common master 02442650b1bed084c43c2cb96572e2165787b78e Add edge rule to support vnf grouping Issue-ID: AAI-1829 Change-Id: I994a31ac2d737be1db3e5a0821dbc09a32b473c6 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-11-01Updated git submodulesKajur, Harish (vk250x)1-0/+0
Project: aai/aai-common master c4cce58aa04187ae5c7f1917d30aca061424ee50 Update to add relationship to aggregate route Issue-ID: AAI-1824 Change-Id: I68e5e900db8f6a1a3489c66cd8ae71bbe977e98f Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-11-01Updated git submodulesKajur, Harish (vk250x)1-0/+0
Project: aai/aai-common master f220ba5f41b10728da4b36379189f1278a5420c4 Add upgrade cycle to cloud region Issue-ID: AAI-1828 Change-Id: Ifee15d4824a26319f159ed030b0c7f1ab8500041 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-11-01Updated git submodulesKajur, Harish (vk250x)1-0/+0
Project: aai/aai-common master 9d661ab0572c486ad0534fd21d502de0782bd4ea Add required properties to schema Issue-ID: AAI-1826 Change-Id: Ifc7122880e2c98888aa6b478cba3f70fb4c62e52 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-11-01Updated git submodulesKajur, Harish (vk250x)1-0/+0
Project: aai/aai-common master 9bae143d3310eb57bfbb0674f62f278f740db0f4 Replace platform specific line seperators System Issue-ID: AAI-1463 Change-Id: Ibdd3803dd825342d54dfa1b008f1a8c2d78d6198 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-11-01Updated git submodulesKajur, Harish (vk250x)1-0/+0
Project: aai/aai-common master 653948302e921dbcee24ed6746c73557c0b54c92 Add aggregate route object Issue-ID: AAI-1824 Change-Id: I3b1fd2b0dca1add9736b49b26ede67e413aa2586 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-11-01Updated git submodulesKajur, Harish (vk250x)1-0/+0
Project: aai/aai-common master d82a30bd3cb3c0d7fd7c1696abbb4e142631c595 Support generic-vnf vendor information Issue-ID: AAI-1823 Change-Id: Ifa4ab02584bf99565286dcbaab38339030c70228 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-11-01Updated git submodulesKajur, Harish (vk250x)1-0/+0
Project: aai/aai-common master f63960c075b06aa540aa8acccf4beff4497aab77 Add orchestration status to pnf Issue-ID: AAI-1822 Change-Id: Ic78c2f272d25cd0068241db409c0927aaa622471 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-11-01Updated git submodulesKajur, Harish (vk250x)1-0/+0
Project: aai/aai-common master 2a51416d266f0afa29a2246346e6d69cf38384bb Add priority property to l-interface Issue-ID: AAI-1820 Change-Id: Iea36a1d1e4c94ea2bc1cd698c482b4fd1db163a9 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-11-01Updated git submodulesKajur, Harish (vk250x)1-0/+0
Project: aai/aai-common master fa0792d839d67142e916b12f083e9db067ab5f8d Add vrf schema and edge rules Issue-ID: AAI-1813 Change-Id: I1c0f53d9c75ea9d568bd8020680b75ef0a4bf3f6 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-11-01Updated git submodulesKajur, Harish (vk250x)1-0/+0
Project: aai/aai-common master ef398c570cbee1e1ff41aa62cfde5a41fc6d4a08 Add support for v15 APIs Issue-ID: AAI-1812 Change-Id: I2542371baf8f33da1ab2ea3b19073b1f1dc870f4 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-10-22Updated git submodulesJames Forsyth1-0/+0
Project: aai/aai-common master 426992d0bf2e3a3d3123bd716960cd33dd20fc39 Merge "fix xsd generation when obj crosses oxm files" fix xsd generation when obj crosses oxm files Issue-ID: AAI-1654 Change-Id: I118b0d94099c7f986303fc9dd9e5dae5144b4bbb Signed-off-by: LaMont, William (wl2432) <wl2432@us.att.com>
2018-10-13Updated git submodulesJames Forsyth1-0/+0
Project: aai/aai-common master 27e7d8a0111e3a0df6c43da3c0cb6a5b888bf17d Merge "some test cases added" some test cases added Change-Id: Iaf98e45665979d156838d1c7596845108b015cc7 Issue-ID: AAI-1661 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-10-13Updated git submodulesJames Forsyth1-0/+0
Project: aai/aai-common master 4843d76e54fc50882ca1bc7c3cc8ff11544ad122 Merge "exception scenario covered in AAIGraphTest.java" exception scenario covered in AAIGraphTest.java Change-Id: I63009b10aec1e1a73348eaeaa536b1a64dcc11b8 Issue-ID: AAI-1662 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-10-12Updated git submodulesKajur, Harish (vk250x)1-0/+0
Project: aai/aai-common master 2470b451f74cb511a6939c443193ce644424b055 Upversion aai-common to 1.4.0-SNAPSHOT Issue-ID: AAI-1726 Change-Id: Ia7fc62d72baefad98d0aa97ffb1f5df1d25693f1 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-10-02Updated git submodulesBenjamin, Max (mb388a)1-0/+0
Project: aai/aai-common master 6713cba6c39f2e8f57fb835a4cfb7d6dfc411d94 Pojos are now serializable Change-Id: I562c05a4157708af8fdd7537e56bcadc5123d136 Issue-ID: AAI-1695 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-28Updated git submodulesJames Forsyth1-0/+0
Project: aai/aai-common master a612c49bcde2d34a6dc996e2aa93101872b8e1ed Merge "test case to check the singleton instance" test case to check the singleton instance Change-Id: I9c6472923df7ec6a250e3b81c6b5f833b53d5c29 Issue-ID: AAI-1646 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-27Updated git submodulesVenkata Harish Kajur1-0/+0
Project: aai/aai-common master cd74decdcf3db6c623b347177559eb786dd3590b Merge "Upversion to 1.3.1" Upversion to 1.3.1 Issue-ID: AAI-1678 Change-Id: I2bafe046d5c99e3db63862dd5b1ca1ed2da5135b Signed-off-by: Jimmy Forsyth <jf2512@att.com>
2018-09-26Updated git submodulesKeong Lim1-0/+0
Project: aai/aai-common master 8115308366aa9cc8129b9379a61f7ab84d77f84e AAI-1671 Update wan-port-config EdgeRules Issue-ID: AAI-1671 The EdgeRules for wan-port-config to service-instance should be "MANY2MANY". Change-Id: Id76e8405d3ce9955d63280320807c4feffd58990 Signed-off-by: Keong Lim <keong.lim@huawei.com>
2018-09-21Updated git submodulesMaharajh, Robby (rx2202)1-0/+0
Project: aai/aai-common master dce5708124f72b9276791024e2d7add51e2e236b Change edge rule between vnfc and vfmodule Issue-ID: AAI-1668 Change-Id: I36819ab70109cce7991824fe21ae154ca7b26a40 Signed-off-by: Maharajh, Robby (rx2202) <rx2202@att.com>
2018-09-20Updated git submodulesMaharajh, Robby (rx2202)1-0/+0
Project: aai/aai-common master e6ea336a1083e5de13055382ee1235118d44aec2 Update cvlan-tag uri template Issue-ID: AAI-1665 Change-Id: I8e3a549382e68b9738e2732b6dee06726f6d64d6 Signed-off-by: Maharajh, Robby (rx2202) <rx2202@att.com>
2018-09-20Updated git submodulesVenkata Harish K Kajur1-0/+0
Project: aai/aai-common master 112404c8a85ec97f1366dd274e5415210ffee7b7 Exclude groovy indy Issue-ID: AAI-1632 Change-Id: I4c52de06f20d1a89ff2403b98af73a89a04467ea Signed-off-by: Venkata Harish K Kajur <vk250x@att.com>
2018-09-20Updated git submodulesKajur, Harish (vk250x)1-0/+0
Project: aai/aai-common master 42af0df3d0433146bfffbcd9e61a26e0e6015879 Update guava to 19.0 Issue-ID: AAI-1298 Change-Id: I0a880be136f8ea3c0d780e0f9653006a5d5ebc61 Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-09-19Updated git submodulesKajur, Harish (vk250x)1-0/+0
Project: aai/aai-common master aca93d55686c19c18a14c0b7a04e62a21d9f568c Update pnp schema to right file Issue-ID: AAI-1551 Change-Id: I2bcad1f60beae9ac192f5c2f3d11119272cae94a Signed-off-by: Kajur, Harish (vk250x) <vk250x@att.com>
2018-09-19Updated git submodulesJames Forsyth1-0/+0
Project: aai/aai-common master 2ba3019491ecbdd3b0b208cee0702b25438e8c12 Merge "Test cases added for RequestError.java" Test cases added for RequestError.java Change-Id: I16d1fbe7ca03ecd6659161ae9bfbf3d4bd5c59be Issue-ID: AAI-1610 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-19Updated git submodulesJames Forsyth1-0/+0
Project: aai/aai-common master 3a95d0bff41d01150aad68edd672d51b5e2637ab Merge "Added unit test for PolicyException.java" Added unit test for PolicyException.java Change-Id: I76ecc0d4e4193be1343afae2906fb179768dbbdb Issue-ID: AAI-1607 Signed-off-by: Mohamed Asgar Samiulla <sammoham@in.ibm.com>
2018-09-19Updated git submodulesVenkata Harish Kajur1-0/+0
Project: aai/aai-common master 0325baf2da147059bc6505aa0782c69093721887 Merge "Add pnp schema and edgerules files" Add pnp schema and edgerules files Issue-ID: AAI-1551 Change-Id: I8e7e70b01de1f8387694e2398d3f0d9e1080f1f9 Signed-off-by: Jimmy Forsyth <jf2512@att.com>
2018-09-19Updated git submodulesKeong Lim1-0/+0
Project: aai/aai-common master 1df206c251de52d8e6bf145fddb0b8a6c082105d AAI-1639 Update wan-port-config to support IPv4/v6 Issue-ID: AAI-1639 Update wan-port-config with ipv4-address, ipv6-address, provider-ipv4-address and provider-ipv6-address. For compatibility, keep ip-address and provider-ip-address as previously published, but plan to deprecate and remove them. Change-Id: Id96f90bb4034b8cb0c17f13a601ec881a67e9cf2 Signed-off-by: Keong Lim <keong.lim@huawei.com>