summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-05-19Update git submodulesBartek Grzybowski1-0/+0
* Update docs/submodules/integration.git from branch 'master' to a89abf819ed802c3aedc98eae281066d4c5b50dd - Make the actions decorator a static method in a subclass Change-Id: I2bd702ff1d92c80510204cb4666f6c3db7fa62e0 Issue-ID: INT-1577 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com> - Create a boilerplate decorator for MassPnfSim class actions Change-Id: Ia095a608d204e3da6dae101afa04f2e66a9bceeb Issue-ID: INT-1577 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-05-19Update git submodulesSylvain Desbureaux1-0/+0
* Update docs/submodules/oom.git from branch 'master' to e65e54a0d356f5d834c6556159c314d7bdcd3ddd - Merge "Update oof so callback credentials" - Update oof so callback credentials Update oof so callback credentials Change-Id: I210c1fe8f89a486a740449b641f8ff94fd1d3a8e Signed-off-by: vrvarma <vikas.varma@att.com> Issue-ID: OPTFRA-756
2020-05-19Update git submodulesKrzysztof Opasiak1-0/+0
* Update docs/submodules/oom.git from branch 'master' to 3e5fa9a35abca0df060c43b4ebfa660a223485b3 - [COMMON] Fix certInitializer to use proper global values One of reasons why certInitializer is a proper chart that you need to put in your requirements.yaml is to avoid copy-pasting the same global values among different charts. As it turned out in tests we've been not "mangling" global values properly while creating $subchartDot. This patch fixes the issue. Issue-ID: AAF-1134 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com> Change-Id: I630154c4eedd7192ebb1881e5899c8df495d988b
2020-05-19Update git submodulesEinat Vinouze1-0/+0
* Update docs/submodules/vid.git from branch 'master' to 19016e3c0951ff994956e93b1c24e412a7ed542e - Introduce FeatureManager to ResourceCommand Issue-ID: VID-821 Signed-off-by: Einat Vinouze <einat.vinouze@intl.att.com> Change-Id: Id6c663d4612d69a48b4a9425db082fb6c33e08b1 Signed-off-by: Einat Vinouze <einat.vinouze@intl.att.com>
2020-05-19Update git submodulesFrancis Toth1-0/+0
* Update docs/submodules/sdc.git from branch 'master' to 9279f7e71679fb16c7ae74ef7c1b7948e381af01 - Refactor ArtifactsBusinessLogic::generateAndSaveToscaArtifact This commit aims to make some minor refactoring related to the either used in ArtifactsBusinessLogic::generateAndSaveToscaArtifact. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I4923e014146a17f1cd035db3513359a2ab8f38f2 Issue-ID: SDC-2812
2020-05-19Update git submoduleszm3301-0/+0
* Update docs/submodules/so.git from branch 'master' to b6b317acefcf741afe56cb9899769c01c707c557 - Add relationship to allocate resource Issue-ID: SO-2919 Signed-off-by: zm330 <zhangminyj@chinamobile.com> Change-Id: I4232439be1729255fc128b268b1a3168d51507ff
2020-05-18Update git submodulesRajamohan Raj1-0/+0
* Update docs/submodules/multicloud/k8s.git from branch 'master' to dbc92bae58ffbeb38f5c3e5c58a1da2fb3b349f4 - Adding meta data for app in appContext In this patch, modified the appContext and rtc lib by adding functions for setting and getting the meta data associated with the apps. Issue-ID: MULTICLOUD-1064 Signed-off-by: Rajamohan Raj <rajamohan.raj@intel.com> Change-Id: I08f91ddda3044f172caf7b2673c069fed16c32c4
2020-05-18Update git submodulesTaka Cho1-0/+0
* Update docs/submodules/appc.git from branch 'master' to 8fda37850448fc0bef11468aee79da0d9b8c9e81 - update release note for Frankfurt APPC release note updated for Frankfurt release Issue-ID: APPC-1880 Change-Id: I1bff2a6f8f2d6f032033fb80ccc22796be608823 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-05-18Update git submodulesSunder Tattavarada1-0/+0
* Update docs/submodules/portal.git from branch 'master' to 6e93deab9dc5a96cd4d1cc38b66a795193ce4938 - Merge "removed code smells" - removed code smells Issue-ID: PORTAL-865 Change-Id: I9940591ac0a176b961347950525c5bdf3ae06bf0 Signed-off-by: Rupinder <rupinsi1@in.ibm.com>
2020-05-18Update git submodulesSunder Tattavarada1-0/+0
* Update docs/submodules/portal.git from branch 'master' to ad71ab45da79247f3ef1f695aa1a732434d70eca - Merge "lower code smells" - lower code smells Issue-ID: PORTAL-865 Change-Id: Idaf75320d3b3bb8a675a9f021951a3c57ae62ac7 Signed-off-by: Rupinder <rupinsi1@in.ibm.com>
2020-05-18Update git submodulesSandeep Shah1-0/+0
* Update docs/submodules/ccsdk/distribution.git from branch 'master' to ff21fbb2e3d52f1ca80a9adfd6a8c8bf01b5f6d2 - Bug fix in DMAAP publication templates Remove "0a" hex newline character at the end of the DMAAP publication template files. DMAAP message router is very sensitive Issue-ID: CCSDK-2379 Signed-off-by: SandeepLinux <Sandeep.Shah@ibm.com> Change-Id: I7b4e5925c693463cea3441eb15f0e2d4dd3f8416
2020-05-18Update git submodulesDan Timoney1-0/+0
* Update docs/submodules/ccsdk/features.git from branch 'master' to 02c2ad26a25bcc58eb45b70d8d4cf7d2ef035e4e - Merge "Fix data-provider response times extremly long and instability observed" - Fix data-provider response times extremly long and instability observed Issue-ID: SDNC-1193 Signed-off-by: herbert <herbert.eiselt@highstreet-technologies.com> Change-Id: Ic85bff4b62ca61efa63a7b02b37f04b5e1932588
2020-05-18Update git submodulesBrendan Tschaen1-0/+0
* Update docs/submodules/music.git from branch 'master' to 425ef488b7d634e78d88bdeb2503104b59012d13 - Merge "Sonar issue fix in LockCleanUpDaemon" - Sonar issue fix in LockCleanUpDaemon Issue-ID: MUSIC-583 Change-Id: Icc16848de6eaa6ac31112084da012fda9adfdf03 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2020-05-18Update git submodulesezhil1-0/+0
* Update docs/submodules/music.git from branch 'master' to e826554678ac9214dc23724c2988dfb9a61af3ea - junit Testcase for MusicContainerFilter Issue-ID: MUSIC-583 Change-Id: If1a428f89dd8b1f1687173c7fd8cb563d2daad84 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2020-05-18Update git submodulesDan Timoney1-0/+0
* Update docs/submodules/ccsdk/cds.git from branch 'master' to 2f467eb7afcaad363ea08246ec473094a5346c9e - Merge "Test Current version and apply changes" - Test Current version and apply changes Issue-ID: CCSDK-2374 Signed-off-by: Sarah Abouzainah <sabouzainah.ext@orange.com> Change-Id: Ibe36d0981d91054412ac5218d5d121bff37db6f4
2020-05-18Update git submodulesAbdelmuhaimen Seaudi1-0/+0
* Update docs/submodules/ccsdk/cds.git from branch 'master' to 8cd1be656b7354beac76d4095131ea38a58bd7f4 - update vlb cds instantiation and scale out package Issue-ID: CCSDK-2376 Signed-off-by: Abdelmuhaimen Seaudi <abdelmuhaimen.seaudi@orange.com> Change-Id: I307ed09b73487e8c830eadf26b477601b0a0d6f4
2020-05-18Update git submodulesherbert1-0/+0
* Update docs/submodules/ccsdk/features.git from branch 'master' to fa93e2c6ad94861460a0d14a447af01d4379b0a2 - Fix Cluster AkaTimeoutException Issue-ID: SDNC-1191 Signed-off-by: herbert <herbert.eiselt@highstreet-technologies.com> Change-Id: I7a85d66778f6b278d960257d4d8664ec8605253e
2020-05-18Update git submodulesRupinder1-0/+0
* Update docs/submodules/appc.git from branch 'master' to 0be119cd1220b346e731daf30bdce0b1b9077da5 - added asserts statements in 5 JUnits Issue-ID: APPC-1859 Change-Id: I121ff2a1514310ccffdecdf2a1bcc78e62f0dbff Signed-off-by: Rupinder <rupinsi1@in.ibm.com>
2020-05-18Update git submodulesRupinder1-0/+0
* Update docs/submodules/appc.git from branch 'master' to ece150b7f8acc61dd983f6674bf9c8d4f086b84c - added assert statements in 4 jUnits Issue-ID: APPC-1859 Change-Id: I82620e573e99fab83870da8402947989d3497895 Signed-off-by: Rupinder <rupinsi1@in.ibm.com>
2020-05-18Update git submodulesRupinder1-0/+0
* Update docs/submodules/appc.git from branch 'master' to 2d2cfcffbc2032be20034f69f34cc72983b1cfe6 - added asserts statements in JUnits Issue-ID: APPC-1859 Change-Id: I7fbc6a536e0f3fc40d652c3cc402fcb0b9fc7020 Signed-off-by: Rupinder <rupinsi1@in.ibm.com>
2020-05-18Update git submodulesPamela Dragosh1-0/+0
* Update docs/submodules/policy/parent.git from branch 'master' to 47ee485cebc0e50702f9b591095d57232d2636ce - Merge "Add documentation for SDNC actor" - Add documentation for SDNC actor Issue-ID: POLICY-2515 Change-Id: I087c3d38205c8f158ef395b198b682d99ea45c23 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-05-18Update git submodulesPamela Dragosh1-0/+0
* Update docs/submodules/policy/parent.git from branch 'master' to b217c6908fe5e9604a59627a786385852e7e8ae4 - Merge "Removing label reference for section not available." - Removing label reference for section not available. Change-Id: I42345fd32a380d3d1a81be9bb7a2ce9fa7aa5f1d Issue-ID: POLICY-2511 Signed-off-by: uj426b <uj426b@att.com>
2020-05-18Update git submodulessebdet1-0/+0
* Update docs/submodules/clamp.git from branch 'master' to 061ecec6a6099ad7fb480b0fe67f6e5154f9db23 - Add info in the SVG Add two additional fields in the SVG for the UI so that components can easily get the data without the need to access the models Issue-ID: CLAMP-852 Signed-off-by: sebdet <sebastien.determe@intl.att.com> Change-Id: I872d3c8b0336d813e1a1cf590f6c8a06cccbe230
2020-05-18Update git submodulesFrancis Toth1-0/+0
* Update docs/submodules/sdc.git from branch 'master' to bf37c21229e1b60937202c3962b24f14b45c96e5 - Refactor CsarUtil::extractVfcArtifact Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: Ica8d17d4f3c763920f406ccb89fb3e464d05eab4 Issue-ID: SDC-2812
2020-05-18Update git submodulesFrancis Toth1-0/+0
* Update docs/submodules/sdc.git from branch 'master' to 0ff3fcba8b7d645e497a7300776bde86590ec70c - Refactor tosca representation retrieval in CsarUtils::populateZip This commit aims to simplify CsarUtils::populateZip by extracting how a tosca representation is fetched to another function. this enables to reduce the overall cyclomatic complexity of the function. Some additional work still needs to be done especially regarding the ToscaRepresentation and MainYamlWithDependencies classes (These happen to be really similar). This will be done in another change in the near future. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I93600d0752565de523cf2285b1fa2ba43a96334f Issue-ID: SDC-2812
2020-05-18Update git submodulesBartek Grzybowski1-0/+0
* Update docs/submodules/oom/offline-installer.git from branch 'master' to 3e8a8868d7ef936ad85a360845d2c071d585c57b - Merge "Adding Ubuntu support in Ansible - vncserver role" - Adding Ubuntu support in Ansible - vncserver role Extending ansible playbooks of ubuntu support. Creating new test with Ubuntu image for Molecule in vncserver role. Issue-ID: OOM-1671 Signed-off-by: Jan Benedikt <j.benedikt@partner.samsung.com> Change-Id: Ie57885d30166f319629e160c38a9053c18837515
2020-05-18Update git submodulesKrzysztof Opasiak1-0/+0
* Update docs/submodules/oom.git from branch 'master' to 9d0f567fc4c4ff12af022ed8e87854b1fd24d0dd - Merge "deploy.sh does not work on Mac os x because untar directory is created before helm fetch" - deploy.sh does not work on Mac os x because untar directory is created before helm fetch Issue-ID: OOM-2407 Signed-off-by: yoonsoonjahng <yoonsoon.jahng@yoppworks.com> Change-Id: I20e6169bd8c7794db4c6972bfd7bca4f0bf6a910 Change-Id: I01f8c26539e6ceb828a73458d74a8185e9a5081f Signed-off-by: yoonsoonjahng <yoonsoon.jahng@yoppworks.com>
2020-05-18Update git submodulesEinat Vinouze1-0/+0
* Update docs/submodules/vid.git from branch 'master' to aaec5296d2fa63828c320e4a3fb1e5ed0e168de2 - Add pause icon to the instantiationStatus table Issue-ID: VID-821 Signed-off-by: Einat Vinouze <einat.vinouze@intl.att.com> Change-Id: Idbe53b0d0f3515e5c5321f4631ff45ac459377c6 Signed-off-by: Einat Vinouze <einat.vinouze@intl.att.com>
2020-05-18Update git submodulesYuanHong Deng1-0/+0
* Update docs/submodules/vfc/nfvo/lcm.git from branch 'master' to 1f55bd9564c95d4eabd3addfe6d2542e9db853b5 - Update VNF interface and IP information in A&AI Change-Id: Ic33df46dd08f4a23986f1117e3ba759cbcb08a67 Issue-ID: VFC-1673 Signed-off-by: YuanHong Deng <dengyuanhong@chinamobile.com>
2020-05-18Update git submodulesYuanHong Deng1-0/+0
* Update docs/submodules/vfc/nfvo/lcm.git from branch 'master' to e85c495cfb902c4dad94f87265699c3c027e4fed - Update the nslcm code to update the resourceName Change-Id: Ib93fdb8c1097793c8bc3f8b4c8461de5bac09c28 Issue-ID: VFC-1657 Signed-off-by: YuanHong Deng <dengyuanhong@chinamobile.com>
2020-05-18Update git submodulesBenjamin, Max (mb388a)1-0/+0
* Update docs/submodules/so.git from branch 'master' to 959d27a96f24cf74dfa3764df64b65a1ba9b9cbb - updated aai-schema dependency to 1.7.2 Issue-ID: SO-2939 Change-Id: I5e9f47af8d51a0aee8d150e1956ad7ef85206988 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
2020-05-18Update git submodulesJan Benedikt1-0/+0
* Update docs/submodules/oom/offline-installer.git from branch 'master' to 2c34d1d7a33e34c9984ac78460fd8e7c815024c5 - Adding Ubuntu support in Ansible - package-repository role Extending ansible playbooks of ubuntu support. Creating new test with Ubuntu image for Molecule in package-repository role. Issue-ID: OOM-1671 Signed-off-by: Jan Benedikt <j.benedikt@partner.samsung.com> Change-Id: I85d4e6857536fa06c7eb4f4042c1ed64fcbf903e
2020-05-18Update git submodulesYuanHong Deng1-0/+0
* Update docs/submodules/vfc/nfvo/lcm.git from branch 'master' to b4722c4b672a1415b37a3a7a00811d637819c48c - Implement VNF interface APIs Issue-ID: VFC-1671 Change-Id: I7b9e37113991b637f60c68c08c71ba54a527fdc8 Signed-off-by: YuanHong Deng <dengyuanhong@chinamobile.com>
2020-05-18Update git submodulesSylvain Desbureaux1-0/+0
* Update docs/submodules/oom.git from branch 'master' to b6e666836146077d9062357399f9fb725e752ba1 - Merge "[COMMON] Use "" instead of {} as a default value to avoid warning" - [COMMON] Use "" instead of {} as a default value to avoid warning After we upgraded our helm version we started getting below issues with emails: Warning: Merging destination map for chart 'curator'. Overwriting table item 'image', with non table value: onap/sdnc-image:1.8.2 To fix this let's just use "" instead of () for our daily operations. Issue-ID: OOM-2412 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com> Change-Id: I5f2c215c281036a7eb921d6a805527c807a4aca9
2020-05-18Update git submodulesSylvain Desbureaux1-0/+0
* Update docs/submodules/oom.git from branch 'master' to a8672794ffc7c4b9486df575e665301fd9db3d97 - Merge "Bump version of readiness image" - Bump version of readiness image New readiness image proposes several new stuff: * smaller size * ability to wait for daemonset Issue-ID: OOM-2373 Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com> Change-Id: I4af9a09393c5b71214d8f4db2c1a095b260c9fbd
2020-05-18Update git submodulesMorgan Richomme1-0/+0
* Update docs/submodules/oom.git from branch 'master' to 068d592f5460020a5485e0c697c0afede4e167d7 - Merge "[COMMON] Enable password generation in postgres" - [COMMON] Enable password generation in postgres Issue-ID: OOM-2250 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com> Change-Id: Ibad1e8d523d2a182d2f43e1ae2b46fff07c11e01
2020-05-18Update git submodulesChris André1-0/+0
* Update docs/submodules/sdc.git from branch 'master' to cbf02a29680b79b0cdc19b2002e642de949dffca - OrchestrationTemplateDaoZusammenImpl - Add tests for the presence of Optional values Issue-ID: SDC-3015 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: Iae0ce3d1b4bb5a72f04f0cd8a890c84eb15b214c
2020-05-17Update git submodulesRodrigo Lima1-0/+0
* Update docs/submodules/sdc.git from branch 'master' to 768742ee00920426d9d81aef56dcd0298bf9f1d0 - Remove powermock from ContextTracker - Remove powermock from ContextTrackerTest - Add package level constructor to ContextTracker to pass clear and put functions Issue-ID: SDC-3058 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I82519538b763b00f2768801f06929773bfb58013
2020-05-17Update git submodulesEinat Vinouze1-0/+0
* Update docs/submodules/vid.git from branch 'master' to a1891033584c124bc6e58676f9109b182707e3e8 - Move pauseInstantiation from VfModule to BaseResource Issue-ID: VID-821 Change-Id: Iacb80bba25596b26cb33fd91d9b2c4a4f9a6d08b Signed-off-by: Einat Vinouze <einat.vinouze@intl.att.com>
2020-05-17Update git submodulesRodrigo Lima1-0/+0
* Update docs/submodules/sdc.git from branch 'master' to 3a28b9af8d08fc2cf8d9af9b38578fd034999dc2 - Remove powermock from ValidationConfigManagerTest - Remove powermock reference from ValidationConfigManagerTest Issue-ID: SDC-3064 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: Ib330b0fcaf132e5d67f65b482a80b5b75f8c336b
2020-05-17Update git submodulesRodrigo Lima1-0/+0
* Update docs/submodules/sdc.git from branch 'master' to 6ff5f15cd520b2414768b12ecc3cd4638b200352 - Remove powermock from ArtifactValidationUtilsTest - Remove powermock reference from ArtifactValidationUtilsTest - Use junit 5 imports instead of junit 4 Issue-ID: SDC-3067 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I6388e133024ed1e7604e90fc24ba3e84a33da4f7
2020-05-17Update git submodulesRodrigo Lima1-0/+0
* Update docs/submodules/sdc.git from branch 'master' to 3e6caca29ecf74b0bacdfc7f20990e9820fc987d - Remove powermock from ReportManagerTest - Remove powermock reference from ReportManagerTest - Use Junit 5 imports instead of junit 4 Issue-ID: SDC-3066 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: Iece6e5741d5f2f5bc5db2ec7c85c63948776d601
2020-05-17Update git submodulesRodrigo Lima1-0/+0
* Update docs/submodules/sdc.git from branch 'master' to bcf6a1c5302625ea034067cab8c3489746f733bd - Remove powermock from HostAddressCacheTest - Remove powermock and easymock from HostAddressCacheTest - Add package level constructor to HostAddressCache and pass read address function to verified in unit test Issue-ID: SDC-3068 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I749211393d9e0ecb3ff3b587dc0f811b58bb967c
2020-05-17Update git submodulesFuss, Areli (af732p)1-0/+0
* Update docs/submodules/sdc.git from branch 'master' to a532a8c241439ee774326068137e6b5cbb8f348f - sdc-backend-init does not restart on healthcheck failure Issue-ID: SDC-3063 Change-Id: I6c4a796f42060832ee8a37a708dedda7e7e98c70 Signed-off-by: Fuss, Areli (af732p) <areli.fuss@intl.att.com>
2020-05-17Update git submodulesTufman, Shay (st198j)1-0/+0
* Update docs/submodules/sdc.git from branch 'master' to 8a6289f745fd37afcad9d0a15a6666c50fb46aef - Fix edit deployment artifact icon, and download Change-Id: I9e66870b03fcc5edcea30a18809cf8a2c539e674 Issue-ID: SDC-3053 Signed-off-by: Tufman, Shay (st198j) <st198j@att.com>
2020-05-17Update git submodulesChris André1-0/+0
* Update docs/submodules/sdc.git from branch 'master' to bd98f6033c9dddb50507c04ff70095955c346273 - Work around potential NullPointerExceptions in ComponentInstanceOperation - Rewrite of `updateAttributeValueInResourceInstance` Issue-ID: SDC-2923 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I1becdec8c10515976835e7d8fb0208b9cbad10bb
2020-05-17Update git submodulesAlexey Sandler1-0/+0
* Update docs/submodules/vid.git from branch 'master' to c8a3cfffe97ec18a54f43e82c3d4f65a65d7eefb - Add to VFM context menu action "Add pause upon completion". Issue-ID: VID-821 Signed-off-by: Alexey Sandler <alexey.sandler@intl.att.com> Change-Id: I8b0ef7021fb7b74e8ad12ae92e581510491d9605 Signed-off-by: Alexey Sandler <alexey.sandler@intl.att.com>
2020-05-16Update git submodulesRupinder1-0/+0
* Update docs/submodules/appc.git from branch 'master' to 6e31b176be9421c154ac7d164254d9df31d68d56 - added assert statements in jUnits Issue-ID: APPC-1859 Change-Id: I80ce69ae34b7560bef1b1be06b8c3bb9fef73e22 Signed-off-by: Rupinder <rupinsi1@in.ibm.com>
2020-05-16Update git submodulesRupinder1-0/+0
* Update docs/submodules/appc.git from branch 'master' to db0d945a6f3f0a446ad47f1faa4c5c63da846327 - added atleat one assert statement in test case Issue-ID: APPC-1859 Change-Id: I0aa503664224aa2f6d1ced5faff59f7156609693 Signed-off-by: Rupinder <rupinsi1@in.ibm.com>
2020-05-15Update git submodulesRupinder1-0/+0
* Update docs/submodules/appc.git from branch 'master' to fc616287f11ebe888cbbbf866d983cddbb193f1a - worked on code smells Removed some unused imports and reorder the modifiers to comply with java language Issue-ID: APPC-1859 Change-Id: Ieaf032f7d4466186b4813e6dcee5c475e4472d4d Signed-off-by: Rupinder <rupinsi1@in.ibm.com>