summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-08-20Sonar major issuesSumapriya Sarvepalli1-4/+4
Replace with the diamond operator Sonar Link: https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WkgwGn37JfbyHyq&resolved=false&severities=MAJOR Location: src/main/java/com/att/dmf/mr/backends/kafka/KafkaConsumerCache.java Line No:L166 L395 L419 L463 Change-Id: Ie766fa53303bf45a4e028c5a557ce45f8e211f99 Issue-ID: DMAAP-616 Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
2018-08-17Sonar Major issuesSumapriya Sarvepalli1-19/+13
This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WkrwGn37JfbyH0E&resolved=false Location: src/main/java/com/att/dmf/mr/backends/kafka/Kafka011Consumer.java Line No:L45 L64 L129 L142 L261 L269 L283 L289 L363 L368 L377 L385 L399 L401 Change-Id: Id747f017cc0f09694181ce410c697895fcfafafa Issue-ID: DMAAP-610 Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
2018-08-17Sonar Major issuesSumapriya Sarvepalli1-2/+0
This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WkSwGn37JfbyHyc&resolved=false&severities=MAJOR Location: src/main/java/com/att/dmf/mr/backends/Publisher.java Line No:L32 L98 Issue-ID: DMAAP-609 Change-Id: I73b5ac924bc51386a88caac7df23ebb8aaa31eb1 Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
2018-08-16Sonar Major issuesSumapriya Sarvepalli1-3/+3
This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WkawGn37JfbyHyj&resolved=false&severities=MAJOR Location: src/main/java/com/att/dmf/mr/backends/Consumer.java Line No: L80 L82 L103 Change-Id: I64380e4693373d1f4695c07757f524b021f95e87 Issue-ID: DMAAP-603 Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
2018-08-14fix security vulnerabilitiesv1.1.5sunil unnava1-4/+18
Issue-ID: DMAAP-592 Change-Id: I8555e3633222e3599b29dafd8fd0ec17bb426773 Signed-off-by: sunil unnava <su622b@att.com>
2018-08-14remove tomcat dependenciessunil unnava1-6/+6
Issue-ID: DMAAP-592 Change-Id: I8164b3b8c0e99714d12b52d35c59c8bf37bc1766 Signed-off-by: sunil unnava <su622b@att.com>
2018-08-14update the testcases after the kafka 11 changessunil unnava208-3810/+5047
Issue-ID: DMAAP-526 Change-Id: I477a8ee05fb3cdd76af726b6ca0d1a69aa9eef93 Signed-off-by: sunil unnava <su622b@att.com>
2018-05-09Merge "sonar critical for Conditional Statement"2.0.0-ONAPbeijing2.0.0-ONAPRam Koya1-2/+3
2018-05-09Merge "sonar critical for Conditional Statement"Ram Koya1-1/+4
2018-05-09Merge "sonar critical for Exception handling"Ram Koya1-1/+1
2018-05-09Merge "Sonar major issues"Ram Koya1-1/+1
2018-05-09Merge changes I6d43e553,I8e07515b,Ida4d83cd,Id70b6f40,Ic9b25d4f, ...Ram Koya4-6/+9
* changes: sonar major for commented-out lines sonar critical for conditional statement sonar minor issue for unused import sonar major issue for commented-out lines sonar major issue for commented-out lines sonar major issue for 2 statements per line
2018-05-09sonar major for commented-out linesSahani Ravindrana Naik1-1/+1
This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=Sahani_Naik&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false Location: src/main/java/com/att/nsa/cambria/backends/kafka/KafkaConsumerCache.java Line No-49 Change-Id: I6d43e55351c18bdbedae87a17fa2eb5f78ebd3a1 Issue-ID: DMAAP-481 Signed-off-by: Sahani Ravindrana Naik <sn00552219@techmahindra.com>
2018-05-09sonar critical for conditional statementSahani Ravindrana Naik1-1/+3
This line will not be executed conditionally; only the first line of this 2-line block will be. The rest will execute unconditionally Sonar Link: https://sonar.onap.org/project/issues?assignees=Sahani_Naik&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false Location: src/main/java/com/att/nsa/cambria/service/impl/TopicServiceImpl.java Line No-166 Change-Id: I8e07515bb42960205f7f4982d99184cf946402ac Issue-ID: DMAAP-480 Signed-off-by: Sahani Ravindrana Naik <sn00552219@techmahindra.com>
2018-05-07Merge "sonar critical for Conditional Statement"Ram Koya1-1/+3
2018-05-07Sonar major issuesSurendra Reddy Katam1-1/+1
This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VaZ732hFUzlqc5lg&resolved=false&severities=MAJOR Location: src/main/java/com/att/nsa/apiServer/metrics/cambria/DMaaPMetricsSender.java Line No-182 Change-Id: Iaaa992fde4da4d74ec9ce8dca2c42909537ea909 Issue-ID: DMAAP-467 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-05-07sonar minor issue for unused importSahani Ravindrana Naik1-1/+1
Remove this unused import 'com.att.nsa.drumlin.till.nv.rrNvReadable' Sonar Link: https://sonar.onap.org/project/issues?assignees=Sahani_Naik&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false Location: src/main/java/com/att/nsa/apiServer/metrics/cambria/DMaaPMetricsSender.java Line No-43 Change-Id: Ida4d83cde56c0765debc27f6765dce1ad4ef03a4 Issue-ID: DMAAP-468 Signed-off-by: Sahani Ravindrana Naik <sn00552219@techmahindra.com>
2018-05-07Sonar major issuesSurendra Reddy Katam1-1/+0
This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VaZ732hFUzlqc5lg&resolved=false&severities=MAJOR Location: src/main/java/com/att/nsa/apiServer/metrics/cambria/DMaaPMetricsSender.java Line No-80 Change-Id: I5b5ac4044ae73d963c198a0737f200d2aca261a9 Issue-ID: DMAAP-466 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-05-07sonar critical for Exception handlingSaurabh Kumar261-1/+1
Rethrow this exception Sonar Link: https://sonar.onap.org/project/issues?assignees=SaurabhKumar26&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nas/cambria/resources/streamReaders/CambriaRawStreamReader.java Line No. 131 Change-Id: I27409b296d30d3d2fee459f769b5eb06ec729ecc Issue-ID: DMAAP-471 Signed-off-by: Saurabh Kumar26 <sk00552209@techmahindra.com>
2018-05-07sonar critical for Conditional StatementSaurabh Kumar261-1/+4
added '{}' after if statement Sonar Link: https://sonar.onap.org/project/issues?assignees=SaurabhKumar26&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/cambria/beans/DMaaPKafkaConsumerFactory.java Line No. 116 Change-Id: Icc24ec635035e9d62486bcd972263c5926d8b4e1 Issue-ID: DMAAP-470 Signed-off-by: Saurabh Kumar26 <sk00552209@techmahindra.com>
2018-05-07sonar critical for Conditional StatementSaurabh Kumar261-2/+3
added '{}' after if statement Sonar Link: https://sonar.onap.org/project/issues?assignees=SaurabhKumar26&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false&severities=CRITICAL Location: src/.../att/nsa/cambria/backends/kafka/KafkaConsumerCache.java Line No. 542 Change-Id: I811432fc77002d49c374f070e3438ed88bc0eb16 Issue-ID: DMAAP-469 Signed-off-by: Saurabh Kumar26 <sk00552209@techmahindra.com>
2018-05-04sonar critical for Conditional StatementSaurabh Kumar261-1/+3
added '{}' after if statement Sonar Link: https://sonar.onap.org/project/issues?assignees=SaurabhKumar26&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false&severities=CRITICAL Location: src/.../att/nsa/cambria/backends/kafka/KafkaConsumerCache.java Line No. 244 Change-Id: I293b0543f1a0ccfc3fcd4633e6ef2b54751f0ab8 Issue-ID: DMAAP-463 Signed-off-by: Saurabh Kumar26 <sk00552209@techmahindra.com>
2018-05-04sonar major issue for commented-out linesSahani Ravindrana Naik1-1/+1
This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=Sahani_Naik&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr Location: src/main/java/com/att/nsa/cambria/backends/Consumer.java Line No-78 Change-Id: Id70b6f40b95917690ac78f1cc387cd779cfe3d6a Issue-ID: DMAAP-459 Signed-off-by: Sahani Ravindrana Naik <sn00552219@techmahindra.com>
2018-05-03sonar major issue for commented-out linesSahani Ravindrana Naik1-1/+1
This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=Sahani_Naik&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false Location: src/main/java/com/att/nsa/apiServer/metrics/cambria/DMaaPMetricsSender.java Line No-89 Change-Id: Ic9b25d4f38fe8ffb7584a3662895b1488d572da0 Issue-ID: DMAAP-457 Signed-off-by: Sahani Ravindrana Naik <sn00552219@techmahindra.com>
2018-05-03sonar major issue for 2 statements per lineSahani Ravindrana Naik1-3/+4
At most one statement is allowed per line, but 2 statements were found on this line Sonar Link: https://sonar.onap.org/project/issues?assignees=Sahani_Naik&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VaZ932hFUzlqc5lz&resolved=false Location: src/main/java/com/att/nsa/apiServer/metrics/cambria/DMaaPMetricsSender.java Line No-87 Change-Id: I55b8452eda65d5b3fdedd87fa68326d60d9cd457 Issue-ID: DMAAP-454 Signed-off-by: Sahani Ravindrana Naik <sn00552219@techmahindra.com>
2018-04-27Merge changes I624da3f9,I5e879cf1,I43199346,I124eefbc,If36c06fcv1.1.4Ram Koya5-3/+12
* changes: Sonar critical issues Sonar critical issues Sonar critical issues Sonar critical issues Sonar critical issues
2018-04-26Updated the spring-expression versionsu622b2-3/+3
Issue-ID: DMAAP-431 Change-Id: Ib8c6ed39265aee9b18eda334dcadfc8ec78ba61b Signed-off-by: su622b <sunil.unnava@att.com>
2018-04-20Changes for AAF authenticationsu622b3-28/+6
Issue-ID: DMAAP-245 Change-Id: I92076166f38ff948a4d2719fe983a2ef64514849 Signed-off-by: su622b <sunil.unnava@att.com>
2018-04-18Changes for security and licence issuessu622b1-4/+4
Issue-ID: DMAAP-431 Change-Id: I0e0504d8c19c946cbdd3e440236ad9b92990fc18 Signed-off-by: su622b <sunil.unnava@att.com>
2018-04-18Sonar critical issuesSurendra Reddy Katam1-0/+1
Either log or rethrow this exception Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vahb32hFUzlqc5uC&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/cambria/resources/streamReaders/CambriaJsonStreamReader.java Line No-74 Change-Id: I624da3f9a741d243595a0f7da9593ddbb64b4e43 Issue-ID: DMAAP-430 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-04-18Sonar critical issuesSurendra Reddy Katam1-1/+1
Either log or rethrow this exception Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vakn32hFUzlqc5yP&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/cambria/service/impl/MMServiceImpl.java Line No-225 Change-Id: I5e879cf1f2d1a96ec7207278d9395fa8771c6e6f Issue-ID: DMAAP-429 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-04-17Changes for security vulnerabilitiessu622b1-3/+8
Issue-ID: DMAAP-387 Change-Id: I5714786059f0a2abe9be74fffb0fa00d0b6c7443 Signed-off-by: su622b <sunil.unnava@att.com>
2018-04-17Sonar critical issuesSurendra Reddy Katam1-1/+1
Define and throw a dedicated exception instead of using a generic one Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vaf-32hFUzlqc5ry&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/cambria/metrics/publisher/CambriaPublisherUtility.java Line No-56 Change-Id: I43199346fee31ed87618c69e7f46c7ef6d0a0a69 Issue-ID: DMAAP-426 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-04-17Sonar critical issuesSurendra Reddy Katam1-0/+5
Either log or rethrow this exception Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vah332hFUzlqc5uo&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/cambria/resources/streamReaders/CambriaTextStreamReader.java Line No-132 Change-Id: I124eefbc7834d6eb3d02ceda34425967506227f4 Issue-ID: DMAAP-419 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-04-17Sonar critical issuesSurendra Reddy Katam1-1/+4
Either re-interrupt this method or rethrow the InterruptedException Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VahN32hFUzlqc5tz&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/cambria/resources/CambriaOutboundEventStream.java Line No-329 Change-Id: If36c06fc3fbfd94a455e90b2c1f5c12ed7575eb4 Issue-ID: DMAAP-417 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-04-16Sonar critical issuesSurendra Reddy Katam1-1/+1
Define and throw a dedicated exception instead of using a generic one Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VaZ832hFUzlqc5lo&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/apiServer/metrics/cambria/DMaaPMetricsSender.java Line No-148 Change-Id: Iac2254a7faf965a26c02f4ef2f270f8ee1671bb7 Issue-ID: DMAAP-412 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-04-16Sonar critical issuesSurendra Reddy Katam1-0/+1
Either log or rethrow this exception Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vakn32hFUzlqc5yQ&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/cambria/service/impl/MMServiceImpl.java Line No-237 Change-Id: I309316b9c90fecc9a0cf44c9f54ce6521cdc0b57 Issue-ID: DMAAP-411 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-04-13Sonar critical issuesSurendra Reddy Katam1-1/+6
Either log or rethrow this exception Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vahb32hFUzlqc5uD&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/cambria/resources/streamReaders/CambriaJsonStreamReader.java Line No-111 Change-Id: I98b083ebc2410e3da5a15d52d4917311b33d10f7 Issue-ID: DMAAP-408 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-04-13Sonar critical issuesSurendra Reddy Katam1-1/+1
Define and throw a dedicated exception instead of using a generic one Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-ValN32hFUzlqc5zj&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/cambria/service/impl/UIServiceImpl.java Line No-118 Change-Id: Ief99865ceb889340c2895b023cede8c355052c19 Issue-ID: DMAAP-407 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-04-12Sonar critical issuesSurendra Reddy Katam1-1/+2
Either re-interrupt this method or rethrow the InterruptedException Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VabL32hFUzlqc5nF&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/cambria/backends/kafka/KafkaConsumerCache.java Line No-543 Change-Id: I55e02be114874ba791d7caf72665d4a655fa833b Issue-ID: DMAAP-406 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-04-12Sonar critical issuesSurendra Reddy Katam1-1/+2
Either re-interrupt this method or rethrow the InterruptedException Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vacn32hFUzlqc5o4&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/cambria/beans/DMaaPCambriaLimiter.java Line No-144 Change-Id: I6c57315d9a4fc913a5e336feb63e2a11910a9ad8 Issue-ID: DMAAP-405 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-04-11Sonar critical issuesSurendra Reddy Katam1-0/+1
Either log or rethrow this exception Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VabL32hFUzlqc5nK&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/cambria/backends/kafka/KafkaConsumerCache.java Line No-523 Change-Id: Id475b0aaf8d7a877a4b9c3487fd9980f97eb55e6 Issue-ID: DMAAP-403 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-04-11Sonar critical issuesSurendra Reddy Katam1-1/+1
Either log or rethrow this exception Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VanH32hFUzlqc51u&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/filter/ContentLengthFilter.java Line No-107 Change-Id: I0ba58d2ef57ff1e74f9adff505b68b6b7971f335 Issue-ID: DMAAP-402 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-04-10Merge "sonar critical for errorhandling"varun gudisena0-0/+0
2018-04-10Sonar critical issuesSurendra Reddy Katam1-1/+1
Either log or rethrow this exception Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VabL32hFUzlqc5nJ&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/cambria/backends/kafka/KafkaConsumerCache.java Line No-404 Change-Id: Ibd2bbb3d4ece97921a9c3dffa02562c5591cf841 Issue-ID: DMAAP-401 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-04-10Sonar critical issuesSurendra Reddy Katam1-1/+1
Either log or rethrow this exception Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vac632hFUzlqc5ph&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/cambria/beans/DMaaPKafkaConsumerFactory.java Line No-189 Change-Id: Idec33f4ce7e00d5069ea6206a596edd677364f00 Issue-ID: DMAAP-400 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-04-10Sonar critical issuesSurendra Reddy Katam1-0/+1
Either re-interrupt this method or rethrow the InterruptedException Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VabL32hFUzlqc5nE&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/cambria/backends/kafka/KafkaConsumerCache.java Line No-268 Change-Id: I2fce3e65c0522fba0527be75db0f6075018606a5 Issue-ID: DMAAP-398 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-04-09Merge "sonar critical for errorhandling"varun gudisena1-1/+1
2018-04-09Merge "sonar critical for errorhandling"varun gudisena1-1/+2
2018-04-09Merge "sonar critical for errorhandling"varun gudisena1-1/+1