diff options
| author |   Sumapriya Sarvepalli <ss00493505@techmahindra.com> | 2018-08-23 17:50:44 +0530 |
|---|---|---|
| committer | Sumapriya Sarvepalli <ss00493505@techmahindra.com> | 2018-08-23 17:50:44 +0530 |
| commit | 269664f77e2bf3e1e9ec828f7aaca0466b585c4a (patch) | |
| tree | c24bd22f6144cc62c80f2ea6c061dca176cdef9b /src/main | |
| parent | 962e97959cfe711da4222dcb0e3cb3abebfc3d74 (diff) | |
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WkywGn37JfbyH0q&resolved=false&rules=squid%3ACommentedOutCodeLine&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/backends/kafka/KafkaPublisher.java
Line No:L44 L79 L83 L87 L92 L97 L187 L203 L231 L234
Change-Id: I478277f42a305dfcd604fe4bd40a7377213356da
Issue-ID: DMAAP-635
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Diffstat (limited to 'src/main')
| -rw-r--r-- | src/main/java/com/att/dmf/mr/backends/kafka/KafkaPublisher.java | 24 |
1 files changed, 9 insertions, 15 deletions
diff --git a/src/main/java/com/att/dmf/mr/backends/kafka/KafkaPublisher.java b/src/main/java/com/att/dmf/mr/backends/kafka/KafkaPublisher.java index 30209f0..dc4bcd5 100644 --- a/src/main/java/com/att/dmf/mr/backends/kafka/KafkaPublisher.java +++ b/src/main/java/com/att/dmf/mr/backends/kafka/KafkaPublisher.java @@ -41,7 +41,7 @@ import com.att.eelf.configuration.EELFLogger; import com.att.eelf.configuration.EELFManager; import com.att.nsa.drumlin.till.nv.rrNvReadable; -//import kafka.FailedToSendMessageException; + //import kafka.javaapi.producer.Producer; //import kafka.producer.KeyedMessage; //import kafka.producer.ProducerConfig; @@ -76,25 +76,23 @@ public class KafkaPublisher implements Publisher { kafkaConnUrl="localhost:9092"; } - //String jaaspath="C:/ATT/Apps/dmaapCodedmaap-framework/dmaap/bundleconfig-local/etc/appprops/kafka_pub_jaas.conf"; + // props.put("bootstrap.servers", bootSever); //System.setProperty("java.security.auth.login.config",jaaspath); - /*transferSetting( props, "sasl.jaas.config", "org.apache.kafka.common.security.plain.PlainLoginModule required username='admin' password='admin_secret';"); - transferSetting( props, "security.protocol", "SASL_PLAINTEXT"); - transferSetting( props, "sasl.mechanism", "PLAIN");*/ + transferSetting( props, "bootstrap.servers",kafkaConnUrl); - //transferSetting( props, "metadata.broker.list", kafkaConnUrl); + transferSetting( props, "request.required.acks", "1"); transferSetting( props, "message.send.max.retries", "5"); transferSetting(props, "retry.backoff.ms", "150"); - //props.put("serializer.class", "kafka.serializer.StringEncoder"); + props.put("key.serializer", "org.apache.kafka.common.serialization.StringSerializer"); props.put("value.serializer", "org.apache.kafka.common.serialization.StringSerializer"); - //fConfig = new ProducerConfig(props); + //fProducer = new Producer<String, String>(fConfig); fProducer = new KafkaProducer<>(props); } @@ -184,7 +182,7 @@ try{ for (message o : msgs) { final ProducerRecord<String, String> data = new ProducerRecord<String, String>(topic, o.getKey(), o.toString()); - //kms.add(data); + try { @@ -200,7 +198,7 @@ try{ } //private final rrNvReadable fSettings; - //private ProducerConfig fConfig; + private Producer<String, String> fProducer; /** @@ -227,9 +225,5 @@ try{ } - //@Override - //public void sendBatchMessage(String topic, ArrayList<KeyedMessage<String, String>> kms) throws IOException { - // TODO Auto-generated method stub - - //} + }
\ No newline at end of file |