summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSurendra Reddy Katam <SK00524980@techmahindra.com>2018-09-10 15:24:44 +0530
committerSurendra Reddy Katam <SK00524980@techmahindra.com>2018-09-10 15:24:44 +0530
commitef5fa212032f5aef7891ad87e41ee086f4501522 (patch)
tree9bab39b45aa6089edbf0abd4463450f08c3dd553
parent4482915cb339579c2680ea1991b8680e89d521c1 (diff)
Sonar Major issues
This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false&severities=MAJOR Location: src/main/java/com/att/dmf/mr/service/impl/TopicServiceImpl.java Line No- L219 L238 Change-Id: I8101e70e522991ea66dcc0ce142287ee5a5644e8 Issue-ID: DMAAP-759 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
-rw-r--r--src/main/java/com/att/dmf/mr/service/impl/TopicServiceImpl.java38
1 files changed, 19 insertions, 19 deletions
diff --git a/src/main/java/com/att/dmf/mr/service/impl/TopicServiceImpl.java b/src/main/java/com/att/dmf/mr/service/impl/TopicServiceImpl.java
index 6f041f1..42a7089 100644
--- a/src/main/java/com/att/dmf/mr/service/impl/TopicServiceImpl.java
+++ b/src/main/java/com/att/dmf/mr/service/impl/TopicServiceImpl.java
@@ -216,17 +216,17 @@ public class TopicServiceImpl implements TopicService {
// (null==dmaapContext.getRequest().getHeader("Authorization") && null
- /*else if (user == null && null == dmaapContext.getRequest().getHeader("Authorization")
- ) {
- LOGGER.error("Failed to create topic" + topicBean.getTopicName() + ", Authentication failed.");
+
+
+
- ErrorResponse errRes = new ErrorResponse(HttpStatus.SC_UNAUTHORIZED,
- DMaaPResponseCode.ACCESS_NOT_PERMITTED.getResponseCode(),
- "Failed to create topic: Access Denied.User does not have permission to perform create topic");
+
+
+
- LOGGER.info(errRes.toString());
- // throw new DMaaPAccessDeniedException(errRes);
- }*/
+
+
+
if (user == null /*&& (null != dmaapContext.getRequest().getHeader("Authorization")
)*/) {
@@ -235,20 +235,20 @@ public class TopicServiceImpl implements TopicService {
// ACL authentication is not provided so we will use the aaf
// authentication
- /*LOGGER.info("Authorization the topic");
+
- String permission = "";
- String nameSpace = "";
- if (topicBean.getTopicName().indexOf(".") > 1)
- nameSpace = topicBean.getTopicName().substring(0, topicBean.getTopicName().lastIndexOf("."));
+
+
+
+
- String mrFactoryVal = AJSCPropertiesMap.getProperty(CambriaConstants.msgRtr_prop,
- "msgRtr.topicfactory.aaf");
+
+
- // AJSCPropertiesMap.getProperty(CambriaConstants.msgRtr_prop,kSettings_KafkaZookeeper);
+
- permission = mrFactoryVal + nameSpace + "|create";
- DMaaPAAFAuthenticator aaf = new DMaaPAAFAuthenticatorImpl();*/
+
+
if (false) {