diff options
| author |   sliard <samuel.liard@gmail.com> | 2021-04-07 17:28:50 +0200 |
|---|---|---|
| committer | sliard <samuel.liard@gmail.com> | 2021-04-12 16:02:59 +0200 |
| commit | 78ebc9a64fac6231e3e594200b9335a4c6372ed1 (patch) | |
| tree | 4e48966a35f6cceaac4c00b705e640830e34c634 /src/main/java/org/onap/dmaap/mr/client/impl/MRBatchPublisher.java | |
| parent | 8a00d4324ea7621df1a1febb8936df2807cbc443 (diff) | |
First sonar issues review
Issue-ID: DMAAP-1585
Change-Id: I5dc4d3d4cab75f5fabcc8d4f351eac4d3ea50d17
Signed-off-by: sliard <samuel.liard@gmail.com>
Diffstat (limited to 'src/main/java/org/onap/dmaap/mr/client/impl/MRBatchPublisher.java')
| -rw-r--r-- | src/main/java/org/onap/dmaap/mr/client/impl/MRBatchPublisher.java | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/src/main/java/org/onap/dmaap/mr/client/impl/MRBatchPublisher.java b/src/main/java/org/onap/dmaap/mr/client/impl/MRBatchPublisher.java index bcd4403..5c7259c 100644 --- a/src/main/java/org/onap/dmaap/mr/client/impl/MRBatchPublisher.java +++ b/src/main/java/org/onap/dmaap/mr/client/impl/MRBatchPublisher.java @@ -54,7 +54,7 @@ import org.onap.dmaap.mr.client.response.MRPublisherResponse; @Deprecated public class MRBatchPublisher implements MRBatchingPublisher { - public static final long kMinMaxAgeMs = 1; + public static final long MIN_MAX_AGE_MS = 1; /** * Create a batch publisher. @@ -66,10 +66,10 @@ public class MRBatchPublisher implements MRBatchingPublisher */ public MRBatchPublisher ( Collection<String> baseUrls, String topic, int maxBatchSize, long maxAgeMs, boolean compress ) { - if ( maxAgeMs < kMinMaxAgeMs ) + if ( maxAgeMs < MIN_MAX_AGE_MS) { - fLog.warn ( "Max age in ms is less than the minimum. Overriding to " + kMinMaxAgeMs ); - maxAgeMs = kMinMaxAgeMs; + fLog.warn ( "Max age in ms is less than the minimum. Overriding to " + MIN_MAX_AGE_MS); + maxAgeMs = MIN_MAX_AGE_MS; } try { @@ -279,7 +279,7 @@ public class MRBatchPublisher implements MRBatchingPublisher /** * Called to queue a message. - * @param m + * @param msgs * @throws IOException */ public void queue ( Collection<message> msgs ) throws IOException @@ -364,7 +364,7 @@ public class MRBatchPublisher implements MRBatchingPublisher fLog.warn ( "Send failed, rebuilding send queue." ); // note the time for back-off - fDontSendUntilMs = sfWaitAfterError + System.currentTimeMillis (); + fDontSendUntilMs = SF_WAIT_AFTER_ERROR + System.currentTimeMillis (); // the send failed. reconstruct the pending queue fWriteLock.lock (); @@ -406,7 +406,7 @@ public class MRBatchPublisher implements MRBatchingPublisher private final WriteLock fWriteLock; private final ReadLock fReadLock; private long fDontSendUntilMs; - private static final long sfWaitAfterError = 1000; + private static final long SF_WAIT_AFTER_ERROR = 1000; } // this is static so that it's clearly not using any mutable member data outside of a lock |