diff options
| author |   Ram Koya <rk541m@att.com> | 2018-09-13 14:59:31 +0000 |
|---|---|---|
| committer |   Gerrit Code Review <gerrit@onap.org> | 2018-09-13 14:59:31 +0000 |
| commit | d6c28ce28b8c66fe9784af894cf9385f6d2c8e76 (patch) | |
| tree | d9594385aaa95980005d9cc0076121187fd44f82 /datarouter-prov/src/main | |
| parent | c7708c4957a822b48e14570a0695b6572eb22469 (diff) | |
| parent | ad6e9810549ef2b0d78c235f9ba29d5774ef8582 (diff) | |
Merge "Added fix for string comparison reported in sonar"
Diffstat (limited to 'datarouter-prov/src/main')
| -rw-r--r-- | datarouter-prov/src/main/java/org/onap/dmaap/datarouter/authz/impl/ProvAuthorizer.java | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/authz/impl/ProvAuthorizer.java b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/authz/impl/ProvAuthorizer.java index b7df151c..c76ce42a 100644 --- a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/authz/impl/ProvAuthorizer.java +++ b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/authz/impl/ProvAuthorizer.java @@ -126,21 +126,21 @@ public class ProvAuthorizer implements Authorizer { private boolean allowFeedsCollectionAccess(AuthzResource resource, String method, String subject, String subjectgroup) { // Allow GET or POST unconditionally - return method != null && (method.equalsIgnoreCase("GET") || method.equalsIgnoreCase("POST")); + return method != null && ("GET".equalsIgnoreCase(method) || "POST".equalsIgnoreCase(method)); } private boolean allowSubsCollectionAccess(AuthzResource resource, String method, String subject, String subjectgroup) { // Allow GET or POST unconditionally - return method != null && (method.equalsIgnoreCase("GET") || method.equalsIgnoreCase("POST")); + return method != null && ("GET".equalsIgnoreCase(method) || "POST".equalsIgnoreCase(method)); } private boolean allowFeedAccess(AuthzResource resource, String method, String subject, String subjectgroup) { boolean decision = false; // Allow GET, PUT, or DELETE if requester (subject) is the owner (publisher) of the feed - if ( method != null && (method.equalsIgnoreCase("GET") || method.equalsIgnoreCase("PUT") || - method.equalsIgnoreCase("DELETE"))) { + if ( method != null && ("GET".equalsIgnoreCase(method) || "PUT".equalsIgnoreCase(method) || + "DELETE".equalsIgnoreCase(method))) { String owner = provData.getFeedOwner(resource.getId()); decision = (owner != null) && owner.equals(subject); @@ -159,8 +159,8 @@ public class ProvAuthorizer implements Authorizer { boolean decision = false; // Allow GET, PUT, or DELETE if requester (subject) is the owner of the subscription (subscriber) - if (method != null && (method.equalsIgnoreCase("GET") || method.equalsIgnoreCase("PUT") || - method.equalsIgnoreCase("DELETE") || method.equalsIgnoreCase("POST"))) { + if (method != null && ("GET".equalsIgnoreCase(method) || "PUT".equalsIgnoreCase(method) || + "DELETE".equalsIgnoreCase(method) || "POST".equalsIgnoreCase(method))) { String owner = provData.getSubscriptionOwner(resource.getId()); decision = (owner != null) && owner.equals(subject); |