aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorConor Ward <conor.ward@ericsson.com>2018-09-21 12:29:15 +0000
committerConor Ward <conor.ward@ericsson.com>2018-09-21 12:29:15 +0000
commitbc6df0d31264c1cebb895dbb09c6bdefd435c044 (patch)
treea09d90fef6d8e09ae00a30aa9bfd439763a0529d
parent46ef61c0fe477483be17dbf9af2ef3b1023da0d8 (diff)
Fix BaseServlet Vulnerabilities
Change-Id: I385b591e0725d3e356d986e2950259d88ec48dc5 Signed-off-by: Conor Ward <conor.ward@ericsson.com> Issue-ID: DMAAP-775
-rwxr-xr-xdatarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/BaseServlet.java10
1 files changed, 3 insertions, 7 deletions
diff --git a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/BaseServlet.java b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/BaseServlet.java
index 3838cadf..be87e133 100755
--- a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/BaseServlet.java
+++ b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/BaseServlet.java
@@ -535,7 +535,6 @@ public class BaseServlet extends HttpServlet implements ProvDataProvider {
mailprops.load(inStream);
} catch (IOException e) {
intlogger.fatal("PROV9003 Opening properties: " + e.getMessage());
- e.printStackTrace();
System.exit(1);
} finally {
try {
@@ -560,7 +559,7 @@ public class BaseServlet extends HttpServlet implements ProvDataProvider {
try {
notifyPSTeam(p.get("org.onap.dmaap.datarouter.provserver.https.relax.notify").toString());
} catch (Exception e) {
- e.printStackTrace();
+ intlogger.warn("Exception: " + e.getMessage());
}
}
mailSendFlag = true;
@@ -697,7 +696,6 @@ public class BaseServlet extends HttpServlet implements ProvDataProvider {
} catch (SQLException e) {
rv = false;
intlogger.warn("PROV0005 doInsert: " + e.getMessage());
- e.printStackTrace();
} finally {
if (conn != null) {
db.release(conn);
@@ -722,7 +720,6 @@ public class BaseServlet extends HttpServlet implements ProvDataProvider {
} catch (SQLException e) {
rv = false;
intlogger.warn("PROV0006 doUpdate: " + e.getMessage());
- e.printStackTrace();
} finally {
if (conn != null) {
db.release(conn);
@@ -747,7 +744,6 @@ public class BaseServlet extends HttpServlet implements ProvDataProvider {
} catch (SQLException e) {
rv = false;
intlogger.warn("PROV0007 doDelete: " + e.getMessage());
- e.printStackTrace();
} finally {
if (conn != null) {
db.release(conn);
@@ -910,7 +906,7 @@ public class BaseServlet extends HttpServlet implements ProvDataProvider {
return true;
}
} catch (JSONException e) {
- e.printStackTrace();
+ intlogger.error("JSONException: " + e.getMessage());
}
}
return false;
@@ -980,7 +976,7 @@ public class BaseServlet extends HttpServlet implements ProvDataProvider {
MDC.put(MDC_SERVER_FQDN, InetAddress.getLocalHost().getHostName());
MDC.put(MDC_SERVER_IP_ADDRESS, InetAddress.getLocalHost().getHostAddress());
} catch (Exception e) {
- e.printStackTrace();
+ intlogger.error("Exception: " + e.getMessage());
}
}