1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
|
/*-
* ============LICENSE_START=======================================================
* org.onap.dmaap
* ================================================================================
* Copyright (C) 2019 Nokia Intellectual Property. All rights reserved.
* ================================================================================
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
* ============LICENSE_END=========================================================
*/
package org.onap.dmaap.dbcapi.resources;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.mockito.Matchers.anyString;
import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import java.io.PrintWriter;
import java.io.StringWriter;
import javax.servlet.FilterChain;
import javax.servlet.FilterConfig;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.ExpectedException;
import org.junit.runner.RunWith;
import org.mockito.Mock;
import org.mockito.Spy;
import org.mockito.runners.MockitoJUnitRunner;
import org.onap.aaf.cadi.filter.CadiFilter;
import org.onap.dmaap.dbcapi.util.DmaapConfig;
@RunWith(MockitoJUnitRunner.class)
public class AAFAuthenticationFilterTest {
@Spy
private AAFAuthenticationFilter filter;
@Mock
private FilterConfig filterConfig;
@Mock
private CadiFilter cadiFilterMock;
@Mock
private HttpServletRequest servletRequest;
@Mock
private HttpServletResponse servletResponse;
@Mock
private FilterChain filterChain;
@Mock
private DmaapConfig dmaapConfig;
@Rule
public ExpectedException thrown = ExpectedException.none();
@Before
public void setUp() throws Exception {
doReturn(dmaapConfig).when(filter).getConfig();
}
@Test
public void init_shouldNotInitializeCADI_whenAafIsNotUsed() throws Exception {
//given
doReturn("false").when(dmaapConfig).getProperty(eq(AAFAuthenticationFilter.CADI_AUTHN_FLAG), anyString());
//when
filter.init(filterConfig);
//then
assertFalse(filter.isCadiEnabled());
assertNull(filter.getCadiFilter());
}
@Test
public void doFilter_shouldSkipCADI_whenAafIsNotUsed() throws Exception {
//given
doReturn("false").when(dmaapConfig).getProperty(eq(AAFAuthenticationFilter.CADI_AUTHN_FLAG), anyString());
filter.init(filterConfig);
filter.setCadiFilter(cadiFilterMock);
//when
filter.doFilter(servletRequest, servletResponse, filterChain);
//then
verify(filterChain).doFilter(servletRequest,servletResponse);
verifyZeroInteractions(cadiFilterMock,servletRequest,servletResponse);
}
@Test
public void init_shouldFail_whenAafIsUsed_andCadiPropertiesHasNotBeenSet() throws Exception {
//given
doReturn("true").when(dmaapConfig).getProperty(eq(AAFAuthenticationFilter.CADI_AUTHN_FLAG), anyString());
doReturn("").when(dmaapConfig).getProperty(AAFAuthenticationFilter.CADI_PROPERTIES);
//then
thrown.expect(ServletException.class);
thrown.expectMessage("Cannot initialize CADI filter.CADI properties not available.");
//when
filter.init(filterConfig);
}
@Test
public void init_shouldFail_whenAafIsUsed_andInvalidCadiPropertiesSet() throws Exception {
//given
String invalidFilePath = "src/test/resources/notExisting.properties";
doReturn("true").when(dmaapConfig).getProperty(eq(AAFAuthenticationFilter.CADI_AUTHN_FLAG), anyString());
doReturn(invalidFilePath).when(dmaapConfig).getProperty(AAFAuthenticationFilter.CADI_PROPERTIES);
//then
thrown.expect(ServletException.class);
thrown.expectMessage("Could not load CADI properties file: "+invalidFilePath);
//when
filter.init(filterConfig);
}
/*
* See https://jira.onap.org/browse/DMAAP-1361 for why this is commented out
@Test
public void init_shouldInitializeCADI_whenAafIsUsed_andValidCadiPropertiesSet() throws Exception {
//given
doReturn("true").when(dmaapConfig).getProperty(eq(AAFAuthenticationFilter.CADI_AUTHN_FLAG), anyString());
doReturn("src/test/resources/cadi.properties").when(dmaapConfig).getProperty(AAFAuthenticationFilter.CADI_PROPERTIES);
//when
filter.init(filterConfig);
//then
assertTrue(filter.isCadiEnabled());
assertNotNull(filter.getCadiFilter());
}
@Test
public void doFilter_shouldUseCADIfilter_andAuthenticateUser_whenAAFisUsed_andUserIsValid() throws Exception{
//given
initCADIFilter();
doReturn(200).when(servletResponse).getStatus();
//when
filter.doFilter(servletRequest,servletResponse,filterChain);
//then
verify(cadiFilterMock).doFilter(servletRequest,servletResponse,filterChain);
verify(servletResponse).getStatus();
verifyNoMoreInteractions(servletResponse);
verifyZeroInteractions(filterChain, servletRequest);
}
@Test
public void doFilter_shouldUseCADIfilter_andReturnAuthenticationError_whenAAFisUsed_andUserInvalid() throws Exception{
//given
String errorResponseJson = "{\"code\":401,\"message\":\"invalid or no credentials provided\",\"fields\":\"Authentication\",\"2xx\":false}";
initCADIFilter();
doReturn(401).when(servletResponse).getStatus();
StringWriter sw = new StringWriter();
PrintWriter pw = new PrintWriter(sw);
doReturn(pw).when(servletResponse).getWriter();
//when
filter.doFilter(servletRequest,servletResponse,filterChain);
//then
verify(cadiFilterMock).doFilter(servletRequest,servletResponse,filterChain);
verify(servletResponse).getStatus();
verify(servletResponse).setContentType("application/json");
verifyZeroInteractions(filterChain, servletRequest);
assertEquals(errorResponseJson, sw.toString());
}
private void initCADIFilter() throws Exception{
doReturn("true").when(dmaapConfig).getProperty(eq(AAFAuthenticationFilter.CADI_AUTHN_FLAG), anyString());
doReturn("src/test/resources/cadi.properties").when(dmaapConfig).getProperty(AAFAuthenticationFilter.CADI_PROPERTIES);
filter.init(filterConfig);
filter.setCadiFilter(cadiFilterMock);
}
*/
}
|
