diff options
| author |   Rajamohan Raj <rajamohan.raj@intel.com> | 2019-10-31 23:51:29 +0000 |
|---|---|---|
| committer |   Marco Platania <platania@research.att.com> | 2019-11-04 14:02:09 +0000 |
| commit | 68d118176bb53c36b31a7060cfa16ad5acac1765 (patch) | |
| tree | c6dfd74445126f24e8d63457e33720fc5e0d38bb /vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/skaffold.yaml | |
| parent | 68042495ef1e1e6dff7fed7fc2691b01cf672fe1 (diff) | |
HDFS-WriterApp-Fixed all the code review comments
Fixed all the code review comments by Kiran
1. Implemented a boolean channel instead of empty struct channel for signal, use WaitGroup
to ensure all writers finish cleanup.
2. Introduce JSON tags for configs
4. remove all panic and fatalf code to ensure that the app doesnt crash anytime.
5. remove unneccessary hdfsWriter null checks.
6.remove the 'run' variable used in the infinite loop, replaced with 'return'
Issue-ID: ONAPARC-453
Change-Id: Ic77c59dc75a8898a3cf34999850e6687d40e7faa
Signed-off-by: Rajamohan Raj <rajamohan.raj@intel.com>
Diffstat (limited to 'vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/skaffold.yaml')
| -rw-r--r-- | vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/skaffold.yaml | 20 |
1 files changed, 8 insertions, 12 deletions
diff --git a/vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/skaffold.yaml b/vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/skaffold.yaml index c207967f..22e173f9 100644 --- a/vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/skaffold.yaml +++ b/vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/skaffold.yaml @@ -1,19 +1,15 @@ -apiVersion: skaffold/v1beta6 +apiVersion: skaffold/v1beta13 kind: Config build: + artifacts: + - image: hdfs-writer tagPolicy: sha256: {} - artifacts: - - context: . - image: hdfs-writer - local: - useBuildkit: false - useDockerCLI: false deploy: kubectl: manifests: - - kubernetes-manifests/** -profiles: - - name: cloudbuild - build: - googleCloudBuild: {} + - kubernetes-manifests/configmap_hdfs.yaml + - kubernetes-manifests/configmap_kafka.yaml + - kubernetes-manifests/configmap_writer.yaml + - kubernetes-manifests/hdfs_writer_deployment.yaml + - kubernetes-manifests/hdfs_writer_service.yaml |