diff options
| author |   Rajamohan Raj <rajamohan.raj@intel.com> | 2019-10-31 23:51:29 +0000 |
|---|---|---|
| committer |   Marco Platania <platania@research.att.com> | 2019-11-04 14:02:09 +0000 |
| commit | 68d118176bb53c36b31a7060cfa16ad5acac1765 (patch) | |
| tree | c6dfd74445126f24e8d63457e33720fc5e0d38bb /vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/Dockerfile | |
| parent | 68042495ef1e1e6dff7fed7fc2691b01cf672fe1 (diff) | |
HDFS-WriterApp-Fixed all the code review comments
Fixed all the code review comments by Kiran
1. Implemented a boolean channel instead of empty struct channel for signal, use WaitGroup
to ensure all writers finish cleanup.
2. Introduce JSON tags for configs
4. remove all panic and fatalf code to ensure that the app doesnt crash anytime.
5. remove unneccessary hdfsWriter null checks.
6.remove the 'run' variable used in the infinite loop, replaced with 'return'
Issue-ID: ONAPARC-453
Change-Id: Ic77c59dc75a8898a3cf34999850e6687d40e7faa
Signed-off-by: Rajamohan Raj <rajamohan.raj@intel.com>
Diffstat (limited to 'vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/Dockerfile')
| -rw-r--r-- | vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/Dockerfile | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/Dockerfile b/vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/Dockerfile index ee476717..dd2b475d 100644 --- a/vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/Dockerfile +++ b/vnfs/DAaaS/microservices/GoApps/src/go-hdfs-writer/Dockerfile @@ -7,7 +7,7 @@ RUN go get -u github.com/go-delve/delve/cmd/dlv WORKDIR /src/hdfs-writer RUN mkdir /librdkafka-dir && cd /librdkafka-dir -RUN git clone https://github.com/edenhill/librdkafka.git && \ +RUN git clone https://github.com/edenhill/librdkafka.git && \ cd librdkafka && \ ./configure --prefix /usr && \ make && \ |