Add XML validation

Issue-ID: DCAEGEN2-1217
Change-Id: Ic76885ab1c8e020a2bded05a264092684a747461
Signed-off-by: JoeOLeary <joseph.o.leary@est.tech>

4 files changed, 120 insertions, 3 deletions

diff --git a/src/test/java/org/onap/dcaegen2/services/pmmapper/utils/XMLValidatorTest.java b/src/test/java/org/onap/dcaegen2/services/pmmapper/utils/XMLValidatorTest.java
new file mode 100644
index 0000000..aca0fe6
--- /dev/null
+++ b/src/test/java/org/onap/dcaegen2/services/pmmapper/utils/XMLValidatorTest.java
@@ -0,0 +1,87 @@
+/*-
+ * ============LICENSE_START=======================================================
+ *  Copyright (C) 2019 Nordix Foundation.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.dcaegen2.services.pmmapper.utils;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import java.io.IOException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.List;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.MethodSource;
+import org.mockito.junit.jupiter.MockitoExtension;
+import org.onap.dcaegen2.services.pmmapper.model.Event;
+import utils.EventUtils;
+
+
+@ExtendWith(MockitoExtension.class)
+class XMLValidatorTest {
+    private static final Path metadata = Paths.get("src/test/resources/valid_metadata.json");
+    private static final Path dataDirectory = Paths.get("src/test/resources/xml_validator_test/test_data/");
+    private static final Path xsd = Paths.get("src/main/resources/measCollec_plusString.xsd");
+    private XMLValidator objUnderTest;
+
+    @BeforeEach
+    void setup() {
+        objUnderTest = new XMLValidator(xsd);
+    }
+
+    @Test
+    void testBadSchema() {
+        assertThrows(IllegalArgumentException.class, () ->
+                new XMLValidator(Paths.get("src/test/resources/mapping_data/valid_data/meas_type_and_r.xml")));
+    }
+
+    @Test
+    void testNullInput() {
+        assertThrows(NullPointerException.class, () -> objUnderTest.validate(null));
+    }
+
+    @ParameterizedTest
+    @MethodSource("getValidEvents")
+    void testValidEventsPass(Event testEvent) {
+        assertTrue(objUnderTest.validate(testEvent));
+    }
+
+    @ParameterizedTest
+    @MethodSource("getInvalidEvents")
+    void testInvalidEventsFail(Event testEvent) {
+        assertFalse(objUnderTest.validate(testEvent));
+    }
+
+    private static List<Event> getValidEvents() throws IOException {
+        Path validDataDirectory = Paths.get(dataDirectory.toString() + "/valid/");
+        return EventUtils.eventsFromDirectory(validDataDirectory, metadata);
+    }
+
+    private static List<Event> getInvalidEvents() throws IOException {
+        Path invalidDataDirectory = Paths.get(dataDirectory.toString() + "/invalid/");
+        return EventUtils.eventsFromDirectory(invalidDataDirectory, metadata);
+    }
+
+}
diff --git a/src/test/java/utils/EventUtils.java b/src/test/java/utils/EventUtils.java
index b265f1d..90317c2 100644
--- a/src/test/java/utils/EventUtils.java
+++ b/src/test/java/utils/EventUtils.java
@@ -31,19 +31,17 @@ import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.HashMap;
 import java.util.List;
-import java.util.Map;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
 import org.onap.dcaegen2.services.pmmapper.model.Event;
 import org.onap.dcaegen2.services.pmmapper.model.EventMetadata;
-import org.slf4j.MDC;
 
 public class EventUtils {
 
 
     /**
-     * reads contents of files inside the eventBodyDirectory, combines contents with metadata to make an Event Object.
+     * Reads contents of files inside the eventBodyDirectory, combines contents with metadata to make an Event Object.
      * Fails test in the event of failure to read a file.
      * @param eventBodyDirectory Path to directory with event body files.
      * @param metadataPath Path to file with metadata object.
diff --git a/src/test/resources/xml_validator_test/test_data/invalid/no_file_header.xml b/src/test/resources/xml_validator_test/test_data/invalid/no_file_header.xml
new file mode 100644
index 0000000..8e5669f
--- /dev/null
+++ b/src/test/resources/xml_validator_test/test_data/invalid/no_file_header.xml
@@ -0,0 +1,22 @@
+<measCollecFile xmlns="http://www.3gpp.org/ftp/specs/archive/32_series/32.435#measCollec">
+    <measData>
+        <managedElement swVersion="r0.1" localDn="Dublin"/>
+        <measInfo measInfoId="some meas info id">
+            <job jobId="some jobId"/>
+            <granPeriod endTime="2018-10-02T12:15:00Z" duration="PT900S"/>
+            <repPeriod duration="PT900S"/>
+            <measType p="1">a</measType>
+            <measType p="2">b</measType>
+            <measType p="3">c</measType>
+            <measValue measObjLdn="some measObjLdn">
+                <r p="1">86</r>
+                <r p="2">67</r>
+                <r p="3">14</r>
+                <suspect>false</suspect>
+            </measValue>
+        </measInfo>
+    </measData>
+    <fileFooter>
+        <measCollec endTime="2018-10-02T12:15:00+01:00"/>
+    </fileFooter>
+</measCollecFile>
diff --git a/src/test/resources/xml_validator_test/test_data/valid/no_measdata.xml b/src/test/resources/xml_validator_test/test_data/valid/no_measdata.xml
new file mode 100644
index 0000000..5b8eb5a
--- /dev/null
+++ b/src/test/resources/xml_validator_test/test_data/valid/no_measdata.xml
@@ -0,0 +1,10 @@
+<measCollecFile xmlns="http://www.3gpp.org/ftp/specs/archive/32_series/32.435#measCollec">
+    <fileHeader dnPrefix="some dnPrefix" vendorName="FooBar Ltd"
+                fileFormatVersion="32.435 V10.0">
+        <fileSender localDn="Dublin"/>
+        <measCollec beginTime="2018-10-02T12:00:00+01:00"/>
+    </fileHeader>
+    <fileFooter>
+        <measCollec endTime="2018-10-02T12:15:00+01:00"/>
+    </fileFooter>
+</measCollecFile>