Heartbeat code refactoring

code optimization & test improvement

Issue-ID: DCAEGEN2-2953
Signed-off-by: Vijay Venkatesh Kumar <vv770d@att.com>
Change-Id: I99229d966c13ad666ac994ab5a582aeeaa306639
Signed-off-by: Vijay Venkatesh Kumar <vv770d@att.com>

1 files changed, 63 insertions, 0 deletions

diff --git a/tests/test_htbt_runtime_pid.py b/tests/test_htbt_runtime_pid.py
new file mode 100644
index 0000000..96379d9
--- /dev/null
+++ b/tests/test_htbt_runtime_pid.py
@@ -0,0 +1,63 @@
+# ============LICENSE_START=======================================================
+# Copyright (c) 2017-2023 AT&T Intellectual Property. All rights reserved.
+# Copyright (c) 2019 Pantheon.tech. All rights reserved.
+# Copyright (c) 2021 Fujitsu Ltd.
+# ================================================================================
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ============LICENSE_END=========================================================
+
+import unittest
+from miss_htbt_service.mod import htbt_runtime_pid
+
+
+class test_save_pid(unittest.TestCase):
+    """
+    Test the save_pid mod
+    """
+
+    def test_correct_usage(self):
+        """
+        Test that attempt to create pid file in standard location works
+        """
+        result = htbt_runtime_pid.save_pid("/tmp/snmptrap_test_pid_file")
+        self.assertEqual(result, True)
+
+    def test_missing_directory(self):
+        """
+        Test that attempt to create pid file in missing dir fails
+        """
+        result = htbt_runtime_pid.save_pid("/bogus/directory/for/snmptrap_test_pid_file")
+        self.assertEqual(result, False)
+
+
+class test_rm_pid(unittest.TestCase):
+    """
+    Test the rm_pid mod
+    """
+
+    def test_correct_usage(self):
+        """
+        Test that attempt to remove pid file in standard location works
+        """
+        # must create it before removing it
+        result = htbt_runtime_pid.save_pid("/tmp/snmptrap_test_pid_file")
+        self.assertEqual(result, True)
+        result = htbt_runtime_pid.rm_pid("/tmp/snmptrap_test_pid_file")
+        self.assertEqual(result, True)
+
+    def test_missing_file(self):
+        """
+        Test that attempt to rm non-existent pid file fails
+        """
+        result = htbt_runtime_pid.rm_pid("/tmp/snmptrap_test_pid_file_9999")
+        self.assertEqual(result, False)