1 files changed, 154 insertions, 113 deletions
diff --git a/components/datalake-handler/feeder/src/test/java/org/onap/datalake/feeder/controller/TopicControllerTest.java b/components/datalake-handler/feeder/src/test/java/org/onap/datalake/feeder/controller/TopicControllerTest.java
index 988010ec..17107120 100644
--- a/components/datalake-handler/feeder/src/test/java/org/onap/datalake/feeder/controller/TopicControllerTest.java
+++ b/components/datalake-handler/feeder/src/test/java/org/onap/datalake/feeder/controller/TopicControllerTest.java
@@ -3,6 +3,7 @@
  * ONAP : DATALAKE
  * ================================================================================
  * Copyright (C) 2018-2019 Huawei. All rights reserved.
+ * Copyright (C) 2022 Wipro Limited.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -27,145 +28,185 @@ import org.mockito.Mock;
 import org.mockito.junit.MockitoJUnitRunner;
 import org.onap.datalake.feeder.config.ApplicationConfiguration;
 import org.onap.datalake.feeder.controller.domain.PostReturnBody;
+import org.onap.datalake.feeder.domain.Kafka;
 import org.onap.datalake.feeder.domain.Topic;
 import org.onap.datalake.feeder.dto.TopicConfig;
+import org.onap.datalake.feeder.repository.KafkaRepository;
 import org.onap.datalake.feeder.repository.TopicNameRepository;
 import org.onap.datalake.feeder.repository.TopicRepository;
 import org.onap.datalake.feeder.service.DbService;
 import org.onap.datalake.feeder.service.DmaapService;
 import org.onap.datalake.feeder.service.TopicService;
 import org.onap.datalake.feeder.util.TestUtil;
+import org.springframework.context.ApplicationContext;
 import org.springframework.validation.BindingResult;
 
 import javax.servlet.http.HttpServletResponse;
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Optional;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNull;
+import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
 @RunWith(MockitoJUnitRunner.class)
 public class TopicControllerTest {
 
-	static String DEFAULT_TOPIC_NAME = "_DL_DEFAULT_";
+    static String DEFAULT_TOPIC_NAME = "_DL_DEFAULT_";
 
-	@Mock
-	private HttpServletResponse httpServletResponse;
+    @Mock
+    private HttpServletResponse httpServletResponse;
 
-	@Mock
-	private BindingResult mockBindingResult;
+    @Mock
+    private BindingResult mockBindingResult;
 
-	@Mock
-	private TopicRepository topicRepository;
+    @Mock
+    private TopicRepository topicRepository;
 
-	@Mock
-	private TopicService topicService;
+    @Mock
+    private TopicService topicService;
 
-	@Mock
-	private TopicNameRepository topicNameRepository;
+    @Mock
+    private TopicNameRepository topicNameRepository;
+
+    @Mock
+    private KafkaRepository kafkaRepository;
+
+    @InjectMocks
+    TopicController topicController;
+
+    @Mock
+    private ApplicationConfiguration config;
+
+    @Mock
+    private ApplicationContext context;
+
+    @Mock
+    private DbService dbService;
+
+    @Mock
+    private DmaapService dmaapService;
+
+    @Before
+    public void setupTest() throws NoSuchFieldException, IllegalAccessException {
+        // While the default boolean return value for a mock is 'false',
+        // it's good to be explicit anyway:
+        when(mockBindingResult.hasErrors()).thenReturn(false);
+    }
+
+    @Test
+    public void testListTopic() throws IOException, NoSuchFieldException, IllegalAccessException {}
+
+    @Test
+    public void testCreateTopic() throws IOException {
+        Topic a = TestUtil.newTopic("a");
+        a.setId(1);
+        a.setEnabled(true);
+
+        TopicConfig ac = a.getTopicConfig();
+
+        when(topicService.fillTopicConfiguration(ac)).thenReturn(a);
+        PostReturnBody < TopicConfig > postTopic = topicController.createTopic(ac, mockBindingResult, httpServletResponse);
+        assertEquals(postTopic.getStatusCode(), 200);
+
+        when(topicService.fillTopicConfiguration(ac)).thenReturn(a);
+        a.setTtl(0);
+        PostReturnBody < TopicConfig > postTopicConfig = topicController.createTopic(ac, mockBindingResult, httpServletResponse);
+        assertEquals(postTopicConfig.getStatusCode(), 200);
+
+        when(mockBindingResult.hasErrors()).thenReturn(true);
+        PostReturnBody < TopicConfig > topicConfig = topicController.createTopic(ac, mockBindingResult, httpServletResponse);
+        assertEquals(null, topicConfig);
+    }
+
+    @Test
+    public void testUpdateTopic() throws IOException {
+        Topic a = TestUtil.newTopic("a");
+        a.setId(1);
+        a.setEnabled(true);
+
+        TopicConfig ac = a.getTopicConfig();
+
+        when(topicService.getTopic(1)).thenReturn(a);
+        PostReturnBody < TopicConfig > postConfig1 = topicController.updateTopic(1, ac, mockBindingResult, httpServletResponse);
+        assertEquals(200, postConfig1.getStatusCode());
+        TopicConfig ret = postConfig1.getReturnBody();
+        assertEquals("a", ret.getName());
+        assertEquals(true, ret.isEnabled());
+
+        topicController.updateTopic(0, ac, mockBindingResult, httpServletResponse);
+
+        when(topicService.getTopic(1)).thenReturn(null);
+        topicController.updateTopic(1, ac, mockBindingResult, httpServletResponse);
+
+        when(mockBindingResult.hasErrors()).thenReturn(true);
+        PostReturnBody < TopicConfig > postConfig2 = topicController.updateTopic(1, ac, mockBindingResult, httpServletResponse);
+        assertNull(postConfig2);
+
+    }
+
+    @Test
+    public void testGetTopic() throws IOException {
+        Topic a = TestUtil.newTopic("a");
+        a.setId(1);
+        a.setEnabled(true);
+
+        when(topicService.getTopic(1)).thenReturn(a);
+        TopicConfig ac = topicController.getTopic(1, httpServletResponse);
+        when(topicService.getTopic(1)).thenReturn(null);
+        ac = topicController.getTopic(1, httpServletResponse);
+    }
+
+    @Test
+    public void testDeleteTopic() throws IOException {
+        Topic a = TestUtil.newTopic("a");
+        a.setId(1);
+        a.setEnabled(true);
+
+        when(topicService.getTopic(1)).thenReturn(a);
+        topicController.deleteTopic(1, httpServletResponse);
+        when(topicService.getTopic(1)).thenReturn(null);
+        topicController.deleteTopic(1, httpServletResponse);
+    }
+
+    @Test
+    public void testList() {
+        ArrayList < Topic > topics = new ArrayList < > ();
+        topics.add(TestUtil.newTopic("a"));
+        topics.add(TestUtil.newTopic(DEFAULT_TOPIC_NAME));
+        when(topicRepository.findAll()).thenReturn(topics);
+
+        List < Integer > ids = topicController.list();
+        for (Integer topic: ids) {
+            System.out.println(topic);
+        }
+    }
+
+    @Test
+    public void testGetDefaultConfigNull() throws IOException {
+        Topic topic = null;
+        when(topicService.getDefaultTopicFromFeeder()).thenReturn(topic);
+        assertEquals(null, topicController.getDefaultConfig(httpServletResponse));
+    }
+
+    @Test
+    public void testGetDefaultConfig() throws IOException {
+        Topic topic = TestUtil.newTopic(DEFAULT_TOPIC_NAME);
+        when(topicService.getDefaultTopicFromFeeder()).thenReturn(topic);
+        assertEquals(topic.getName(), topicController.getDefaultConfig(httpServletResponse).getName());
+    }
+
+    @Test
+    public void testListDmaapTopics() {
+        Kafka kafka = TestUtil.newKafka("test");
+        when(kafkaRepository.findById(1)).thenReturn(Optional.of(kafka));
+        DmaapService dmaapService = mock(DmaapService.class);
+        when(context.getBean(DmaapService.class, kafka)).thenReturn(dmaapService);
+        when(dmaapService.getTopics()).thenReturn(null);
+        assertEquals(null, topicController.listDmaapTopics(1));
+    }
 
-	@InjectMocks
-	TopicController topicController;
-
-	@Mock
-	private ApplicationConfiguration config;
-
-	@Mock
-	private DbService dbService;
-
-	@Mock
-	private DmaapService dmaapService;
-
-	@Before
-	public void setupTest() throws NoSuchFieldException, IllegalAccessException {
-		// While the default boolean return value for a mock is 'false',
-		// it's good to be explicit anyway:
-		when(mockBindingResult.hasErrors()).thenReturn(false);
-	}
-
-	@Test
-	public void testListTopic() throws IOException, NoSuchFieldException, IllegalAccessException {
-	}
-
-	@Test
-	public void testCreateTopic() throws IOException {
-		Topic a = TestUtil.newTopic("a");
-		a.setId(1);
-		a.setEnabled(true);
-
-		TopicConfig ac = a.getTopicConfig();
-
-		when(topicService.fillTopicConfiguration(ac)).thenReturn(a);
-		PostReturnBody<TopicConfig> postTopic = topicController.createTopic(ac, mockBindingResult, httpServletResponse);
-		assertEquals(postTopic.getStatusCode(), 200);
-
-		when(mockBindingResult.hasErrors()).thenReturn(true);
-		PostReturnBody<TopicConfig> topicConfig = topicController.createTopic(ac, mockBindingResult, httpServletResponse);
-		assertEquals(null, topicConfig);
-	}
-
-	@Test
-	public void testUpdateTopic() throws IOException {
-		Topic a = TestUtil.newTopic("a");
-		a.setId(1);
-		a.setEnabled(true);
-
-		TopicConfig ac = a.getTopicConfig();
-
-		when(topicService.getTopic(1)).thenReturn(a);
-		PostReturnBody<TopicConfig> postConfig1 = topicController.updateTopic(1, ac, mockBindingResult, httpServletResponse);
-		assertEquals(200, postConfig1.getStatusCode());
-		TopicConfig ret = postConfig1.getReturnBody();
-		assertEquals("a", ret.getName());
-		assertEquals(true, ret.isEnabled());
-
-		topicController.updateTopic(0, ac, mockBindingResult, httpServletResponse);
-
-		when(topicService.getTopic(1)).thenReturn(null);
-		topicController.updateTopic(1, ac, mockBindingResult, httpServletResponse);
-
-		when(mockBindingResult.hasErrors()).thenReturn(true);
-		PostReturnBody<TopicConfig> postConfig2 = topicController.updateTopic(1, ac, mockBindingResult, httpServletResponse);
-		assertNull(postConfig2);
-
-	}
-
-	@Test
-	public void testGetTopic() throws IOException {
-		Topic a = TestUtil.newTopic("a");
-		a.setId(1);
-		a.setEnabled(true);
-
-		when(topicService.getTopic(1)).thenReturn(a);
-		TopicConfig ac = topicController.getTopic(1, httpServletResponse);
-		when(topicService.getTopic(1)).thenReturn(null);
-		ac = topicController.getTopic(1, httpServletResponse);
-	}
-
-	@Test
-	public void testDeleteTopic() throws IOException {
-		Topic a = TestUtil.newTopic("a");
-		a.setId(1);
-		a.setEnabled(true);
-
-		when(topicService.getTopic(1)).thenReturn(a);
-		topicController.deleteTopic(1, httpServletResponse);
-		when(topicService.getTopic(1)).thenReturn(null);
-		topicController.deleteTopic(1, httpServletResponse);
-	}
-
-	@Test
-	public void testList() {
-		ArrayList<Topic> topics = new ArrayList<>();
-		topics.add(TestUtil.newTopic("a"));
-		topics.add(TestUtil.newTopic(DEFAULT_TOPIC_NAME));
-		when(topicRepository.findAll()).thenReturn(topics);
-
-		List<Integer> ids = topicController.list();
-		for (Integer topic : ids) {
-			System.out.println(topic);
-		}
-	}
 }