3.2.0/5.2.0 - fixed zip folder bug by admzip lib

- external version 3.2.0
- internal version 5.2.0 for code change - no API change

- fixed the zip folder bug when sending the blueprint to cloudify
  = this bug was preventing the opening of the blueprint
    in cloudify UI because the folder record was not properly
    formatted by admzip lib 0.4.7
- upgraded adm-zip lib to the latest version 0.4.13

- unit tested the zipping of the blueprint file under subfolder
  without having the subfolder record in zip
  = manual unzip in linux shows proper subfolder/file structure
  = automatic unzip is not supported by the old ubuntu
  = would need upgrading the node.js/ubuntu and installing unzip
    for proper testing - see code comments in unit-test

- zip file created by admzip unzips properly both in linux
  and in Windows
  = zip still has some header warnings, but not critical

unit test coverage summary
Statements   : 80.94% ( 943/1165 )
Branches     : 58.22% ( 294/505 )
Functions    : 81.28% ( 165/203 )
Lines        : 81.48% ( 933/1145 )

Change-Id: I48e44f025c21ef51de5a7422c8db9433581c787f
Signed-off-by: Alex Shatov <alexs@att.com>
Issue-ID: DCAEGEN2-855

1 files changed, 2 insertions, 3 deletions

diff --git a/lib/cloudify.js b/lib/cloudify.js
index 138b986..1cd5489 100644
--- a/lib/cloudify.js
+++ b/lib/cloudify.js
@@ -1,5 +1,5 @@
 /*
-Copyright(c) 2017-2018 AT&T Intellectual Property. All rights reserved.
+Copyright(c) 2017-2019 AT&T Intellectual Property. All rights reserved.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
@@ -231,8 +231,7 @@ exports.uploadBlueprint = function(req, bpid, blueprint) {
 
     // Cloudify API wants a gzipped tar of a directory, not the blueprint text
     const zip = new admzip();
-    zip.addFile('work/', new Buffer(0));
-    zip.addFile('work/blueprint.yaml', new Buffer(blueprint, 'utf8'));
+    zip.addFile('work/blueprint.yaml', Buffer.from(blueprint, 'utf8'));
     const zip_buffer = zip.toBuffer();
 
     // Set up the HTTP PUT request