fixed 500 "value" argument is out of bounds

- convert the EOL to linux "\n" in the blueprint
   before zipping and sending to cloudify to avoid crashing
   when the blueprint is windows "\r\n" or mac "\r" based
- on catching the exception - log the stack
- added logger.info that replaced the logger.debug
   in a variety of places

- external version 2.1.2, internal version 4.4.2
- unit test code coverage
   Statements   : 84.26% ( 942/1118 )
   Branches       : 64.14% ( 322/502 )
   Functions      : 81.68% ( 156/191 )
   Lines              : 84.32% ( 930/1103 )

Change-Id: I9f5f28ddd5d143ca4903316c9199df7d27682143
Signed-off-by: Alex Shatov <alexs@att.com>
Issue-ID: DCAEGEN2-487

1 files changed, 3 insertions, 1 deletions

diff --git a/lib/dcae-deployments.js b/lib/dcae-deployments.js
index 5d98a69..193f6b9 100644
--- a/lib/dcae-deployments.js
+++ b/lib/dcae-deployments.js
@@ -37,7 +37,7 @@ const inventory = inv({url: config.inventory.url});
 app.use(middleware.checkType('application/json'));		// Validate type
 app.use(bodyParser.json({strict: true}));				// Parse body as JSON
 app.use(function(req, res, next) {
-	log.debug(req.dcaeReqId,
+	log.info(req.dcaeReqId,
 		"new req: " + req.method + " " + req.originalUrl +
 		" from: " + req.ip + " body: " + JSON.stringify(req.body)
 	);
@@ -165,6 +165,7 @@ app.put('/:deploymentId', function(req, res, next) {
 			/* Already sent the response, so just log error */
 			/* Don't remove from inventory, because there is a deployment on CM that might need to be removed */
 			error.message = "Error deploying deploymentId " + req.params['deploymentId'] + ": " + error.message
+						  + " " + (error.stack || "").replace(/\n/g, " ");
 			log.error(error, req);
 			log.audit(req, 500, error.message);
 		}
@@ -212,6 +213,7 @@ app.delete('/:deploymentId', function(req, res, next) {
 		else {
 			/* Error happened after we sent the response--log it */
 			error.message = "Error undeploying deploymentId " + req.params['deploymentId'] + ": " + error.message
+						  + " " + (error.stack || "").replace(/\n/g, " ");
 			log.error(error, req);
 			log.audit(req, 500, error.message);
 		}