diff options
author | Dhrumin Desai <dd303q@att.com> | 2021-09-29 08:34:18 -0400 |
---|---|---|
committer | Dhrumin Desai <dd303q@att.com> | 2021-10-04 21:30:28 -0400 |
commit | a494a322554924f6f9c3d6cc79240f54d3a8da0b (patch) | |
tree | 60477325bd8d86d2fb50965ec47eb6a9bd541e06 /mod2/helm-generator/helmchartgenerator-core/src/main/java/org/onap/dcaegen2/platform/helmchartgenerator/chartbuilder/ChartBuilder.java | |
parent | 0d1b8727a44b0add010b79e495b799e538057d20 (diff) |
Improved helm-generator code to make it more testable and improved code coverage
Issue-ID: DCAEGEN2-2911
Issue-ID: DCAEGEN2-2917
Change-Id: Ifc1f336b627b37a9356a3a72b33fcac18bdaa686
Signed-off-by: Dhrumin Desai <dd303q@att.com>
Diffstat (limited to 'mod2/helm-generator/helmchartgenerator-core/src/main/java/org/onap/dcaegen2/platform/helmchartgenerator/chartbuilder/ChartBuilder.java')
-rw-r--r-- | mod2/helm-generator/helmchartgenerator-core/src/main/java/org/onap/dcaegen2/platform/helmchartgenerator/chartbuilder/ChartBuilder.java | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/mod2/helm-generator/helmchartgenerator-core/src/main/java/org/onap/dcaegen2/platform/helmchartgenerator/chartbuilder/ChartBuilder.java b/mod2/helm-generator/helmchartgenerator-core/src/main/java/org/onap/dcaegen2/platform/helmchartgenerator/chartbuilder/ChartBuilder.java index ac73544..21f5dae 100644 --- a/mod2/helm-generator/helmchartgenerator-core/src/main/java/org/onap/dcaegen2/platform/helmchartgenerator/chartbuilder/ChartBuilder.java +++ b/mod2/helm-generator/helmchartgenerator-core/src/main/java/org/onap/dcaegen2/platform/helmchartgenerator/chartbuilder/ChartBuilder.java @@ -41,14 +41,20 @@ public class ChartBuilder { @Autowired private ChartGenerator chartGenerator; + @Autowired + private ChartTemplateStructureValidator validator; + /** * constructor of ChartBuilder * @param specParser implementation of ComponentSpecParser * @param chartGenerator implementation of ChartGenerator + * @param validator implementation of Chart Template Validator */ - public ChartBuilder(ComponentSpecParser specParser, ChartGenerator chartGenerator) { + public ChartBuilder(ComponentSpecParser specParser, ChartGenerator chartGenerator, + ChartTemplateStructureValidator validator) { this.specParser = specParser; this.chartGenerator = chartGenerator; + this.validator = validator; } /** @@ -61,7 +67,7 @@ public class ChartBuilder { * @throws Exception */ public File build(String specFileLocation, String chartTemplateLocation, String outputLocation, String specSchemaLocation ) throws Exception { - ChartTemplateStructureValidator.validateChartTemplateStructure(chartTemplateLocation); + validator.validateChartTemplateStructure(chartTemplateLocation); ChartInfo chartInfo = specParser.extractChartInfo(specFileLocation, chartTemplateLocation, specSchemaLocation); return chartGenerator.generate(chartTemplateLocation, chartInfo, outputLocation); } |