BpGen refactor Code Quality Issue-ID: DCAEGEN2-2502

Issue-ID: DCAEGEN2-2502
Change-Id: If6e08f0bb88c9039fb27898d50d2645f79175ba4
Signed-off-by: Ravi Mantena <rx908f@att.com>

1 files changed, 11 insertions, 10 deletions

diff --git a/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/QuotationService.java b/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/QuotationService.java
index c79ec56..642a13e 100644
--- a/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/QuotationService.java
+++ b/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/QuotationService.java
@@ -30,22 +30,24 @@ import java.util.LinkedHashMap;
 
 /**
  * @author : Ravi Mantena
- * @date 10/16/2020
- * Application: ONAP - Blueprint Generator
- * Common ONAP Service used by ONAP and DMAAP Blueprint to set Quotations of generated Blueprint
+ * @date 10/16/2020 Application: ONAP - Blueprint Generator Common ONAP Service to set Quotations of
+ * generated Blueprint
  */
-
-
 @Service
 public class QuotationService {
 
-    // Method to add Quotes for String Types
+    /**
+     * Adds Quotes for String Types for generated Blueprint
+     *
+     * @param bp Blueprint
+     * @return
+     */
     public OnapBlueprint setQuotations(OnapBlueprint bp) {
-        for(String s: bp.getInputs().keySet()) {
+        for (String s : bp.getInputs().keySet()) {
             LinkedHashMap<String, Object> temp = bp.getInputs().get(s);
-            if(temp.get("type") == "string") {
+            if (temp.get("type") == "string") {
                 String def = (String) temp.get("default");
-                if(def != null){
+                if (def != null) {
                     def = def.replaceAll("\"$", "").replaceAll("^\"", "");
                 }
                 def = '"' + def + '"';
@@ -55,5 +57,4 @@ public class QuotationService {
         }
         return bp;
     }
-
 }