Fix sonar issues

- Use Map instead of LinkedHashMap when possible
- Rename some constants
- Remove some commented lines
- Add logger
- Other minor improvements and refactor

Issue-ID: DCAEGEN2-2636
Signed-off-by: Joanna Jeremicz <joanna.jeremicz@nokia.com>
Change-Id: I7a03cee453b3d254c4ff0fdf51c60a0ae4a61c42

1 files changed, 3 insertions, 3 deletions

diff --git a/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/QuotationService.java b/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/QuotationService.java
index 642a13e..fef4447 100644
--- a/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/QuotationService.java
+++ b/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/common/QuotationService.java
@@ -4,6 +4,7 @@
  *  *  org.onap.dcae
  *  *  ================================================================================
  *  *  Copyright (c) 2020  AT&T Intellectual Property. All rights reserved.
+ *  *  Copyright (c) 2021 Nokia. All rights reserved.
  *  *  ================================================================================
  *  *  Licensed under the Apache License, Version 2.0 (the "License");
  *  *  you may not use this file except in compliance with the License.
@@ -23,11 +24,10 @@
 
 package org.onap.blueprintgenerator.service.common;
 
+import java.util.Map;
 import org.onap.blueprintgenerator.model.common.OnapBlueprint;
 import org.springframework.stereotype.Service;
 
-import java.util.LinkedHashMap;
-
 /**
  * @author : Ravi Mantena
  * @date 10/16/2020 Application: ONAP - Blueprint Generator Common ONAP Service to set Quotations of
@@ -44,7 +44,7 @@ public class QuotationService {
      */
     public OnapBlueprint setQuotations(OnapBlueprint bp) {
         for (String s : bp.getInputs().keySet()) {
-            LinkedHashMap<String, Object> temp = bp.getInputs().get(s);
+            Map<String, Object> temp = bp.getInputs().get(s);
             if (temp.get("type") == "string") {
                 String def = (String) temp.get("default");
                 if (def != null) {