1 files changed, 129 insertions, 124 deletions
diff --git a/src/test/java/org/onap/dcae/restapi/ApiAuthInterceptionTest.java b/src/test/java/org/onap/dcae/restapi/ApiAuthInterceptionTest.java
index 4398faad..e6d67cf4 100644
--- a/src/test/java/org/onap/dcae/restapi/ApiAuthInterceptionTest.java
+++ b/src/test/java/org/onap/dcae/restapi/ApiAuthInterceptionTest.java
@@ -2,7 +2,7 @@
  * ============LICENSE_START=======================================================
  * org.onap.dcaegen2.collectors.ves
  * ================================================================================
- * Copyright (C) 2018 Nokia. All rights reserved.
+ * Copyright (C) 2018 - 2019 Nokia. All rights reserved.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,18 +20,8 @@
 
 package org.onap.dcae.restapi;
 
-import static org.mockito.Mockito.atLeastOnce;
-import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;
-
 import io.vavr.collection.HashMap;
 import io.vavr.collection.Map;
-import java.io.IOException;
-import java.io.PrintWriter;
-import javax.servlet.FilterChain;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.mockito.InjectMocks;
@@ -45,128 +35,143 @@ import org.springframework.http.HttpStatus;
 import org.springframework.security.test.web.servlet.request.SecurityMockMvcRequestPostProcessors;
 import org.springframework.test.web.servlet.request.MockMvcRequestBuilders;
 
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import java.io.IOException;
+import java.io.PrintWriter;
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
 @RunWith(MockitoJUnitRunner.Silent.class)
 public class ApiAuthInterceptionTest {
-    private static final String USERNAME = "Foo";
-    private static final String PASSWORD = "Bar";
-    private static final Map<String, String> CREDENTIALS = HashMap.of(USERNAME, PASSWORD);
+  private static final String USERNAME = "Foo";
+  private static final String PASSWORD = "Bar";
+  private static final Map<String, String> CREDENTIALS = HashMap.of(USERNAME, PASSWORD);
 
-    @Mock
-    private Logger log;
+  @Mock
+  private Logger log;
 
-    @Mock
-    private ApplicationSettings settings;
+  @Mock
+  private ApplicationSettings settings;
 
-    @Mock
-    private HttpServletResponse response;
+  @Mock
+  private HttpServletResponse response;
 
-    @Mock
-    private FilterChain obj;
+  @Mock
+  private Object obj;
 
-    @Mock
-    private PrintWriter writer;
+  @Mock
+  private PrintWriter writer;
 
-    @InjectMocks
-    private ApiAuthInterceptor sut;
+  @InjectMocks
+  private ApiAuthInterceptor sut;
 
 
-    private HttpServletRequest createEmptyRequest() {
-        return MockMvcRequestBuilders
+  private HttpServletRequest createEmptyRequest() {
+    return MockMvcRequestBuilders
+        .post("")
+        .buildRequest(null);
+  }
+
+  private HttpServletRequest createRequestWithAuthorizationHeader() {
+    return SecurityMockMvcRequestPostProcessors
+        .httpBasic(USERNAME, PASSWORD)
+        .postProcessRequest(
+            MockMvcRequestBuilders
                 .post("")
-                .buildRequest(null);
-    }
-
-    private HttpServletRequest createRequestWithAuthorizationHeader() {
-        return SecurityMockMvcRequestPostProcessors
-                .httpBasic(USERNAME, PASSWORD)
-                .postProcessRequest(
-                        MockMvcRequestBuilders
-                                .post("")
-                                .buildRequest(null));
-    }
-
-    @Test
-    public void shouldSucceedWhenAuthorizationIsDisabled() throws IOException, ServletException {
-        // given
-        final HttpServletRequest request = createEmptyRequest();
-
-        when(settings.authMethod()).thenReturn(AuthMethodType.NO_AUTH.value());
-
-        // when
-        sut.doFilter(request, response, obj);
-
-        // then
-        verify(obj, atLeastOnce()).doFilter(request, response);
-    }
-
-    @Test
-    public void shouldFailDueToEmptyBasicAuthorizationHeader() throws IOException, ServletException {
-        // given
-        final HttpServletRequest request = createEmptyRequest();
-
-        when(settings.authMethod()).thenReturn(AuthMethodType.BASIC_AUTH.value());
-        when(response.getWriter()).thenReturn(writer);
-
-        // when
-        sut.doFilter(request, response, obj);
-
-        // then
-        verify(response).setStatus(HttpStatus.UNAUTHORIZED.value());
-        verify(writer).write(ApiException.UNAUTHORIZED_USER.toJSON().toString());
-    }
-
-    @Test
-    public void shouldFailDueToBasicAuthenticationUserMissingFromSettings()
-        throws IOException, ServletException {
-        // given
-        final HttpServletRequest request = createRequestWithAuthorizationHeader();
-
-        when(settings.authMethod()).thenReturn(AuthMethodType.BASIC_AUTH.value());
-        when(response.getWriter()).thenReturn(writer);
-
-        // when
-        sut.doFilter(request, response, obj);
-
-        // then
-        verify(response).setStatus(HttpStatus.UNAUTHORIZED.value());
-        verify(writer).write(ApiException.UNAUTHORIZED_USER.toJSON().toString());
-    }
-
-    @Test
-    public void shouldSucceed() throws IOException, ServletException {
-        // given
-        final HttpServletRequest request = createRequestWithAuthorizationHeader();
-        when(settings.authMethod()).thenReturn(AuthMethodType.BASIC_AUTH.value());
-        when(settings.validAuthorizationCredentials()).thenReturn(
-            HashMap.of(USERNAME, "$2a$10$BsZkEynNm/93wbAeeZuxJeu6IHRyQl4XReqDg2BtYOFDhUsz20.3G"));
-        when(response.getWriter()).thenReturn(writer);
-
-        // when
-        sut.doFilter(request, response, obj);
-
-        // then
-        verify(obj, atLeastOnce()).doFilter(request, response);
-    }
-
-    @Test
-    public void shouldFailDueToInvalidBasicAuthorizationHeaderValue()
-        throws IOException, ServletException {
-        // given
-        final HttpServletRequest request =
-                MockMvcRequestBuilders
-                        .post("")
-                        .header(HttpHeaders.AUTHORIZATION, "FooBar")
-                        .buildRequest(null);
-
-        when(settings.authMethod()).thenReturn(AuthMethodType.BASIC_AUTH.value());
-        when(settings.validAuthorizationCredentials()).thenReturn(CREDENTIALS);
-        when(response.getWriter()).thenReturn(writer);
-
-        // when
-        sut.doFilter(request, response, obj);
-
-        //then
-        verify(response).setStatus(HttpStatus.UNAUTHORIZED.value());
-        verify(writer).write(ApiException.UNAUTHORIZED_USER.toJSON().toString());
-    }
+                .buildRequest(null));
+  }
+
+  @Test
+  public void shouldSucceedWhenAuthorizationIsDisabled() throws IOException {
+    // given
+    final HttpServletRequest request = createEmptyRequest();
+
+    when(settings.authMethod()).thenReturn(AuthMethodType.NO_AUTH.value());
+
+    // when
+    final boolean isAuthorized = sut.preHandle(request, response, obj);
+
+    // then
+    assertTrue(isAuthorized);
+  }
+
+  @Test
+  public void shouldFailDueToEmptyBasicAuthorizationHeader() throws IOException {
+    // given
+    final HttpServletRequest request = createEmptyRequest();
+
+    when(settings.authMethod()).thenReturn(AuthMethodType.BASIC_AUTH.value());
+    when(response.getWriter()).thenReturn(writer);
+
+    // when
+    final boolean isAuthorized = sut.preHandle(request, response, obj);
+
+
+    // then
+    assertFalse(isAuthorized);
+
+    verify(response).setStatus(HttpStatus.UNAUTHORIZED.value());
+    verify(writer).write(ApiException.UNAUTHORIZED_USER.toJSON().toString());
+  }
+
+  @Test
+  public void shouldFailDueToBasicAuthenticationUserMissingFromSettings() throws IOException {
+    // given
+    final HttpServletRequest request = createRequestWithAuthorizationHeader();
+
+    when(settings.authMethod()).thenReturn(AuthMethodType.BASIC_AUTH.value());
+    when(response.getWriter()).thenReturn(writer);
+
+    // when
+    final boolean isAuthorized = sut.preHandle(request, response, obj);
+
+    // then
+    assertFalse(isAuthorized);
+
+    verify(response).setStatus(HttpStatus.UNAUTHORIZED.value());
+    verify(writer).write(ApiException.UNAUTHORIZED_USER.toJSON().toString());
+  }
+
+  @Test
+  public void shouldSucceed() throws IOException {
+    // given
+    final HttpServletRequest request = createRequestWithAuthorizationHeader();
+    when(settings.authMethod()).thenReturn(AuthMethodType.BASIC_AUTH.value());
+    when(settings.validAuthorizationCredentials()).thenReturn(
+        HashMap.of(USERNAME, "$2a$10$BsZkEynNm/93wbAeeZuxJeu6IHRyQl4XReqDg2BtYOFDhUsz20.3G"));
+    when(response.getWriter()).thenReturn(writer);
+
+    // when
+    final boolean isAuthorized = sut.preHandle(request, response, obj);
+
+    // then
+    assertTrue(isAuthorized);
+  }
+
+  @Test
+  public void shouldFailDueToInvalidBasicAuthorizationHeaderValue() throws IOException {
+    // given
+    final HttpServletRequest request =
+        MockMvcRequestBuilders
+            .post("")
+            .header(HttpHeaders.AUTHORIZATION, "FooBar")
+            .buildRequest(null);
+
+    when(settings.authMethod()).thenReturn(AuthMethodType.BASIC_AUTH.value());
+    when(settings.validAuthorizationCredentials()).thenReturn(CREDENTIALS);
+    when(response.getWriter()).thenReturn(writer);
+
+    // when
+    final boolean isAuthorized = sut.preHandle(request, response, obj);
+
+    // then
+    assertFalse(isAuthorized);
+
+    verify(response).setStatus(HttpStatus.UNAUTHORIZED.value());
+    verify(writer).write(ApiException.UNAUTHORIZED_USER.toJSON().toString());
+  }
 }