diff options
author | Vijay Venkatesh Kumar <vv770d@att.com> | 2019-11-11 15:31:21 +0000 |
---|---|---|
committer | Gerrit Code Review <gerrit@onap.org> | 2019-11-11 15:31:21 +0000 |
commit | 7547ad7dbd45fff19c948da675ab09d72775f973 (patch) | |
tree | 379d27d02f2782e2a02e1b4f37c25f740302994c /src | |
parent | 4b7a95ec2282fadb00c419a96c00b62f8a1d4028 (diff) | |
parent | 7ae9816dd0da3e374d9b1153db2b09048b422e6d (diff) |
Merge "Add tests for EventValidator"
Diffstat (limited to 'src')
-rw-r--r-- | src/test/java/org/onap/dcae/restapi/EventValidatorTest.java | 124 |
1 files changed, 124 insertions, 0 deletions
diff --git a/src/test/java/org/onap/dcae/restapi/EventValidatorTest.java b/src/test/java/org/onap/dcae/restapi/EventValidatorTest.java new file mode 100644 index 00000000..5bacd31c --- /dev/null +++ b/src/test/java/org/onap/dcae/restapi/EventValidatorTest.java @@ -0,0 +1,124 @@ +/*- + * ============LICENSE_START======================================================= + * org.onap.dcaegen2.collectors.ves + * ================================================================================ + * Copyright (C) 2019 Nokia. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.onap.dcae.restapi; + +import com.github.fge.jackson.JsonLoader; +import com.github.fge.jsonschema.core.exceptions.ProcessingException; +import com.github.fge.jsonschema.main.JsonSchemaFactory; +import org.json.JSONObject; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.extension.ExtendWith; +import org.mockito.InjectMocks; +import org.mockito.Mock; +import org.mockito.junit.jupiter.MockitoExtension; +import org.onap.dcae.ApplicationSettings; +import org.springframework.http.ResponseEntity; + +import java.io.IOException; +import java.util.Optional; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.Mockito.when; + +@ExtendWith(MockitoExtension.class) +public class EventValidatorTest { + private static final String DUMMY_SCHEMA_VERSION = "v5"; + private static final String DUMMY_TYPE = "type"; + + private static JSONObject jsonObject; + + @Mock + private static ApplicationSettings settings; + + @InjectMocks + private static EventValidator sut; + + @BeforeAll + static void setupTests(){ + jsonObject = new JSONObject("{" + DUMMY_TYPE + ":dummy}"); + } + + @Test + public void shouldReturnEmptyOptionalOnJsonSchemaValidationDisabled() { + //given + when(settings.jsonSchemaValidationEnabled()).thenReturn(false); + + //when + Optional<ResponseEntity<String>> result = sut.validate(jsonObject, DUMMY_TYPE, DUMMY_SCHEMA_VERSION); + + //then + assertEquals(Optional.empty(), result); + + } + + @Test + public void shouldReturnInvalidJsonErrorOnWrongType() { + //given + when(settings.jsonSchemaValidationEnabled()).thenReturn(true); + + //when + Optional<ResponseEntity<String>> result = sut.validate(jsonObject, "wrongType", DUMMY_SCHEMA_VERSION); + + //then + assertEquals(generateResponseOptional(ApiException.INVALID_JSON_INPUT), result); + } + + @Test + public void shouldReturnSchemaValidationFailedErrorOnInvalidJsonObjectSchema() throws ProcessingException, IOException { + //given + String schemaRejectingEverything = "{\"not\":{}}"; + mockJsonSchema(schemaRejectingEverything); + when(settings.jsonSchemaValidationEnabled()).thenReturn(true); + + //when + Optional<ResponseEntity<String>> result = sut.validate(jsonObject, DUMMY_TYPE, DUMMY_SCHEMA_VERSION); + + //then + assertEquals(generateResponseOptional(ApiException.SCHEMA_VALIDATION_FAILED), result); + } + + @Test + public void shouldReturnEmptyOptionalOnValidJsonObjectSchema() throws ProcessingException, IOException { + //given + String schemaAcceptingEverything = "{}"; + mockJsonSchema(schemaAcceptingEverything); + when(settings.jsonSchemaValidationEnabled()).thenReturn(true); + + //when + Optional<ResponseEntity<String>> result = sut.validate(jsonObject, DUMMY_TYPE, DUMMY_SCHEMA_VERSION); + + //then + assertEquals(Optional.empty(), result); + } + + private void mockJsonSchema(String jsonSchema) throws IOException, ProcessingException { + when(settings.jsonSchema(any())).thenReturn( + JsonSchemaFactory.byDefault() + .getJsonSchema(JsonLoader.fromString(jsonSchema))); + } + + private Optional<ResponseEntity<String>> generateResponseOptional(ApiException schemaValidationFailed) { + return Optional.of(ResponseEntity.status(schemaValidationFailed.httpStatusCode) + .body(schemaValidationFailed.toJSON().toString())); + } +}
\ No newline at end of file |