Remove dead code from VESCollector

Many things there are unused or have inproper modifiers,
spelling etc. I run static analysis tool (Intellij code inspect)
and clear those things up. It will be easier to maintain now.
No actual behavior changes were done.

Issue-ID: DCAEGEN2-526
Signed-off-by: PawelSzalapski <pawel.szalapski@nokia.com>
Change-Id: I1a4ad0c896bd32165cba654344ffc5245648c615

2 files changed, 1 insertions, 124 deletions

diff --git a/src/test/resources/test_collector_ip_op.properties b/src/test/resources/test_collector_ip_op.properties
index a78258ec..f29a2ba6 100644
--- a/src/test/resources/test_collector_ip_op.properties
+++ b/src/test/resources/test_collector_ip_op.properties
@@ -1,78 +1,16 @@
-###############################################################################
-##
-## Collector Server config
-##
-##	- Default values are shown as commented settings.
-##
-###############################################################################
-##
-## HTTP(S) service
-##
-##	Normally:
-##
-##		- 8080 is http service
-##		- https is disabled by default (-1)
-##
-##		- At this time, the server always binds to 0.0.0.0
-##
-## The default port when header.authflag is disabled (0)
 collector.service.port=-1
-
-## The secure port is required if header.authflag is set to 1 (true)
-## Authentication is only supported via secure port
-## When enabled - require valid keystore defined
 collector.service.secure.port=8443
-
-## The keystore must be setup per installation when secure port is configured
 collector.keystore.file.location=/opt/app/dcae-certificate/keystore.jks
 collector.keystore.passwordfile=/opt/app/dcae-certificate/.password
 collector.keystore.alias=dynamically generated
-
-
-###############################################################################
-## Processing
-##
-## If there's a problem that prevents the collector from processing alarms,
-## it's normally better to apply back pressure to the caller than to try to
-## buffer beyond a reasonable size limit. With a limit, the server won't crash
-## due to being out of memory, and the caller will get a 5xx reply saying the
-## server is in trouble.
-collector.inputQueue.maxPending=8096
-
-## Schema Validation checkflag
-## default no validation checkflag (-1)
-## If enabled (1) - schemafile location must be specified
 collector.schema.checkflag=1
 collector.schema.file={\"v1\":\"./etc/CommonEventFormat_27.2.json\",\"v2\":\"./etc/CommonEventFormat_27.2.json\",\"v3\":\"./etc/CommonEventFormat_27.2.json\",\"v4\":\"./etc/CommonEventFormat_27.2.json\",\"v5\":\"./etc/CommonEventFormat_28.4.json\"}
-
-## List all streamid per domain to be supported. The streamid should match to channel name on dmaapfile  
 collector.dmaap.streamid=fault=ves-fault,ves-fault-secondary|syslog=ves-syslog,ves-syslog-secondary|heartbeat=ves-heartbeat,ves-heartbeat-secondary|measurementsForVfScaling=ves-measurement,ves-measurement-secondary|mobileFlow=ves-mobileflow,ves-mobileflow-secondary|other=ves-other,ves-other-secondary|stateChange=ves-statechange,ves-statechange-secondary|thresholdCrossingAlert=ves-thresholdCrossingAlert,ves-thresholdCrossingAlert-secondary|voiceQuality=ves-voicequality,ves-voicequality-secondary|sipSignaling=ves-sipsignaling,ves-sipsignaling-secondary
 collector.dmaapfile=./etc/DmaapConfig.json
-
-## Custom ExceptionConfiguration
-exceptionConfig=./etc/ExceptionConfig.json
-
-## authflag control authentication by the collector
-## If enabled (1) - then authlist has to be defined
-## When authflag is enabled, only secure port will be supported
-## To disable enter 0
 header.authflag=1
-## Combination of userid,base64 encoded pwd list to be supported
-## userid and pwd comma separated; pipe delimitation between each pair
 header.authlist=sample1,c2FtcGxlMQ==|userid1,base64encodepwd1|userid2,base64encodepwd2
-
-## Event transformation Flag - when set expects configurable transformation
-## defined under ./etc/eventTransform.json
-## Enabled by default; to disable set to 0
 event.transform.flag=1
+collector.inputQueue.maxPending = 8096
 streams_subscribes = {}
 services_calls = {}
 tomcat.maxthreads = 200
-
-###############################################################################
-##
-## Tomcat control
-##
-#tomcat.maxthreads=(tomcat default, which is usually 200)
-
-
diff --git a/src/test/resources/testcollector.properties b/src/test/resources/testcollector.properties
index 7c00a208..7de53d61 100644
--- a/src/test/resources/testcollector.properties
+++ b/src/test/resources/testcollector.properties
@@ -1,75 +1,14 @@
-###############################################################################

-##

-## Collector Server config

-##

-##	- Default values are shown as commented settings.

-##

-###############################################################################

-##

-## HTTP(S) service

-##

-##	Normally:

-##

-##		- 8080 is http service

-##		- https is disabled by default (-1)

-##

-##		- At this time, the server always binds to 0.0.0.0

-##

-## The default port when header.authflag is disabled (0)

 collector.service.port=9999

-

-## The secure port is required if header.authflag is set to 1 (true)

-## Authentication is only supported via secure port

-## When enabled - require valid keystore defined

 collector.service.secure.port=8443

-

-## The keystore must be setup per installation when secure port is configured

 collector.keystore.file.location=../etc/keystore

 collector.keystore.passwordfile=./etc/passwordfile

 collector.keystore.alias=tomcat

-

-

-###############################################################################

-## Processing

-##

-## If there's a problem that prevents the collector from processing alarms,

-## it's normally better to apply back pressure to the caller than to try to

-## buffer beyond a reasonable size limit. With a limit, the server won't crash

-## due to being out of memory, and the caller will get a 5xx reply saying the

-## server is in trouble.

-collector.inputQueue.maxPending=8096

-

-## Schema Validation checkflag

-## default no validation checkflag (-1)

-## If enabled (1) - schemafile location must be specified

 collector.schema.checkflag=1

 collector.schema.file={\"v1\":\"./etc/CommonEventFormat_27.2.json\",\"v2\":\"./etc/CommonEventFormat_27.2.json\",\"v3\":\"./etc/CommonEventFormat_27.2.json\",\"v4\":\"./etc/CommonEventFormat_27.2.json\",\"v5\":\"./etc/CommonEventFormat_28.4.json\"}

-

-## List all streamid per domain to be supported. The streamid should match to channel name on dmaapfile  

 collector.dmaap.streamid=fault=sec_fault|syslog=sec_syslog|heartbeat=sec_heartbeat|measurementsForVfScaling=sec_measurement|mobileFlow=sec_mobileflow|other=sec_other|stateChange=sec_statechange|thresholdCrossingAlert=sec_thresholdCrossingAlert|voiceQuality=ves_voicequality|sipSignaling=ves_sipsignaling

 collector.dmaapfile=./etc/DmaapConfig.json

-

-## Custom ExceptionConfiguration

-exceptionConfig=./etc/ExceptionConfig.json

-

-## authflag control authentication by the collector

-## If enabled (1) - then authlist has to be defined

-## When authflag is enabled, only secure port will be supported

-## To disable enter 0

 header.authflag=1

-## Combination of userid,base64 encoded pwd list to be supported

-## userid and pwd comma separated; pipe delimitation between each pair

 header.authlist=secureid,IWRjYWVSb2FkbTEyMyEt|sample1,c2FtcGxlMQ==

-

-## Event transformation Flag - when set expects configurable transformation

-## defined under ./etc/eventTransform.json

-## Enabled by default; to disable set to 0

 event.transform.flag=1

 

-###############################################################################

-##

-## Tomcat control

-##

-#tomcat.maxthreads=(tomcat default, which is usually 200)

-