added test coverage

Change-Id: Ie8310bab09ce329e499263f07b3ab2d3a8969727
Issue-ID: DCAEGEN2-630
Signed-off-by: Ladue, David (dl3158) <dl3158@att.com>

3 files changed, 112 insertions, 2 deletions

diff --git a/tests/test_snmptrapd.py b/tests/test_snmptrapd.py
index 941c0ae..85681ea 100644
--- a/tests/test_snmptrapd.py
+++ b/tests/test_snmptrapd.py
@@ -10,6 +10,9 @@ import trapd_runtime_pid
 import trapd_io
 import trapd_get_cbs_config
 
+from pysnmp.hlapi import *
+from pysnmp import debug
+
 class test_snmptrapd(unittest.TestCase):
     """
     Test the save_pid mod
@@ -123,5 +126,29 @@ class test_snmptrapd(unittest.TestCase):
         # open eelf logs
         trapd_io.open_eelf_logs()
 
+    def test_v1_trap_receipt(self):
+        """
+        Test receiving traps
+        """
+
+        # init vars
+        tds.init()
+
+        # request load of CBS data
+        os.environ.update(CBS_SIM_JSON='/tmp/opt/app/snmptrap/etc/snmptrapd.json')
+        trapd_get_cbs_config.get_cbs_config()
+
+        errorIndication, errorStatus, errorIndex, varbinds = next(sendNotification(SnmpEngine(),
+             CommunityData('not_public'),
+             UdpTransportTarget(('localhost', 6162)),
+             ContextData(),
+             'trap',
+             [ObjectType(ObjectIdentity('.1.3.6.1.4.1.999.1'), OctetString('test trap - ignore')),
+              ObjectType(ObjectIdentity('.1.3.6.1.4.1.999.2'), OctetString('ONAP pytest trap'))])
+        )
+
+        result = errorIndication
+        self.assertEqual(result, None)
+
 if __name__ == '__main__':
     unittest.main()
diff --git a/tests/test_trapd_http_session.py b/tests/test_trapd_http_session.py
index 8f61d08..a423be6 100644
--- a/tests/test_trapd_http_session.py
+++ b/tests/test_trapd_http_session.py
@@ -7,14 +7,37 @@ class test_init_session_obj(unittest.TestCase):
     Test the init_session_obj mod
     """
  
-    def test_correct_usage(self):
+    def init_session(self):
         """
-        Test that attempt to create http session object works
+        test creation of http session
         """
         result = trapd_http_session.init_session_obj()
         compare = str(result).startswith("<requests.sessions.Session object at")
         self.assertEqual(compare, True)
  
+    def test_reset(self):
+        """
+        test reset of existing http session
+        """
+        sess = trapd_http_session.init_session_obj()
+        result = trapd_http_session.reset_session_obj(sess)
+        compare = str(result).startswith("<requests.sessions.Session object at")
+        self.assertEqual(compare, True)
+ 
+    def close_existing_session(self):
+        """
+        test close of existing http session
+        """
+        sess = trapd_http_session.init_session_obj()
+        result = trapd_http_session.close_session_obj(sess)
+        self.assertEqual(result, True)
+ 
+    def close_nonexistent_session(self):
+        """
+        test close of non-existent http session
+        """
+        result = trapd_http_session.close_session_obj(None)
+        self.assertEqual(result, True)
  
 if __name__ == '__main__':
     unittest.main()
diff --git a/tests/test_trapd_snmpv3.py b/tests/test_trapd_snmpv3.py
new file mode 100644
index 0000000..2a0ef12
--- /dev/null
+++ b/tests/test_trapd_snmpv3.py
@@ -0,0 +1,60 @@
+import pytest
+import json
+import unittest
+import os
+
+from onap_dcae_cbs_docker_client.client import get_config
+from trapd_exit import cleanup_and_exit
+from trapd_io import stdout_logger, ecomp_logger
+import trapd_settings as tds
+import trapd_snmpv3
+
+from pysnmp.entity import engine, config
+ 
+class test_snmpv3_config(unittest.TestCase):
+    """
+    Test snmpv3 module
+    """
+
+    def test_v3_config_present(self):
+        """
+        Test that snmpv3 config is present
+        """
+        tds.c_config = json.loads("{ \"snmptrapd\": { \"version\": \"1.4.0\", \"title\": \"ONAP SNMP Trap Receiver\" }, \"protocols\": { \"transport\": \"udp\", \"ipv4_interface\": \"0.0.0.0\", \"ipv4_port\": 6162, \"ipv6_interface\": \"::1\", \"ipv6_port\": 6162 }, \"cache\": { \"dns_cache_ttl_seconds\": 60 }, \"publisher\": { \"http_timeout_milliseconds\": 1500, \"http_retries\": 3, \"http_milliseconds_between_retries\": 750, \"http_primary_publisher\": \"true\", \"http_peer_publisher\": \"unavailable\", \"max_traps_between_publishes\": 10, \"max_milliseconds_between_publishes\": 10000 }, \"streams_publishes\": { \"sec_fault_unsecure\": { \"type\": \"message_router\", \"aaf_password\": null, \"dmaap_info\": { \"location\": \"mtl5\", \"client_id\": null, \"client_role\": null, \"topic_url\": \"http://localhost:3904/events/ONAP-COLLECTOR-SNMPTRAP\" }, \"aaf_username\": null } }, \"files\": { \"runtime_base_dir\": \"/tmp/opt/app/snmptrap\", \"log_dir\": \"logs\", \"data_dir\": \"data\", \"pid_dir\": \"tmp\", \"arriving_traps_log\": \"snmptrapd_arriving_traps.log\", \"snmptrapd_diag\": \"snmptrapd_prog_diag.log\", \"traps_stats_log\": \"snmptrapd_stats.csv\", \"perm_status_file\": \"snmptrapd_status.log\", \"eelf_base_dir\": \"/tmp/opt/app/snmptrap/logs\", \"eelf_error\": \"error.log\", \"eelf_debug\": \"debug.log\", \"eelf_audit\": \"audit.log\", \"eelf_metrics\": \"metrics.log\", \"roll_frequency\": \"day\", \"minimum_severity_to_log\": 2 }, \"trap_config\": { \"sw_interval_in_seconds\": 60, \"notify_oids\": { \".1.3.6.1.4.1.9.0.1\": { \"sw_high_water_in_interval\": 102, \"sw_low_water_in_interval\": 7, \"category\": \"logonly\" }, \".1.3.6.1.4.1.9.0.2\": { \"sw_high_water_in_interval\": 101, \"sw_low_water_in_interval\": 7, \"category\": \"logonly\" }, \".1.3.6.1.4.1.9.0.3\": { \"sw_high_water_in_interval\": 102, \"sw_low_water_in_interval\": 7, \"category\": \"logonly\" }, \".1.3.6.1.4.1.9.0.4\": { \"sw_high_water_in_interval\": 10, \"sw_low_water_in_interval\": 3, \"category\": \"logonly\" } } }, \"snmpv3_config\": { \"usm_users\": [ { \"user\": \"usr-sha-aes256\", \"engineId\": \"8000000001020304\", \"usmHMACSHAAuth\": \"authkey1\", \"usmAesCfb256\": \"privkey1\" }, { \"user\": \"user1\", \"engineId\": \"8000000000000001\", \"usmHMACMD5Auth\": \"authkey1\", \"usmDESPriv\": \"privkey1\" }, { \"user\": \"user2\", \"engineId\": \"8000000000000002\", \"usmHMACSHAAuth\": \"authkey2\", \"usmAesCfb128\": \"privkey2\" }, { \"user\": \"user3\", \"engineId\": \"8000000000000003\", \"usmHMACSHAAuth\": \"authkey3\", \"usmAesCfb256\": \"privkey3\" }, { \"user\": \"user4\"} , { \"engineId\": \"1\"}, { \"user\": \"user6\", \"engineId\": \"8000000000000006\", \"usmNoAuth\": \"authkey3\", \"usmAesCfb192\": \"privkey6\" }, { \"user\": \"user7\", \"engineId\": \"8000000000000007\", \"usmNoAuth\": \"\", \"usmNoPriv\": \"\" }] } }")
+
+        # del os.environ['CBS_SIM_JSON']
+        # result = trapd_get_cbs_config.get_cbs_config()
+        # print("result: %s" % result)
+        # compare = str(result).startswith("{'snmptrap': ")
+        # self.assertEqual(compare, False)
+
+        with pytest.raises(Exception) as pytest_wrapped_sys_exit:
+            snmp_engine = engine.SnmpEngine()
+            result = trapd_snmpv3.load_snmpv3_credentials(config, snmp_engine, tds.c_config)
+            # config, snmp_engine=trapd_snmpv3.load_snmpv3_credentials(config, snmp_engine, pytest_json_data_with_v3)
+            assert pytest_wrapped_sys_exit.type == SystemExit
+            # assert pytest_wrapped_sys_exit.value.code == 1
+
+ 
+    def test_v3_config_not_present(self):
+        """
+        Test that app is ok if v3 config not present
+        """
+        tds.c_config = json.loads("{ \"snmptrapd\": { \"version\": \"1.4.0\", \"title\": \"ONAP SNMP Trap Receiver\" }, \"protocols\": { \"transport\": \"udp\", \"ipv4_interface\": \"0.0.0.0\", \"ipv4_port\": 6162, \"ipv6_interface\": \"::1\", \"ipv6_port\": 6162 }, \"cache\": { \"dns_cache_ttl_seconds\": 60 }, \"publisher\": { \"http_timeout_milliseconds\": 1500, \"http_retries\": 3, \"http_milliseconds_between_retries\": 750, \"http_primary_publisher\": \"true\", \"http_peer_publisher\": \"unavailable\", \"max_traps_between_publishes\": 10, \"max_milliseconds_between_publishes\": 10000 }, \"streams_publishes\": { \"sec_fault_unsecure\": { \"type\": \"message_router\", \"aaf_password\": null, \"dmaap_info\": { \"location\": \"mtl5\", \"client_id\": null, \"client_role\": null, \"topic_url\": \"http://localhost:3904/events/ONAP-COLLECTOR-SNMPTRAP\" }, \"aaf_username\": null } }, \"files\": { \"runtime_base_dir\": \"/tmp/opt/app/snmptrap\", \"log_dir\": \"logs\", \"data_dir\": \"data\", \"pid_dir\": \"tmp\", \"arriving_traps_log\": \"snmptrapd_arriving_traps.log\", \"snmptrapd_diag\": \"snmptrapd_prog_diag.log\", \"traps_stats_log\": \"snmptrapd_stats.csv\", \"perm_status_file\": \"snmptrapd_status.log\", \"eelf_base_dir\": \"/tmp/opt/app/snmptrap/logs\", \"eelf_error\": \"error.log\", \"eelf_debug\": \"debug.log\", \"eelf_audit\": \"audit.log\", \"eelf_metrics\": \"metrics.log\", \"roll_frequency\": \"day\", \"minimum_severity_to_log\": 2 }, \"trap_config\": { \"sw_interval_in_seconds\": 60, \"notify_oids\": { \".1.3.6.1.4.1.9.0.1\": { \"sw_high_water_in_interval\": 102, \"sw_low_water_in_interval\": 7, \"category\": \"logonly\" }, \".1.3.6.1.4.1.9.0.2\": { \"sw_high_water_in_interval\": 101, \"sw_low_water_in_interval\": 7, \"category\": \"logonly\" }, \".1.3.6.1.4.1.9.0.3\": { \"sw_high_water_in_interval\": 102, \"sw_low_water_in_interval\": 7, \"category\": \"logonly\" }, \".1.3.6.1.4.1.9.0.4\": { \"sw_high_water_in_interval\": 10, \"sw_low_water_in_interval\": 3, \"category\": \"logonly\" } } } }")
+
+        # del os.environ['CBS_SIM_JSON']
+        # result = trapd_get_cbs_config.get_cbs_config()
+        # print("result: %s" % result)
+        # compare = str(result).startswith("{'snmptrap': ")
+        # self.assertEqual(compare, False)
+
+        with pytest.raises(Exception) as pytest_wrapped_sys_exit:
+            snmp_engine = engine.SnmpEngine()
+            result = trapd_snmpv3.load_snmpv3_credentials(config, snmp_engine, tds.c_config)
+            # config, snmp_engine=trapd_snmpv3.load_snmpv3_credentials(config, snmp_engine, pytest_json_data_with_v3)
+            assert pytest_wrapped_sys_exit.type == SystemExit
+            # assert pytest_wrapped_sys_exit.value.code == 1
+
+ 
+if __name__ == '__main__':
+    unittest.main()