1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
|
/*
* ============LICENSE_START=======================================================
* dcaegen2-collectors-veshv
* ================================================================================
* Copyright (C) 2019 NOKIA
* ================================================================================
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
* ============LICENSE_END=========================================================
*/
package org.onap.dcae.collectors.veshv.config.impl
import arrow.core.None
import arrow.core.Option
import arrow.core.Some
import org.assertj.core.api.Assertions.*
import org.jetbrains.spek.api.Spek
import org.jetbrains.spek.api.dsl.describe
import org.jetbrains.spek.api.dsl.given
import org.jetbrains.spek.api.dsl.it
import org.onap.dcae.collectors.veshv.config.api.model.ValidationException
import org.onap.dcae.collectors.veshv.utils.logging.LogLevel
import org.onap.dcaegen2.services.sdk.model.streams.dmaap.KafkaSink
import kotlin.test.fail
internal object ConfigurationValidatorTest : Spek({
describe("ConfigurationValidator") {
val cut = ConfigurationValidator()
describe("validating partial configuration with missing fields") {
val config = PartialConfiguration(listenPort = Some(5))
it("should return ValidationException with missing required fields description") {
val result = cut.validate(config)
result.fold({
assertThat(it.message).doesNotContain(PartialConfiguration::listenPort.name)
assertThat(it.message).contains(PartialConfiguration::idleTimeoutSec.name)
assertThat(it.message).contains(PartialConfiguration::firstRequestDelaySec.name)
assertThat(it.message).contains(PartialConfiguration::requestIntervalSec.name)
assertThat(it.message).contains(PartialConfiguration::streamPublishers.name)
assertThat(it.message).contains(PartialConfiguration::keyStoreFile.name)
assertThat(it.message).contains(PartialConfiguration::keyStorePasswordFile.name)
assertThat(it.message).contains(PartialConfiguration::trustStoreFile.name)
assertThat(it.message).contains(PartialConfiguration::trustStorePasswordFile.name)
assertThat(it.message).doesNotContain(PartialConfiguration::logLevel.name)
assertThat(it.message).doesNotContain(PartialConfiguration::sslDisable.name)
}, { fail("Should be ValidationException") })
}
}
describe("validating complete valid configuration") {
val config = PartialConfiguration(
listenPort = Some(defaultListenPort),
idleTimeoutSec = Some(defaultIdleTimeoutSec),
firstRequestDelaySec = Some(defaultFirstReqDelaySec),
requestIntervalSec = Some(defaultRequestIntervalSec),
sslDisable = Some(false),
keyStoreFile = Some(KEYSTORE),
keyStorePasswordFile = Some(KEYSTORE_PASSWORD),
trustStoreFile = Some(TRUSTSTORE),
trustStorePasswordFile = Some(TRUSTSTORE_PASSWORD),
streamPublishers = Some(sampleStreamsDefinition),
logLevel = Some(LogLevel.TRACE)
)
it("should create validated configuration") {
val result = cut.validate(config)
result.fold(
{
fail("Configuration should have been created successfully")
},
{
assertThat(it.listenPort)
.isEqualTo(defaultListenPort)
assertThat(it.idleTimeoutSec)
.isEqualTo(defaultIdleTimeoutSec)
it.securityConfiguration.fold({
fail("Should have been validated successfully")
}, {
assertThat(it.keyStoreFile).isEqualTo(KEYSTORE)
assertThat(it.keyStorePasswordFile).isEqualTo(KEYSTORE_PASSWORD)
assertThat(it.trustStoreFile).isEqualTo(TRUSTSTORE)
assertThat(it.trustStorePasswordFile).isEqualTo(TRUSTSTORE_PASSWORD)
})
assertThat(it.cbsConfiguration.firstRequestDelaySec).isEqualTo(defaultFirstReqDelaySec)
assertThat(it.cbsConfiguration.requestIntervalSec).isEqualTo(defaultRequestIntervalSec)
assertThat(it.streamPublishers).isEqualTo(sampleStreamsDefinition)
assertThat(it.logLevel).isEqualTo(Some(LogLevel.TRACE))
}
)
}
}
describe("validating configuration with security disabled") {
val config = partialConfiguration(
sslDisable = Some(true),
keyStoreFile = Some(""),
keyStorePasswordFile = None,
trustStoreFile = None,
trustStorePasswordFile = Some("")
)
it("should return validated configuration regardless of security keys presence") {
val result = cut.validate(config)
result.fold(
{
fail("Configuration should have been created successfully but was $it")
},
{
assertThat(it.idleTimeoutSec).isEqualTo(defaultIdleTimeoutSec)
assertThat(it.securityConfiguration.isEmpty()).isTrue()
assertThat(it.cbsConfiguration.firstRequestDelaySec).isEqualTo(defaultFirstReqDelaySec)
assertThat(it.cbsConfiguration.requestIntervalSec).isEqualTo(defaultRequestIntervalSec)
assertThat(it.streamPublishers).isEqualTo(sampleStreamsDefinition)
}
)
}
}
describe("validating configuration with ssl disable missing") {
val config = partialConfiguration(
sslDisable = None
)
it("should return validated configuration") {
val result = cut.validate(config)
result.fold(
{
fail("Configuration should have been created successfully but was $it")
},
{
it.securityConfiguration.fold({
fail("Should have been validated successfully")
}, {
assertThat(it.keyStoreFile).isEqualTo(KEYSTORE)
assertThat(it.keyStorePasswordFile).isEqualTo(KEYSTORE_PASSWORD)
assertThat(it.trustStoreFile).isEqualTo(TRUSTSTORE)
assertThat(it.trustStorePasswordFile).isEqualTo(TRUSTSTORE_PASSWORD)
})
}
)
}
}
describe("validating configuration with ssl enabled, but not all required security fields set") {
val config = partialConfiguration(
sslDisable = Some(false),
keyStoreFile = Some(KEYSTORE),
keyStorePasswordFile = None,
trustStoreFile = None,
trustStorePasswordFile = Some(TRUSTSTORE_PASSWORD)
)
it("should return validated configuration") {
val result = cut.validate(config)
assertThat(result.isLeft())
.describedAs("security validation result")
.isTrue()
}
}
describe("validating CBS configuration from partial") {
given("valid CBS configuration") {
val config = partialConfiguration()
it("should returned validated config") {
val result = cut.validatedCbsConfiguration(config)
assertThat(result.firstRequestDelaySec).isEqualTo(defaultFirstReqDelaySec)
assertThat(result.requestIntervalSec).isEqualTo(defaultRequestIntervalSec)
}
}
given("missing firstReqDelaySec") {
val config = partialConfiguration(
firstReqDelaySec = None
)
it("should throw validation exception") {
assertThatExceptionOfType(ValidationException::class.java).isThrownBy {
cut.validatedCbsConfiguration(config)
}.withMessageContaining(PartialConfiguration::firstRequestDelaySec.name)
}
}
given("missing requestIntervalSec") {
val config = partialConfiguration(
requestIntervalSec = None)
it("should throw validation exception") {
assertThatExceptionOfType(ValidationException::class.java).isThrownBy {
cut.validatedCbsConfiguration(config)
}.withMessageContaining(PartialConfiguration::requestIntervalSec.name)
}
}
}
}
})
private fun partialConfiguration(listenPort: Option<Int> = Some(defaultListenPort),
idleTimeoutSec: Option<Long> = Some(defaultIdleTimeoutSec),
firstReqDelaySec: Option<Long> = Some(defaultFirstReqDelaySec),
requestIntervalSec: Option<Long> = Some(defaultRequestIntervalSec),
sslDisable: Option<Boolean> = Some(false),
keyStoreFile: Option<String> = Some(KEYSTORE),
keyStorePasswordFile: Option<String> = Some(KEYSTORE_PASSWORD),
trustStoreFile: Option<String> = Some(TRUSTSTORE),
trustStorePasswordFile: Option<String> = Some(TRUSTSTORE_PASSWORD),
streamPublishers: Option<List<KafkaSink>> = Some(sampleStreamsDefinition),
logLevel: Option<LogLevel> = Some(LogLevel.INFO)
) = PartialConfiguration(
listenPort = listenPort,
idleTimeoutSec = idleTimeoutSec,
firstRequestDelaySec = firstReqDelaySec,
requestIntervalSec = requestIntervalSec,
sslDisable = sslDisable,
keyStoreFile = keyStoreFile,
keyStorePasswordFile = keyStorePasswordFile,
trustStoreFile = trustStoreFile,
trustStorePasswordFile = trustStorePasswordFile,
streamPublishers = streamPublishers,
logLevel = logLevel
)
|
