Age | Commit message (Collapse) | Author | Files | Lines |
|
Check if logger invocations don't use unoptimal invocations, eg.
concatenation `debug("a=" + a)` instead of lambda use `debug {"a=" + a}`
Unfortunately to avoid defining dependencies in many places and having
circural dependencies it was necessarry to reorganize the maven module
structure. The goal was to have `sources` module with production code and
`build` module with build-time tooling (detekt rules among them).
Issue-ID: DCAEGEN2-1002
Change-Id: I36e677b98972aaae6905d722597cbce5e863d201
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
|
|
- changed plugin invocation due to backwards incompatible
changes made in detekt's RC9 version
- disabled few rules that we actually don't follow in our code and
we seem to be fine with it
- turned on UnusedPrivateMember as it actually is a code smell/debt
- supressed warnings in where it was plausible (according to common sense)
- fixed warnings wherever possible
Change-Id: I7be97f471ff46786ef1fca3432b759e7820ac681
Issue-ID: DCAEGEN2-996
Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
|
|
- latest tag should not be used to prevent confusion with casablanca,
instead 1.1-SNAPSHOT should when referring to latests (Dublin) build
- this allows for less frequent changes in CSIT
repository after code freeze (when changes need to
update service version)
Change-Id: I4c94a5a2e90d0c77d51110ed97c9e28c30130f10
Issue-ID: DCAEGEN2-983
Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
|
|
* Changed version from 4.0.0-SNAPSHOT to 1.1.0-SNAPSHOT as per Vijay
suggestion
* Updated Reactor to BOM Californium-SR2
* Updated mockito-kotlin to 2.0.0
* Introduced some fixes to support OpenJDK 11 compilation
Change-Id: Ib25979ef50c7241a019bf98efd9759e0b8792d58
Issue-ID: DCAEGEN2-961
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
|
|
|
|
Change-Id: I3f8cc792677f01b6f4eeb7cc36822b6a9ed482d9
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Issue-ID: DCAEGEN2-969
|
|
Update protobuf and maven protobuf plugin versions
Change-Id: I12dbc71926d74eb78ef4553e4b7abe72d34274e0
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Issue-ID: DCAEGEN2-962
|
|
Migrate to Kotlin 1.3 with non-experimental coroutines support. Also
bump Arrow-Kt version so it follows 1.3 release.
Change-Id: Ia2f26d0c710b7cfae709e35700b72607aeddaf00
Issue-ID: DCAEGEN2-949
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
|
|
Change-Id: I4e1a53ea95ec8d880ff00aa94d3ba5511c23eadf
Issue-ID: DCAEGEN2-943
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
|
|
Replace netty-tcnative bindings for OpenSSL with JDK provided
implementation by default.
Change-Id: I59a4797ce43d15a791eab00bfd25cb730a271207
Issue-ID: DCAEGEN2-816
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
|
|
For now revert the update. Will provide another fix later.
Change-Id: Iaf5fdd64c6e06e63ddc93d759025ab989b0d63db
Issue-ID: DCAEGEN2-801
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
|
|
Change-Id: I7237cede772e79a1cd18835c85b43bcd81710a50
Issue-ID: DCAEGEN2-801
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
|
|
Change-Id: If706e3eefb41f7c4a55212c70518f61069efeb40
Issue-ID: DCAEGEN2-766
Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
|
|
|
|
* Handling docker proxy configuration in a reasonable way
* Should skip coverage verification when skipTests was set
* Get rid of resources encoding warning
* Fix check-coverage output on Jenkins
Change-Id: If828fc41a88074931649e739c615a8b9d8db8739
Issue-ID: DCAEGEN2-755
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
|
|
Also refactor to make it possible.
Change-Id: I6da6d3f33e57c524a7e353ecebd3e045d8ceed2a
Issue-ID: DCAEGEN2-739
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
|
|
Also there was a need to refactor the code, because application logic
was placed inside Ratpack handlers.
Change-Id: Iba3d4d039a98ba88e0dba580c1b7726b53440538
Issue-ID: DCAEGEN2-732
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
|
|
Change-Id: I3fa764feef63d1318adf7ba8128ea2b86055951a
Issue-ID: DCAEGEN2-742
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
|
|
Use centrally managed guava version specified in
oparent. Includes upgrade to oparent 1.2.0.
This change was submitted by script and may include
additional whitespace or formatting changes.
Change-Id: I0f54a8a9fb9ce4536c621c81f9c3be54d121a4e1
Issue-ID: INT-619
Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
|
|
Minimum coverage set to 60%. It works by parsing aggregated Jacoco
report as oposed to jacoco:check goal which checks coverage at most
on submodule level.
Change-Id: Ie6f50ce9b2f15e62ad84480611897a98321a7af2
Issue-ID: DCAEGEN2-681
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
|
|
* Upgrade to Jacoco version with Kotlin support
* Reorganize hv-collector-coverage pom.xml so aggregated report works
again
Change-Id: I636d901114701e2c6669d45add85aafcad8a6783
Issue-ID: DCAEGEN2-729
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
|
|
Kotlin and Arrow updated. Also used Jacoco in version 0.8.1 because one
defined in oparent fails with new Kotlin.
Change-Id: I42e70c08454205fc732cca092c3ec0637f6118d3
Issue-ID: DCAEGEN2-720
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
|
|
Group ID has been changed from org.onap.dcaegen2.collectors.veshv to
org.onap.dcaegen2.collectors.hv-ves.
Change-Id: I077e244ed56df22dd45bfe8dd1eee238f811a552
Issue-ID: DCAEGEN2-719
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
|
|
|
|
In order to minimize complexity and possibly improve performance (thread count)
reactor-netty should be used instead of Ratpack. Also reorganize code to
be more consistent and differentiated readiness and liveness endpoints
(for future use in K8s Pod definition).
As an example I've defined health check probe in docker-compose YAML.
Change-Id: I1b5ce3d685e7ae5b0515b2146ae4fa88b3b41186
Issue-ID: DCAEGEN2-705
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
|
|
If not explocitly called with -DskipDockerPush=false Maven will not push
docker images to the registry. The change is introduced in order for
'{project-name}-{stream}-docker-java-shell-daily' to do the push but all
other Jenkins jobs should skip this step.
Also set hv-collector-analysis version to 1.0.0-SNAPSHOT as it's not a
child of root pom (it contains only custom definitions needed for detekt
plugin to work).
Change-Id: Icc4a1d6cc1a763fad417860b45ffdad30524f67b
Issue-ID: DCAEGEN2-661
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
|
|
* Docker is built in "docker" profile
* It is turned on by default
* "mvn install" builds and tags docker image
* "mvn deploy" pushes the image to the registry
* "mvn -DskipDocker ..." skips docker build
* Temporarily use OpenJDK 8 instead of 10 - it require us to
specify additional JVM options for use inside containers on production
hence addition of run-java.sh
Change-Id: Ifa67df4ed7de9f3d300d6f6de999a890486dea24
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
Issue-ID: DCAEGEN2-653
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
|
|
- Downgraded checkstyle-plugin version to not break build - oparent
uses deprecated config property that cannot be overriden... Also it
uses plugin version from 2014...
- Moved jacoco plugin definition for similiar reasons.
- Bumped maven-surefire-plugin.
- Also added missing license in file. Not sure why CI did not catch
that one earlier
- removed nexus properties that should be inherited from onap
`version` artifact (parent of oparent)
- Use upgraded maven-failsafe-plugin - works with java 8, not sure
about Java 9+
Change-Id: I47e441315cc0e1dc49ed474450db0ee3d2701a10
Issue-ID: DCAEGEN2-700
Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
|
|
Change-Id: Ic4b8b59ced9dc19c9ebf26131036a9e1a752164f
Issue-ID: DCAEGEN2-659
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
|
|
Create ves-hv-collector-health-check module with dummy api server and connect it with ves-hv-collector-main
This is a preparation for health check mechanism implementation
Change-Id: I2f668ab7337b1ed7e2afea6c56f34880de3ef1b5
Issue-ID: DCAEGEN2-659
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
|
|
Change-Id: I089c63edd1859c6941f0791f1cf3a09526b6d028
Issue-ID: DCAEGEN2-660
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
|
|
Change-Id: I72d5c511a90fd2d357227aa94b968cc63bd4ca68
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
Issue-ID: DCAEGEN2-653
|
|
* re-enable after seed code temporary workaround
* move docker build from package to deploy phase
Change-Id: Ic338247590b019c90cf9241075a255bfaff28c5b
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
Issue-ID: DCAEGEN2-653
|
|
- removed duplicate code that was creating VesMessages
and similiar objects
- removed duplicate code in command line parsing tests
- made minor refactorings to avoid passing unnecessary params
and to be as verbose as possible in tests
Closes ONAP-699
Change-Id: I2607f1f775054ae1c5f275c231895f838b415371
Signed-off-by: fkrzywka <filip.krzywka@nokia.com>
Issue-ID: DCAEGEN2-601
|
|
- currently containers are healthy if they have successfully started
their Http servers thus simple endpoint at /healthcheck is sufficient
- to enable docker healthcheck we need to add `curl` to docker images
- http_proxy needs to be provided for docker to be able to build images
behind proxy
Closes ONAP-695
Change-Id: I02f0b8cc2732713b5307dbc34ba604d8185b74fc
Signed-off-by: fkrzywka <filip.krzywka@nokia.com>
Issue-ID: DCAEGEN2-601
|
|
Fix timeout issue when using consul blocking query calls
by switching to standard requests peformed in given interval
Closes ONAP-628
Change-Id: Ifaf7ddfa27045015a7a90c178e0d6d38955c0c58
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Issue-ID: DCAEGEN2-601
|
|
* Reordered alphabetically modules in main pom file
* Removed unused imports
* Corrected visibility for fields/methods
* Fix typos in tests
Change-Id: I35c515b3844bc8517cc6ffb0c6557596505536c9
Signed-off-by: fkrzywka <filip.krzywka@nokia.com>
Issue-ID: DCAEGEN2-601
|
|
Closes ONAP-501
Change-Id: Ia5dc5f67e18c302abbeac7e0373cef479f4befb8
Signed-off-by: kjaniak <kornel.janiak@nokia.com>
Issue-ID: DCAEGEN2-601
|
|
New name: hv-collector-xnf-simulator
Closes ONAP-492
Change-Id: I161dda0d01e90bfe35e5e2d575ec9e81cc8bf3c3
Signed-off-by: Jakub Dudycz <jdudycz@nokia.com>
Issue-ID: DCAEGEN2-601
|
|
Change-Id: I949e1f5ac07be03a1537f07a0b5281171e43c09b
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
Issue-ID: DCAEGEN2-601
|
|
Change-Id: I8735b9a0c7b9e7d623e071098ee00d91d8a69fbf
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
Issue-ID: DCAEGEN2-601
|
|
Change-Id: I40ea95c162067f9d099e578fb236c5877562041b
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
Issue-ID: DCAEGEN2-601
|
|
* Kotlin upgrade
* Monad usage on APIs
* Idle timeout
* Simulator enhancements
Closes ONAP-390
Change-Id: I3c00fcfe38c722caf661ddaad428cf089eeefcaa
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
Issue-ID: DCAEGEN2-601
|
|
Closes ONAP-345
Change-Id: I58c145b1d37a6b32fbe5b157723c152eb571a2dd
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
Issue-ID: DCAEGEN2-601
|
|
Closes ONAP-265
Closes ONAP-267
Change-Id: I394476cf7ba3851d663a2995dc7fe591dae5be41
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
Issue-ID: DCAEGEN2-601
|
|
I wanted to use oparent as parent pom but unfortunately jacoco plugin is
configured differently there. Currently oparent provides support for
jacoco (static code analysis), checkstyle (licenses + code style) and
swagger api documentation.
In ves-hv:
* jacoco is preconfigured for kotlin (but currently not very usable as
it's not ready for kotlin-generated code ie. displayed coverage is
well under the actual coverage; there is an ongoing effort in jacoco
and kotlin communities to fix that).
* checkstyle - this task adds support for checking licenses using
oparent:checkstyle artifact. Static code analysis is already done
using Detekt.
* swagger - ves-hv is not exposing REST API so there is no need for
this.
Closes ONAP-364
Change-Id: If2727a97d826dcab473b2e1e80171d8124ae52d4
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
Issue-ID: DCAEGEN2-601
|
|
Closes ONAP-266
Change-Id: Iaa000e976fcdc4274aa88ce7d0a6cd5866987680
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
Issue-ID: DCAEGEN2-601
|
|
Change-Id: I4c0be20f414f356f7c6a28fcdc330b4b8aca5eb9
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
Issue-ID: DCAEGEN2-601
|
|
Change-Id: Ife1d98af977a439ef7196caa2cf8fb0968e65fe3
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
Issue-ID: DCAEGEN2-601
|
|
WireFrame extracted to domain module
Domain package name in collector-core changed to avoid collision
Merged Protobuf module with new domain module
Closes ONAP-253.
Change-Id: Ie7ac0bb877eae018a7520b4f3ceebe9fd51dbf65
Signed-off-by: fkrzywka <filip.krzywka@nokia.com>
Issue-ID: DCAEGEN2-601
|