aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-12-13Merge "Align logback configuration"Piotr Jaszczyk9-214/+371
2018-12-13Align logback configurationFilip Krzywka9-214/+371
- followed current logging guidelines in regard of format - in simulators currently very simple (minimalistic) pattern will be used as they do not contain any MDCs or Markers - in main logbacks included three patterns varying on verbosity and human-readability (for production full logging, ie. ONAP_LOG_PATTERN, should be used) - removed logback-test from domain module as it was not enabled anyway (no dependency on logback) and we should never have need for logging in this module - made logback-tests consistent (using simple pattern) except in component-tests, where it might be useful to have more verbose output (including MDCs etc.) Change-Id: Ifd851d12a77d5303b836a25c0e168e18a3a804e9 Issue-ID: DCAEGEN2-1026 Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
2018-12-13Merge "Add of adapter fun with param ClientContext"Piotr Jaszczyk9-28/+61
2018-12-13Add of adapter fun with param ClientContextkjaniak9-28/+61
Change-Id: Ib9ac6ab16c51ddf40ae849f4ce04ab7e25609f56 Issue-ID: DCAEGEN2-1031 Signed-off-by: kjaniak <kornel.janiak@nokia.com>
2018-12-12Add helper scriptsFilip Krzywka11-0/+458
Change-Id: I8d5b48511e1b7f9cb7d1f65e8605ebe4cf1b17fc Issue-ID: DCAEGEN2-1027 Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
2018-12-10Add Markers logsFilip Krzywka6-7/+85
Change-Id: I5d3c9e1e4659782719e4847c5bcedbca39c173a0 Issue-ID: DCAEGEN2-669 Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
2018-12-10Add log diagnostic contextPiotr Jaszczyk37-328/+469
As it's not trivial to use MDC directly from logging framework in reactive application, we need to do some work manually. The approach proposed is an explicit MDC handling, which means that context is kept as an object created after establishing client connection. Next, new instance of HvVesCollector (and its dependencies) is created. Every object is propagated with ClientContext so it can use it when calling logger methods. In the future ClientContext might be used to support other use-cases, ie. per-topic access control. As a by-product I had to refactor our Logger wrapper, too. It already had too many functions and after adding MDC number would be doubled. Change-Id: I9c5d3f5e1d1be1db66d28d292eb0e1c38d8d0ffe Issue-ID: DCAEGEN2-671 Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
2018-12-06Update INFO.yamlJessica Wagantall1-3/+16
Add Piotr Jaszczyk and Piotr Wielebski Remove Przemyslaw Wasala Change-Id: I2b8fae7a3f3423dd9877e38d3ddc765d6b343291 Issue-ID: CIMAN-33 Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
2018-12-05Enhance of logging in test partkjaniak15-47/+164
Change-Id: Ibdec0ac5cead7e46ada4c32983b9ccf962df703b Issue-ID: DCAEGEN2-1004 Signed-off-by: kjaniak <kornel.janiak@nokia.com>
2018-12-04Harmonize logging and add new logsFilip Krzywka22-84/+398
- corrected docker-compose consul url Change-Id: I78df868e0dd51008ef39d01553e6a0a3b8273a54 Issue-ID: DCAEGEN2-1003 Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
2018-11-29Custom detekt rule for logger usage checkPiotr Jaszczyk168-133/+600
Check if logger invocations don't use unoptimal invocations, eg. concatenation `debug("a=" + a)` instead of lambda use `debug {"a=" + a}` Unfortunately to avoid defining dependencies in many places and having circural dependencies it was necessarry to reorganize the maven module structure. The goal was to have `sources` module with production code and `build` module with build-time tooling (detekt rules among them). Issue-ID: DCAEGEN2-1002 Change-Id: I36e677b98972aaae6905d722597cbce5e863d201 Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
2018-11-28Bump checkstyle versionFilip Krzywka27-65/+41
- changed plugin invocation due to backwards incompatible changes made in detekt's RC9 version - disabled few rules that we actually don't follow in our code and we seem to be fine with it - turned on UnusedPrivateMember as it actually is a code smell/debt - supressed warnings in where it was plausible (according to common sense) - fixed warnings wherever possible Change-Id: I7be97f471ff46786ef1fca3432b759e7820ac681 Issue-ID: DCAEGEN2-996 Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
2018-11-27Merge "Remove Consul configuration decoding"Vijay Venkatesh Kumar2-43/+16
2018-11-27Merge "Fix tagging for CSITs"Vijay Venkatesh Kumar1-1/+2
2018-11-27Merge "Add healthcheck script"Vijay Venkatesh Kumar2-0/+5
2018-11-22Fix tagging for CSITsFilip Krzywka1-1/+2
- latest tag should not be used to prevent confusion with casablanca, instead 1.1-SNAPSHOT should when referring to latests (Dublin) build - this allows for less frequent changes in CSIT repository after code freeze (when changes need to update service version) Change-Id: I4c94a5a2e90d0c77d51110ed97c9e28c30130f10 Issue-ID: DCAEGEN2-983 Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
2018-11-22Remove Consul configuration decodingFilip Krzywka2-43/+16
Change-Id: I36a6aea55507abfb61613806c93257b049d6eea4 Issue-ID: DCAEGEN2-827 Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
2018-11-22Add healthcheck scriptFilip Krzywka2-0/+5
To be used in HV-VES deployment template Change-Id: I87e1d52db2bb530e131837052f55a29adb5d524b Issue-ID: DCAEGEN2-794 Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
2018-11-21Fix xNF simulator sslContextFilip Krzywka1-6/+7
If --ssl-disable flag is specified in command line arguments, we shouldn't put sslContext into TcpClient as this results in IllegalArgument. Change-Id: I2e2d2ea89736f1e372e1b408c8f3cbe50bf1ecea Issue-ID: DCAEGEN2-985 Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
2018-11-20Update proto file to v14Jakub Dudycz3-15/+29
- update proto file - update vesEventListenerVersion validation regex to match new requirements Change-Id: Ic0bd855fd03caa3ca3120b2c49d5fa4f53de2540 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com> Issue-ID: DCAEGEN2-984
2018-11-19Merge "Fix Common Event Header fields validation"Przemyslaw Wasala4-8/+27
2018-11-19Fix Common Event Header fields validationJakub Dudycz4-8/+27
- "sequence" is no longer a required parameter, since deafult value "0" is acceptable - "vesEventListenerVersion" has to match the regular expression "7\.[0-9]+\.[0-9]+" Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com> Issue-ID: DCAEGEN2-976 Change-Id: I2f9fd6f375ccca3255cc9e035918dc37cc97bd6a
2018-11-15Update project and dependenciesPiotr Jaszczyk35-359/+280
* Changed version from 4.0.0-SNAPSHOT to 1.1.0-SNAPSHOT as per Vijay suggestion * Updated Reactor to BOM Californium-SR2 * Updated mockito-kotlin to 2.0.0 * Introduced some fixes to support OpenJDK 11 compilation Change-Id: Ib25979ef50c7241a019bf98efd9759e0b8792d58 Issue-ID: DCAEGEN2-961 Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
2018-11-13Handle stream error earlyFilip Krzywka5-10/+37
Should fix inconsistent logging due to Reactor Signal sometimes propagating from WireChunkDecoder stream to VesHvCollector stream as Signal.CANCEL instead of Signal.ERROR and thus not being handled correctly. As a drawback however we will log error twice in case it comes from WireChunkDecoder as we want to terminate connection in such case and so we need to propagate error. In WireChunkDecoder `doOnTerminate` was changed to `doFinally` as this method handles also cancellation signals and not only terminal signals. Also fixed minor checkstyle reported issues. Change-Id: I6e91d96c5a1a3ecf30603db9a71e032c770d507f Issue-ID: DCAEGEN2-955 Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
2018-11-09Merge "Switch to JRE 11 in Dockerfiles"Przemyslaw Wasala4-19/+6
2018-11-09Switch to JRE 11 in DockerfilesJakub Dudycz4-19/+6
Change-Id: I3f8cc792677f01b6f4eeb7cc36822b6a9ed482d9 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com> Issue-ID: DCAEGEN2-969
2018-11-07Update protobuf version to 3.6.1Jakub Dudycz1-2/+2
Update protobuf and maven protobuf plugin versions Change-Id: I12dbc71926d74eb78ef4553e4b7abe72d34274e0 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com> Issue-ID: DCAEGEN2-962
2018-11-06Upgrade Kotlin to 1.3Piotr Jaszczyk11-11/+24
Migrate to Kotlin 1.3 with non-experimental coroutines support. Also bump Arrow-Kt version so it follows 1.3 release. Change-Id: Ia2f26d0c710b7cfae709e35700b72607aeddaf00 Issue-ID: DCAEGEN2-949 Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
2018-11-05Change version numbers for Dublin releasePiotr Jaszczyk15-16/+16
Change-Id: I4e1a53ea95ec8d880ff00aa94d3ba5511c23eadf Issue-ID: DCAEGEN2-943 Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
2018-10-05Remove any inconsistencies with specification3.0.0-ONAP1.0.0Piotr Jaszczyk8-140/+38
* Fix payloadId field issue (was 1 byte, should use 2 byts) * Copy final version of protobuf and asn definitions (mostly comments) * Added links to yet-to-be updated RTD documentation Change-Id: I69bda676423ad601797d95577ff8af6707cacb0c Issue-ID: DCAEGEN2-857 Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
2018-10-05Introduce configurable payload size limitationPiotr Jaszczyk34-61/+137
Maximum payload size will be configurable (from command line parameter or environment variable). The default value is same as previous hardcoded value, ie. 1 MiB = 1024 * 1024 bytes. Change-Id: Iec83d8295252bac353d3794b13454fdbbc80ecc4 Issue-ID: DCAEGEN2-856 Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
2018-10-04Change magic byte from 0xFF to 0xAAPiotr Jaszczyk3-8/+8
In final protocol specification the value has changed to 0xAA. Change-Id: Id86c15117732b03bca38c674960d5eba8da88a6e Issue-ID: DCAEGEN2-854 Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
2018-10-03Change domain to lower casePiotr Jaszczyk10-45/+54
Change-Id: I097def2ba720fafe0a1e1a88e87f8c03663627c9 Issue-ID: DCAEGEN2-847 Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
2018-10-01HV-VES Domain updatePiotr Jaszczyk17-218/+215
Change domain name. In this project this yields following changes: * Comment change in VesEvent proto * Updated measurements proto (kept as documentation only, ie. not used in the collector) * Update name in test scenarios for unit and component scope Change-Id: I719077b5fcb642c067d25b7aa174a2e629404689 Issue-ID: DCAEGEN2-847 Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
2018-09-24Use JDK security providerPiotr Jaszczyk41-600/+948
Replace netty-tcnative bindings for OpenSSL with JDK provided implementation by default. Change-Id: I59a4797ce43d15a791eab00bfd25cb730a271207 Issue-ID: DCAEGEN2-816 Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
2018-09-24Merge "Remove end-of-transmission message from protocol"Przemyslaw Wasala22-455/+201
2018-09-24Merge "Update README.md"Przemyslaw Wasala1-0/+55
2018-09-24Remove end-of-transmission message from protocolFilip Krzywka22-455/+201
Also update protobuf files definitions to latest version. Change-Id: I0cd5d2d8deec5c787e2d3948d3d905fa672f9fea Issue-ID: DCAEGEN2-775 Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
2018-09-20Enhance releasing memoryFilip Krzywka3-18/+21
- Some buffers may be emitted as cancelled and thus they would not be handled by doOnTerminate method - Moved data stream creation for Netty inbound to time when collector is fully functional Change-Id: If2f2195fadeca957679f6be696802f48a616f48d Issue-ID: DCAEGEN2-815 Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
2018-09-20Revert reactor upgrade (fix for tcnative bug)Piotr Jaszczyk1-1/+1
For now revert the update. Will provide another fix later. Change-Id: Iaf5fdd64c6e06e63ddc93d759025ab989b0d63db Issue-ID: DCAEGEN2-801 Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
2018-09-20Update README.mdIzabela Zawadzka1-0/+55
Add important links, background and implementation details, describe compability aspects and extendability Change-Id: Ie38300a0d33b347c5d0d82b3e8547039e54829f3 Issue-ID: DCAEGEN2-798 Signed-off-by: Izabela Zawadzka <izabela.zawadzka@nokia.com>
2018-09-19Update Kotlin and Reactor versionsPiotr Jaszczyk1-2/+2
Change-Id: I7237cede772e79a1cd18835c85b43bcd81710a50 Issue-ID: DCAEGEN2-801 Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
2018-09-19Align to logging requirementsFilip Krzywka1-29/+39
- Pattern does not contain MDCs and Markers as HV-VES will not provide that kind of trace context in Casablanca release. - Pattern does not contain replace(...){} parts from most recent version of guideline as these parts significantly decrease logs readability in current format Change-Id: I03a9cef8b7f92208244a65c4846f280d560e037a Issue-ID: DCAEGEN2-799 Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
2018-09-18Merge "Align with latest HV-VES proto definition"Przemyslaw Wasala36-475/+535
2018-09-17Merge "update root license"Lusheng Ji1-202/+36
2018-09-17Align with latest HV-VES proto definitionFilip Krzywka36-475/+535
- excluded measurements proto files from build to keep them reference-only Change-Id: I8c6de20eeeb1b9f8cd2ae4e865de368afe55cc91 Issue-ID: DCAEGEN2-775 Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
2018-09-17Read flags from env variablesFilip Krzywka1-1/+2
The application configuration should be read from command line options as well as from environment variables. The priority: cmd-line over env over defaults. Change-Id: Ib62d5d68003a006901d9be8a81fca354def8fea4 Issue-ID: DCAEGEN2-748 Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
2018-09-14update root licensevagrant1-202/+36
Change-Id: If7db842404cc345057414d478b58874dd8b6853b Signed-off-by: Vijay Venkatesh Kumar <vv770d@att.com> Issue-ID: DCAEGEN2-595
2018-09-13Align with configuration present in consulJakub Dudycz2-4/+4
Rename few configuration json keys inside collector code to match those on consul. Change-Id: I400aebce98049118a30d7959dc6655a4da6016bf Issue-ID: DCAEGEN2-774 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-09-11Remove security vulnerabilityFilip Krzywka1-0/+7
Change-Id: If706e3eefb41f7c4a55212c70518f61069efeb40 Issue-ID: DCAEGEN2-766 Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>